From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67B4CC4338F for ; Mon, 2 Aug 2021 23:16:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4CB1160725 for ; Mon, 2 Aug 2021 23:16:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232596AbhHBXQr (ORCPT ); Mon, 2 Aug 2021 19:16:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:59712 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232192AbhHBXQp (ORCPT ); Mon, 2 Aug 2021 19:16:45 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id B321560EC0; Mon, 2 Aug 2021 23:16:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627946195; bh=0CE6qR/gop+OdKgxD/k5bSNptqvMl6JQUMWiGm6+tfw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=JL0zMLYdH8Ohwr0tKC+IKekf9Qbx/szIeRH9N8fqiDCVhLUwEpH0OaP2BmrUBBOMe J3d2gpr0JPj+pzFs3AWElm9jmuiqcZnxjHChKTXJAQWwlWelFoGHHNcIj/UBCcLnlB h+/MMl4u+SZq16NuI3C67q2HZweSwyOitqWIgJD4HZT4Pqc+pJPJqABOSeKxHrUCDM UlgJqUlXToOjoMEgH6wjA7bNQI2Kc+VnewJDgfZWG6m3nFPYTIICwkoTRuYHNTfKLJ UtRDwZ81YzKbbrKn4oTHVbrTX8+pRytq8MdWuHIh/97vwkaZJ75slHtGja2GXC0iCN pDLNuM01n7y5A== Received: by mail-ed1-f51.google.com with SMTP id n2so26623713eda.10; Mon, 02 Aug 2021 16:16:35 -0700 (PDT) X-Gm-Message-State: AOAM53019CpA/WjU0yg72JJeKz+ZX1dD7yRS7r8t1NtU+9vjLYt08Trz i8GDcZP7e3vzPu4s3VKHbX5Tx32MRyzFNmwUKg== X-Google-Smtp-Source: ABdhPJxJAhueT9lDCmD6Pnv55JDItfMv10i4eCO+yqwvWYDC+oNsWVEH5yVZqBJ6i6TEgSsxIe1LvfnoD9+mHDpuKCw= X-Received: by 2002:aa7:c6d3:: with SMTP id b19mr21633222eds.303.1627946194379; Mon, 02 Aug 2021 16:16:34 -0700 (PDT) MIME-Version: 1.0 References: <1627888227-5757-1-git-send-email-yongqiang.niu@mediatek.com> <1627888227-5757-2-git-send-email-yongqiang.niu@mediatek.com> In-Reply-To: <1627888227-5757-2-git-send-email-yongqiang.niu@mediatek.com> From: Chun-Kuang Hu Date: Tue, 3 Aug 2021 07:16:23 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3] drm/mediatek: clear pending flag when cmdq packet is done. To: Yongqiang Niu Cc: Chun-Kuang Hu , Rob Herring , Matthias Brugger , Philipp Zabel , David Airlie , Daniel Vetter , Jassi Brar , Fabien Parent , Dennis YC Hsieh , DTML , Linux ARM , "moderated list:ARM/Mediatek SoC support" , linux-kernel , DRI Development , Project_Global_Chrome_Upstream_Group@mediatek.com, Hsin-Yi Wang Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Yongqiang: Yongqiang Niu =E6=96=BC 2021=E5=B9=B48=E6=9C= =882=E6=97=A5 =E9=80=B1=E4=B8=80 =E4=B8=8B=E5=8D=883:11=E5=AF=AB=E9=81=93= =EF=BC=9A > > In cmdq mode, packet may be flushed before it is executed, so > the pending flag should be cleared after cmdq packet is done. > > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 51 +++++++++++++++++++++++++++= ++---- > 1 file changed, 46 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/me= diatek/mtk_drm_crtc.c > index 4c25e33..2a2d43e 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > @@ -267,6 +267,40 @@ static void ddp_cmdq_cb(struct mbox_client *cl, void= *mssg) > { > struct mtk_drm_crtc *mtk_crtc =3D container_of(cl, struct mtk_drm= _crtc, cmdq_cl); > struct cmdq_cb_data *data =3D mssg; > + struct mtk_crtc_state *state; > + unsigned int i; > + > + state =3D to_mtk_crtc_state(mtk_crtc->base.state); > + > + if (state->pending_config) { No matter pending_config is true or not, it would be false after this. So we could simply drop this checking. > + state->pending_config =3D false; > + } > + > + if (mtk_crtc->pending_planes) { > + for (i =3D 0; i < mtk_crtc->layer_nr; i++) { > + struct drm_plane *plane =3D &mtk_crtc->planes[i]; > + struct mtk_plane_state *plane_state; > + > + plane_state =3D to_mtk_plane_state(plane->state); > + > + if (plane_state->pending.config) Ditto. > + plane_state->pending.config =3D false; > + } > + mtk_crtc->pending_planes =3D false; > + } > + > + if (mtk_crtc->pending_async_planes) { > + for (i =3D 0; i < mtk_crtc->layer_nr; i++) { > + struct drm_plane *plane =3D &mtk_crtc->planes[i]; > + struct mtk_plane_state *plane_state; > + > + plane_state =3D to_mtk_plane_state(plane->state); > + > + if (plane_state->pending.async_config) Ditto. Regards, Chun-Kuang. > + plane_state->pending.async_config =3D fal= se; > + } > + mtk_crtc->pending_async_planes =3D false; > + } > > mtk_crtc->cmdq_vblank_cnt =3D 0; > mtk_drm_cmdq_pkt_destroy(mtk_crtc->cmdq_chan, data->pkt); > @@ -423,7 +457,8 @@ static void mtk_crtc_ddp_config(struct drm_crtc *crtc= , > state->pending_vrefresh, 0, > cmdq_handle); > > - state->pending_config =3D false; > + if (!cmdq_handle) > + state->pending_config =3D false; > } > > if (mtk_crtc->pending_planes) { > @@ -443,9 +478,12 @@ static void mtk_crtc_ddp_config(struct drm_crtc *crt= c, > mtk_ddp_comp_layer_config(comp, local_lay= er, > plane_state, > cmdq_handle); > - plane_state->pending.config =3D false; > + if (!cmdq_handle) > + plane_state->pending.config =3D false; > } > - mtk_crtc->pending_planes =3D false; > + > + if (!cmdq_handle) > + mtk_crtc->pending_planes =3D false; > } > > if (mtk_crtc->pending_async_planes) { > @@ -465,9 +503,12 @@ static void mtk_crtc_ddp_config(struct drm_crtc *crt= c, > mtk_ddp_comp_layer_config(comp, local_lay= er, > plane_state, > cmdq_handle); > - plane_state->pending.async_config =3D false; > + if (!cmdq_handle) > + plane_state->pending.async_config =3D fal= se; > } > - mtk_crtc->pending_async_planes =3D false; > + > + if (!cmdq_handle) > + mtk_crtc->pending_async_planes =3D false; > } > } > > -- > 1.8.1.1.dirty > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45770C4338F for ; Mon, 2 Aug 2021 23:17:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F2D5A60725 for ; Mon, 2 Aug 2021 23:17:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org F2D5A60725 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Qa2zcUmcMmFDasf8ZEEXMKDpADHARl5AUDEe1xv2erc=; b=iTSRJBcHRNPH/i AymbkwFINZGKfADuSdwN4whNcCTRFmogOXMQLsdBBJf+qNh6XN0Ix4ivVvdXphzxsIbGwVwYjYeis w5KuAi9IHu34bJ2WzfAMnMDyZR1qqu94dyW58UxYClC+QzwMDYCSUs33CFcYjRUJpkcADt3pydShL r0uz9+R9G2Eq/wE0UI2FRdT40sMZFi+HkWssIQbDmH9gmygHhyLLd195+WyhX7o7QYEQ1yaQSC95Y SG7ynQCH37zESSSXE2HOawe03gari2a/SakZAwHAU17nqXI7V71hZBN79xKUnAm5dsP3wK+bCiCQP OvJwmlI3l8RCnm7LfDsg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mAhAv-000ZMj-Qp; Mon, 02 Aug 2021 23:16:49 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mAhAi-000ZCb-A9; Mon, 02 Aug 2021 23:16:37 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id B682860EE6; Mon, 2 Aug 2021 23:16:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627946195; bh=0CE6qR/gop+OdKgxD/k5bSNptqvMl6JQUMWiGm6+tfw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=JL0zMLYdH8Ohwr0tKC+IKekf9Qbx/szIeRH9N8fqiDCVhLUwEpH0OaP2BmrUBBOMe J3d2gpr0JPj+pzFs3AWElm9jmuiqcZnxjHChKTXJAQWwlWelFoGHHNcIj/UBCcLnlB h+/MMl4u+SZq16NuI3C67q2HZweSwyOitqWIgJD4HZT4Pqc+pJPJqABOSeKxHrUCDM UlgJqUlXToOjoMEgH6wjA7bNQI2Kc+VnewJDgfZWG6m3nFPYTIICwkoTRuYHNTfKLJ UtRDwZ81YzKbbrKn4oTHVbrTX8+pRytq8MdWuHIh/97vwkaZJ75slHtGja2GXC0iCN pDLNuM01n7y5A== Received: by mail-ed1-f53.google.com with SMTP id ec13so26146802edb.0; Mon, 02 Aug 2021 16:16:35 -0700 (PDT) X-Gm-Message-State: AOAM532AgTCfLeL1uGPVZdnrCYvNml3G3UEMzEKcU+XDexmAkqNDIgB7 OeGPwq1iM4TXOy7e6+UAqYdSUSiH6isY0pfcsg== X-Google-Smtp-Source: ABdhPJxJAhueT9lDCmD6Pnv55JDItfMv10i4eCO+yqwvWYDC+oNsWVEH5yVZqBJ6i6TEgSsxIe1LvfnoD9+mHDpuKCw= X-Received: by 2002:aa7:c6d3:: with SMTP id b19mr21633222eds.303.1627946194379; Mon, 02 Aug 2021 16:16:34 -0700 (PDT) MIME-Version: 1.0 References: <1627888227-5757-1-git-send-email-yongqiang.niu@mediatek.com> <1627888227-5757-2-git-send-email-yongqiang.niu@mediatek.com> In-Reply-To: <1627888227-5757-2-git-send-email-yongqiang.niu@mediatek.com> From: Chun-Kuang Hu Date: Tue, 3 Aug 2021 07:16:23 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3] drm/mediatek: clear pending flag when cmdq packet is done. To: Yongqiang Niu Cc: Chun-Kuang Hu , Rob Herring , Matthias Brugger , Philipp Zabel , David Airlie , Daniel Vetter , Jassi Brar , Fabien Parent , Dennis YC Hsieh , DTML , Linux ARM , "moderated list:ARM/Mediatek SoC support" , linux-kernel , DRI Development , Project_Global_Chrome_Upstream_Group@mediatek.com, Hsin-Yi Wang X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210802_161636_422697_A0F75BB2 X-CRM114-Status: GOOD ( 18.42 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org SGksIFlvbmdxaWFuZzoKCllvbmdxaWFuZyBOaXUgPHlvbmdxaWFuZy5uaXVAbWVkaWF0ZWsuY29t PiDmlrwgMjAyMeW5tDjmnIgy5pelIOmAseS4gCDkuIvljYgzOjEx5a+r6YGT77yaCj4KPiBJbiBj bWRxIG1vZGUsIHBhY2tldCBtYXkgYmUgZmx1c2hlZCBiZWZvcmUgaXQgaXMgZXhlY3V0ZWQsIHNv Cj4gdGhlIHBlbmRpbmcgZmxhZyBzaG91bGQgYmUgY2xlYXJlZCBhZnRlciBjbWRxIHBhY2tldCBp cyBkb25lLgo+Cj4gU2lnbmVkLW9mZi1ieTogWW9uZ3FpYW5nIE5pdSA8eW9uZ3FpYW5nLm5pdUBt ZWRpYXRlay5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2Ny dGMuYyB8IDUxICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLQo+ICAxIGZpbGUgY2hh bmdlZCwgNDYgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9jcnRjLmMgYi9kcml2ZXJzL2dwdS9kcm0v bWVkaWF0ZWsvbXRrX2RybV9jcnRjLmMKPiBpbmRleCA0YzI1ZTMzLi4yYTJkNDNlIDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2NydGMuYwo+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2NydGMuYwo+IEBAIC0yNjcsNiArMjY3LDQw IEBAIHN0YXRpYyB2b2lkIGRkcF9jbWRxX2NiKHN0cnVjdCBtYm94X2NsaWVudCAqY2wsIHZvaWQg Km1zc2cpCj4gIHsKPiAgICAgICAgIHN0cnVjdCBtdGtfZHJtX2NydGMgKm10a19jcnRjID0gY29u dGFpbmVyX29mKGNsLCBzdHJ1Y3QgbXRrX2RybV9jcnRjLCBjbWRxX2NsKTsKPiAgICAgICAgIHN0 cnVjdCBjbWRxX2NiX2RhdGEgKmRhdGEgPSBtc3NnOwo+ICsgICAgICAgc3RydWN0IG10a19jcnRj X3N0YXRlICpzdGF0ZTsKPiArICAgICAgIHVuc2lnbmVkIGludCBpOwo+ICsKPiArICAgICAgIHN0 YXRlID0gdG9fbXRrX2NydGNfc3RhdGUobXRrX2NydGMtPmJhc2Uuc3RhdGUpOwo+ICsKPiArICAg ICAgIGlmIChzdGF0ZS0+cGVuZGluZ19jb25maWcpIHsKCk5vIG1hdHRlciBwZW5kaW5nX2NvbmZp ZyBpcyB0cnVlIG9yIG5vdCwgaXQgd291bGQgYmUgZmFsc2UgYWZ0ZXIgdGhpcy4KU28gd2UgY291 bGQgc2ltcGx5IGRyb3AgdGhpcyBjaGVja2luZy4KCj4gKyAgICAgICAgICAgICAgIHN0YXRlLT5w ZW5kaW5nX2NvbmZpZyA9IGZhbHNlOwo+ICsgICAgICAgfQo+ICsKPiArICAgICAgIGlmIChtdGtf Y3J0Yy0+cGVuZGluZ19wbGFuZXMpIHsKPiArICAgICAgICAgICAgICAgZm9yIChpID0gMDsgaSA8 IG10a19jcnRjLT5sYXllcl9ucjsgaSsrKSB7Cj4gKyAgICAgICAgICAgICAgICAgICAgICAgc3Ry dWN0IGRybV9wbGFuZSAqcGxhbmUgPSAmbXRrX2NydGMtPnBsYW5lc1tpXTsKPiArICAgICAgICAg ICAgICAgICAgICAgICBzdHJ1Y3QgbXRrX3BsYW5lX3N0YXRlICpwbGFuZV9zdGF0ZTsKPiArCj4g KyAgICAgICAgICAgICAgICAgICAgICAgcGxhbmVfc3RhdGUgPSB0b19tdGtfcGxhbmVfc3RhdGUo cGxhbmUtPnN0YXRlKTsKPiArCj4gKyAgICAgICAgICAgICAgICAgICAgICAgaWYgKHBsYW5lX3N0 YXRlLT5wZW5kaW5nLmNvbmZpZykKCkRpdHRvLgoKPiArICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIHBsYW5lX3N0YXRlLT5wZW5kaW5nLmNvbmZpZyA9IGZhbHNlOwo+ICsgICAgICAgICAg ICAgICB9Cj4gKyAgICAgICAgICAgICAgIG10a19jcnRjLT5wZW5kaW5nX3BsYW5lcyA9IGZhbHNl Owo+ICsgICAgICAgfQo+ICsKPiArICAgICAgIGlmIChtdGtfY3J0Yy0+cGVuZGluZ19hc3luY19w bGFuZXMpIHsKPiArICAgICAgICAgICAgICAgZm9yIChpID0gMDsgaSA8IG10a19jcnRjLT5sYXll cl9ucjsgaSsrKSB7Cj4gKyAgICAgICAgICAgICAgICAgICAgICAgc3RydWN0IGRybV9wbGFuZSAq cGxhbmUgPSAmbXRrX2NydGMtPnBsYW5lc1tpXTsKPiArICAgICAgICAgICAgICAgICAgICAgICBz dHJ1Y3QgbXRrX3BsYW5lX3N0YXRlICpwbGFuZV9zdGF0ZTsKPiArCj4gKyAgICAgICAgICAgICAg ICAgICAgICAgcGxhbmVfc3RhdGUgPSB0b19tdGtfcGxhbmVfc3RhdGUocGxhbmUtPnN0YXRlKTsK PiArCj4gKyAgICAgICAgICAgICAgICAgICAgICAgaWYgKHBsYW5lX3N0YXRlLT5wZW5kaW5nLmFz eW5jX2NvbmZpZykKCkRpdHRvLgoKUmVnYXJkcywKQ2h1bi1LdWFuZy4KCj4gKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBwbGFuZV9zdGF0ZS0+cGVuZGluZy5hc3luY19jb25maWcgPSBm YWxzZTsKPiArICAgICAgICAgICAgICAgfQo+ICsgICAgICAgICAgICAgICBtdGtfY3J0Yy0+cGVu ZGluZ19hc3luY19wbGFuZXMgPSBmYWxzZTsKPiArICAgICAgIH0KPgo+ICAgICAgICAgbXRrX2Ny dGMtPmNtZHFfdmJsYW5rX2NudCA9IDA7Cj4gICAgICAgICBtdGtfZHJtX2NtZHFfcGt0X2Rlc3Ry b3kobXRrX2NydGMtPmNtZHFfY2hhbiwgZGF0YS0+cGt0KTsKPiBAQCAtNDIzLDcgKzQ1Nyw4IEBA IHN0YXRpYyB2b2lkIG10a19jcnRjX2RkcF9jb25maWcoc3RydWN0IGRybV9jcnRjICpjcnRjLAo+ ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0YXRlLT5wZW5kaW5nX3ZyZWZy ZXNoLCAwLAo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNtZHFfaGFuZGxl KTsKPgo+IC0gICAgICAgICAgICAgICBzdGF0ZS0+cGVuZGluZ19jb25maWcgPSBmYWxzZTsKPiAr ICAgICAgICAgICAgICAgaWYgKCFjbWRxX2hhbmRsZSkKPiArICAgICAgICAgICAgICAgICAgICAg ICBzdGF0ZS0+cGVuZGluZ19jb25maWcgPSBmYWxzZTsKPiAgICAgICAgIH0KPgo+ICAgICAgICAg aWYgKG10a19jcnRjLT5wZW5kaW5nX3BsYW5lcykgewo+IEBAIC00NDMsOSArNDc4LDEyIEBAIHN0 YXRpYyB2b2lkIG10a19jcnRjX2RkcF9jb25maWcoc3RydWN0IGRybV9jcnRjICpjcnRjLAo+ICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbXRrX2RkcF9jb21wX2xheWVyX2NvbmZpZyhj b21wLCBsb2NhbF9sYXllciwKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgcGxhbmVfc3RhdGUsCj4gICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNtZHFfaGFuZGxlKTsKPiAtICAg ICAgICAgICAgICAgICAgICAgICBwbGFuZV9zdGF0ZS0+cGVuZGluZy5jb25maWcgPSBmYWxzZTsK PiArICAgICAgICAgICAgICAgICAgICAgICBpZiAoIWNtZHFfaGFuZGxlKQo+ICsgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgcGxhbmVfc3RhdGUtPnBlbmRpbmcuY29uZmlnID0gZmFsc2U7 Cj4gICAgICAgICAgICAgICAgIH0KPiAtICAgICAgICAgICAgICAgbXRrX2NydGMtPnBlbmRpbmdf cGxhbmVzID0gZmFsc2U7Cj4gKwo+ICsgICAgICAgICAgICAgICBpZiAoIWNtZHFfaGFuZGxlKQo+ ICsgICAgICAgICAgICAgICAgICAgICAgIG10a19jcnRjLT5wZW5kaW5nX3BsYW5lcyA9IGZhbHNl Owo+ICAgICAgICAgfQo+Cj4gICAgICAgICBpZiAobXRrX2NydGMtPnBlbmRpbmdfYXN5bmNfcGxh bmVzKSB7Cj4gQEAgLTQ2NSw5ICs1MDMsMTIgQEAgc3RhdGljIHZvaWQgbXRrX2NydGNfZGRwX2Nv bmZpZyhzdHJ1Y3QgZHJtX2NydGMgKmNydGMsCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBtdGtfZGRwX2NvbXBfbGF5ZXJfY29uZmlnKGNvbXAsIGxvY2FsX2xheWVyLAo+ICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwbGFu ZV9zdGF0ZSwKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgY21kcV9oYW5kbGUpOwo+IC0gICAgICAgICAgICAgICAgICAgICAgIHBsYW5l X3N0YXRlLT5wZW5kaW5nLmFzeW5jX2NvbmZpZyA9IGZhbHNlOwo+ICsgICAgICAgICAgICAgICAg ICAgICAgIGlmICghY21kcV9oYW5kbGUpCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBwbGFuZV9zdGF0ZS0+cGVuZGluZy5hc3luY19jb25maWcgPSBmYWxzZTsKPiAgICAgICAgICAg ICAgICAgfQo+IC0gICAgICAgICAgICAgICBtdGtfY3J0Yy0+cGVuZGluZ19hc3luY19wbGFuZXMg PSBmYWxzZTsKPiArCj4gKyAgICAgICAgICAgICAgIGlmICghY21kcV9oYW5kbGUpCj4gKyAgICAg ICAgICAgICAgICAgICAgICAgbXRrX2NydGMtPnBlbmRpbmdfYXN5bmNfcGxhbmVzID0gZmFsc2U7 Cj4gICAgICAgICB9Cj4gIH0KPgo+IC0tCj4gMS44LjEuMS5kaXJ0eQo+CgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eC1tZWRpYXRlayBtYWlsaW5n IGxpc3QKTGludXgtbWVkaWF0ZWtAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5m cmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LW1lZGlhdGVrCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCE30C4338F for ; Mon, 2 Aug 2021 23:18:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7F7A760EE6 for ; Mon, 2 Aug 2021 23:18:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7F7A760EE6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7qOZgKDM6nBbrcNNoI8xmtnbJCCvtYP0ZQu4wLnGFX0=; b=sTCHNHi46tuumj sx0f3mOGym+A/yzm25KIUrc2a6EKx+38BSRqzSR4E599Jc83+atUExYT+XrmceeE/FjepKI/6JZd2 +Vchcbr4nsf2r0B3EjpkHCBbfu6V4IGoM+YYli+eD1kuNUrqpi61nhsw2t/w5UESmzUXH8pGtr7Vs 2iXHhY9Q+m2LAYAyyelmHG75vDBuvBky6bSkyjIxljPfXJd0OkXdT23tyXAX5WfudhSkpGIq88jrH +uIEPDBJGiDackVWCp8uFvlq2JoNkRu/TEGJPBbQHR2tPHcfCVdc8jO72mtj9Sb+Ph8HIa8RAjHbH Z36RAJQtwAXSFuV5Lfkw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mAhAm-000ZE7-3t; Mon, 02 Aug 2021 23:16:40 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mAhAi-000ZCb-A9; Mon, 02 Aug 2021 23:16:37 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id B682860EE6; Mon, 2 Aug 2021 23:16:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627946195; bh=0CE6qR/gop+OdKgxD/k5bSNptqvMl6JQUMWiGm6+tfw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=JL0zMLYdH8Ohwr0tKC+IKekf9Qbx/szIeRH9N8fqiDCVhLUwEpH0OaP2BmrUBBOMe J3d2gpr0JPj+pzFs3AWElm9jmuiqcZnxjHChKTXJAQWwlWelFoGHHNcIj/UBCcLnlB h+/MMl4u+SZq16NuI3C67q2HZweSwyOitqWIgJD4HZT4Pqc+pJPJqABOSeKxHrUCDM UlgJqUlXToOjoMEgH6wjA7bNQI2Kc+VnewJDgfZWG6m3nFPYTIICwkoTRuYHNTfKLJ UtRDwZ81YzKbbrKn4oTHVbrTX8+pRytq8MdWuHIh/97vwkaZJ75slHtGja2GXC0iCN pDLNuM01n7y5A== Received: by mail-ed1-f53.google.com with SMTP id ec13so26146802edb.0; Mon, 02 Aug 2021 16:16:35 -0700 (PDT) X-Gm-Message-State: AOAM532AgTCfLeL1uGPVZdnrCYvNml3G3UEMzEKcU+XDexmAkqNDIgB7 OeGPwq1iM4TXOy7e6+UAqYdSUSiH6isY0pfcsg== X-Google-Smtp-Source: ABdhPJxJAhueT9lDCmD6Pnv55JDItfMv10i4eCO+yqwvWYDC+oNsWVEH5yVZqBJ6i6TEgSsxIe1LvfnoD9+mHDpuKCw= X-Received: by 2002:aa7:c6d3:: with SMTP id b19mr21633222eds.303.1627946194379; Mon, 02 Aug 2021 16:16:34 -0700 (PDT) MIME-Version: 1.0 References: <1627888227-5757-1-git-send-email-yongqiang.niu@mediatek.com> <1627888227-5757-2-git-send-email-yongqiang.niu@mediatek.com> In-Reply-To: <1627888227-5757-2-git-send-email-yongqiang.niu@mediatek.com> From: Chun-Kuang Hu Date: Tue, 3 Aug 2021 07:16:23 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3] drm/mediatek: clear pending flag when cmdq packet is done. To: Yongqiang Niu Cc: Chun-Kuang Hu , Rob Herring , Matthias Brugger , Philipp Zabel , David Airlie , Daniel Vetter , Jassi Brar , Fabien Parent , Dennis YC Hsieh , DTML , Linux ARM , "moderated list:ARM/Mediatek SoC support" , linux-kernel , DRI Development , Project_Global_Chrome_Upstream_Group@mediatek.com, Hsin-Yi Wang X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210802_161636_422697_A0F75BB2 X-CRM114-Status: GOOD ( 18.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGksIFlvbmdxaWFuZzoKCllvbmdxaWFuZyBOaXUgPHlvbmdxaWFuZy5uaXVAbWVkaWF0ZWsuY29t PiDmlrwgMjAyMeW5tDjmnIgy5pelIOmAseS4gCDkuIvljYgzOjEx5a+r6YGT77yaCj4KPiBJbiBj bWRxIG1vZGUsIHBhY2tldCBtYXkgYmUgZmx1c2hlZCBiZWZvcmUgaXQgaXMgZXhlY3V0ZWQsIHNv Cj4gdGhlIHBlbmRpbmcgZmxhZyBzaG91bGQgYmUgY2xlYXJlZCBhZnRlciBjbWRxIHBhY2tldCBp cyBkb25lLgo+Cj4gU2lnbmVkLW9mZi1ieTogWW9uZ3FpYW5nIE5pdSA8eW9uZ3FpYW5nLm5pdUBt ZWRpYXRlay5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2Ny dGMuYyB8IDUxICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLQo+ICAxIGZpbGUgY2hh bmdlZCwgNDYgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9jcnRjLmMgYi9kcml2ZXJzL2dwdS9kcm0v bWVkaWF0ZWsvbXRrX2RybV9jcnRjLmMKPiBpbmRleCA0YzI1ZTMzLi4yYTJkNDNlIDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2NydGMuYwo+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2NydGMuYwo+IEBAIC0yNjcsNiArMjY3LDQw IEBAIHN0YXRpYyB2b2lkIGRkcF9jbWRxX2NiKHN0cnVjdCBtYm94X2NsaWVudCAqY2wsIHZvaWQg Km1zc2cpCj4gIHsKPiAgICAgICAgIHN0cnVjdCBtdGtfZHJtX2NydGMgKm10a19jcnRjID0gY29u dGFpbmVyX29mKGNsLCBzdHJ1Y3QgbXRrX2RybV9jcnRjLCBjbWRxX2NsKTsKPiAgICAgICAgIHN0 cnVjdCBjbWRxX2NiX2RhdGEgKmRhdGEgPSBtc3NnOwo+ICsgICAgICAgc3RydWN0IG10a19jcnRj X3N0YXRlICpzdGF0ZTsKPiArICAgICAgIHVuc2lnbmVkIGludCBpOwo+ICsKPiArICAgICAgIHN0 YXRlID0gdG9fbXRrX2NydGNfc3RhdGUobXRrX2NydGMtPmJhc2Uuc3RhdGUpOwo+ICsKPiArICAg ICAgIGlmIChzdGF0ZS0+cGVuZGluZ19jb25maWcpIHsKCk5vIG1hdHRlciBwZW5kaW5nX2NvbmZp ZyBpcyB0cnVlIG9yIG5vdCwgaXQgd291bGQgYmUgZmFsc2UgYWZ0ZXIgdGhpcy4KU28gd2UgY291 bGQgc2ltcGx5IGRyb3AgdGhpcyBjaGVja2luZy4KCj4gKyAgICAgICAgICAgICAgIHN0YXRlLT5w ZW5kaW5nX2NvbmZpZyA9IGZhbHNlOwo+ICsgICAgICAgfQo+ICsKPiArICAgICAgIGlmIChtdGtf Y3J0Yy0+cGVuZGluZ19wbGFuZXMpIHsKPiArICAgICAgICAgICAgICAgZm9yIChpID0gMDsgaSA8 IG10a19jcnRjLT5sYXllcl9ucjsgaSsrKSB7Cj4gKyAgICAgICAgICAgICAgICAgICAgICAgc3Ry dWN0IGRybV9wbGFuZSAqcGxhbmUgPSAmbXRrX2NydGMtPnBsYW5lc1tpXTsKPiArICAgICAgICAg ICAgICAgICAgICAgICBzdHJ1Y3QgbXRrX3BsYW5lX3N0YXRlICpwbGFuZV9zdGF0ZTsKPiArCj4g KyAgICAgICAgICAgICAgICAgICAgICAgcGxhbmVfc3RhdGUgPSB0b19tdGtfcGxhbmVfc3RhdGUo cGxhbmUtPnN0YXRlKTsKPiArCj4gKyAgICAgICAgICAgICAgICAgICAgICAgaWYgKHBsYW5lX3N0 YXRlLT5wZW5kaW5nLmNvbmZpZykKCkRpdHRvLgoKPiArICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIHBsYW5lX3N0YXRlLT5wZW5kaW5nLmNvbmZpZyA9IGZhbHNlOwo+ICsgICAgICAgICAg ICAgICB9Cj4gKyAgICAgICAgICAgICAgIG10a19jcnRjLT5wZW5kaW5nX3BsYW5lcyA9IGZhbHNl Owo+ICsgICAgICAgfQo+ICsKPiArICAgICAgIGlmIChtdGtfY3J0Yy0+cGVuZGluZ19hc3luY19w bGFuZXMpIHsKPiArICAgICAgICAgICAgICAgZm9yIChpID0gMDsgaSA8IG10a19jcnRjLT5sYXll cl9ucjsgaSsrKSB7Cj4gKyAgICAgICAgICAgICAgICAgICAgICAgc3RydWN0IGRybV9wbGFuZSAq cGxhbmUgPSAmbXRrX2NydGMtPnBsYW5lc1tpXTsKPiArICAgICAgICAgICAgICAgICAgICAgICBz dHJ1Y3QgbXRrX3BsYW5lX3N0YXRlICpwbGFuZV9zdGF0ZTsKPiArCj4gKyAgICAgICAgICAgICAg ICAgICAgICAgcGxhbmVfc3RhdGUgPSB0b19tdGtfcGxhbmVfc3RhdGUocGxhbmUtPnN0YXRlKTsK PiArCj4gKyAgICAgICAgICAgICAgICAgICAgICAgaWYgKHBsYW5lX3N0YXRlLT5wZW5kaW5nLmFz eW5jX2NvbmZpZykKCkRpdHRvLgoKUmVnYXJkcywKQ2h1bi1LdWFuZy4KCj4gKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBwbGFuZV9zdGF0ZS0+cGVuZGluZy5hc3luY19jb25maWcgPSBm YWxzZTsKPiArICAgICAgICAgICAgICAgfQo+ICsgICAgICAgICAgICAgICBtdGtfY3J0Yy0+cGVu ZGluZ19hc3luY19wbGFuZXMgPSBmYWxzZTsKPiArICAgICAgIH0KPgo+ICAgICAgICAgbXRrX2Ny dGMtPmNtZHFfdmJsYW5rX2NudCA9IDA7Cj4gICAgICAgICBtdGtfZHJtX2NtZHFfcGt0X2Rlc3Ry b3kobXRrX2NydGMtPmNtZHFfY2hhbiwgZGF0YS0+cGt0KTsKPiBAQCAtNDIzLDcgKzQ1Nyw4IEBA IHN0YXRpYyB2b2lkIG10a19jcnRjX2RkcF9jb25maWcoc3RydWN0IGRybV9jcnRjICpjcnRjLAo+ ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0YXRlLT5wZW5kaW5nX3ZyZWZy ZXNoLCAwLAo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNtZHFfaGFuZGxl KTsKPgo+IC0gICAgICAgICAgICAgICBzdGF0ZS0+cGVuZGluZ19jb25maWcgPSBmYWxzZTsKPiAr ICAgICAgICAgICAgICAgaWYgKCFjbWRxX2hhbmRsZSkKPiArICAgICAgICAgICAgICAgICAgICAg ICBzdGF0ZS0+cGVuZGluZ19jb25maWcgPSBmYWxzZTsKPiAgICAgICAgIH0KPgo+ICAgICAgICAg aWYgKG10a19jcnRjLT5wZW5kaW5nX3BsYW5lcykgewo+IEBAIC00NDMsOSArNDc4LDEyIEBAIHN0 YXRpYyB2b2lkIG10a19jcnRjX2RkcF9jb25maWcoc3RydWN0IGRybV9jcnRjICpjcnRjLAo+ICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbXRrX2RkcF9jb21wX2xheWVyX2NvbmZpZyhj b21wLCBsb2NhbF9sYXllciwKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgcGxhbmVfc3RhdGUsCj4gICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNtZHFfaGFuZGxlKTsKPiAtICAg ICAgICAgICAgICAgICAgICAgICBwbGFuZV9zdGF0ZS0+cGVuZGluZy5jb25maWcgPSBmYWxzZTsK PiArICAgICAgICAgICAgICAgICAgICAgICBpZiAoIWNtZHFfaGFuZGxlKQo+ICsgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgcGxhbmVfc3RhdGUtPnBlbmRpbmcuY29uZmlnID0gZmFsc2U7 Cj4gICAgICAgICAgICAgICAgIH0KPiAtICAgICAgICAgICAgICAgbXRrX2NydGMtPnBlbmRpbmdf cGxhbmVzID0gZmFsc2U7Cj4gKwo+ICsgICAgICAgICAgICAgICBpZiAoIWNtZHFfaGFuZGxlKQo+ ICsgICAgICAgICAgICAgICAgICAgICAgIG10a19jcnRjLT5wZW5kaW5nX3BsYW5lcyA9IGZhbHNl Owo+ICAgICAgICAgfQo+Cj4gICAgICAgICBpZiAobXRrX2NydGMtPnBlbmRpbmdfYXN5bmNfcGxh bmVzKSB7Cj4gQEAgLTQ2NSw5ICs1MDMsMTIgQEAgc3RhdGljIHZvaWQgbXRrX2NydGNfZGRwX2Nv bmZpZyhzdHJ1Y3QgZHJtX2NydGMgKmNydGMsCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBtdGtfZGRwX2NvbXBfbGF5ZXJfY29uZmlnKGNvbXAsIGxvY2FsX2xheWVyLAo+ICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwbGFu ZV9zdGF0ZSwKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgY21kcV9oYW5kbGUpOwo+IC0gICAgICAgICAgICAgICAgICAgICAgIHBsYW5l X3N0YXRlLT5wZW5kaW5nLmFzeW5jX2NvbmZpZyA9IGZhbHNlOwo+ICsgICAgICAgICAgICAgICAg ICAgICAgIGlmICghY21kcV9oYW5kbGUpCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBwbGFuZV9zdGF0ZS0+cGVuZGluZy5hc3luY19jb25maWcgPSBmYWxzZTsKPiAgICAgICAgICAg ICAgICAgfQo+IC0gICAgICAgICAgICAgICBtdGtfY3J0Yy0+cGVuZGluZ19hc3luY19wbGFuZXMg PSBmYWxzZTsKPiArCj4gKyAgICAgICAgICAgICAgIGlmICghY21kcV9oYW5kbGUpCj4gKyAgICAg ICAgICAgICAgICAgICAgICAgbXRrX2NydGMtPnBlbmRpbmdfYXN5bmNfcGxhbmVzID0gZmFsc2U7 Cj4gICAgICAgICB9Cj4gIH0KPgo+IC0tCj4gMS44LjEuMS5kaXJ0eQo+CgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxp bmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3Rz LmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80678C4320A for ; Mon, 2 Aug 2021 23:16:38 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 473A160F11 for ; Mon, 2 Aug 2021 23:16:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 473A160F11 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BE5116E0FC; Mon, 2 Aug 2021 23:16:37 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id EE2D56E0FC for ; Mon, 2 Aug 2021 23:16:35 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id C261160EE9 for ; Mon, 2 Aug 2021 23:16:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627946195; bh=0CE6qR/gop+OdKgxD/k5bSNptqvMl6JQUMWiGm6+tfw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=JL0zMLYdH8Ohwr0tKC+IKekf9Qbx/szIeRH9N8fqiDCVhLUwEpH0OaP2BmrUBBOMe J3d2gpr0JPj+pzFs3AWElm9jmuiqcZnxjHChKTXJAQWwlWelFoGHHNcIj/UBCcLnlB h+/MMl4u+SZq16NuI3C67q2HZweSwyOitqWIgJD4HZT4Pqc+pJPJqABOSeKxHrUCDM UlgJqUlXToOjoMEgH6wjA7bNQI2Kc+VnewJDgfZWG6m3nFPYTIICwkoTRuYHNTfKLJ UtRDwZ81YzKbbrKn4oTHVbrTX8+pRytq8MdWuHIh/97vwkaZJ75slHtGja2GXC0iCN pDLNuM01n7y5A== Received: by mail-ed1-f47.google.com with SMTP id cf5so15127311edb.2 for ; Mon, 02 Aug 2021 16:16:35 -0700 (PDT) X-Gm-Message-State: AOAM531ENKrzQ1THr1Re6MWL5Vvh6lHI9zz9BbB8S9uacYOxmQLL/HLT DVhocjDwqmMUI4hbCxTl35OHqymXIIls/QIg1Q== X-Google-Smtp-Source: ABdhPJxJAhueT9lDCmD6Pnv55JDItfMv10i4eCO+yqwvWYDC+oNsWVEH5yVZqBJ6i6TEgSsxIe1LvfnoD9+mHDpuKCw= X-Received: by 2002:aa7:c6d3:: with SMTP id b19mr21633222eds.303.1627946194379; Mon, 02 Aug 2021 16:16:34 -0700 (PDT) MIME-Version: 1.0 References: <1627888227-5757-1-git-send-email-yongqiang.niu@mediatek.com> <1627888227-5757-2-git-send-email-yongqiang.niu@mediatek.com> In-Reply-To: <1627888227-5757-2-git-send-email-yongqiang.niu@mediatek.com> From: Chun-Kuang Hu Date: Tue, 3 Aug 2021 07:16:23 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3] drm/mediatek: clear pending flag when cmdq packet is done. To: Yongqiang Niu Cc: Chun-Kuang Hu , Rob Herring , Matthias Brugger , Philipp Zabel , David Airlie , Daniel Vetter , Jassi Brar , Fabien Parent , Dennis YC Hsieh , DTML , Linux ARM , "moderated list:ARM/Mediatek SoC support" , linux-kernel , DRI Development , Project_Global_Chrome_Upstream_Group@mediatek.com, Hsin-Yi Wang Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, Yongqiang: Yongqiang Niu =E6=96=BC 2021=E5=B9=B48=E6=9C= =882=E6=97=A5 =E9=80=B1=E4=B8=80 =E4=B8=8B=E5=8D=883:11=E5=AF=AB=E9=81=93= =EF=BC=9A > > In cmdq mode, packet may be flushed before it is executed, so > the pending flag should be cleared after cmdq packet is done. > > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 51 +++++++++++++++++++++++++++= ++---- > 1 file changed, 46 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/me= diatek/mtk_drm_crtc.c > index 4c25e33..2a2d43e 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > @@ -267,6 +267,40 @@ static void ddp_cmdq_cb(struct mbox_client *cl, void= *mssg) > { > struct mtk_drm_crtc *mtk_crtc =3D container_of(cl, struct mtk_drm= _crtc, cmdq_cl); > struct cmdq_cb_data *data =3D mssg; > + struct mtk_crtc_state *state; > + unsigned int i; > + > + state =3D to_mtk_crtc_state(mtk_crtc->base.state); > + > + if (state->pending_config) { No matter pending_config is true or not, it would be false after this. So we could simply drop this checking. > + state->pending_config =3D false; > + } > + > + if (mtk_crtc->pending_planes) { > + for (i =3D 0; i < mtk_crtc->layer_nr; i++) { > + struct drm_plane *plane =3D &mtk_crtc->planes[i]; > + struct mtk_plane_state *plane_state; > + > + plane_state =3D to_mtk_plane_state(plane->state); > + > + if (plane_state->pending.config) Ditto. > + plane_state->pending.config =3D false; > + } > + mtk_crtc->pending_planes =3D false; > + } > + > + if (mtk_crtc->pending_async_planes) { > + for (i =3D 0; i < mtk_crtc->layer_nr; i++) { > + struct drm_plane *plane =3D &mtk_crtc->planes[i]; > + struct mtk_plane_state *plane_state; > + > + plane_state =3D to_mtk_plane_state(plane->state); > + > + if (plane_state->pending.async_config) Ditto. Regards, Chun-Kuang. > + plane_state->pending.async_config =3D fal= se; > + } > + mtk_crtc->pending_async_planes =3D false; > + } > > mtk_crtc->cmdq_vblank_cnt =3D 0; > mtk_drm_cmdq_pkt_destroy(mtk_crtc->cmdq_chan, data->pkt); > @@ -423,7 +457,8 @@ static void mtk_crtc_ddp_config(struct drm_crtc *crtc= , > state->pending_vrefresh, 0, > cmdq_handle); > > - state->pending_config =3D false; > + if (!cmdq_handle) > + state->pending_config =3D false; > } > > if (mtk_crtc->pending_planes) { > @@ -443,9 +478,12 @@ static void mtk_crtc_ddp_config(struct drm_crtc *crt= c, > mtk_ddp_comp_layer_config(comp, local_lay= er, > plane_state, > cmdq_handle); > - plane_state->pending.config =3D false; > + if (!cmdq_handle) > + plane_state->pending.config =3D false; > } > - mtk_crtc->pending_planes =3D false; > + > + if (!cmdq_handle) > + mtk_crtc->pending_planes =3D false; > } > > if (mtk_crtc->pending_async_planes) { > @@ -465,9 +503,12 @@ static void mtk_crtc_ddp_config(struct drm_crtc *crt= c, > mtk_ddp_comp_layer_config(comp, local_lay= er, > plane_state, > cmdq_handle); > - plane_state->pending.async_config =3D false; > + if (!cmdq_handle) > + plane_state->pending.async_config =3D fal= se; > } > - mtk_crtc->pending_async_planes =3D false; > + > + if (!cmdq_handle) > + mtk_crtc->pending_async_planes =3D false; > } > } > > -- > 1.8.1.1.dirty >