From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 699F8C433E0 for ; Tue, 4 Aug 2020 15:56:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 53ADE208A9 for ; Tue, 4 Aug 2020 15:56:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596556577; bh=r9szaxcb0fGCAe0HMLSnjnkiEt8lN82rikVx3Wzyc8k=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=siz4fg+yE1YCjX28EHUQlcPzo6KVNhHEj9o0y3mt8X6WtP8OjC/R/61NS+TLzUCbg v/d58YlTOoze05k7Yw/8LXlIqyNSlqUKGadU8Zd3mzDIGUeWJ9WiMmrDkoHXo4sJL6 QdkiHywZyq10QOjNscAig1NlWyKrVNs7ZWPb4JSo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728948AbgHDP4O (ORCPT ); Tue, 4 Aug 2020 11:56:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:56376 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726398AbgHDP4L (ORCPT ); Tue, 4 Aug 2020 11:56:11 -0400 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DCEF522BED; Tue, 4 Aug 2020 15:56:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596556571; bh=r9szaxcb0fGCAe0HMLSnjnkiEt8lN82rikVx3Wzyc8k=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Gn27xIYBRAdQ0HUbjrU0tl+T1HMHIOKi4NVP/JyyaE6gJ7Bdx/AQ+UqqHhNAgPxHU i+QHBYY/kYwJXZ29c9+zCWHKfuN+QTEA/tURLegO5jnKftEtEvMU94Y8SwrVDTH9kO 7j9BEUqKjSaLkvJZ+eelyokQWgMscR0UTF6YnBWA= Received: by mail-ed1-f44.google.com with SMTP id m20so20779504eds.2; Tue, 04 Aug 2020 08:56:10 -0700 (PDT) X-Gm-Message-State: AOAM531JTRoeA4xeqB9qDGRXC1DsePAzuVzqsf5ubUeh7Hf38lewg7Lt 7aSLXPIKZUMqwcxstzw+GtH+JC9/RM2pnsk6BA== X-Google-Smtp-Source: ABdhPJw6PbsNIUkr8bnNDmHBfLq9tqqzI0fjOv2L1LAiywI4YCnZbHGEMCWLZ++QY9tilg2ZojDUiq6jFGbXXUGQAss= X-Received: by 2002:a50:e109:: with SMTP id h9mr7783463edl.47.1596556569352; Tue, 04 Aug 2020 08:56:09 -0700 (PDT) MIME-Version: 1.0 References: <1596010690-13178-1-git-send-email-neal.liu@mediatek.com> <1596010690-13178-3-git-send-email-neal.liu@mediatek.com> <1596427295.22971.20.camel@mtkswgap22> <1596506892.17917.2.camel@mtkswgap22> In-Reply-To: <1596506892.17917.2.camel@mtkswgap22> From: Chun-Kuang Hu Date: Tue, 4 Aug 2020 23:55:57 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 2/2] soc: mediatek: add mtk-devapc driver To: Neal Liu Cc: Chun-Kuang Hu , Rob Herring , Matthias Brugger , devicetree@vger.kernel.org, wsd_upstream , lkml , "moderated list:ARM/Mediatek SoC support" , Linux ARM Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Neal Liu =E6=96=BC 2020=E5=B9=B48=E6=9C=884=E6=97= =A5 =E9=80=B1=E4=BA=8C =E4=B8=8A=E5=8D=8810:08=E5=AF=AB=E9=81=93=EF=BC=9A > > On Tue, 2020-08-04 at 00:04 +0800, Chun-Kuang Hu wrote: > > Hi, Neal: > > > > Neal Liu =E6=96=BC 2020=E5=B9=B48=E6=9C=883=E6= =97=A5 =E9=80=B1=E4=B8=80 =E4=B8=8B=E5=8D=8812:01=E5=AF=AB=E9=81=93=EF=BC= =9A > > > > > > Hi Chun-Kuang, > > > > > > On Sat, 2020-08-01 at 08:12 +0800, Chun-Kuang Hu wrote: > > > > Hi, Neal: > > > > > > > > This patch is for "mediatek,mt6779-devapc", so I think commit title > > > > should show the SoC ID. > > > > > > Okay, I'll change title to 'soc:mediatek: add mt6779 devapc driver'. > > > > > > > > > > > Neal Liu =E6=96=BC 2020=E5=B9=B47=E6=9C=882= 9=E6=97=A5 =E9=80=B1=E4=B8=89 =E4=B8=8B=E5=8D=884:29=E5=AF=AB=E9=81=93=EF= =BC=9A > > > > > > > > > > MediaTek bus fabric provides TrustZone security support and data > > > > > protection to prevent slaves from being accessed by unexpected > > > > > masters. > > > > > The security violation is logged and sent to the processor for > > > > > further analysis or countermeasures. > > > > > > > > > > Any occurrence of security violation would raise an interrupt, an= d > > > > > it will be handled by mtk-devapc driver. The violation > > > > > information is printed in order to find the murderer. > > > > > > > > > > Signed-off-by: Neal Liu > > > > > --- > > > > > > > > [snip] > > > > > > > > > + > > > > > +struct mtk_devapc_context { > > > > > + struct device *dev; > > > > > + u32 vio_idx_num; > > > > > + void __iomem *devapc_pd_base; > > > > > + struct mtk_devapc_vio_info *vio_info; > > > > > + const struct mtk_devapc_pd_offset *offset; > > > > > + const struct mtk_devapc_vio_dbgs *vio_dbgs; > > > > > +}; > > > > > > > > I think this structure should separate the constant part. The const= ant part is: > > > > > > > > struct mtk_devapc_data { > > > > const u32 vio_idx_num; > > > > const struct mtk_devapc_pd_offset *offset; /* I would like to > > > > remove struct mtk_devapc_pd_offset and directly put its member into > > > > this structure */ > > > > const struct mtk_devapc_vio_dbgs *vio_dbgs; /* This may disappe= ar */ > > > > }; > > > > > > > > And the context is: > > > > > > > > struct mtk_devapc_context { > > > > struct device *dev; > > > > void __iomem *devapc_pd_base; > > > > const struct mtk_devapc_data *data; > > > > }; > > > > > > > > So when you define this, you would not waste memory to store non-co= nstant data. > > > > > > > > static const struct mtk_devapc_data devapc_mt6779 =3D { > > > > .vio_idx_num =3D 510, > > > > .offset =3D &mt6779_pd_offset, > > > > .vio_dbgs =3D &mt6779_vio_dbgs, > > > > }; > > > > > > > > > > Sorry, I still don't understand why this refactoring will not waste > > > memory to store non-constant data. Could you explain more details? > > > To my understanding, we still also have to allocate memory to store d= ev > > > & devapc_pd_base. > > > > In some situation, it is. You make the non-constant data a global > > variable. I think the context data should be dynamic allocated. If > > this driver is not probed, the non-constant data occupy the memory. > > > > I got your point! In this case, we can save these 2 data structure > space, right? > > struct device *dev; > void __iomem *devapc_pd_base; Right. > > I'll refactoring this data structures on next patch. Thanks ! > > > Regards, > > Chun-Kuang. > > > > > > > > > Regards, > > > > Chun-Kuang. > > > > > > > > > + > > > > > +#endif /* __MTK_DEVAPC_H__ */ > > > > > -- > > > > > 1.7.9.5 > > > > > _______________________________________________ > > > > > Linux-mediatek mailing list > > > > > Linux-mediatek@lists.infradead.org > > > > > http://lists.infradead.org/mailman/listinfo/linux-mediatek > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E286C433E0 for ; Tue, 4 Aug 2020 15:56:29 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 37F10208A9 for ; Tue, 4 Aug 2020 15:56:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="2YqYQGg4"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Gn27xIYB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 37F10208A9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1cLk6oWAhmcwb5JiOQqbeAaY1igjkImOAfDOORbgkZA=; b=2YqYQGg4yacTiW7qWrnKQyXfA vJQbsYVuVykxNSSguXiE90HO7jZJuAqmZRWujOgj16nDiZwnCNYJF2IHsQHRFShJTXRKpBLXPcS4u hDAIgA+yjDMTvSflfWnFkJPm98Nw96mg5Pg783cCBetWtC+Yy5h4A50v0u5SNSy48P/6DwbeAjCkH 8HP/EHvkn57dMd8iW0akimU6HVQEj2bUx//lxrkt4TXADt+2IKgX8eMULV/yy2X74+Rloezmg6Yl1 V+w27Jzc3gKHTjiX4p/IpX+e1mKZkcQmexo7Xx34xiCieTkGsqNvs3t9MJjXx9uYJ+9gNLS/yBS75 ZyYbxUUTA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k2zIX-0002aE-MQ; Tue, 04 Aug 2020 15:56:17 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k2zIS-0002YY-JX; Tue, 04 Aug 2020 15:56:13 +0000 Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D2E9622B40; Tue, 4 Aug 2020 15:56:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596556571; bh=r9szaxcb0fGCAe0HMLSnjnkiEt8lN82rikVx3Wzyc8k=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Gn27xIYBRAdQ0HUbjrU0tl+T1HMHIOKi4NVP/JyyaE6gJ7Bdx/AQ+UqqHhNAgPxHU i+QHBYY/kYwJXZ29c9+zCWHKfuN+QTEA/tURLegO5jnKftEtEvMU94Y8SwrVDTH9kO 7j9BEUqKjSaLkvJZ+eelyokQWgMscR0UTF6YnBWA= Received: by mail-ed1-f50.google.com with SMTP id bs17so11504592edb.1; Tue, 04 Aug 2020 08:56:10 -0700 (PDT) X-Gm-Message-State: AOAM531xAy9Uh1DMrRriCc/izyTL714ZffB88fVjLWssqMahgdBulXOm qxDaEDt2Pk/GE5l+wCEi/jMPMjHyuchzxERKmg== X-Google-Smtp-Source: ABdhPJw6PbsNIUkr8bnNDmHBfLq9tqqzI0fjOv2L1LAiywI4YCnZbHGEMCWLZ++QY9tilg2ZojDUiq6jFGbXXUGQAss= X-Received: by 2002:a50:e109:: with SMTP id h9mr7783463edl.47.1596556569352; Tue, 04 Aug 2020 08:56:09 -0700 (PDT) MIME-Version: 1.0 References: <1596010690-13178-1-git-send-email-neal.liu@mediatek.com> <1596010690-13178-3-git-send-email-neal.liu@mediatek.com> <1596427295.22971.20.camel@mtkswgap22> <1596506892.17917.2.camel@mtkswgap22> In-Reply-To: <1596506892.17917.2.camel@mtkswgap22> From: Chun-Kuang Hu Date: Tue, 4 Aug 2020 23:55:57 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 2/2] soc: mediatek: add mtk-devapc driver To: Neal Liu X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200804_115612_793464_43D2B36E X-CRM114-Status: GOOD ( 30.95 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chun-Kuang Hu , wsd_upstream , devicetree@vger.kernel.org, lkml , Rob Herring , "moderated list:ARM/Mediatek SoC support" , Matthias Brugger , Linux ARM Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org TmVhbCBMaXUgPG5lYWwubGl1QG1lZGlhdGVrLmNvbT4g5pa8IDIwMjDlubQ45pyINOaXpSDpgLHk uowg5LiK5Y2IMTA6MDjlr6vpgZPvvJoKPgo+IE9uIFR1ZSwgMjAyMC0wOC0wNCBhdCAwMDowNCAr MDgwMCwgQ2h1bi1LdWFuZyBIdSB3cm90ZToKPiA+IEhpLCBOZWFsOgo+ID4KPiA+IE5lYWwgTGl1 IDxuZWFsLmxpdUBtZWRpYXRlay5jb20+IOaWvCAyMDIw5bm0OOaciDPml6Ug6YCx5LiAIOS4i+WN iDEyOjAx5a+r6YGT77yaCj4gPiA+Cj4gPiA+IEhpIENodW4tS3VhbmcsCj4gPiA+Cj4gPiA+IE9u IFNhdCwgMjAyMC0wOC0wMSBhdCAwODoxMiArMDgwMCwgQ2h1bi1LdWFuZyBIdSB3cm90ZToKPiA+ ID4gPiBIaSwgTmVhbDoKPiA+ID4gPgo+ID4gPiA+IFRoaXMgcGF0Y2ggaXMgZm9yICJtZWRpYXRl ayxtdDY3NzktZGV2YXBjIiwgc28gSSB0aGluayBjb21taXQgdGl0bGUKPiA+ID4gPiBzaG91bGQg c2hvdyB0aGUgU29DIElELgo+ID4gPgo+ID4gPiBPa2F5LCBJJ2xsIGNoYW5nZSB0aXRsZSB0byAn c29jOm1lZGlhdGVrOiBhZGQgbXQ2Nzc5IGRldmFwYyBkcml2ZXInLgo+ID4gPgo+ID4gPiA+Cj4g PiA+ID4gTmVhbCBMaXUgPG5lYWwubGl1QG1lZGlhdGVrLmNvbT4g5pa8IDIwMjDlubQ35pyIMjnm l6Ug6YCx5LiJIOS4i+WNiDQ6Mjnlr6vpgZPvvJoKPiA+ID4gPiA+Cj4gPiA+ID4gPiBNZWRpYVRl ayBidXMgZmFicmljIHByb3ZpZGVzIFRydXN0Wm9uZSBzZWN1cml0eSBzdXBwb3J0IGFuZCBkYXRh Cj4gPiA+ID4gPiBwcm90ZWN0aW9uIHRvIHByZXZlbnQgc2xhdmVzIGZyb20gYmVpbmcgYWNjZXNz ZWQgYnkgdW5leHBlY3RlZAo+ID4gPiA+ID4gbWFzdGVycy4KPiA+ID4gPiA+IFRoZSBzZWN1cml0 eSB2aW9sYXRpb24gaXMgbG9nZ2VkIGFuZCBzZW50IHRvIHRoZSBwcm9jZXNzb3IgZm9yCj4gPiA+ ID4gPiBmdXJ0aGVyIGFuYWx5c2lzIG9yIGNvdW50ZXJtZWFzdXJlcy4KPiA+ID4gPiA+Cj4gPiA+ ID4gPiBBbnkgb2NjdXJyZW5jZSBvZiBzZWN1cml0eSB2aW9sYXRpb24gd291bGQgcmFpc2UgYW4g aW50ZXJydXB0LCBhbmQKPiA+ID4gPiA+IGl0IHdpbGwgYmUgaGFuZGxlZCBieSBtdGstZGV2YXBj IGRyaXZlci4gVGhlIHZpb2xhdGlvbgo+ID4gPiA+ID4gaW5mb3JtYXRpb24gaXMgcHJpbnRlZCBp biBvcmRlciB0byBmaW5kIHRoZSBtdXJkZXJlci4KPiA+ID4gPiA+Cj4gPiA+ID4gPiBTaWduZWQt b2ZmLWJ5OiBOZWFsIExpdSA8bmVhbC5saXVAbWVkaWF0ZWsuY29tPgo+ID4gPiA+ID4gLS0tCj4g PiA+ID4KPiA+ID4gPiBbc25pcF0KPiA+ID4gPgo+ID4gPiA+ID4gKwo+ID4gPiA+ID4gK3N0cnVj dCBtdGtfZGV2YXBjX2NvbnRleHQgewo+ID4gPiA+ID4gKyAgICAgICBzdHJ1Y3QgZGV2aWNlICpk ZXY7Cj4gPiA+ID4gPiArICAgICAgIHUzMiB2aW9faWR4X251bTsKPiA+ID4gPiA+ICsgICAgICAg dm9pZCBfX2lvbWVtICpkZXZhcGNfcGRfYmFzZTsKPiA+ID4gPiA+ICsgICAgICAgc3RydWN0IG10 a19kZXZhcGNfdmlvX2luZm8gKnZpb19pbmZvOwo+ID4gPiA+ID4gKyAgICAgICBjb25zdCBzdHJ1 Y3QgbXRrX2RldmFwY19wZF9vZmZzZXQgKm9mZnNldDsKPiA+ID4gPiA+ICsgICAgICAgY29uc3Qg c3RydWN0IG10a19kZXZhcGNfdmlvX2RiZ3MgKnZpb19kYmdzOwo+ID4gPiA+ID4gK307Cj4gPiA+ ID4KPiA+ID4gPiBJIHRoaW5rIHRoaXMgc3RydWN0dXJlIHNob3VsZCBzZXBhcmF0ZSB0aGUgY29u c3RhbnQgcGFydC4gVGhlIGNvbnN0YW50IHBhcnQgaXM6Cj4gPiA+ID4KPiA+ID4gPiBzdHJ1Y3Qg bXRrX2RldmFwY19kYXRhIHsKPiA+ID4gPiAgICAgY29uc3QgdTMyIHZpb19pZHhfbnVtOwo+ID4g PiA+ICAgICBjb25zdCBzdHJ1Y3QgbXRrX2RldmFwY19wZF9vZmZzZXQgKm9mZnNldDsgLyogSSB3 b3VsZCBsaWtlIHRvCj4gPiA+ID4gcmVtb3ZlIHN0cnVjdCBtdGtfZGV2YXBjX3BkX29mZnNldCBh bmQgZGlyZWN0bHkgcHV0IGl0cyBtZW1iZXIgaW50bwo+ID4gPiA+IHRoaXMgc3RydWN0dXJlICov Cj4gPiA+ID4gICAgIGNvbnN0IHN0cnVjdCBtdGtfZGV2YXBjX3Zpb19kYmdzICp2aW9fZGJnczsg LyogVGhpcyBtYXkgZGlzYXBwZWFyICovCj4gPiA+ID4gfTsKPiA+ID4gPgo+ID4gPiA+IEFuZCB0 aGUgY29udGV4dCBpczoKPiA+ID4gPgo+ID4gPiA+IHN0cnVjdCBtdGtfZGV2YXBjX2NvbnRleHQg ewo+ID4gPiA+ICAgICBzdHJ1Y3QgZGV2aWNlICpkZXY7Cj4gPiA+ID4gICAgIHZvaWQgX19pb21l bSAqZGV2YXBjX3BkX2Jhc2U7Cj4gPiA+ID4gICAgIGNvbnN0IHN0cnVjdCBtdGtfZGV2YXBjX2Rh dGEgKmRhdGE7Cj4gPiA+ID4gfTsKPiA+ID4gPgo+ID4gPiA+IFNvIHdoZW4geW91IGRlZmluZSB0 aGlzLCB5b3Ugd291bGQgbm90IHdhc3RlIG1lbW9yeSB0byBzdG9yZSBub24tY29uc3RhbnQgZGF0 YS4KPiA+ID4gPgo+ID4gPiA+IHN0YXRpYyBjb25zdCBzdHJ1Y3QgbXRrX2RldmFwY19kYXRhIGRl dmFwY19tdDY3NzkgPSB7Cj4gPiA+ID4gIC52aW9faWR4X251bSA9IDUxMCwKPiA+ID4gPiAgLm9m ZnNldCA9ICZtdDY3NzlfcGRfb2Zmc2V0LAo+ID4gPiA+ICAudmlvX2RiZ3MgPSAmbXQ2Nzc5X3Zp b19kYmdzLAo+ID4gPiA+IH07Cj4gPiA+ID4KPiA+ID4KPiA+ID4gU29ycnksIEkgc3RpbGwgZG9u J3QgdW5kZXJzdGFuZCB3aHkgdGhpcyByZWZhY3RvcmluZyB3aWxsIG5vdCB3YXN0ZQo+ID4gPiBt ZW1vcnkgdG8gc3RvcmUgbm9uLWNvbnN0YW50IGRhdGEuIENvdWxkIHlvdSBleHBsYWluIG1vcmUg ZGV0YWlscz8KPiA+ID4gVG8gbXkgdW5kZXJzdGFuZGluZywgd2Ugc3RpbGwgYWxzbyBoYXZlIHRv IGFsbG9jYXRlIG1lbW9yeSB0byBzdG9yZSBkZXYKPiA+ID4gJiBkZXZhcGNfcGRfYmFzZS4KPiA+ Cj4gPiBJbiBzb21lIHNpdHVhdGlvbiwgaXQgaXMuIFlvdSBtYWtlIHRoZSBub24tY29uc3RhbnQg ZGF0YSBhIGdsb2JhbAo+ID4gdmFyaWFibGUuIEkgdGhpbmsgdGhlIGNvbnRleHQgZGF0YSBzaG91 bGQgYmUgZHluYW1pYyBhbGxvY2F0ZWQuIElmCj4gPiB0aGlzIGRyaXZlciBpcyBub3QgcHJvYmVk LCB0aGUgbm9uLWNvbnN0YW50IGRhdGEgb2NjdXB5IHRoZSBtZW1vcnkuCj4gPgo+Cj4gSSBnb3Qg eW91ciBwb2ludCEgSW4gdGhpcyBjYXNlLCB3ZSBjYW4gc2F2ZSB0aGVzZSAyIGRhdGEgc3RydWN0 dXJlCj4gc3BhY2UsIHJpZ2h0Pwo+Cj4gc3RydWN0IGRldmljZSAqZGV2Owo+IHZvaWQgX19pb21l bSAqZGV2YXBjX3BkX2Jhc2U7CgpSaWdodC4KCj4KPiBJJ2xsIHJlZmFjdG9yaW5nIHRoaXMgZGF0 YSBzdHJ1Y3R1cmVzIG9uIG5leHQgcGF0Y2guIFRoYW5rcyAhCj4KPiA+IFJlZ2FyZHMsCj4gPiBD aHVuLUt1YW5nLgo+ID4KPiA+ID4KPiA+ID4gPiBSZWdhcmRzLAo+ID4gPiA+IENodW4tS3Vhbmcu Cj4gPiA+ID4KPiA+ID4gPiA+ICsKPiA+ID4gPiA+ICsjZW5kaWYgLyogX19NVEtfREVWQVBDX0hf XyAqLwo+ID4gPiA+ID4gLS0KPiA+ID4gPiA+IDEuNy45LjUKPiA+ID4gPiA+IF9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gPiA+ID4gPiBMaW51eC1tZWRp YXRlayBtYWlsaW5nIGxpc3QKPiA+ID4gPiA+IExpbnV4LW1lZGlhdGVrQGxpc3RzLmluZnJhZGVh ZC5vcmcKPiA+ID4gPiA+IGh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGlu Zm8vbGludXgtbWVkaWF0ZWsKPiA+ID4KPgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KTGludXgtbWVkaWF0ZWsgbWFpbGluZyBsaXN0CkxpbnV4LW1lZGlh dGVrQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1h bi9saXN0aW5mby9saW51eC1tZWRpYXRlawo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 871DBC433E0 for ; Tue, 4 Aug 2020 15:57:47 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5FD88208A9 for ; Tue, 4 Aug 2020 15:57:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="B+KsUmnd"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Gn27xIYB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5FD88208A9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pWBwc+J/YayBkBQZvk32Tz7uF0FwnbHeQnY1d7ex0fs=; b=B+KsUmnd2U81Ga7Exx3znQk4t 1/u0rnh8sk1iw1f49OPqXTFitklnBMAC8aE5HZ277KR2MzBw4EpzQWTkQj5eK2wXR1jDtkujO+vCa 6+eCYS4HLTgqd3HeD8FrAvfLXGp0+r9niXVsN0yGWDwDZIUg4nsGS1F57fk3UDVAIo/tzuayqaorU lxYU6yh/O5X5Pd2MCf4TntdRSqicKLfx6UPuAl76JgEqwuLXRJE0JVvbS6Kw8xWHsE3Qc9yJP9u0L Nc3ojxe7ZOM/MLMkRtWjZKyBnSViTSJTWykq4M1jpARFmIY6YepH8HYFN8mkdt8FP4VKJYAZ3swSo T7q4mssCg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k2zIV-0002Zj-MV; Tue, 04 Aug 2020 15:56:15 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k2zIS-0002YY-JX; Tue, 04 Aug 2020 15:56:13 +0000 Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D2E9622B40; Tue, 4 Aug 2020 15:56:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596556571; bh=r9szaxcb0fGCAe0HMLSnjnkiEt8lN82rikVx3Wzyc8k=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Gn27xIYBRAdQ0HUbjrU0tl+T1HMHIOKi4NVP/JyyaE6gJ7Bdx/AQ+UqqHhNAgPxHU i+QHBYY/kYwJXZ29c9+zCWHKfuN+QTEA/tURLegO5jnKftEtEvMU94Y8SwrVDTH9kO 7j9BEUqKjSaLkvJZ+eelyokQWgMscR0UTF6YnBWA= Received: by mail-ed1-f50.google.com with SMTP id bs17so11504592edb.1; Tue, 04 Aug 2020 08:56:10 -0700 (PDT) X-Gm-Message-State: AOAM531xAy9Uh1DMrRriCc/izyTL714ZffB88fVjLWssqMahgdBulXOm qxDaEDt2Pk/GE5l+wCEi/jMPMjHyuchzxERKmg== X-Google-Smtp-Source: ABdhPJw6PbsNIUkr8bnNDmHBfLq9tqqzI0fjOv2L1LAiywI4YCnZbHGEMCWLZ++QY9tilg2ZojDUiq6jFGbXXUGQAss= X-Received: by 2002:a50:e109:: with SMTP id h9mr7783463edl.47.1596556569352; Tue, 04 Aug 2020 08:56:09 -0700 (PDT) MIME-Version: 1.0 References: <1596010690-13178-1-git-send-email-neal.liu@mediatek.com> <1596010690-13178-3-git-send-email-neal.liu@mediatek.com> <1596427295.22971.20.camel@mtkswgap22> <1596506892.17917.2.camel@mtkswgap22> In-Reply-To: <1596506892.17917.2.camel@mtkswgap22> From: Chun-Kuang Hu Date: Tue, 4 Aug 2020 23:55:57 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 2/2] soc: mediatek: add mtk-devapc driver To: Neal Liu X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200804_115612_793464_43D2B36E X-CRM114-Status: GOOD ( 30.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chun-Kuang Hu , wsd_upstream , devicetree@vger.kernel.org, lkml , Rob Herring , "moderated list:ARM/Mediatek SoC support" , Matthias Brugger , Linux ARM Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org TmVhbCBMaXUgPG5lYWwubGl1QG1lZGlhdGVrLmNvbT4g5pa8IDIwMjDlubQ45pyINOaXpSDpgLHk uowg5LiK5Y2IMTA6MDjlr6vpgZPvvJoKPgo+IE9uIFR1ZSwgMjAyMC0wOC0wNCBhdCAwMDowNCAr MDgwMCwgQ2h1bi1LdWFuZyBIdSB3cm90ZToKPiA+IEhpLCBOZWFsOgo+ID4KPiA+IE5lYWwgTGl1 IDxuZWFsLmxpdUBtZWRpYXRlay5jb20+IOaWvCAyMDIw5bm0OOaciDPml6Ug6YCx5LiAIOS4i+WN iDEyOjAx5a+r6YGT77yaCj4gPiA+Cj4gPiA+IEhpIENodW4tS3VhbmcsCj4gPiA+Cj4gPiA+IE9u IFNhdCwgMjAyMC0wOC0wMSBhdCAwODoxMiArMDgwMCwgQ2h1bi1LdWFuZyBIdSB3cm90ZToKPiA+ ID4gPiBIaSwgTmVhbDoKPiA+ID4gPgo+ID4gPiA+IFRoaXMgcGF0Y2ggaXMgZm9yICJtZWRpYXRl ayxtdDY3NzktZGV2YXBjIiwgc28gSSB0aGluayBjb21taXQgdGl0bGUKPiA+ID4gPiBzaG91bGQg c2hvdyB0aGUgU29DIElELgo+ID4gPgo+ID4gPiBPa2F5LCBJJ2xsIGNoYW5nZSB0aXRsZSB0byAn c29jOm1lZGlhdGVrOiBhZGQgbXQ2Nzc5IGRldmFwYyBkcml2ZXInLgo+ID4gPgo+ID4gPiA+Cj4g PiA+ID4gTmVhbCBMaXUgPG5lYWwubGl1QG1lZGlhdGVrLmNvbT4g5pa8IDIwMjDlubQ35pyIMjnm l6Ug6YCx5LiJIOS4i+WNiDQ6Mjnlr6vpgZPvvJoKPiA+ID4gPiA+Cj4gPiA+ID4gPiBNZWRpYVRl ayBidXMgZmFicmljIHByb3ZpZGVzIFRydXN0Wm9uZSBzZWN1cml0eSBzdXBwb3J0IGFuZCBkYXRh Cj4gPiA+ID4gPiBwcm90ZWN0aW9uIHRvIHByZXZlbnQgc2xhdmVzIGZyb20gYmVpbmcgYWNjZXNz ZWQgYnkgdW5leHBlY3RlZAo+ID4gPiA+ID4gbWFzdGVycy4KPiA+ID4gPiA+IFRoZSBzZWN1cml0 eSB2aW9sYXRpb24gaXMgbG9nZ2VkIGFuZCBzZW50IHRvIHRoZSBwcm9jZXNzb3IgZm9yCj4gPiA+ ID4gPiBmdXJ0aGVyIGFuYWx5c2lzIG9yIGNvdW50ZXJtZWFzdXJlcy4KPiA+ID4gPiA+Cj4gPiA+ ID4gPiBBbnkgb2NjdXJyZW5jZSBvZiBzZWN1cml0eSB2aW9sYXRpb24gd291bGQgcmFpc2UgYW4g aW50ZXJydXB0LCBhbmQKPiA+ID4gPiA+IGl0IHdpbGwgYmUgaGFuZGxlZCBieSBtdGstZGV2YXBj IGRyaXZlci4gVGhlIHZpb2xhdGlvbgo+ID4gPiA+ID4gaW5mb3JtYXRpb24gaXMgcHJpbnRlZCBp biBvcmRlciB0byBmaW5kIHRoZSBtdXJkZXJlci4KPiA+ID4gPiA+Cj4gPiA+ID4gPiBTaWduZWQt b2ZmLWJ5OiBOZWFsIExpdSA8bmVhbC5saXVAbWVkaWF0ZWsuY29tPgo+ID4gPiA+ID4gLS0tCj4g PiA+ID4KPiA+ID4gPiBbc25pcF0KPiA+ID4gPgo+ID4gPiA+ID4gKwo+ID4gPiA+ID4gK3N0cnVj dCBtdGtfZGV2YXBjX2NvbnRleHQgewo+ID4gPiA+ID4gKyAgICAgICBzdHJ1Y3QgZGV2aWNlICpk ZXY7Cj4gPiA+ID4gPiArICAgICAgIHUzMiB2aW9faWR4X251bTsKPiA+ID4gPiA+ICsgICAgICAg dm9pZCBfX2lvbWVtICpkZXZhcGNfcGRfYmFzZTsKPiA+ID4gPiA+ICsgICAgICAgc3RydWN0IG10 a19kZXZhcGNfdmlvX2luZm8gKnZpb19pbmZvOwo+ID4gPiA+ID4gKyAgICAgICBjb25zdCBzdHJ1 Y3QgbXRrX2RldmFwY19wZF9vZmZzZXQgKm9mZnNldDsKPiA+ID4gPiA+ICsgICAgICAgY29uc3Qg c3RydWN0IG10a19kZXZhcGNfdmlvX2RiZ3MgKnZpb19kYmdzOwo+ID4gPiA+ID4gK307Cj4gPiA+ ID4KPiA+ID4gPiBJIHRoaW5rIHRoaXMgc3RydWN0dXJlIHNob3VsZCBzZXBhcmF0ZSB0aGUgY29u c3RhbnQgcGFydC4gVGhlIGNvbnN0YW50IHBhcnQgaXM6Cj4gPiA+ID4KPiA+ID4gPiBzdHJ1Y3Qg bXRrX2RldmFwY19kYXRhIHsKPiA+ID4gPiAgICAgY29uc3QgdTMyIHZpb19pZHhfbnVtOwo+ID4g PiA+ICAgICBjb25zdCBzdHJ1Y3QgbXRrX2RldmFwY19wZF9vZmZzZXQgKm9mZnNldDsgLyogSSB3 b3VsZCBsaWtlIHRvCj4gPiA+ID4gcmVtb3ZlIHN0cnVjdCBtdGtfZGV2YXBjX3BkX29mZnNldCBh bmQgZGlyZWN0bHkgcHV0IGl0cyBtZW1iZXIgaW50bwo+ID4gPiA+IHRoaXMgc3RydWN0dXJlICov Cj4gPiA+ID4gICAgIGNvbnN0IHN0cnVjdCBtdGtfZGV2YXBjX3Zpb19kYmdzICp2aW9fZGJnczsg LyogVGhpcyBtYXkgZGlzYXBwZWFyICovCj4gPiA+ID4gfTsKPiA+ID4gPgo+ID4gPiA+IEFuZCB0 aGUgY29udGV4dCBpczoKPiA+ID4gPgo+ID4gPiA+IHN0cnVjdCBtdGtfZGV2YXBjX2NvbnRleHQg ewo+ID4gPiA+ICAgICBzdHJ1Y3QgZGV2aWNlICpkZXY7Cj4gPiA+ID4gICAgIHZvaWQgX19pb21l bSAqZGV2YXBjX3BkX2Jhc2U7Cj4gPiA+ID4gICAgIGNvbnN0IHN0cnVjdCBtdGtfZGV2YXBjX2Rh dGEgKmRhdGE7Cj4gPiA+ID4gfTsKPiA+ID4gPgo+ID4gPiA+IFNvIHdoZW4geW91IGRlZmluZSB0 aGlzLCB5b3Ugd291bGQgbm90IHdhc3RlIG1lbW9yeSB0byBzdG9yZSBub24tY29uc3RhbnQgZGF0 YS4KPiA+ID4gPgo+ID4gPiA+IHN0YXRpYyBjb25zdCBzdHJ1Y3QgbXRrX2RldmFwY19kYXRhIGRl dmFwY19tdDY3NzkgPSB7Cj4gPiA+ID4gIC52aW9faWR4X251bSA9IDUxMCwKPiA+ID4gPiAgLm9m ZnNldCA9ICZtdDY3NzlfcGRfb2Zmc2V0LAo+ID4gPiA+ICAudmlvX2RiZ3MgPSAmbXQ2Nzc5X3Zp b19kYmdzLAo+ID4gPiA+IH07Cj4gPiA+ID4KPiA+ID4KPiA+ID4gU29ycnksIEkgc3RpbGwgZG9u J3QgdW5kZXJzdGFuZCB3aHkgdGhpcyByZWZhY3RvcmluZyB3aWxsIG5vdCB3YXN0ZQo+ID4gPiBt ZW1vcnkgdG8gc3RvcmUgbm9uLWNvbnN0YW50IGRhdGEuIENvdWxkIHlvdSBleHBsYWluIG1vcmUg ZGV0YWlscz8KPiA+ID4gVG8gbXkgdW5kZXJzdGFuZGluZywgd2Ugc3RpbGwgYWxzbyBoYXZlIHRv IGFsbG9jYXRlIG1lbW9yeSB0byBzdG9yZSBkZXYKPiA+ID4gJiBkZXZhcGNfcGRfYmFzZS4KPiA+ Cj4gPiBJbiBzb21lIHNpdHVhdGlvbiwgaXQgaXMuIFlvdSBtYWtlIHRoZSBub24tY29uc3RhbnQg ZGF0YSBhIGdsb2JhbAo+ID4gdmFyaWFibGUuIEkgdGhpbmsgdGhlIGNvbnRleHQgZGF0YSBzaG91 bGQgYmUgZHluYW1pYyBhbGxvY2F0ZWQuIElmCj4gPiB0aGlzIGRyaXZlciBpcyBub3QgcHJvYmVk LCB0aGUgbm9uLWNvbnN0YW50IGRhdGEgb2NjdXB5IHRoZSBtZW1vcnkuCj4gPgo+Cj4gSSBnb3Qg eW91ciBwb2ludCEgSW4gdGhpcyBjYXNlLCB3ZSBjYW4gc2F2ZSB0aGVzZSAyIGRhdGEgc3RydWN0 dXJlCj4gc3BhY2UsIHJpZ2h0Pwo+Cj4gc3RydWN0IGRldmljZSAqZGV2Owo+IHZvaWQgX19pb21l bSAqZGV2YXBjX3BkX2Jhc2U7CgpSaWdodC4KCj4KPiBJJ2xsIHJlZmFjdG9yaW5nIHRoaXMgZGF0 YSBzdHJ1Y3R1cmVzIG9uIG5leHQgcGF0Y2guIFRoYW5rcyAhCj4KPiA+IFJlZ2FyZHMsCj4gPiBD aHVuLUt1YW5nLgo+ID4KPiA+ID4KPiA+ID4gPiBSZWdhcmRzLAo+ID4gPiA+IENodW4tS3Vhbmcu Cj4gPiA+ID4KPiA+ID4gPiA+ICsKPiA+ID4gPiA+ICsjZW5kaWYgLyogX19NVEtfREVWQVBDX0hf XyAqLwo+ID4gPiA+ID4gLS0KPiA+ID4gPiA+IDEuNy45LjUKPiA+ID4gPiA+IF9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gPiA+ID4gPiBMaW51eC1tZWRp YXRlayBtYWlsaW5nIGxpc3QKPiA+ID4gPiA+IExpbnV4LW1lZGlhdGVrQGxpc3RzLmluZnJhZGVh ZC5vcmcKPiA+ID4gPiA+IGh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGlu Zm8vbGludXgtbWVkaWF0ZWsKPiA+ID4KPgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJt LWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21h aWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=