From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-21.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A2EEC433DB for ; Sat, 30 Jan 2021 09:55:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 60D5764DCC for ; Sat, 30 Jan 2021 09:55:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231503AbhA3Jyw (ORCPT ); Sat, 30 Jan 2021 04:54:52 -0500 Received: from mail.kernel.org ([198.145.29.99]:45578 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231843AbhA3JvT (ORCPT ); Sat, 30 Jan 2021 04:51:19 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 226D064E1D; Sat, 30 Jan 2021 09:50:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612000238; bh=LgbTJ3tIY4Lnts/jruQ5ky4J32Gja9Xar9VtrIT5m7s=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=ZGc4Dp9pFYJB3Qk84ZMLh8zkmFk5HHHd/Bjgs6SCzp5+3kOiR1vyYsgvfrAbVT/Ff 2jDaPOyMG8UPPNXpBDb/5EPhgpr1ecE/3RDWHo+OPFjEjsULvaGx2/uCp2SUxnHwp8 2kgoIE+MGS/QX0+BoPSCYb5l0NifbdP8+YDbGTiMnAeUaOwZjfdj9JspGUvd3MngMd vfoPduAzugr5SYmF7FNqwTTgv7iLSPLECf9Dh31REt+cHXFsAgjnPT7k/w0jv3UwSi tvPdS1/k16VJ/TZKFBiHDwKJ5Dbo8i/UY5MVq7Rx9Xbfj1Zx7Eo6ms08CNTMyUk9a3 vQtq7fNqMx6Rg== Received: by mail-ej1-f41.google.com with SMTP id bl23so16599651ejb.5; Sat, 30 Jan 2021 01:50:38 -0800 (PST) X-Gm-Message-State: AOAM533wa0Ytk0/C14HKA0MP2j9NKcgRTr0TjptPKPt7sW+lK3ymaHXf fj+W+sQ2mnNxXKw5kKeGZM/0/w3S8m+ZGF4Ong== X-Google-Smtp-Source: ABdhPJxwx47bk8a8xJ4z+4Bse0bBxxcXlzdas3fZag7eVRjxwW7pgp0Q0F5u63eOPTKakYowMCaLKipX3ONZL2WLuXE= X-Received: by 2002:a17:906:7f98:: with SMTP id f24mr8362943ejr.75.1612000236687; Sat, 30 Jan 2021 01:50:36 -0800 (PST) MIME-Version: 1.0 References: <20210129092209.2584718-1-hsinyi@chromium.org> <20210129092209.2584718-4-hsinyi@chromium.org> In-Reply-To: <20210129092209.2584718-4-hsinyi@chromium.org> From: Chun-Kuang Hu Date: Sat, 30 Jan 2021 17:50:23 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v13 3/8] drm/mediatek: add mtk_dither_set_common() function To: Hsin-Yi Wang Cc: CK Hu , Philipp Zabel , Matthias Brugger , Mark Rutland , DTML , Yongqiang Niu , David Airlie , linux-kernel , DRI Development , "moderated list:ARM/Mediatek SoC support" , Daniel Vetter , Linux ARM Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Hsin-Yi: Hsin-Yi Wang =E6=96=BC 2021=E5=B9=B41=E6=9C=8829=E6= =97=A5 =E9=80=B1=E4=BA=94 =E4=B8=8B=E5=8D=885:23=E5=AF=AB=E9=81=93=EF=BC=9A > > Current implementation of mtk_dither_set() cast dev data to > struct mtk_ddp_comp_dev. But other devices with different dev data > would also call this function. > > Separate necessary parameters out so other device components (dither, > gamma) can call this function. Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/= log/?h=3Dmediatek-drm-next Regards, Chun-Kuang. > > Signed-off-by: Hsin-Yi Wang > Reviewed-by: CK Hu > --- > drivers/gpu/drm/mediatek/mtk_disp_drv.h | 4 +++ > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 27 ++++++++++++++------- > 2 files changed, 22 insertions(+), 9 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_disp_drv.h b/drivers/gpu/drm/me= diatek/mtk_disp_drv.h > index 46d199b7b4a29..9e5537f76b22a 100644 > --- a/drivers/gpu/drm/mediatek/mtk_disp_drv.h > +++ b/drivers/gpu/drm/mediatek/mtk_disp_drv.h > @@ -17,6 +17,10 @@ void mtk_color_config(struct device *dev, unsigned int= w, > unsigned int bpc, struct cmdq_pkt *cmdq_pkt); > void mtk_color_start(struct device *dev); > > +void mtk_dither_set_common(void __iomem *regs, struct cmdq_client_reg *c= mdq_reg, > + unsigned int bpc, unsigned int cfg, > + unsigned int dither_en, struct cmdq_pkt *cmdq_= pkt); > + > void mtk_dpi_start(struct device *dev); > void mtk_dpi_stop(struct device *dev); > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/dr= m/mediatek/mtk_drm_ddp_comp.c > index 7b5293429426d..07804ab16f44d 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > @@ -151,33 +151,42 @@ static void mtk_ddp_clk_disable(struct device *dev) > clk_disable_unprepare(priv->clk); > } > > -static void mtk_dither_set(struct device *dev, unsigned int bpc, > - unsigned int CFG, struct cmdq_pkt *cmdq_pkt) > -{ > - struct mtk_ddp_comp_dev *priv =3D dev_get_drvdata(dev); > > +void mtk_dither_set_common(void __iomem *regs, struct cmdq_client_reg *c= mdq_reg, > + unsigned int bpc, unsigned int cfg, > + unsigned int dither_en, struct cmdq_pkt *cmdq_= pkt) > +{ > /* If bpc equal to 0, the dithering function didn't be enabled */ > if (bpc =3D=3D 0) > return; > > if (bpc >=3D MTK_MIN_BPC) { > - mtk_ddp_write(cmdq_pkt, 0, &priv->cmdq_reg, priv->regs, D= ISP_DITHER_5); > - mtk_ddp_write(cmdq_pkt, 0, &priv->cmdq_reg, priv->regs, D= ISP_DITHER_7); > + mtk_ddp_write(cmdq_pkt, 0, cmdq_reg, regs, DISP_DITHER_5)= ; > + mtk_ddp_write(cmdq_pkt, 0, cmdq_reg, regs, DISP_DITHER_7)= ; > mtk_ddp_write(cmdq_pkt, > DITHER_LSB_ERR_SHIFT_R(MTK_MAX_BPC - bpc) | > DITHER_ADD_LSHIFT_R(MTK_MAX_BPC - bpc) | > DITHER_NEW_BIT_MODE, > - &priv->cmdq_reg, priv->regs, DISP_DITHER_15= ); > + cmdq_reg, regs, DISP_DITHER_15); > mtk_ddp_write(cmdq_pkt, > DITHER_LSB_ERR_SHIFT_B(MTK_MAX_BPC - bpc) | > DITHER_ADD_LSHIFT_B(MTK_MAX_BPC - bpc) | > DITHER_LSB_ERR_SHIFT_G(MTK_MAX_BPC - bpc) | > DITHER_ADD_LSHIFT_G(MTK_MAX_BPC - bpc), > - &priv->cmdq_reg, priv->regs, DISP_DITHER_16= ); > - mtk_ddp_write(cmdq_pkt, DISP_DITHERING, &priv->cmdq_reg, = priv->regs, CFG); > + cmdq_reg, regs, DISP_DITHER_16); > + mtk_ddp_write(cmdq_pkt, dither_en, cmdq_reg, regs, cfg); > } > } > > +static void mtk_dither_set(struct device *dev, unsigned int bpc, > + unsigned int cfg, struct cmdq_pkt *cmdq_pkt) > +{ > + struct mtk_ddp_comp_dev *priv =3D dev_get_drvdata(dev); > + > + mtk_dither_set_common(priv->regs, &priv->cmdq_reg, bpc, cfg, > + DISP_DITHERING, cmdq_pkt); > +} > + > static void mtk_od_config(struct device *dev, unsigned int w, > unsigned int h, unsigned int vrefresh, > unsigned int bpc, struct cmdq_pkt *cmdq_pkt) > -- > 2.30.0.365.g02bc693789-goog > > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4461BC433DB for ; Sat, 30 Jan 2021 09:50:52 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ED17B64E09 for ; Sat, 30 Jan 2021 09:50:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ED17B64E09 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IN2hfhusnNrIX8mWXq8pp7GsMgFeidx2jB7JhiBDwLw=; b=QurpNZUlMeYiH6FE9+N9KQ/VS QYP/3X4yYabWGaxETjIt/TOayRQxtT4cbEGy1fKvRTCL9f9lpTH/hmaGOio9sSqXWLdc5VQ900UpM nlCbrS8oiFqhGaafWmQCy+78/5HMblIftO7Fx2QyuguAZh/wM7nxjCO03xmXbU8ZYrsuPHtvp6vr5 lEMUJ28zhEyCXXnBJmri6hhJPxcT3ebWzumDxWSJJBKdRV3v0WDfYbKAp7Ia5tbefgMuProtqyTan TAeh9dwKbSH1IEen223rW6C7xYPoAvra5gllo/8+/B6vWsN2w8rugpVxdjHeT9UgMIFvoG8kgAlim vR4ieFVEg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l5mtu-0002jT-Qj; Sat, 30 Jan 2021 09:50:42 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l5mtr-0002ib-J6; Sat, 30 Jan 2021 09:50:40 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 18CC564E06; Sat, 30 Jan 2021 09:50:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612000238; bh=LgbTJ3tIY4Lnts/jruQ5ky4J32Gja9Xar9VtrIT5m7s=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=ZGc4Dp9pFYJB3Qk84ZMLh8zkmFk5HHHd/Bjgs6SCzp5+3kOiR1vyYsgvfrAbVT/Ff 2jDaPOyMG8UPPNXpBDb/5EPhgpr1ecE/3RDWHo+OPFjEjsULvaGx2/uCp2SUxnHwp8 2kgoIE+MGS/QX0+BoPSCYb5l0NifbdP8+YDbGTiMnAeUaOwZjfdj9JspGUvd3MngMd vfoPduAzugr5SYmF7FNqwTTgv7iLSPLECf9Dh31REt+cHXFsAgjnPT7k/w0jv3UwSi tvPdS1/k16VJ/TZKFBiHDwKJ5Dbo8i/UY5MVq7Rx9Xbfj1Zx7Eo6ms08CNTMyUk9a3 vQtq7fNqMx6Rg== Received: by mail-ej1-f48.google.com with SMTP id rv9so16549537ejb.13; Sat, 30 Jan 2021 01:50:38 -0800 (PST) X-Gm-Message-State: AOAM533bBp96/udTlEtsDungeoxyE69KsQ/5J2CvFntS3l5n2S0Eoa7u laJlimQlN6vMxF2qwlnr0j/r0tSzSbyjxn5Ccw== X-Google-Smtp-Source: ABdhPJxwx47bk8a8xJ4z+4Bse0bBxxcXlzdas3fZag7eVRjxwW7pgp0Q0F5u63eOPTKakYowMCaLKipX3ONZL2WLuXE= X-Received: by 2002:a17:906:7f98:: with SMTP id f24mr8362943ejr.75.1612000236687; Sat, 30 Jan 2021 01:50:36 -0800 (PST) MIME-Version: 1.0 References: <20210129092209.2584718-1-hsinyi@chromium.org> <20210129092209.2584718-4-hsinyi@chromium.org> In-Reply-To: <20210129092209.2584718-4-hsinyi@chromium.org> From: Chun-Kuang Hu Date: Sat, 30 Jan 2021 17:50:23 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v13 3/8] drm/mediatek: add mtk_dither_set_common() function To: Hsin-Yi Wang X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210130_045039_781478_08937616 X-CRM114-Status: GOOD ( 20.65 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , DTML , Philipp Zabel , David Airlie , linux-kernel , DRI Development , Matthias Brugger , "moderated list:ARM/Mediatek SoC support" , Yongqiang Niu , CK Hu , Daniel Vetter , Linux ARM Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org SGksIEhzaW4tWWk6CgpIc2luLVlpIFdhbmcgPGhzaW55aUBjaHJvbWl1bS5vcmc+IOaWvCAyMDIx 5bm0MeaciDI55pelIOmAseS6lCDkuIvljYg1OjIz5a+r6YGT77yaCj4KPiBDdXJyZW50IGltcGxl bWVudGF0aW9uIG9mIG10a19kaXRoZXJfc2V0KCkgY2FzdCBkZXYgZGF0YSB0bwo+IHN0cnVjdCBt dGtfZGRwX2NvbXBfZGV2LiBCdXQgb3RoZXIgZGV2aWNlcyB3aXRoIGRpZmZlcmVudCBkZXYgZGF0 YQo+IHdvdWxkIGFsc28gY2FsbCB0aGlzIGZ1bmN0aW9uLgo+Cj4gU2VwYXJhdGUgbmVjZXNzYXJ5 IHBhcmFtZXRlcnMgb3V0IHNvIG90aGVyIGRldmljZSBjb21wb25lbnRzIChkaXRoZXIsCj4gZ2Ft bWEpIGNhbiBjYWxsIHRoaXMgZnVuY3Rpb24uCgpBcHBsaWVkIHRvIG1lZGlhdGVrLWRybS1uZXh0 IFsxXSwgdGhhbmtzLgoKWzFdIGh0dHBzOi8vZ2l0Lmtlcm5lbC5vcmcvcHViL3NjbS9saW51eC9r ZXJuZWwvZ2l0L2NodW5rdWFuZy5odS9saW51eC5naXQvbG9nLz9oPW1lZGlhdGVrLWRybS1uZXh0 CgpSZWdhcmRzLApDaHVuLUt1YW5nLgoKPgo+IFNpZ25lZC1vZmYtYnk6IEhzaW4tWWkgV2FuZyA8 aHNpbnlpQGNocm9taXVtLm9yZz4KPiBSZXZpZXdlZC1ieTogQ0sgSHUgPGNrLmh1QG1lZGlhdGVr LmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kaXNwX2Rydi5oICAg ICB8ICA0ICsrKwo+ICBkcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9kZHBfY29tcC5j IHwgMjcgKysrKysrKysrKysrKystLS0tLS0tCj4gIDIgZmlsZXMgY2hhbmdlZCwgMjIgaW5zZXJ0 aW9ucygrKSwgOSBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v bWVkaWF0ZWsvbXRrX2Rpc3BfZHJ2LmggYi9kcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2Rp c3BfZHJ2LmgKPiBpbmRleCA0NmQxOTliN2I0YTI5Li45ZTU1MzdmNzZiMjJhIDEwMDY0NAo+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZGlzcF9kcnYuaAo+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZGlzcF9kcnYuaAo+IEBAIC0xNyw2ICsxNywxMCBAQCB2 b2lkIG10a19jb2xvcl9jb25maWcoc3RydWN0IGRldmljZSAqZGV2LCB1bnNpZ25lZCBpbnQgdywK PiAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IGJwYywgc3RydWN0IGNtZHFfcGt0 ICpjbWRxX3BrdCk7Cj4gIHZvaWQgbXRrX2NvbG9yX3N0YXJ0KHN0cnVjdCBkZXZpY2UgKmRldik7 Cj4KPiArdm9pZCBtdGtfZGl0aGVyX3NldF9jb21tb24odm9pZCBfX2lvbWVtICpyZWdzLCBzdHJ1 Y3QgY21kcV9jbGllbnRfcmVnICpjbWRxX3JlZywKPiArICAgICAgICAgICAgICAgICAgICAgICAg ICB1bnNpZ25lZCBpbnQgYnBjLCB1bnNpZ25lZCBpbnQgY2ZnLAo+ICsgICAgICAgICAgICAgICAg ICAgICAgICAgIHVuc2lnbmVkIGludCBkaXRoZXJfZW4sIHN0cnVjdCBjbWRxX3BrdCAqY21kcV9w a3QpOwo+ICsKPiAgdm9pZCBtdGtfZHBpX3N0YXJ0KHN0cnVjdCBkZXZpY2UgKmRldik7Cj4gIHZv aWQgbXRrX2RwaV9zdG9wKHN0cnVjdCBkZXZpY2UgKmRldik7Cj4KPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fZGRwX2NvbXAuYyBiL2RyaXZlcnMvZ3B1L2Ry bS9tZWRpYXRlay9tdGtfZHJtX2RkcF9jb21wLmMKPiBpbmRleCA3YjUyOTM0Mjk0MjZkLi4wNzgw NGFiMTZmNDRkIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJt X2RkcF9jb21wLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9kZHBf Y29tcC5jCj4gQEAgLTE1MSwzMyArMTUxLDQyIEBAIHN0YXRpYyB2b2lkIG10a19kZHBfY2xrX2Rp c2FibGUoc3RydWN0IGRldmljZSAqZGV2KQo+ICAgICAgICAgY2xrX2Rpc2FibGVfdW5wcmVwYXJl KHByaXYtPmNsayk7Cj4gIH0KPgo+IC1zdGF0aWMgdm9pZCBtdGtfZGl0aGVyX3NldChzdHJ1Y3Qg ZGV2aWNlICpkZXYsIHVuc2lnbmVkIGludCBicGMsCj4gLSAgICAgICAgICAgICAgICAgICB1bnNp Z25lZCBpbnQgQ0ZHLCBzdHJ1Y3QgY21kcV9wa3QgKmNtZHFfcGt0KQo+IC17Cj4gLSAgICAgICBz dHJ1Y3QgbXRrX2RkcF9jb21wX2RldiAqcHJpdiA9IGRldl9nZXRfZHJ2ZGF0YShkZXYpOwo+Cj4g K3ZvaWQgbXRrX2RpdGhlcl9zZXRfY29tbW9uKHZvaWQgX19pb21lbSAqcmVncywgc3RydWN0IGNt ZHFfY2xpZW50X3JlZyAqY21kcV9yZWcsCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgdW5z aWduZWQgaW50IGJwYywgdW5zaWduZWQgaW50IGNmZywKPiArICAgICAgICAgICAgICAgICAgICAg ICAgICB1bnNpZ25lZCBpbnQgZGl0aGVyX2VuLCBzdHJ1Y3QgY21kcV9wa3QgKmNtZHFfcGt0KQo+ ICt7Cj4gICAgICAgICAvKiBJZiBicGMgZXF1YWwgdG8gMCwgdGhlIGRpdGhlcmluZyBmdW5jdGlv biBkaWRuJ3QgYmUgZW5hYmxlZCAqLwo+ICAgICAgICAgaWYgKGJwYyA9PSAwKQo+ICAgICAgICAg ICAgICAgICByZXR1cm47Cj4KPiAgICAgICAgIGlmIChicGMgPj0gTVRLX01JTl9CUEMpIHsKPiAt ICAgICAgICAgICAgICAgbXRrX2RkcF93cml0ZShjbWRxX3BrdCwgMCwgJnByaXYtPmNtZHFfcmVn LCBwcml2LT5yZWdzLCBESVNQX0RJVEhFUl81KTsKPiAtICAgICAgICAgICAgICAgbXRrX2RkcF93 cml0ZShjbWRxX3BrdCwgMCwgJnByaXYtPmNtZHFfcmVnLCBwcml2LT5yZWdzLCBESVNQX0RJVEhF Ul83KTsKPiArICAgICAgICAgICAgICAgbXRrX2RkcF93cml0ZShjbWRxX3BrdCwgMCwgY21kcV9y ZWcsIHJlZ3MsIERJU1BfRElUSEVSXzUpOwo+ICsgICAgICAgICAgICAgICBtdGtfZGRwX3dyaXRl KGNtZHFfcGt0LCAwLCBjbWRxX3JlZywgcmVncywgRElTUF9ESVRIRVJfNyk7Cj4gICAgICAgICAg ICAgICAgIG10a19kZHBfd3JpdGUoY21kcV9wa3QsCj4gICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgRElUSEVSX0xTQl9FUlJfU0hJRlRfUihNVEtfTUFYX0JQQyAtIGJwYykgfAo+ICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIERJVEhFUl9BRERfTFNISUZUX1IoTVRLX01BWF9CUEMg LSBicGMpIHwKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBESVRIRVJfTkVXX0JJVF9N T0RFLAo+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICZwcml2LT5jbWRxX3JlZywgcHJp di0+cmVncywgRElTUF9ESVRIRVJfMTUpOwo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAg IGNtZHFfcmVnLCByZWdzLCBESVNQX0RJVEhFUl8xNSk7Cj4gICAgICAgICAgICAgICAgIG10a19k ZHBfd3JpdGUoY21kcV9wa3QsCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgRElUSEVS X0xTQl9FUlJfU0hJRlRfQihNVEtfTUFYX0JQQyAtIGJwYykgfAo+ICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIERJVEhFUl9BRERfTFNISUZUX0IoTVRLX01BWF9CUEMgLSBicGMpIHwKPiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBESVRIRVJfTFNCX0VSUl9TSElGVF9HKE1US19N QVhfQlBDIC0gYnBjKSB8Cj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgRElUSEVSX0FE RF9MU0hJRlRfRyhNVEtfTUFYX0JQQyAtIGJwYyksCj4gLSAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgJnByaXYtPmNtZHFfcmVnLCBwcml2LT5yZWdzLCBESVNQX0RJVEhFUl8xNik7Cj4gLSAg ICAgICAgICAgICAgIG10a19kZHBfd3JpdGUoY21kcV9wa3QsIERJU1BfRElUSEVSSU5HLCAmcHJp di0+Y21kcV9yZWcsIHByaXYtPnJlZ3MsIENGRyk7Cj4gKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgY21kcV9yZWcsIHJlZ3MsIERJU1BfRElUSEVSXzE2KTsKPiArICAgICAgICAgICAgICAg bXRrX2RkcF93cml0ZShjbWRxX3BrdCwgZGl0aGVyX2VuLCBjbWRxX3JlZywgcmVncywgY2ZnKTsK PiAgICAgICAgIH0KPiAgfQo+Cj4gK3N0YXRpYyB2b2lkIG10a19kaXRoZXJfc2V0KHN0cnVjdCBk ZXZpY2UgKmRldiwgdW5zaWduZWQgaW50IGJwYywKPiArICAgICAgICAgICAgICAgICAgIHVuc2ln bmVkIGludCBjZmcsIHN0cnVjdCBjbWRxX3BrdCAqY21kcV9wa3QpCj4gK3sKPiArICAgICAgIHN0 cnVjdCBtdGtfZGRwX2NvbXBfZGV2ICpwcml2ID0gZGV2X2dldF9kcnZkYXRhKGRldik7Cj4gKwo+ ICsgICAgICAgbXRrX2RpdGhlcl9zZXRfY29tbW9uKHByaXYtPnJlZ3MsICZwcml2LT5jbWRxX3Jl ZywgYnBjLCBjZmcsCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgRElTUF9ESVRIRVJJ TkcsIGNtZHFfcGt0KTsKPiArfQo+ICsKPiAgc3RhdGljIHZvaWQgbXRrX29kX2NvbmZpZyhzdHJ1 Y3QgZGV2aWNlICpkZXYsIHVuc2lnbmVkIGludCB3LAo+ICAgICAgICAgICAgICAgICAgICAgICAg ICAgdW5zaWduZWQgaW50IGgsIHVuc2lnbmVkIGludCB2cmVmcmVzaCwKPiAgICAgICAgICAgICAg ICAgICAgICAgICAgIHVuc2lnbmVkIGludCBicGMsIHN0cnVjdCBjbWRxX3BrdCAqY21kcV9wa3Qp Cj4gLS0KPiAyLjMwLjAuMzY1LmcwMmJjNjkzNzg5LWdvb2cKPgo+Cj4gX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBMaW51eC1tZWRpYXRlayBtYWlsaW5n IGxpc3QKPiBMaW51eC1tZWRpYXRla0BsaXN0cy5pbmZyYWRlYWQub3JnCj4gaHR0cDovL2xpc3Rz LmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1tZWRpYXRlawoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXgtbWVkaWF0ZWsgbWFp bGluZyBsaXN0CkxpbnV4LW1lZGlhdGVrQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3Rz LmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1tZWRpYXRlawo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B97DBC433DB for ; Sat, 30 Jan 2021 09:51:54 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7226C64E06 for ; Sat, 30 Jan 2021 09:51:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7226C64E06 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=eQRXutVmYwvpl3woW3ePSo1l77/dWgD+/ZgR5De0Sdo=; b=Tpcn7IxocsQ5RjKK8EYT1zXtK c5OobCdMw3+9kqUZo8Yd5kOiXOQ7KVeD2ngOgfOU4C6GyNivzF2+MOXc4i3ZCyJzx50Ocrw1bs0fx 4RIfFsILaV06CZgjkzfooUgiODtg4e4zbHQGSUJJeqy6heT9BLpjGh55HzG8X5/kUNH/0Yh2eVPzJ /IcYZZKC6UFskg/vnQRH+clqgf1UEw3bcj2iyA1OpUgB3XHYNg5p0zeYXV97FOBYuzUP6atCbHHLl NiQOpMAsmcLj0c9/LEjHOjJhExpl9xhfh4o81fQH4qOpXNTxkWq6QTo+vr9GvNvsiWdwJQiqZ2a7l HCYytbLpw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l5mtt-0002jB-ED; Sat, 30 Jan 2021 09:50:41 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l5mtr-0002ib-J6; Sat, 30 Jan 2021 09:50:40 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 18CC564E06; Sat, 30 Jan 2021 09:50:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612000238; bh=LgbTJ3tIY4Lnts/jruQ5ky4J32Gja9Xar9VtrIT5m7s=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=ZGc4Dp9pFYJB3Qk84ZMLh8zkmFk5HHHd/Bjgs6SCzp5+3kOiR1vyYsgvfrAbVT/Ff 2jDaPOyMG8UPPNXpBDb/5EPhgpr1ecE/3RDWHo+OPFjEjsULvaGx2/uCp2SUxnHwp8 2kgoIE+MGS/QX0+BoPSCYb5l0NifbdP8+YDbGTiMnAeUaOwZjfdj9JspGUvd3MngMd vfoPduAzugr5SYmF7FNqwTTgv7iLSPLECf9Dh31REt+cHXFsAgjnPT7k/w0jv3UwSi tvPdS1/k16VJ/TZKFBiHDwKJ5Dbo8i/UY5MVq7Rx9Xbfj1Zx7Eo6ms08CNTMyUk9a3 vQtq7fNqMx6Rg== Received: by mail-ej1-f48.google.com with SMTP id rv9so16549537ejb.13; Sat, 30 Jan 2021 01:50:38 -0800 (PST) X-Gm-Message-State: AOAM533bBp96/udTlEtsDungeoxyE69KsQ/5J2CvFntS3l5n2S0Eoa7u laJlimQlN6vMxF2qwlnr0j/r0tSzSbyjxn5Ccw== X-Google-Smtp-Source: ABdhPJxwx47bk8a8xJ4z+4Bse0bBxxcXlzdas3fZag7eVRjxwW7pgp0Q0F5u63eOPTKakYowMCaLKipX3ONZL2WLuXE= X-Received: by 2002:a17:906:7f98:: with SMTP id f24mr8362943ejr.75.1612000236687; Sat, 30 Jan 2021 01:50:36 -0800 (PST) MIME-Version: 1.0 References: <20210129092209.2584718-1-hsinyi@chromium.org> <20210129092209.2584718-4-hsinyi@chromium.org> In-Reply-To: <20210129092209.2584718-4-hsinyi@chromium.org> From: Chun-Kuang Hu Date: Sat, 30 Jan 2021 17:50:23 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v13 3/8] drm/mediatek: add mtk_dither_set_common() function To: Hsin-Yi Wang X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210130_045039_781478_08937616 X-CRM114-Status: GOOD ( 20.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , DTML , Philipp Zabel , David Airlie , linux-kernel , DRI Development , Matthias Brugger , "moderated list:ARM/Mediatek SoC support" , Yongqiang Niu , CK Hu , Daniel Vetter , Linux ARM Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGksIEhzaW4tWWk6CgpIc2luLVlpIFdhbmcgPGhzaW55aUBjaHJvbWl1bS5vcmc+IOaWvCAyMDIx 5bm0MeaciDI55pelIOmAseS6lCDkuIvljYg1OjIz5a+r6YGT77yaCj4KPiBDdXJyZW50IGltcGxl bWVudGF0aW9uIG9mIG10a19kaXRoZXJfc2V0KCkgY2FzdCBkZXYgZGF0YSB0bwo+IHN0cnVjdCBt dGtfZGRwX2NvbXBfZGV2LiBCdXQgb3RoZXIgZGV2aWNlcyB3aXRoIGRpZmZlcmVudCBkZXYgZGF0 YQo+IHdvdWxkIGFsc28gY2FsbCB0aGlzIGZ1bmN0aW9uLgo+Cj4gU2VwYXJhdGUgbmVjZXNzYXJ5 IHBhcmFtZXRlcnMgb3V0IHNvIG90aGVyIGRldmljZSBjb21wb25lbnRzIChkaXRoZXIsCj4gZ2Ft bWEpIGNhbiBjYWxsIHRoaXMgZnVuY3Rpb24uCgpBcHBsaWVkIHRvIG1lZGlhdGVrLWRybS1uZXh0 IFsxXSwgdGhhbmtzLgoKWzFdIGh0dHBzOi8vZ2l0Lmtlcm5lbC5vcmcvcHViL3NjbS9saW51eC9r ZXJuZWwvZ2l0L2NodW5rdWFuZy5odS9saW51eC5naXQvbG9nLz9oPW1lZGlhdGVrLWRybS1uZXh0 CgpSZWdhcmRzLApDaHVuLUt1YW5nLgoKPgo+IFNpZ25lZC1vZmYtYnk6IEhzaW4tWWkgV2FuZyA8 aHNpbnlpQGNocm9taXVtLm9yZz4KPiBSZXZpZXdlZC1ieTogQ0sgSHUgPGNrLmh1QG1lZGlhdGVr LmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kaXNwX2Rydi5oICAg ICB8ICA0ICsrKwo+ICBkcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9kZHBfY29tcC5j IHwgMjcgKysrKysrKysrKysrKystLS0tLS0tCj4gIDIgZmlsZXMgY2hhbmdlZCwgMjIgaW5zZXJ0 aW9ucygrKSwgOSBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v bWVkaWF0ZWsvbXRrX2Rpc3BfZHJ2LmggYi9kcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2Rp c3BfZHJ2LmgKPiBpbmRleCA0NmQxOTliN2I0YTI5Li45ZTU1MzdmNzZiMjJhIDEwMDY0NAo+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZGlzcF9kcnYuaAo+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZGlzcF9kcnYuaAo+IEBAIC0xNyw2ICsxNywxMCBAQCB2 b2lkIG10a19jb2xvcl9jb25maWcoc3RydWN0IGRldmljZSAqZGV2LCB1bnNpZ25lZCBpbnQgdywK PiAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IGJwYywgc3RydWN0IGNtZHFfcGt0 ICpjbWRxX3BrdCk7Cj4gIHZvaWQgbXRrX2NvbG9yX3N0YXJ0KHN0cnVjdCBkZXZpY2UgKmRldik7 Cj4KPiArdm9pZCBtdGtfZGl0aGVyX3NldF9jb21tb24odm9pZCBfX2lvbWVtICpyZWdzLCBzdHJ1 Y3QgY21kcV9jbGllbnRfcmVnICpjbWRxX3JlZywKPiArICAgICAgICAgICAgICAgICAgICAgICAg ICB1bnNpZ25lZCBpbnQgYnBjLCB1bnNpZ25lZCBpbnQgY2ZnLAo+ICsgICAgICAgICAgICAgICAg ICAgICAgICAgIHVuc2lnbmVkIGludCBkaXRoZXJfZW4sIHN0cnVjdCBjbWRxX3BrdCAqY21kcV9w a3QpOwo+ICsKPiAgdm9pZCBtdGtfZHBpX3N0YXJ0KHN0cnVjdCBkZXZpY2UgKmRldik7Cj4gIHZv aWQgbXRrX2RwaV9zdG9wKHN0cnVjdCBkZXZpY2UgKmRldik7Cj4KPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fZGRwX2NvbXAuYyBiL2RyaXZlcnMvZ3B1L2Ry bS9tZWRpYXRlay9tdGtfZHJtX2RkcF9jb21wLmMKPiBpbmRleCA3YjUyOTM0Mjk0MjZkLi4wNzgw NGFiMTZmNDRkIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJt X2RkcF9jb21wLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9kZHBf Y29tcC5jCj4gQEAgLTE1MSwzMyArMTUxLDQyIEBAIHN0YXRpYyB2b2lkIG10a19kZHBfY2xrX2Rp c2FibGUoc3RydWN0IGRldmljZSAqZGV2KQo+ICAgICAgICAgY2xrX2Rpc2FibGVfdW5wcmVwYXJl KHByaXYtPmNsayk7Cj4gIH0KPgo+IC1zdGF0aWMgdm9pZCBtdGtfZGl0aGVyX3NldChzdHJ1Y3Qg ZGV2aWNlICpkZXYsIHVuc2lnbmVkIGludCBicGMsCj4gLSAgICAgICAgICAgICAgICAgICB1bnNp Z25lZCBpbnQgQ0ZHLCBzdHJ1Y3QgY21kcV9wa3QgKmNtZHFfcGt0KQo+IC17Cj4gLSAgICAgICBz dHJ1Y3QgbXRrX2RkcF9jb21wX2RldiAqcHJpdiA9IGRldl9nZXRfZHJ2ZGF0YShkZXYpOwo+Cj4g K3ZvaWQgbXRrX2RpdGhlcl9zZXRfY29tbW9uKHZvaWQgX19pb21lbSAqcmVncywgc3RydWN0IGNt ZHFfY2xpZW50X3JlZyAqY21kcV9yZWcsCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgdW5z aWduZWQgaW50IGJwYywgdW5zaWduZWQgaW50IGNmZywKPiArICAgICAgICAgICAgICAgICAgICAg ICAgICB1bnNpZ25lZCBpbnQgZGl0aGVyX2VuLCBzdHJ1Y3QgY21kcV9wa3QgKmNtZHFfcGt0KQo+ ICt7Cj4gICAgICAgICAvKiBJZiBicGMgZXF1YWwgdG8gMCwgdGhlIGRpdGhlcmluZyBmdW5jdGlv biBkaWRuJ3QgYmUgZW5hYmxlZCAqLwo+ICAgICAgICAgaWYgKGJwYyA9PSAwKQo+ICAgICAgICAg ICAgICAgICByZXR1cm47Cj4KPiAgICAgICAgIGlmIChicGMgPj0gTVRLX01JTl9CUEMpIHsKPiAt ICAgICAgICAgICAgICAgbXRrX2RkcF93cml0ZShjbWRxX3BrdCwgMCwgJnByaXYtPmNtZHFfcmVn LCBwcml2LT5yZWdzLCBESVNQX0RJVEhFUl81KTsKPiAtICAgICAgICAgICAgICAgbXRrX2RkcF93 cml0ZShjbWRxX3BrdCwgMCwgJnByaXYtPmNtZHFfcmVnLCBwcml2LT5yZWdzLCBESVNQX0RJVEhF Ul83KTsKPiArICAgICAgICAgICAgICAgbXRrX2RkcF93cml0ZShjbWRxX3BrdCwgMCwgY21kcV9y ZWcsIHJlZ3MsIERJU1BfRElUSEVSXzUpOwo+ICsgICAgICAgICAgICAgICBtdGtfZGRwX3dyaXRl KGNtZHFfcGt0LCAwLCBjbWRxX3JlZywgcmVncywgRElTUF9ESVRIRVJfNyk7Cj4gICAgICAgICAg ICAgICAgIG10a19kZHBfd3JpdGUoY21kcV9wa3QsCj4gICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgRElUSEVSX0xTQl9FUlJfU0hJRlRfUihNVEtfTUFYX0JQQyAtIGJwYykgfAo+ICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIERJVEhFUl9BRERfTFNISUZUX1IoTVRLX01BWF9CUEMg LSBicGMpIHwKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBESVRIRVJfTkVXX0JJVF9N T0RFLAo+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICZwcml2LT5jbWRxX3JlZywgcHJp di0+cmVncywgRElTUF9ESVRIRVJfMTUpOwo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAg IGNtZHFfcmVnLCByZWdzLCBESVNQX0RJVEhFUl8xNSk7Cj4gICAgICAgICAgICAgICAgIG10a19k ZHBfd3JpdGUoY21kcV9wa3QsCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgRElUSEVS X0xTQl9FUlJfU0hJRlRfQihNVEtfTUFYX0JQQyAtIGJwYykgfAo+ICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIERJVEhFUl9BRERfTFNISUZUX0IoTVRLX01BWF9CUEMgLSBicGMpIHwKPiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBESVRIRVJfTFNCX0VSUl9TSElGVF9HKE1US19N QVhfQlBDIC0gYnBjKSB8Cj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgRElUSEVSX0FE RF9MU0hJRlRfRyhNVEtfTUFYX0JQQyAtIGJwYyksCj4gLSAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgJnByaXYtPmNtZHFfcmVnLCBwcml2LT5yZWdzLCBESVNQX0RJVEhFUl8xNik7Cj4gLSAg ICAgICAgICAgICAgIG10a19kZHBfd3JpdGUoY21kcV9wa3QsIERJU1BfRElUSEVSSU5HLCAmcHJp di0+Y21kcV9yZWcsIHByaXYtPnJlZ3MsIENGRyk7Cj4gKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgY21kcV9yZWcsIHJlZ3MsIERJU1BfRElUSEVSXzE2KTsKPiArICAgICAgICAgICAgICAg bXRrX2RkcF93cml0ZShjbWRxX3BrdCwgZGl0aGVyX2VuLCBjbWRxX3JlZywgcmVncywgY2ZnKTsK PiAgICAgICAgIH0KPiAgfQo+Cj4gK3N0YXRpYyB2b2lkIG10a19kaXRoZXJfc2V0KHN0cnVjdCBk ZXZpY2UgKmRldiwgdW5zaWduZWQgaW50IGJwYywKPiArICAgICAgICAgICAgICAgICAgIHVuc2ln bmVkIGludCBjZmcsIHN0cnVjdCBjbWRxX3BrdCAqY21kcV9wa3QpCj4gK3sKPiArICAgICAgIHN0 cnVjdCBtdGtfZGRwX2NvbXBfZGV2ICpwcml2ID0gZGV2X2dldF9kcnZkYXRhKGRldik7Cj4gKwo+ ICsgICAgICAgbXRrX2RpdGhlcl9zZXRfY29tbW9uKHByaXYtPnJlZ3MsICZwcml2LT5jbWRxX3Jl ZywgYnBjLCBjZmcsCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgRElTUF9ESVRIRVJJ TkcsIGNtZHFfcGt0KTsKPiArfQo+ICsKPiAgc3RhdGljIHZvaWQgbXRrX29kX2NvbmZpZyhzdHJ1 Y3QgZGV2aWNlICpkZXYsIHVuc2lnbmVkIGludCB3LAo+ICAgICAgICAgICAgICAgICAgICAgICAg ICAgdW5zaWduZWQgaW50IGgsIHVuc2lnbmVkIGludCB2cmVmcmVzaCwKPiAgICAgICAgICAgICAg ICAgICAgICAgICAgIHVuc2lnbmVkIGludCBicGMsIHN0cnVjdCBjbWRxX3BrdCAqY21kcV9wa3Qp Cj4gLS0KPiAyLjMwLjAuMzY1LmcwMmJjNjkzNzg5LWdvb2cKPgo+Cj4gX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBMaW51eC1tZWRpYXRlayBtYWlsaW5n IGxpc3QKPiBMaW51eC1tZWRpYXRla0BsaXN0cy5pbmZyYWRlYWQub3JnCj4gaHR0cDovL2xpc3Rz LmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1tZWRpYXRlawoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBt YWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9s aXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C16BC433DB for ; Sat, 30 Jan 2021 09:50:40 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 230EF64E13 for ; Sat, 30 Jan 2021 09:50:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 230EF64E13 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E476D6E030; Sat, 30 Jan 2021 09:50:38 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id 79B3A6E030 for ; Sat, 30 Jan 2021 09:50:38 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 0F36D64E0C for ; Sat, 30 Jan 2021 09:50:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612000238; bh=LgbTJ3tIY4Lnts/jruQ5ky4J32Gja9Xar9VtrIT5m7s=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=ZGc4Dp9pFYJB3Qk84ZMLh8zkmFk5HHHd/Bjgs6SCzp5+3kOiR1vyYsgvfrAbVT/Ff 2jDaPOyMG8UPPNXpBDb/5EPhgpr1ecE/3RDWHo+OPFjEjsULvaGx2/uCp2SUxnHwp8 2kgoIE+MGS/QX0+BoPSCYb5l0NifbdP8+YDbGTiMnAeUaOwZjfdj9JspGUvd3MngMd vfoPduAzugr5SYmF7FNqwTTgv7iLSPLECf9Dh31REt+cHXFsAgjnPT7k/w0jv3UwSi tvPdS1/k16VJ/TZKFBiHDwKJ5Dbo8i/UY5MVq7Rx9Xbfj1Zx7Eo6ms08CNTMyUk9a3 vQtq7fNqMx6Rg== Received: by mail-ej1-f49.google.com with SMTP id ox12so16638782ejb.2 for ; Sat, 30 Jan 2021 01:50:37 -0800 (PST) X-Gm-Message-State: AOAM530j82SohYwYJe1/WzkXzImz4WdHe1RUF1Fj555VVTuZROADKF+Z xRpoJqTiOV6/70+wyPZOMfjNht2y1XNNZU/geA== X-Google-Smtp-Source: ABdhPJxwx47bk8a8xJ4z+4Bse0bBxxcXlzdas3fZag7eVRjxwW7pgp0Q0F5u63eOPTKakYowMCaLKipX3ONZL2WLuXE= X-Received: by 2002:a17:906:7f98:: with SMTP id f24mr8362943ejr.75.1612000236687; Sat, 30 Jan 2021 01:50:36 -0800 (PST) MIME-Version: 1.0 References: <20210129092209.2584718-1-hsinyi@chromium.org> <20210129092209.2584718-4-hsinyi@chromium.org> In-Reply-To: <20210129092209.2584718-4-hsinyi@chromium.org> From: Chun-Kuang Hu Date: Sat, 30 Jan 2021 17:50:23 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v13 3/8] drm/mediatek: add mtk_dither_set_common() function To: Hsin-Yi Wang X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , DTML , David Airlie , linux-kernel , DRI Development , Matthias Brugger , "moderated list:ARM/Mediatek SoC support" , Yongqiang Niu , Linux ARM Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" SGksIEhzaW4tWWk6CgpIc2luLVlpIFdhbmcgPGhzaW55aUBjaHJvbWl1bS5vcmc+IOaWvCAyMDIx 5bm0MeaciDI55pelIOmAseS6lCDkuIvljYg1OjIz5a+r6YGT77yaCj4KPiBDdXJyZW50IGltcGxl bWVudGF0aW9uIG9mIG10a19kaXRoZXJfc2V0KCkgY2FzdCBkZXYgZGF0YSB0bwo+IHN0cnVjdCBt dGtfZGRwX2NvbXBfZGV2LiBCdXQgb3RoZXIgZGV2aWNlcyB3aXRoIGRpZmZlcmVudCBkZXYgZGF0 YQo+IHdvdWxkIGFsc28gY2FsbCB0aGlzIGZ1bmN0aW9uLgo+Cj4gU2VwYXJhdGUgbmVjZXNzYXJ5 IHBhcmFtZXRlcnMgb3V0IHNvIG90aGVyIGRldmljZSBjb21wb25lbnRzIChkaXRoZXIsCj4gZ2Ft bWEpIGNhbiBjYWxsIHRoaXMgZnVuY3Rpb24uCgpBcHBsaWVkIHRvIG1lZGlhdGVrLWRybS1uZXh0 IFsxXSwgdGhhbmtzLgoKWzFdIGh0dHBzOi8vZ2l0Lmtlcm5lbC5vcmcvcHViL3NjbS9saW51eC9r ZXJuZWwvZ2l0L2NodW5rdWFuZy5odS9saW51eC5naXQvbG9nLz9oPW1lZGlhdGVrLWRybS1uZXh0 CgpSZWdhcmRzLApDaHVuLUt1YW5nLgoKPgo+IFNpZ25lZC1vZmYtYnk6IEhzaW4tWWkgV2FuZyA8 aHNpbnlpQGNocm9taXVtLm9yZz4KPiBSZXZpZXdlZC1ieTogQ0sgSHUgPGNrLmh1QG1lZGlhdGVr LmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kaXNwX2Rydi5oICAg ICB8ICA0ICsrKwo+ICBkcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9kZHBfY29tcC5j IHwgMjcgKysrKysrKysrKysrKystLS0tLS0tCj4gIDIgZmlsZXMgY2hhbmdlZCwgMjIgaW5zZXJ0 aW9ucygrKSwgOSBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v bWVkaWF0ZWsvbXRrX2Rpc3BfZHJ2LmggYi9kcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2Rp c3BfZHJ2LmgKPiBpbmRleCA0NmQxOTliN2I0YTI5Li45ZTU1MzdmNzZiMjJhIDEwMDY0NAo+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZGlzcF9kcnYuaAo+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZGlzcF9kcnYuaAo+IEBAIC0xNyw2ICsxNywxMCBAQCB2 b2lkIG10a19jb2xvcl9jb25maWcoc3RydWN0IGRldmljZSAqZGV2LCB1bnNpZ25lZCBpbnQgdywK PiAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IGJwYywgc3RydWN0IGNtZHFfcGt0 ICpjbWRxX3BrdCk7Cj4gIHZvaWQgbXRrX2NvbG9yX3N0YXJ0KHN0cnVjdCBkZXZpY2UgKmRldik7 Cj4KPiArdm9pZCBtdGtfZGl0aGVyX3NldF9jb21tb24odm9pZCBfX2lvbWVtICpyZWdzLCBzdHJ1 Y3QgY21kcV9jbGllbnRfcmVnICpjbWRxX3JlZywKPiArICAgICAgICAgICAgICAgICAgICAgICAg ICB1bnNpZ25lZCBpbnQgYnBjLCB1bnNpZ25lZCBpbnQgY2ZnLAo+ICsgICAgICAgICAgICAgICAg ICAgICAgICAgIHVuc2lnbmVkIGludCBkaXRoZXJfZW4sIHN0cnVjdCBjbWRxX3BrdCAqY21kcV9w a3QpOwo+ICsKPiAgdm9pZCBtdGtfZHBpX3N0YXJ0KHN0cnVjdCBkZXZpY2UgKmRldik7Cj4gIHZv aWQgbXRrX2RwaV9zdG9wKHN0cnVjdCBkZXZpY2UgKmRldik7Cj4KPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fZGRwX2NvbXAuYyBiL2RyaXZlcnMvZ3B1L2Ry bS9tZWRpYXRlay9tdGtfZHJtX2RkcF9jb21wLmMKPiBpbmRleCA3YjUyOTM0Mjk0MjZkLi4wNzgw NGFiMTZmNDRkIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJt X2RkcF9jb21wLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9kZHBf Y29tcC5jCj4gQEAgLTE1MSwzMyArMTUxLDQyIEBAIHN0YXRpYyB2b2lkIG10a19kZHBfY2xrX2Rp c2FibGUoc3RydWN0IGRldmljZSAqZGV2KQo+ICAgICAgICAgY2xrX2Rpc2FibGVfdW5wcmVwYXJl KHByaXYtPmNsayk7Cj4gIH0KPgo+IC1zdGF0aWMgdm9pZCBtdGtfZGl0aGVyX3NldChzdHJ1Y3Qg ZGV2aWNlICpkZXYsIHVuc2lnbmVkIGludCBicGMsCj4gLSAgICAgICAgICAgICAgICAgICB1bnNp Z25lZCBpbnQgQ0ZHLCBzdHJ1Y3QgY21kcV9wa3QgKmNtZHFfcGt0KQo+IC17Cj4gLSAgICAgICBz dHJ1Y3QgbXRrX2RkcF9jb21wX2RldiAqcHJpdiA9IGRldl9nZXRfZHJ2ZGF0YShkZXYpOwo+Cj4g K3ZvaWQgbXRrX2RpdGhlcl9zZXRfY29tbW9uKHZvaWQgX19pb21lbSAqcmVncywgc3RydWN0IGNt ZHFfY2xpZW50X3JlZyAqY21kcV9yZWcsCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgdW5z aWduZWQgaW50IGJwYywgdW5zaWduZWQgaW50IGNmZywKPiArICAgICAgICAgICAgICAgICAgICAg ICAgICB1bnNpZ25lZCBpbnQgZGl0aGVyX2VuLCBzdHJ1Y3QgY21kcV9wa3QgKmNtZHFfcGt0KQo+ ICt7Cj4gICAgICAgICAvKiBJZiBicGMgZXF1YWwgdG8gMCwgdGhlIGRpdGhlcmluZyBmdW5jdGlv biBkaWRuJ3QgYmUgZW5hYmxlZCAqLwo+ICAgICAgICAgaWYgKGJwYyA9PSAwKQo+ICAgICAgICAg ICAgICAgICByZXR1cm47Cj4KPiAgICAgICAgIGlmIChicGMgPj0gTVRLX01JTl9CUEMpIHsKPiAt ICAgICAgICAgICAgICAgbXRrX2RkcF93cml0ZShjbWRxX3BrdCwgMCwgJnByaXYtPmNtZHFfcmVn LCBwcml2LT5yZWdzLCBESVNQX0RJVEhFUl81KTsKPiAtICAgICAgICAgICAgICAgbXRrX2RkcF93 cml0ZShjbWRxX3BrdCwgMCwgJnByaXYtPmNtZHFfcmVnLCBwcml2LT5yZWdzLCBESVNQX0RJVEhF Ul83KTsKPiArICAgICAgICAgICAgICAgbXRrX2RkcF93cml0ZShjbWRxX3BrdCwgMCwgY21kcV9y ZWcsIHJlZ3MsIERJU1BfRElUSEVSXzUpOwo+ICsgICAgICAgICAgICAgICBtdGtfZGRwX3dyaXRl KGNtZHFfcGt0LCAwLCBjbWRxX3JlZywgcmVncywgRElTUF9ESVRIRVJfNyk7Cj4gICAgICAgICAg ICAgICAgIG10a19kZHBfd3JpdGUoY21kcV9wa3QsCj4gICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgRElUSEVSX0xTQl9FUlJfU0hJRlRfUihNVEtfTUFYX0JQQyAtIGJwYykgfAo+ICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIERJVEhFUl9BRERfTFNISUZUX1IoTVRLX01BWF9CUEMg LSBicGMpIHwKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBESVRIRVJfTkVXX0JJVF9N T0RFLAo+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICZwcml2LT5jbWRxX3JlZywgcHJp di0+cmVncywgRElTUF9ESVRIRVJfMTUpOwo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAg IGNtZHFfcmVnLCByZWdzLCBESVNQX0RJVEhFUl8xNSk7Cj4gICAgICAgICAgICAgICAgIG10a19k ZHBfd3JpdGUoY21kcV9wa3QsCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgRElUSEVS X0xTQl9FUlJfU0hJRlRfQihNVEtfTUFYX0JQQyAtIGJwYykgfAo+ICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIERJVEhFUl9BRERfTFNISUZUX0IoTVRLX01BWF9CUEMgLSBicGMpIHwKPiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBESVRIRVJfTFNCX0VSUl9TSElGVF9HKE1US19N QVhfQlBDIC0gYnBjKSB8Cj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgRElUSEVSX0FE RF9MU0hJRlRfRyhNVEtfTUFYX0JQQyAtIGJwYyksCj4gLSAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgJnByaXYtPmNtZHFfcmVnLCBwcml2LT5yZWdzLCBESVNQX0RJVEhFUl8xNik7Cj4gLSAg ICAgICAgICAgICAgIG10a19kZHBfd3JpdGUoY21kcV9wa3QsIERJU1BfRElUSEVSSU5HLCAmcHJp di0+Y21kcV9yZWcsIHByaXYtPnJlZ3MsIENGRyk7Cj4gKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgY21kcV9yZWcsIHJlZ3MsIERJU1BfRElUSEVSXzE2KTsKPiArICAgICAgICAgICAgICAg bXRrX2RkcF93cml0ZShjbWRxX3BrdCwgZGl0aGVyX2VuLCBjbWRxX3JlZywgcmVncywgY2ZnKTsK PiAgICAgICAgIH0KPiAgfQo+Cj4gK3N0YXRpYyB2b2lkIG10a19kaXRoZXJfc2V0KHN0cnVjdCBk ZXZpY2UgKmRldiwgdW5zaWduZWQgaW50IGJwYywKPiArICAgICAgICAgICAgICAgICAgIHVuc2ln bmVkIGludCBjZmcsIHN0cnVjdCBjbWRxX3BrdCAqY21kcV9wa3QpCj4gK3sKPiArICAgICAgIHN0 cnVjdCBtdGtfZGRwX2NvbXBfZGV2ICpwcml2ID0gZGV2X2dldF9kcnZkYXRhKGRldik7Cj4gKwo+ ICsgICAgICAgbXRrX2RpdGhlcl9zZXRfY29tbW9uKHByaXYtPnJlZ3MsICZwcml2LT5jbWRxX3Jl ZywgYnBjLCBjZmcsCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgRElTUF9ESVRIRVJJ TkcsIGNtZHFfcGt0KTsKPiArfQo+ICsKPiAgc3RhdGljIHZvaWQgbXRrX29kX2NvbmZpZyhzdHJ1 Y3QgZGV2aWNlICpkZXYsIHVuc2lnbmVkIGludCB3LAo+ICAgICAgICAgICAgICAgICAgICAgICAg ICAgdW5zaWduZWQgaW50IGgsIHVuc2lnbmVkIGludCB2cmVmcmVzaCwKPiAgICAgICAgICAgICAg ICAgICAgICAgICAgIHVuc2lnbmVkIGludCBicGMsIHN0cnVjdCBjbWRxX3BrdCAqY21kcV9wa3Qp Cj4gLS0KPiAyLjMwLjAuMzY1LmcwMmJjNjkzNzg5LWdvb2cKPgo+Cj4gX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBMaW51eC1tZWRpYXRlayBtYWlsaW5n IGxpc3QKPiBMaW51eC1tZWRpYXRla0BsaXN0cy5pbmZyYWRlYWQub3JnCj4gaHR0cDovL2xpc3Rz LmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1tZWRpYXRlawpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBs aXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK