From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNWANTED_LANGUAGE_BODY, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75A43C433ED for ; Wed, 19 May 2021 11:21:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 503D4613B6 for ; Wed, 19 May 2021 11:21:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349975AbhESLXR (ORCPT ); Wed, 19 May 2021 07:23:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:52572 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241088AbhESLXN (ORCPT ); Wed, 19 May 2021 07:23:13 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 59EFC6108B for ; Wed, 19 May 2021 11:21:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1621423314; bh=fYglNnaQAuxyqNWH/krc3Hg57khobkxg9ya/DgyJ1RQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Q/jAuaSOmf39GSQwhaz77Q8HwKs9NI/MXXDej3zH+ZZ5leN+Gee0CfZC9IdC97cPd FJXNA0CLfB6FzKQeHlUQ0bAO8J4/YZb519tX23nQBxTcKyJQ8bSdsF3rzAxc9MvmxP A5l+cBlPZy8crrKC/CJsg5BdlNVZurEh3kLiVrXZQccx3DAUUeyUdnPpSO9l5q1q9J t8wHD0WuavvnUTn9RALhO1Ws2gViUgrSXj4zzGnFu/YhEvO1ta39iQHxmKORDU72PS 31geyv09Iits+L0Wjt+u2DrIdNF6S9gDeUCo7quGFs6vITfeZPVXH+oL4vxn4QR6u1 Yu9NtpFrJ+ABg== Received: by mail-ed1-f41.google.com with SMTP id g7so2739619edm.4 for ; Wed, 19 May 2021 04:21:54 -0700 (PDT) X-Gm-Message-State: AOAM531ZDr9gPXDTtWaNsHWPh+fQ5Ef9q4uoJhv4gjCBkHzodaAQ7xYk d9VMEEBKXBMYv0p6WoF24YtlcM9Is7U5cL2tfQ== X-Google-Smtp-Source: ABdhPJyhU1VHrUgMaJOH/P0DFczuZUCtXu2r+76ZrF10+WGgIhv+5vQxqqI9hG1DvdaQC+1oa4aSa7YPHzDhOA1Re8U= X-Received: by 2002:aa7:ccc6:: with SMTP id y6mr388400edt.303.1621423312942; Wed, 19 May 2021 04:21:52 -0700 (PDT) MIME-Version: 1.0 References: <20210314233323.23377-1-chunkuang.hu@kernel.org> <20210314233323.23377-2-chunkuang.hu@kernel.org> In-Reply-To: <20210314233323.23377-2-chunkuang.hu@kernel.org> From: Chun-Kuang Hu Date: Wed, 19 May 2021 19:21:42 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/3] mailbox: mtk-cmdq: Remove cmdq_cb_status To: Chun-Kuang Hu Cc: Jassi Brar , Matthias Brugger , Houlong Wei , Bibby Hsieh , Dennis YC Hsieh , linux-kernel , Linux ARM , "moderated list:ARM/Mediatek SoC support" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Jassi: Chun-Kuang Hu =E6=96=BC 2021=E5=B9=B43=E6=9C=8815= =E6=97=A5 =E9=80=B1=E4=B8=80 =E4=B8=8A=E5=8D=887:33=E5=AF=AB=E9=81=93=EF=BC= =9A > > cmdq_cb_status is an error status. Use the standard error number > instead of cmdq_cb_status to prevent status duplication. How do you think about this series? Regards, Chun-Kuang. > > Cc: Jassi Brar > Cc: Matthias Brugger > Cc: Houlong Wei > Cc: Bibby Hsieh > Cc: Dennis YC Hsieh > Cc: linux-kernel@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-mediatek@lists.infradead.org > Signed-off-by: Chun-Kuang Hu > --- > drivers/mailbox/mtk-cmdq-mailbox.c | 10 +++++----- > include/linux/mailbox/mtk-cmdq-mailbox.h | 7 +------ > 2 files changed, 6 insertions(+), 11 deletions(-) > > diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmd= q-mailbox.c > index 5665b6ea8119..3d37c1cd40f1 100644 > --- a/drivers/mailbox/mtk-cmdq-mailbox.c > +++ b/drivers/mailbox/mtk-cmdq-mailbox.c > @@ -180,7 +180,7 @@ static bool cmdq_thread_is_in_wfe(struct cmdq_thread = *thread) > return readl(thread->base + CMDQ_THR_WAIT_TOKEN) & CMDQ_THR_IS_WA= ITING; > } > > -static void cmdq_task_exec_done(struct cmdq_task *task, enum cmdq_cb_sta= tus sta) > +static void cmdq_task_exec_done(struct cmdq_task *task, int sta) > { > struct cmdq_task_cb *cb =3D &task->pkt->async_cb; > struct cmdq_cb_data data; > @@ -244,10 +244,10 @@ static void cmdq_thread_irq_handler(struct cmdq *cm= dq, > curr_task =3D task; > > if (!curr_task || curr_pa =3D=3D task_end_pa - CMDQ_INST_= SIZE) { > - cmdq_task_exec_done(task, CMDQ_CB_NORMAL); > + cmdq_task_exec_done(task, 0); > kfree(task); > } else if (err) { > - cmdq_task_exec_done(task, CMDQ_CB_ERROR); > + cmdq_task_exec_done(task, -ENOEXEC); > cmdq_task_handle_error(curr_task); > kfree(task); > } > @@ -415,7 +415,7 @@ static void cmdq_mbox_shutdown(struct mbox_chan *chan= ) > > list_for_each_entry_safe(task, tmp, &thread->task_busy_list, > list_entry) { > - cmdq_task_exec_done(task, CMDQ_CB_ERROR); > + cmdq_task_exec_done(task, -ECONNABORTED); > kfree(task); > } > > @@ -453,7 +453,7 @@ static int cmdq_mbox_flush(struct mbox_chan *chan, un= signed long timeout) > list_entry) { > cb =3D &task->pkt->async_cb; > if (cb->cb) { > - data.sta =3D CMDQ_CB_ERROR; > + data.sta =3D -ECONNABORTED; > data.data =3D cb->data; > cb->cb(data); > } > diff --git a/include/linux/mailbox/mtk-cmdq-mailbox.h b/include/linux/mai= lbox/mtk-cmdq-mailbox.h > index d5a983d65f05..2f7d9a37d611 100644 > --- a/include/linux/mailbox/mtk-cmdq-mailbox.h > +++ b/include/linux/mailbox/mtk-cmdq-mailbox.h > @@ -65,13 +65,8 @@ enum cmdq_code { > CMDQ_CODE_LOGIC =3D 0xa0, > }; > > -enum cmdq_cb_status { > - CMDQ_CB_NORMAL =3D 0, > - CMDQ_CB_ERROR > -}; > - > struct cmdq_cb_data { > - enum cmdq_cb_status sta; > + int sta; > void *data; > }; > > -- > 2.17.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNWANTED_LANGUAGE_BODY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46EE0C433ED for ; Wed, 19 May 2021 12:50:12 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C4057611AD for ; Wed, 19 May 2021 12:50:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C4057611AD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=eD0UuFMOKA7w5rKQERG6owR5lktcKLtGcbnztpTV+4o=; b=LhDTWV7eL90Jsfiu7e4qyc6mj /wF8U9n2luYt3g3lzJDVZh+XYl5LBMiMvRxfzsLYIEYIjWy3XMOZ+cb3kjtPZgyNTto8iMEBBZe8e fDhGxOCjN5vNF2Fc8TXjfmtDUTW2TYhe6Fcqmw6ubQY28il55rns60g81ystRLSsE6C2xitEQn/uh WEJC3wpQWj9JpYaxs6sdrx2Ge2LFRLmroREuDyoqE1jkG424AUixhFs9PpdruOaTFrxt+9U66PcYk +3GJ8VkQdC+LiYdjeMgiJqzp4dp8I7sm+AmKVayxAoVfjMDU8CFG0oCwaMnAVLfE+MwkyddI8PHIR AIqxbIi9w==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1ljLeG-003y3Q-MF; Wed, 19 May 2021 12:50:04 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ljKH1-003kUy-8i; Wed, 19 May 2021 11:22:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References: MIME-Version:Sender:Reply-To:Content-ID:Content-Description; bh=qnfbbYSoXMFDxE4eFfkMJYMcwwl1FwR3Q2cHcnZPUEY=; b=1lAWh8DTI1IaP+pN2IGoFEpKE4 SylvTR9hkUBA7j32FFAsLMyPIeRYaE3CpaF+NXoB7fQgxSwZSzpCsuJwSh21P29D3LbhnLpM4Ne6Z 3Z1dd0aJ6WlYowBMTqxZFKNsOMf7pUezcROz+tvszwm+ZxtvYULp6zVjZqaTPmtU4V7TWBPHHGQx0 cggX3aTPh4jWZgq2PjXsimk53Z6n7qGQUwxoRTv4zrg0k/mkM8GhCUIreEmO3lfpmuGTwjBIxQNzs n6w8uK5H+s6nn2M95DRBmZ9+tl5PZ1hiJ/19NZRT7iGUAFX4fHR3jqqgE1YtkWVnl1nCr1o9TTkGe h6IIzWgw==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ljKGy-00FOxe-Cc; Wed, 19 May 2021 11:21:57 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 54B016112F; Wed, 19 May 2021 11:21:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1621423314; bh=fYglNnaQAuxyqNWH/krc3Hg57khobkxg9ya/DgyJ1RQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Q/jAuaSOmf39GSQwhaz77Q8HwKs9NI/MXXDej3zH+ZZ5leN+Gee0CfZC9IdC97cPd FJXNA0CLfB6FzKQeHlUQ0bAO8J4/YZb519tX23nQBxTcKyJQ8bSdsF3rzAxc9MvmxP A5l+cBlPZy8crrKC/CJsg5BdlNVZurEh3kLiVrXZQccx3DAUUeyUdnPpSO9l5q1q9J t8wHD0WuavvnUTn9RALhO1Ws2gViUgrSXj4zzGnFu/YhEvO1ta39iQHxmKORDU72PS 31geyv09Iits+L0Wjt+u2DrIdNF6S9gDeUCo7quGFs6vITfeZPVXH+oL4vxn4QR6u1 Yu9NtpFrJ+ABg== Received: by mail-ed1-f45.google.com with SMTP id df21so14920716edb.3; Wed, 19 May 2021 04:21:54 -0700 (PDT) X-Gm-Message-State: AOAM531v9X8CFzBpTVVPnbqCRcAhS3t607bisu6FDsV4JHrO3h+W2qQh +UG9DR0R+nJviB9gwX7zvTG7igtU3FB5iOr51g== X-Google-Smtp-Source: ABdhPJyhU1VHrUgMaJOH/P0DFczuZUCtXu2r+76ZrF10+WGgIhv+5vQxqqI9hG1DvdaQC+1oa4aSa7YPHzDhOA1Re8U= X-Received: by 2002:aa7:ccc6:: with SMTP id y6mr388400edt.303.1621423312942; Wed, 19 May 2021 04:21:52 -0700 (PDT) MIME-Version: 1.0 References: <20210314233323.23377-1-chunkuang.hu@kernel.org> <20210314233323.23377-2-chunkuang.hu@kernel.org> In-Reply-To: <20210314233323.23377-2-chunkuang.hu@kernel.org> From: Chun-Kuang Hu Date: Wed, 19 May 2021 19:21:42 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/3] mailbox: mtk-cmdq: Remove cmdq_cb_status To: Chun-Kuang Hu Cc: Jassi Brar , Matthias Brugger , Houlong Wei , Bibby Hsieh , Dennis YC Hsieh , linux-kernel , Linux ARM , "moderated list:ARM/Mediatek SoC support" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210519_042156_526117_52C16FDC X-CRM114-Status: GOOD ( 19.30 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org SGksIEphc3NpOgoKQ2h1bi1LdWFuZyBIdSA8Y2h1bmt1YW5nLmh1QGtlcm5lbC5vcmc+IOaWvCAy MDIx5bm0M+aciDE15pelIOmAseS4gCDkuIrljYg3OjMz5a+r6YGT77yaCj4KPiBjbWRxX2NiX3N0 YXR1cyBpcyBhbiBlcnJvciBzdGF0dXMuIFVzZSB0aGUgc3RhbmRhcmQgZXJyb3IgbnVtYmVyCj4g aW5zdGVhZCBvZiBjbWRxX2NiX3N0YXR1cyB0byBwcmV2ZW50IHN0YXR1cyBkdXBsaWNhdGlvbi4K CkhvdyBkbyB5b3UgdGhpbmsgYWJvdXQgdGhpcyBzZXJpZXM/CgpSZWdhcmRzLApDaHVuLUt1YW5n LgoKPgo+IENjOiBKYXNzaSBCcmFyIDxqYXNzaXNpbmdoYnJhckBnbWFpbC5jb20+Cj4gQ2M6IE1h dHRoaWFzIEJydWdnZXIgPG1hdHRoaWFzLmJnZ0BnbWFpbC5jb20+Cj4gQ2M6IEhvdWxvbmcgV2Vp IDxob3Vsb25nLndlaUBtZWRpYXRlay5jb20+Cj4gQ2M6IEJpYmJ5IEhzaWVoIDxiaWJieS5oc2ll aEBtZWRpYXRlay5jb20+Cj4gQ2M6IERlbm5pcyBZQyBIc2llaCA8ZGVubmlzLXljLmhzaWVoQG1l ZGlhdGVrLmNvbT4KPiBDYzogbGludXgta2VybmVsQHZnZXIua2VybmVsLm9yZwo+IENjOiBsaW51 eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKPiBDYzogbGludXgtbWVkaWF0ZWtAbGlz dHMuaW5mcmFkZWFkLm9yZwo+IFNpZ25lZC1vZmYtYnk6IENodW4tS3VhbmcgSHUgPGNodW5rdWFu Zy5odUBrZXJuZWwub3JnPgo+IC0tLQo+ICBkcml2ZXJzL21haWxib3gvbXRrLWNtZHEtbWFpbGJv eC5jICAgICAgIHwgMTAgKysrKystLS0tLQo+ICBpbmNsdWRlL2xpbnV4L21haWxib3gvbXRrLWNt ZHEtbWFpbGJveC5oIHwgIDcgKy0tLS0tLQo+ICAyIGZpbGVzIGNoYW5nZWQsIDYgaW5zZXJ0aW9u cygrKSwgMTEgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9tYWlsYm94L210 ay1jbWRxLW1haWxib3guYyBiL2RyaXZlcnMvbWFpbGJveC9tdGstY21kcS1tYWlsYm94LmMKPiBp bmRleCA1NjY1YjZlYTgxMTkuLjNkMzdjMWNkNDBmMSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL21h aWxib3gvbXRrLWNtZHEtbWFpbGJveC5jCj4gKysrIGIvZHJpdmVycy9tYWlsYm94L210ay1jbWRx LW1haWxib3guYwo+IEBAIC0xODAsNyArMTgwLDcgQEAgc3RhdGljIGJvb2wgY21kcV90aHJlYWRf aXNfaW5fd2ZlKHN0cnVjdCBjbWRxX3RocmVhZCAqdGhyZWFkKQo+ICAgICAgICAgcmV0dXJuIHJl YWRsKHRocmVhZC0+YmFzZSArIENNRFFfVEhSX1dBSVRfVE9LRU4pICYgQ01EUV9USFJfSVNfV0FJ VElORzsKPiAgfQo+Cj4gLXN0YXRpYyB2b2lkIGNtZHFfdGFza19leGVjX2RvbmUoc3RydWN0IGNt ZHFfdGFzayAqdGFzaywgZW51bSBjbWRxX2NiX3N0YXR1cyBzdGEpCj4gK3N0YXRpYyB2b2lkIGNt ZHFfdGFza19leGVjX2RvbmUoc3RydWN0IGNtZHFfdGFzayAqdGFzaywgaW50IHN0YSkKPiAgewo+ ICAgICAgICAgc3RydWN0IGNtZHFfdGFza19jYiAqY2IgPSAmdGFzay0+cGt0LT5hc3luY19jYjsK PiAgICAgICAgIHN0cnVjdCBjbWRxX2NiX2RhdGEgZGF0YTsKPiBAQCAtMjQ0LDEwICsyNDQsMTAg QEAgc3RhdGljIHZvaWQgY21kcV90aHJlYWRfaXJxX2hhbmRsZXIoc3RydWN0IGNtZHEgKmNtZHEs Cj4gICAgICAgICAgICAgICAgICAgICAgICAgY3Vycl90YXNrID0gdGFzazsKPgo+ICAgICAgICAg ICAgICAgICBpZiAoIWN1cnJfdGFzayB8fCBjdXJyX3BhID09IHRhc2tfZW5kX3BhIC0gQ01EUV9J TlNUX1NJWkUpIHsKPiAtICAgICAgICAgICAgICAgICAgICAgICBjbWRxX3Rhc2tfZXhlY19kb25l KHRhc2ssIENNRFFfQ0JfTk9STUFMKTsKPiArICAgICAgICAgICAgICAgICAgICAgICBjbWRxX3Rh c2tfZXhlY19kb25lKHRhc2ssIDApOwo+ICAgICAgICAgICAgICAgICAgICAgICAgIGtmcmVlKHRh c2spOwo+ICAgICAgICAgICAgICAgICB9IGVsc2UgaWYgKGVycikgewo+IC0gICAgICAgICAgICAg ICAgICAgICAgIGNtZHFfdGFza19leGVjX2RvbmUodGFzaywgQ01EUV9DQl9FUlJPUik7Cj4gKyAg ICAgICAgICAgICAgICAgICAgICAgY21kcV90YXNrX2V4ZWNfZG9uZSh0YXNrLCAtRU5PRVhFQyk7 Cj4gICAgICAgICAgICAgICAgICAgICAgICAgY21kcV90YXNrX2hhbmRsZV9lcnJvcihjdXJyX3Rh c2spOwo+ICAgICAgICAgICAgICAgICAgICAgICAgIGtmcmVlKHRhc2spOwo+ICAgICAgICAgICAg ICAgICB9Cj4gQEAgLTQxNSw3ICs0MTUsNyBAQCBzdGF0aWMgdm9pZCBjbWRxX21ib3hfc2h1dGRv d24oc3RydWN0IG1ib3hfY2hhbiAqY2hhbikKPgo+ICAgICAgICAgbGlzdF9mb3JfZWFjaF9lbnRy eV9zYWZlKHRhc2ssIHRtcCwgJnRocmVhZC0+dGFza19idXN5X2xpc3QsCj4gICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgbGlzdF9lbnRyeSkgewo+IC0gICAgICAgICAgICAgICBjbWRx X3Rhc2tfZXhlY19kb25lKHRhc2ssIENNRFFfQ0JfRVJST1IpOwo+ICsgICAgICAgICAgICAgICBj bWRxX3Rhc2tfZXhlY19kb25lKHRhc2ssIC1FQ09OTkFCT1JURUQpOwo+ICAgICAgICAgICAgICAg ICBrZnJlZSh0YXNrKTsKPiAgICAgICAgIH0KPgo+IEBAIC00NTMsNyArNDUzLDcgQEAgc3RhdGlj IGludCBjbWRxX21ib3hfZmx1c2goc3RydWN0IG1ib3hfY2hhbiAqY2hhbiwgdW5zaWduZWQgbG9u ZyB0aW1lb3V0KQo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGxpc3RfZW50cnkp IHsKPiAgICAgICAgICAgICAgICAgY2IgPSAmdGFzay0+cGt0LT5hc3luY19jYjsKPiAgICAgICAg ICAgICAgICAgaWYgKGNiLT5jYikgewo+IC0gICAgICAgICAgICAgICAgICAgICAgIGRhdGEuc3Rh ID0gQ01EUV9DQl9FUlJPUjsKPiArICAgICAgICAgICAgICAgICAgICAgICBkYXRhLnN0YSA9IC1F Q09OTkFCT1JURUQ7Cj4gICAgICAgICAgICAgICAgICAgICAgICAgZGF0YS5kYXRhID0gY2ItPmRh dGE7Cj4gICAgICAgICAgICAgICAgICAgICAgICAgY2ItPmNiKGRhdGEpOwo+ICAgICAgICAgICAg ICAgICB9Cj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvbGludXgvbWFpbGJveC9tdGstY21kcS1tYWls Ym94LmggYi9pbmNsdWRlL2xpbnV4L21haWxib3gvbXRrLWNtZHEtbWFpbGJveC5oCj4gaW5kZXgg ZDVhOTgzZDY1ZjA1Li4yZjdkOWEzN2Q2MTEgMTAwNjQ0Cj4gLS0tIGEvaW5jbHVkZS9saW51eC9t YWlsYm94L210ay1jbWRxLW1haWxib3guaAo+ICsrKyBiL2luY2x1ZGUvbGludXgvbWFpbGJveC9t dGstY21kcS1tYWlsYm94LmgKPiBAQCAtNjUsMTMgKzY1LDggQEAgZW51bSBjbWRxX2NvZGUgewo+ ICAgICAgICAgQ01EUV9DT0RFX0xPR0lDID0gMHhhMCwKPiAgfTsKPgo+IC1lbnVtIGNtZHFfY2Jf c3RhdHVzIHsKPiAtICAgICAgIENNRFFfQ0JfTk9STUFMID0gMCwKPiAtICAgICAgIENNRFFfQ0Jf RVJST1IKPiAtfTsKPiAtCj4gIHN0cnVjdCBjbWRxX2NiX2RhdGEgewo+IC0gICAgICAgZW51bSBj bWRxX2NiX3N0YXR1cyAgICAgc3RhOwo+ICsgICAgICAgaW50ICAgICAgICAgICAgICAgICAgICAg c3RhOwo+ICAgICAgICAgdm9pZCAgICAgICAgICAgICAgICAgICAgKmRhdGE7Cj4gIH07Cj4KPiAt LQo+IDIuMTcuMQo+CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpMaW51eC1tZWRpYXRlayBtYWlsaW5nIGxpc3QKTGludXgtbWVkaWF0ZWtAbGlzdHMuaW5m cmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xp bnV4LW1lZGlhdGVrCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNWANTED_LANGUAGE_BODY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D104C433B4 for ; Wed, 19 May 2021 12:50:07 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9CC4A611AD for ; Wed, 19 May 2021 12:50:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9CC4A611AD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NWsW7i5yiljEs/cJAcoSd3fp1pSOKRrVtHpRanZTMdk=; b=diG+gpl2nNET45iMfyT69Vfpu iRq5rx8Ir8OlhrPhqd5+fFGgS/J7Mg3gS/0nPmIvhdT2a4bHEgWRe09SwWaevkOBjttzPwS1Uozkc hjyA+TgIbJUPIoFmjiaANkHKAjaLHVuRnk0LjyV9R9Q76wk92v36ugYFlEveXJlkDOFpaOkOFCecl hU78hVOw/RyZ5Jw9VUet5Cf+Tr8tmeHAnDWVIEeDx7gAHloCbS5xkC6DYNgV2grWVDR1p2Gk1ulRv YE2K2a5k1tolSkb/YvEwcKrlSnwqUBpmCq5rY1LLzime1imZ7k2/CYuFgxfrjpK1hJs6/Fuvjt2AK msPQE4Suw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1ljLcg-003xnG-1v; Wed, 19 May 2021 12:48:26 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ljKH1-003kUy-8i; Wed, 19 May 2021 11:22:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References: MIME-Version:Sender:Reply-To:Content-ID:Content-Description; bh=qnfbbYSoXMFDxE4eFfkMJYMcwwl1FwR3Q2cHcnZPUEY=; b=1lAWh8DTI1IaP+pN2IGoFEpKE4 SylvTR9hkUBA7j32FFAsLMyPIeRYaE3CpaF+NXoB7fQgxSwZSzpCsuJwSh21P29D3LbhnLpM4Ne6Z 3Z1dd0aJ6WlYowBMTqxZFKNsOMf7pUezcROz+tvszwm+ZxtvYULp6zVjZqaTPmtU4V7TWBPHHGQx0 cggX3aTPh4jWZgq2PjXsimk53Z6n7qGQUwxoRTv4zrg0k/mkM8GhCUIreEmO3lfpmuGTwjBIxQNzs n6w8uK5H+s6nn2M95DRBmZ9+tl5PZ1hiJ/19NZRT7iGUAFX4fHR3jqqgE1YtkWVnl1nCr1o9TTkGe h6IIzWgw==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ljKGy-00FOxe-Cc; Wed, 19 May 2021 11:21:57 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 54B016112F; Wed, 19 May 2021 11:21:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1621423314; bh=fYglNnaQAuxyqNWH/krc3Hg57khobkxg9ya/DgyJ1RQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Q/jAuaSOmf39GSQwhaz77Q8HwKs9NI/MXXDej3zH+ZZ5leN+Gee0CfZC9IdC97cPd FJXNA0CLfB6FzKQeHlUQ0bAO8J4/YZb519tX23nQBxTcKyJQ8bSdsF3rzAxc9MvmxP A5l+cBlPZy8crrKC/CJsg5BdlNVZurEh3kLiVrXZQccx3DAUUeyUdnPpSO9l5q1q9J t8wHD0WuavvnUTn9RALhO1Ws2gViUgrSXj4zzGnFu/YhEvO1ta39iQHxmKORDU72PS 31geyv09Iits+L0Wjt+u2DrIdNF6S9gDeUCo7quGFs6vITfeZPVXH+oL4vxn4QR6u1 Yu9NtpFrJ+ABg== Received: by mail-ed1-f45.google.com with SMTP id df21so14920716edb.3; Wed, 19 May 2021 04:21:54 -0700 (PDT) X-Gm-Message-State: AOAM531v9X8CFzBpTVVPnbqCRcAhS3t607bisu6FDsV4JHrO3h+W2qQh +UG9DR0R+nJviB9gwX7zvTG7igtU3FB5iOr51g== X-Google-Smtp-Source: ABdhPJyhU1VHrUgMaJOH/P0DFczuZUCtXu2r+76ZrF10+WGgIhv+5vQxqqI9hG1DvdaQC+1oa4aSa7YPHzDhOA1Re8U= X-Received: by 2002:aa7:ccc6:: with SMTP id y6mr388400edt.303.1621423312942; Wed, 19 May 2021 04:21:52 -0700 (PDT) MIME-Version: 1.0 References: <20210314233323.23377-1-chunkuang.hu@kernel.org> <20210314233323.23377-2-chunkuang.hu@kernel.org> In-Reply-To: <20210314233323.23377-2-chunkuang.hu@kernel.org> From: Chun-Kuang Hu Date: Wed, 19 May 2021 19:21:42 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/3] mailbox: mtk-cmdq: Remove cmdq_cb_status To: Chun-Kuang Hu Cc: Jassi Brar , Matthias Brugger , Houlong Wei , Bibby Hsieh , Dennis YC Hsieh , linux-kernel , Linux ARM , "moderated list:ARM/Mediatek SoC support" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210519_042156_526117_52C16FDC X-CRM114-Status: GOOD ( 19.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGksIEphc3NpOgoKQ2h1bi1LdWFuZyBIdSA8Y2h1bmt1YW5nLmh1QGtlcm5lbC5vcmc+IOaWvCAy MDIx5bm0M+aciDE15pelIOmAseS4gCDkuIrljYg3OjMz5a+r6YGT77yaCj4KPiBjbWRxX2NiX3N0 YXR1cyBpcyBhbiBlcnJvciBzdGF0dXMuIFVzZSB0aGUgc3RhbmRhcmQgZXJyb3IgbnVtYmVyCj4g aW5zdGVhZCBvZiBjbWRxX2NiX3N0YXR1cyB0byBwcmV2ZW50IHN0YXR1cyBkdXBsaWNhdGlvbi4K CkhvdyBkbyB5b3UgdGhpbmsgYWJvdXQgdGhpcyBzZXJpZXM/CgpSZWdhcmRzLApDaHVuLUt1YW5n LgoKPgo+IENjOiBKYXNzaSBCcmFyIDxqYXNzaXNpbmdoYnJhckBnbWFpbC5jb20+Cj4gQ2M6IE1h dHRoaWFzIEJydWdnZXIgPG1hdHRoaWFzLmJnZ0BnbWFpbC5jb20+Cj4gQ2M6IEhvdWxvbmcgV2Vp IDxob3Vsb25nLndlaUBtZWRpYXRlay5jb20+Cj4gQ2M6IEJpYmJ5IEhzaWVoIDxiaWJieS5oc2ll aEBtZWRpYXRlay5jb20+Cj4gQ2M6IERlbm5pcyBZQyBIc2llaCA8ZGVubmlzLXljLmhzaWVoQG1l ZGlhdGVrLmNvbT4KPiBDYzogbGludXgta2VybmVsQHZnZXIua2VybmVsLm9yZwo+IENjOiBsaW51 eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKPiBDYzogbGludXgtbWVkaWF0ZWtAbGlz dHMuaW5mcmFkZWFkLm9yZwo+IFNpZ25lZC1vZmYtYnk6IENodW4tS3VhbmcgSHUgPGNodW5rdWFu Zy5odUBrZXJuZWwub3JnPgo+IC0tLQo+ICBkcml2ZXJzL21haWxib3gvbXRrLWNtZHEtbWFpbGJv eC5jICAgICAgIHwgMTAgKysrKystLS0tLQo+ICBpbmNsdWRlL2xpbnV4L21haWxib3gvbXRrLWNt ZHEtbWFpbGJveC5oIHwgIDcgKy0tLS0tLQo+ICAyIGZpbGVzIGNoYW5nZWQsIDYgaW5zZXJ0aW9u cygrKSwgMTEgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9tYWlsYm94L210 ay1jbWRxLW1haWxib3guYyBiL2RyaXZlcnMvbWFpbGJveC9tdGstY21kcS1tYWlsYm94LmMKPiBp bmRleCA1NjY1YjZlYTgxMTkuLjNkMzdjMWNkNDBmMSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL21h aWxib3gvbXRrLWNtZHEtbWFpbGJveC5jCj4gKysrIGIvZHJpdmVycy9tYWlsYm94L210ay1jbWRx LW1haWxib3guYwo+IEBAIC0xODAsNyArMTgwLDcgQEAgc3RhdGljIGJvb2wgY21kcV90aHJlYWRf aXNfaW5fd2ZlKHN0cnVjdCBjbWRxX3RocmVhZCAqdGhyZWFkKQo+ICAgICAgICAgcmV0dXJuIHJl YWRsKHRocmVhZC0+YmFzZSArIENNRFFfVEhSX1dBSVRfVE9LRU4pICYgQ01EUV9USFJfSVNfV0FJ VElORzsKPiAgfQo+Cj4gLXN0YXRpYyB2b2lkIGNtZHFfdGFza19leGVjX2RvbmUoc3RydWN0IGNt ZHFfdGFzayAqdGFzaywgZW51bSBjbWRxX2NiX3N0YXR1cyBzdGEpCj4gK3N0YXRpYyB2b2lkIGNt ZHFfdGFza19leGVjX2RvbmUoc3RydWN0IGNtZHFfdGFzayAqdGFzaywgaW50IHN0YSkKPiAgewo+ ICAgICAgICAgc3RydWN0IGNtZHFfdGFza19jYiAqY2IgPSAmdGFzay0+cGt0LT5hc3luY19jYjsK PiAgICAgICAgIHN0cnVjdCBjbWRxX2NiX2RhdGEgZGF0YTsKPiBAQCAtMjQ0LDEwICsyNDQsMTAg QEAgc3RhdGljIHZvaWQgY21kcV90aHJlYWRfaXJxX2hhbmRsZXIoc3RydWN0IGNtZHEgKmNtZHEs Cj4gICAgICAgICAgICAgICAgICAgICAgICAgY3Vycl90YXNrID0gdGFzazsKPgo+ICAgICAgICAg ICAgICAgICBpZiAoIWN1cnJfdGFzayB8fCBjdXJyX3BhID09IHRhc2tfZW5kX3BhIC0gQ01EUV9J TlNUX1NJWkUpIHsKPiAtICAgICAgICAgICAgICAgICAgICAgICBjbWRxX3Rhc2tfZXhlY19kb25l KHRhc2ssIENNRFFfQ0JfTk9STUFMKTsKPiArICAgICAgICAgICAgICAgICAgICAgICBjbWRxX3Rh c2tfZXhlY19kb25lKHRhc2ssIDApOwo+ICAgICAgICAgICAgICAgICAgICAgICAgIGtmcmVlKHRh c2spOwo+ICAgICAgICAgICAgICAgICB9IGVsc2UgaWYgKGVycikgewo+IC0gICAgICAgICAgICAg ICAgICAgICAgIGNtZHFfdGFza19leGVjX2RvbmUodGFzaywgQ01EUV9DQl9FUlJPUik7Cj4gKyAg ICAgICAgICAgICAgICAgICAgICAgY21kcV90YXNrX2V4ZWNfZG9uZSh0YXNrLCAtRU5PRVhFQyk7 Cj4gICAgICAgICAgICAgICAgICAgICAgICAgY21kcV90YXNrX2hhbmRsZV9lcnJvcihjdXJyX3Rh c2spOwo+ICAgICAgICAgICAgICAgICAgICAgICAgIGtmcmVlKHRhc2spOwo+ICAgICAgICAgICAg ICAgICB9Cj4gQEAgLTQxNSw3ICs0MTUsNyBAQCBzdGF0aWMgdm9pZCBjbWRxX21ib3hfc2h1dGRv d24oc3RydWN0IG1ib3hfY2hhbiAqY2hhbikKPgo+ICAgICAgICAgbGlzdF9mb3JfZWFjaF9lbnRy eV9zYWZlKHRhc2ssIHRtcCwgJnRocmVhZC0+dGFza19idXN5X2xpc3QsCj4gICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgbGlzdF9lbnRyeSkgewo+IC0gICAgICAgICAgICAgICBjbWRx X3Rhc2tfZXhlY19kb25lKHRhc2ssIENNRFFfQ0JfRVJST1IpOwo+ICsgICAgICAgICAgICAgICBj bWRxX3Rhc2tfZXhlY19kb25lKHRhc2ssIC1FQ09OTkFCT1JURUQpOwo+ICAgICAgICAgICAgICAg ICBrZnJlZSh0YXNrKTsKPiAgICAgICAgIH0KPgo+IEBAIC00NTMsNyArNDUzLDcgQEAgc3RhdGlj IGludCBjbWRxX21ib3hfZmx1c2goc3RydWN0IG1ib3hfY2hhbiAqY2hhbiwgdW5zaWduZWQgbG9u ZyB0aW1lb3V0KQo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGxpc3RfZW50cnkp IHsKPiAgICAgICAgICAgICAgICAgY2IgPSAmdGFzay0+cGt0LT5hc3luY19jYjsKPiAgICAgICAg ICAgICAgICAgaWYgKGNiLT5jYikgewo+IC0gICAgICAgICAgICAgICAgICAgICAgIGRhdGEuc3Rh ID0gQ01EUV9DQl9FUlJPUjsKPiArICAgICAgICAgICAgICAgICAgICAgICBkYXRhLnN0YSA9IC1F Q09OTkFCT1JURUQ7Cj4gICAgICAgICAgICAgICAgICAgICAgICAgZGF0YS5kYXRhID0gY2ItPmRh dGE7Cj4gICAgICAgICAgICAgICAgICAgICAgICAgY2ItPmNiKGRhdGEpOwo+ICAgICAgICAgICAg ICAgICB9Cj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvbGludXgvbWFpbGJveC9tdGstY21kcS1tYWls Ym94LmggYi9pbmNsdWRlL2xpbnV4L21haWxib3gvbXRrLWNtZHEtbWFpbGJveC5oCj4gaW5kZXgg ZDVhOTgzZDY1ZjA1Li4yZjdkOWEzN2Q2MTEgMTAwNjQ0Cj4gLS0tIGEvaW5jbHVkZS9saW51eC9t YWlsYm94L210ay1jbWRxLW1haWxib3guaAo+ICsrKyBiL2luY2x1ZGUvbGludXgvbWFpbGJveC9t dGstY21kcS1tYWlsYm94LmgKPiBAQCAtNjUsMTMgKzY1LDggQEAgZW51bSBjbWRxX2NvZGUgewo+ ICAgICAgICAgQ01EUV9DT0RFX0xPR0lDID0gMHhhMCwKPiAgfTsKPgo+IC1lbnVtIGNtZHFfY2Jf c3RhdHVzIHsKPiAtICAgICAgIENNRFFfQ0JfTk9STUFMID0gMCwKPiAtICAgICAgIENNRFFfQ0Jf RVJST1IKPiAtfTsKPiAtCj4gIHN0cnVjdCBjbWRxX2NiX2RhdGEgewo+IC0gICAgICAgZW51bSBj bWRxX2NiX3N0YXR1cyAgICAgc3RhOwo+ICsgICAgICAgaW50ICAgICAgICAgICAgICAgICAgICAg c3RhOwo+ICAgICAgICAgdm9pZCAgICAgICAgICAgICAgICAgICAgKmRhdGE7Cj4gIH07Cj4KPiAt LQo+IDIuMTcuMQo+CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3Rz LmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5m by9saW51eC1hcm0ta2VybmVsCg==