From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 617AD17F for ; Mon, 9 Aug 2021 13:09:11 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 0A84E61051 for ; Mon, 9 Aug 2021 13:09:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628514551; bh=YzG7BnFCln4Yyp6LxrxvxeyUMj5GmzMjIhVfIPMKSYc=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=B8pvYpwPzQ18zhH2+y0BGlUA/OJhSA/B0e0InC/nca080ep3tJvTyYkjw4iA0bIXy YJkfsyL7WJqFEvGlYZsDdfkS8W4gkzs2dxMYwyXUt2VpcSaAsgcNhIj8ai/6CAVUZ2 ldHAUzQEOhshkYgfdQv79fOgiKArwiLUzaIB6uXf33e9Dwx6fJNaNUWADrL3Q2AY27 Bl9LecINy6PsqQyvEgFzW02xNT9GIlS0Tp9TuaVC5l/yfox0JcJblrMOq9WQey5+Yx UjWS8SLAwRaq9m1jBvtg7XtqOaG9lvGylZ+m8LNCf4Md/cmndcHE0D+U5Qp6wYUHub B20Q3cXMUBSvw== Received: by mail-wr1-f41.google.com with SMTP id m12so21349029wru.12 for ; Mon, 09 Aug 2021 06:09:10 -0700 (PDT) X-Gm-Message-State: AOAM530/a1gnQ4R8iS36Q2XukGWwPi/z4f1W1HmondJQ3DEsWFfM3zHS 0bJfD89n2tGzM3z+EH3VulB0tXmL0BwjcWR5Yg== X-Google-Smtp-Source: ABdhPJzottn9lR1w4Ou5tspJmaMhExuHvfqLuRluAKs7dQZoer2iHn4k6bWFWu6HusN3FgH38v3t3o0558IoBlRW8NU= X-Received: by 2002:a17:906:4156:: with SMTP id l22mr6919385ejk.75.1628514539014; Mon, 09 Aug 2021 06:08:59 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20210625082222.3845-1-tzimmermann@suse.de> <20210625082222.3845-14-tzimmermann@suse.de> In-Reply-To: <20210625082222.3845-14-tzimmermann@suse.de> From: Chun-Kuang Hu Date: Mon, 9 Aug 2021 21:08:48 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 13/27] drm/mediatek: Don't set struct drm_device.irq_enabled To: Thomas Zimmermann Cc: Daniel Vetter , David Airlie , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= , Xinhui.Pan@amd.com, james.qian.wang@arm.com, liviu.dudau@arm.com, mihail.atanassov@arm.com, brian.starkey@arm.com, Maarten Lankhorst , Maxime Ripard , Inki Dae , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , krzysztof.kozlowski@canonical.com, xinliang.liu@linaro.org, tiantao6@hisilicon.com, john.stultz@linaro.org, kong.kongxinwei@hisilicon.com, puck.chen@hisilicon.com, Laurentiu Palcu , Lucas Stach , Philipp Zabel , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Chun-Kuang Hu , Matthias Brugger , Ben Skeggs , Tomi Valkeinen , Sandy Huang , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Yannick Fertre , Philippe Cornu , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Jernej Skrabec , Thierry Reding , jonathanh@nvidia.com, Jyri Sarha , emma@anholt.net, linux-graphics-maintainer@vmware.com, zackr@vmware.com, hyun.kwon@xilinx.com, Laurent Pinchart , michal.simek@xilinx.com, jani.nikula@linux.intel.com, rodrigo.vivi@intel.com, Russell King , kieran.bingham+renesas@ideasonboard.com, Rodrigo Siqueira , Melissa Wen , Haneen Mohammed , amd-gfx@lists.freedesktop.org, DRI Development , Linux ARM , linux-samsung-soc@vger.kernel.org, "moderated list:ARM/Mediatek SoC support" , nouveau@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, Intel Graphics Development , Daniel Vetter Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, Thomas: Thomas Zimmermann =E6=96=BC 2021=E5=B9=B46=E6=9C=8825= =E6=97=A5 =E9=80=B1=E4=BA=94 =E4=B8=8B=E5=8D=884:22=E5=AF=AB=E9=81=93=EF=BC= =9A > > The field drm_device.irq_enabled is only used by legacy drivers > with userspace modesetting. Don't set it in mediatek. > Acked-by: Chun-Kuang Hu > Signed-off-by: Thomas Zimmermann > Reviewed-by: Laurent Pinchart > Acked-by: Daniel Vetter > --- > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/med= iatek/mtk_drm_drv.c > index b46bdb8985da..9b60bec33d3b 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > @@ -270,12 +270,6 @@ static int mtk_drm_kms_init(struct drm_device *drm) > goto err_component_unbind; > } > > - /* > - * We don't use the drm_irq_install() helpers provided by the DRM > - * core, so we need to set this manually in order to allow the > - * DRM_IOCTL_WAIT_VBLANK to operate correctly. > - */ > - drm->irq_enabled =3D true; > ret =3D drm_vblank_init(drm, MAX_CRTC); > if (ret < 0) > goto err_component_unbind; > -- > 2.32.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29D43C4338F for ; Tue, 10 Aug 2021 02:54:10 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DAF4C60FE6 for ; Tue, 10 Aug 2021 02:54:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DAF4C60FE6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8436E89E15; Tue, 10 Aug 2021 02:54:07 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3344D899A5; Mon, 9 Aug 2021 13:09:11 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 06B8861004; Mon, 9 Aug 2021 13:09:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628514551; bh=YzG7BnFCln4Yyp6LxrxvxeyUMj5GmzMjIhVfIPMKSYc=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=B8pvYpwPzQ18zhH2+y0BGlUA/OJhSA/B0e0InC/nca080ep3tJvTyYkjw4iA0bIXy YJkfsyL7WJqFEvGlYZsDdfkS8W4gkzs2dxMYwyXUt2VpcSaAsgcNhIj8ai/6CAVUZ2 ldHAUzQEOhshkYgfdQv79fOgiKArwiLUzaIB6uXf33e9Dwx6fJNaNUWADrL3Q2AY27 Bl9LecINy6PsqQyvEgFzW02xNT9GIlS0Tp9TuaVC5l/yfox0JcJblrMOq9WQey5+Yx UjWS8SLAwRaq9m1jBvtg7XtqOaG9lvGylZ+m8LNCf4Md/cmndcHE0D+U5Qp6wYUHub B20Q3cXMUBSvw== Received: by mail-wr1-f52.google.com with SMTP id k29so8563403wrd.7; Mon, 09 Aug 2021 06:09:10 -0700 (PDT) X-Gm-Message-State: AOAM530HpmV+f8Lh1ZWrTeqml6bwZ6koMhJehP2RdxsiCeeG/g/Hr4PY pnLbIq1I4YazeQco2P15ALRqmfHsVz9MYathnA== X-Google-Smtp-Source: ABdhPJzottn9lR1w4Ou5tspJmaMhExuHvfqLuRluAKs7dQZoer2iHn4k6bWFWu6HusN3FgH38v3t3o0558IoBlRW8NU= X-Received: by 2002:a17:906:4156:: with SMTP id l22mr6919385ejk.75.1628514539014; Mon, 09 Aug 2021 06:08:59 -0700 (PDT) MIME-Version: 1.0 References: <20210625082222.3845-1-tzimmermann@suse.de> <20210625082222.3845-14-tzimmermann@suse.de> In-Reply-To: <20210625082222.3845-14-tzimmermann@suse.de> From: Chun-Kuang Hu Date: Mon, 9 Aug 2021 21:08:48 +0800 X-Gmail-Original-Message-ID: Message-ID: To: Thomas Zimmermann Cc: Daniel Vetter , David Airlie , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= , Xinhui.Pan@amd.com, james.qian.wang@arm.com, liviu.dudau@arm.com, mihail.atanassov@arm.com, brian.starkey@arm.com, Maarten Lankhorst , Maxime Ripard , Inki Dae , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , krzysztof.kozlowski@canonical.com, xinliang.liu@linaro.org, tiantao6@hisilicon.com, john.stultz@linaro.org, kong.kongxinwei@hisilicon.com, puck.chen@hisilicon.com, Laurentiu Palcu , Lucas Stach , Philipp Zabel , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Chun-Kuang Hu , Matthias Brugger , Ben Skeggs , Tomi Valkeinen , Sandy Huang , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Yannick Fertre , Philippe Cornu , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Jernej Skrabec , Thierry Reding , jonathanh@nvidia.com, Jyri Sarha , emma@anholt.net, linux-graphics-maintainer@vmware.com, zackr@vmware.com, hyun.kwon@xilinx.com, Laurent Pinchart , michal.simek@xilinx.com, jani.nikula@linux.intel.com, rodrigo.vivi@intel.com, Russell King , kieran.bingham+renesas@ideasonboard.com, Rodrigo Siqueira , Melissa Wen , Haneen Mohammed , amd-gfx@lists.freedesktop.org, DRI Development , Linux ARM , linux-samsung-soc@vger.kernel.org, "moderated list:ARM/Mediatek SoC support" , nouveau@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, Intel Graphics Development , Daniel Vetter Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailman-Approved-At: Tue, 10 Aug 2021 02:54:05 +0000 Subject: Re: [Nouveau] [PATCH v4 13/27] drm/mediatek: Don't set struct drm_device.irq_enabled X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" Hi, Thomas: Thomas Zimmermann =E6=96=BC 2021=E5=B9=B46=E6=9C=8825= =E6=97=A5 =E9=80=B1=E4=BA=94 =E4=B8=8B=E5=8D=884:22=E5=AF=AB=E9=81=93=EF=BC= =9A > > The field drm_device.irq_enabled is only used by legacy drivers > with userspace modesetting. Don't set it in mediatek. > Acked-by: Chun-Kuang Hu > Signed-off-by: Thomas Zimmermann > Reviewed-by: Laurent Pinchart > Acked-by: Daniel Vetter > --- > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/med= iatek/mtk_drm_drv.c > index b46bdb8985da..9b60bec33d3b 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > @@ -270,12 +270,6 @@ static int mtk_drm_kms_init(struct drm_device *drm) > goto err_component_unbind; > } > > - /* > - * We don't use the drm_irq_install() helpers provided by the DRM > - * core, so we need to set this manually in order to allow the > - * DRM_IOCTL_WAIT_VBLANK to operate correctly. > - */ > - drm->irq_enabled =3D true; > ret =3D drm_vblank_init(drm, MAX_CRTC); > if (ret < 0) > goto err_component_unbind; > -- > 2.32.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8520CC432BE for ; Mon, 9 Aug 2021 13:09:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4396A60F93 for ; Mon, 9 Aug 2021 13:09:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4396A60F93 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=G3kXEJ2R1k1Qw3QqvMsWxQLEimWScvwEJnQN1LOPBiI=; b=huL79L3RP9wcZZ zaXOBsF4ybSDaAcwwgB6IFkc9RGPjsipx4wpGZ4IdT/yG7UShmBCCC6u4ybTQtVDcDmpzKSXhsBjX ZH4vX7TEsJ3qVyBodPE+Sl+MAKNhT6HfXFWEUQWU6iBvwVeNauhbxn394jABnu96EwYumrv9vRLL6 4ptXMsBmdj+Ru0UcgEzhnzpj/z3epecg5PzZl8qUT6PUFYENwRrm+i2aenRv55NovCC/5ICRegNFC IlLK/KDJJ8CFqX1CCSQQEAYxKxDdwO4VW5uXPkcoqC4F4tlz+sTnrmopiBnbZCyh1ztnq9AGarwQ+ vgobjznyFX2954QK3WNw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mD51o-000h0K-Gz; Mon, 09 Aug 2021 13:09:16 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mD51j-000gyL-9s; Mon, 09 Aug 2021 13:09:14 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id C7D6760F93; Mon, 9 Aug 2021 13:09:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628514550; bh=YzG7BnFCln4Yyp6LxrxvxeyUMj5GmzMjIhVfIPMKSYc=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=YmsjoOgVwiRCGySrWrLQ8XAV3Hz23Fmp6MLYCvervZuSKrMaAZslkj4v/hhPPLKYQ bo4QrDLjJrAvJT4Sd0fFUGs0bCtBNV1gh9i13HYWdDpmSjWwAPqOqDotgvqQICL/9Y deEweM9WJz5jdqJoqsQZgcTZV+NXWanhFYNPKzRzWfLqLezWsmne8IOBXWMghv+42c 3e92f/x6lQZcC4+5PxT+UOaHppXO5oJy1OLg6W6OseMdg7x1vithmCkJX2fxZEG4zE IhHqfjPsdDALo4O3nuWicYy+9Pvk6q8Uy5rL93t76MlZVJPARFLmZDQ+t4kUlBFCkY 3KK017L+mf6TQ== Received: by mail-lj1-f182.google.com with SMTP id x9so21562302ljj.2; Mon, 09 Aug 2021 06:09:10 -0700 (PDT) X-Gm-Message-State: AOAM533WhYrYTy1ew118DQMmOXG47AM2htD5zoGN8WJSaWSrS+yTzkz4 PUQSWita9Y7Vtf/JRwOQ0+LhgG5hrRqu9Auw7Q== X-Google-Smtp-Source: ABdhPJzottn9lR1w4Ou5tspJmaMhExuHvfqLuRluAKs7dQZoer2iHn4k6bWFWu6HusN3FgH38v3t3o0558IoBlRW8NU= X-Received: by 2002:a17:906:4156:: with SMTP id l22mr6919385ejk.75.1628514539014; Mon, 09 Aug 2021 06:08:59 -0700 (PDT) MIME-Version: 1.0 References: <20210625082222.3845-1-tzimmermann@suse.de> <20210625082222.3845-14-tzimmermann@suse.de> In-Reply-To: <20210625082222.3845-14-tzimmermann@suse.de> From: Chun-Kuang Hu Date: Mon, 9 Aug 2021 21:08:48 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 13/27] drm/mediatek: Don't set struct drm_device.irq_enabled To: Thomas Zimmermann Cc: Daniel Vetter , David Airlie , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= , Xinhui.Pan@amd.com, james.qian.wang@arm.com, liviu.dudau@arm.com, mihail.atanassov@arm.com, brian.starkey@arm.com, Maarten Lankhorst , Maxime Ripard , Inki Dae , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , krzysztof.kozlowski@canonical.com, xinliang.liu@linaro.org, tiantao6@hisilicon.com, john.stultz@linaro.org, kong.kongxinwei@hisilicon.com, puck.chen@hisilicon.com, Laurentiu Palcu , Lucas Stach , Philipp Zabel , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Chun-Kuang Hu , Matthias Brugger , Ben Skeggs , Tomi Valkeinen , Sandy Huang , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Yannick Fertre , Philippe Cornu , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Jernej Skrabec , Thierry Reding , jonathanh@nvidia.com, Jyri Sarha , emma@anholt.net, linux-graphics-maintainer@vmware.com, zackr@vmware.com, hyun.kwon@xilinx.com, Laurent Pinchart , michal.simek@xilinx.com, jani.nikula@linux.intel.com, rodrigo.vivi@intel.com, Russell King , kieran.bingham+renesas@ideasonboard.com, Rodrigo Siqueira , Melissa Wen , Haneen Mohammed , amd-gfx@lists.freedesktop.org, DRI Development , Linux ARM , linux-samsung-soc@vger.kernel.org, "moderated list:ARM/Mediatek SoC support" , nouveau@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, Intel Graphics Development , Daniel Vetter X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210809_060911_427169_03B73D01 X-CRM114-Status: GOOD ( 18.07 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org SGksIFRob21hczoKClRob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPiDmlrwg MjAyMeW5tDbmnIgyNeaXpSDpgLHkupQg5LiL5Y2INDoyMuWvq+mBk++8mgo+Cj4gVGhlIGZpZWxk IGRybV9kZXZpY2UuaXJxX2VuYWJsZWQgaXMgb25seSB1c2VkIGJ5IGxlZ2FjeSBkcml2ZXJzCj4g d2l0aCB1c2Vyc3BhY2UgbW9kZXNldHRpbmcuIERvbid0IHNldCBpdCBpbiBtZWRpYXRlay4KPgoK QWNrZWQtYnk6IENodW4tS3VhbmcgSHUgPGNodW5rdWFuZy5odUBrZXJuZWwub3JnPgoKPiBTaWdu ZWQtb2ZmLWJ5OiBUaG9tYXMgWmltbWVybWFubiA8dHppbW1lcm1hbm5Ac3VzZS5kZT4KPiBSZXZp ZXdlZC1ieTogTGF1cmVudCBQaW5jaGFydCA8bGF1cmVudC5waW5jaGFydEBpZGVhc29uYm9hcmQu Y29tPgo+IEFja2VkLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgo+ IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9kcnYuYyB8IDYgLS0tLS0t Cj4gIDEgZmlsZSBjaGFuZ2VkLCA2IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2Rydi5jIGIvZHJpdmVycy9ncHUvZHJtL21lZGlh dGVrL210a19kcm1fZHJ2LmMKPiBpbmRleCBiNDZiZGI4OTg1ZGEuLjliNjBiZWMzM2QzYiAxMDA2 NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9kcnYuYwo+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2Rydi5jCj4gQEAgLTI3MCwxMiArMjcw LDYgQEAgc3RhdGljIGludCBtdGtfZHJtX2ttc19pbml0KHN0cnVjdCBkcm1fZGV2aWNlICpkcm0p Cj4gICAgICAgICAgICAgICAgIGdvdG8gZXJyX2NvbXBvbmVudF91bmJpbmQ7Cj4gICAgICAgICB9 Cj4KPiAtICAgICAgIC8qCj4gLSAgICAgICAgKiBXZSBkb24ndCB1c2UgdGhlIGRybV9pcnFfaW5z dGFsbCgpIGhlbHBlcnMgcHJvdmlkZWQgYnkgdGhlIERSTQo+IC0gICAgICAgICogY29yZSwgc28g d2UgbmVlZCB0byBzZXQgdGhpcyBtYW51YWxseSBpbiBvcmRlciB0byBhbGxvdyB0aGUKPiAtICAg ICAgICAqIERSTV9JT0NUTF9XQUlUX1ZCTEFOSyB0byBvcGVyYXRlIGNvcnJlY3RseS4KPiAtICAg ICAgICAqLwo+IC0gICAgICAgZHJtLT5pcnFfZW5hYmxlZCA9IHRydWU7Cj4gICAgICAgICByZXQg PSBkcm1fdmJsYW5rX2luaXQoZHJtLCBNQVhfQ1JUQyk7Cj4gICAgICAgICBpZiAocmV0IDwgMCkK PiAgICAgICAgICAgICAgICAgZ290byBlcnJfY29tcG9uZW50X3VuYmluZDsKPiAtLQo+IDIuMzIu MAo+CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51 eC1tZWRpYXRlayBtYWlsaW5nIGxpc3QKTGludXgtbWVkaWF0ZWtAbGlzdHMuaW5mcmFkZWFkLm9y ZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LW1lZGlh dGVrCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C63B3C432BE for ; Mon, 9 Aug 2021 13:09:18 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8833E60FF2 for ; Mon, 9 Aug 2021 13:09:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8833E60FF2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CFBA989B3B; Mon, 9 Aug 2021 13:09:12 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3344D899A5; Mon, 9 Aug 2021 13:09:11 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 06B8861004; Mon, 9 Aug 2021 13:09:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628514551; bh=YzG7BnFCln4Yyp6LxrxvxeyUMj5GmzMjIhVfIPMKSYc=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=B8pvYpwPzQ18zhH2+y0BGlUA/OJhSA/B0e0InC/nca080ep3tJvTyYkjw4iA0bIXy YJkfsyL7WJqFEvGlYZsDdfkS8W4gkzs2dxMYwyXUt2VpcSaAsgcNhIj8ai/6CAVUZ2 ldHAUzQEOhshkYgfdQv79fOgiKArwiLUzaIB6uXf33e9Dwx6fJNaNUWADrL3Q2AY27 Bl9LecINy6PsqQyvEgFzW02xNT9GIlS0Tp9TuaVC5l/yfox0JcJblrMOq9WQey5+Yx UjWS8SLAwRaq9m1jBvtg7XtqOaG9lvGylZ+m8LNCf4Md/cmndcHE0D+U5Qp6wYUHub B20Q3cXMUBSvw== Received: by mail-wr1-f52.google.com with SMTP id k29so8563403wrd.7; Mon, 09 Aug 2021 06:09:10 -0700 (PDT) X-Gm-Message-State: AOAM530HpmV+f8Lh1ZWrTeqml6bwZ6koMhJehP2RdxsiCeeG/g/Hr4PY pnLbIq1I4YazeQco2P15ALRqmfHsVz9MYathnA== X-Google-Smtp-Source: ABdhPJzottn9lR1w4Ou5tspJmaMhExuHvfqLuRluAKs7dQZoer2iHn4k6bWFWu6HusN3FgH38v3t3o0558IoBlRW8NU= X-Received: by 2002:a17:906:4156:: with SMTP id l22mr6919385ejk.75.1628514539014; Mon, 09 Aug 2021 06:08:59 -0700 (PDT) MIME-Version: 1.0 References: <20210625082222.3845-1-tzimmermann@suse.de> <20210625082222.3845-14-tzimmermann@suse.de> In-Reply-To: <20210625082222.3845-14-tzimmermann@suse.de> From: Chun-Kuang Hu Date: Mon, 9 Aug 2021 21:08:48 +0800 X-Gmail-Original-Message-ID: Message-ID: To: Thomas Zimmermann Cc: Daniel Vetter , David Airlie , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= , Xinhui.Pan@amd.com, james.qian.wang@arm.com, liviu.dudau@arm.com, mihail.atanassov@arm.com, brian.starkey@arm.com, Maarten Lankhorst , Maxime Ripard , Inki Dae , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , krzysztof.kozlowski@canonical.com, xinliang.liu@linaro.org, tiantao6@hisilicon.com, john.stultz@linaro.org, kong.kongxinwei@hisilicon.com, puck.chen@hisilicon.com, Laurentiu Palcu , Lucas Stach , Philipp Zabel , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Chun-Kuang Hu , Matthias Brugger , Ben Skeggs , Tomi Valkeinen , Sandy Huang , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Yannick Fertre , Philippe Cornu , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Jernej Skrabec , Thierry Reding , jonathanh@nvidia.com, Jyri Sarha , emma@anholt.net, linux-graphics-maintainer@vmware.com, zackr@vmware.com, hyun.kwon@xilinx.com, Laurent Pinchart , michal.simek@xilinx.com, jani.nikula@linux.intel.com, rodrigo.vivi@intel.com, Russell King , kieran.bingham+renesas@ideasonboard.com, Rodrigo Siqueira , Melissa Wen , Haneen Mohammed , amd-gfx@lists.freedesktop.org, DRI Development , Linux ARM , linux-samsung-soc@vger.kernel.org, "moderated list:ARM/Mediatek SoC support" , nouveau@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, Intel Graphics Development , Daniel Vetter Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Intel-gfx] [PATCH v4 13/27] drm/mediatek: Don't set struct drm_device.irq_enabled X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi, Thomas: Thomas Zimmermann =E6=96=BC 2021=E5=B9=B46=E6=9C=8825= =E6=97=A5 =E9=80=B1=E4=BA=94 =E4=B8=8B=E5=8D=884:22=E5=AF=AB=E9=81=93=EF=BC= =9A > > The field drm_device.irq_enabled is only used by legacy drivers > with userspace modesetting. Don't set it in mediatek. > Acked-by: Chun-Kuang Hu > Signed-off-by: Thomas Zimmermann > Reviewed-by: Laurent Pinchart > Acked-by: Daniel Vetter > --- > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/med= iatek/mtk_drm_drv.c > index b46bdb8985da..9b60bec33d3b 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > @@ -270,12 +270,6 @@ static int mtk_drm_kms_init(struct drm_device *drm) > goto err_component_unbind; > } > > - /* > - * We don't use the drm_irq_install() helpers provided by the DRM > - * core, so we need to set this manually in order to allow the > - * DRM_IOCTL_WAIT_VBLANK to operate correctly. > - */ > - drm->irq_enabled =3D true; > ret =3D drm_vblank_init(drm, MAX_CRTC); > if (ret < 0) > goto err_component_unbind; > -- > 2.32.0 >