From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F12E7C433E0 for ; Mon, 3 Aug 2020 16:13:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D076420A8B for ; Mon, 3 Aug 2020 16:13:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596471219; bh=HiU07JR1A+F1+Z53kyhPMkQd/qW5e56jQ2jPVulC8+4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=BcKeCiu9w3TsBdFzV4Gm/9aPgjZYtEH181TfX6rFGL8Q0dPd4Uy4XubNCyTl90pd1 B5HkjdXydFAUGRBpu5ZT6ee+BWsslg/fkAk4gic/yws1XhFDd/fwUqG5VxFDSEmTcT yCEifHiajkGKi08mxBE+nXdkYWx1ZsMNgoIgvXfk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728360AbgHCQNj (ORCPT ); Mon, 3 Aug 2020 12:13:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:49638 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726489AbgHCQNj (ORCPT ); Mon, 3 Aug 2020 12:13:39 -0400 Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2A9792177B; Mon, 3 Aug 2020 16:13:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596471217; bh=HiU07JR1A+F1+Z53kyhPMkQd/qW5e56jQ2jPVulC8+4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=X5IxzLoGXGhZ8Bs4qDZQdy04EZQYbwGYyq5pZ6j4Y154+ryCc3QMwHdQGC5v1tq34 4A2h7BH/2Cmd0xibFPwmhNDUoaeGWgtGGAg/l/XlMLE6LQt0g8m2WA7gn23Ll+ewgf tIcyXRtGkEbtd56lShh1UKfNr4Icfv8vx+v7EjRM= Received: by mail-ed1-f47.google.com with SMTP id c15so17971886edj.3; Mon, 03 Aug 2020 09:13:38 -0700 (PDT) X-Gm-Message-State: AOAM531C3bNxd0t4jnJ3tjFqY2g8Cuo5ojtyqNC/ONzD6BxnnEgAQdhp QcxVuh52zaOUAT3Xg18+xmrX/2M5UMQg2D+U6w== X-Google-Smtp-Source: ABdhPJxVBbThlPNq2pTchCAyLxwz7hgBlwFmi8zFSCXl7qnrzYmZzBYIfzjIAbCSg/UXEzg38x48cLfkIWq4AkAuZYg= X-Received: by 2002:a50:d2c7:: with SMTP id q7mr11624009edg.61.1596471216633; Mon, 03 Aug 2020 09:13:36 -0700 (PDT) MIME-Version: 1.0 References: <1596010690-13178-1-git-send-email-neal.liu@mediatek.com> <1596010690-13178-3-git-send-email-neal.liu@mediatek.com> <1596163478.3932.17.camel@mtkswgap22> <1596425521.22971.13.camel@mtkswgap22> In-Reply-To: <1596425521.22971.13.camel@mtkswgap22> From: Chun-Kuang Hu Date: Tue, 4 Aug 2020 00:13:23 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 2/2] soc: mediatek: add mtk-devapc driver To: Neal Liu Cc: Chun-Kuang Hu , Rob Herring , Matthias Brugger , devicetree@vger.kernel.org, wsd_upstream , lkml , "moderated list:ARM/Mediatek SoC support" , Linux ARM Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Neal: Neal Liu =E6=96=BC 2020=E5=B9=B48=E6=9C=883=E6=97= =A5 =E9=80=B1=E4=B8=80 =E4=B8=8A=E5=8D=8811:32=E5=AF=AB=E9=81=93=EF=BC=9A > > Hi Chun-Kuang, > > On Fri, 2020-07-31 at 23:03 +0800, Chun-Kuang Hu wrote: > > Hi, Neal: > > > > Neal Liu =E6=96=BC 2020=E5=B9=B47=E6=9C=8831=E6= =97=A5 =E9=80=B1=E4=BA=94 =E4=B8=8A=E5=8D=8810:44=E5=AF=AB=E9=81=93=EF=BC= =9A > > > > > > Hi Chun-Kuang, > > > > > > > > > On Thu, 2020-07-30 at 00:38 +0800, Chun-Kuang Hu wrote: > > > > Hi, Neal: > > > > > > > > Neal Liu =E6=96=BC 2020=E5=B9=B47=E6=9C=882= 9=E6=97=A5 =E9=80=B1=E4=B8=89 =E4=B8=8B=E5=8D=884:29=E5=AF=AB=E9=81=93=EF= =BC=9A > > > > > > > > > > MediaTek bus fabric provides TrustZone security support and data > > > > > protection to prevent slaves from being accessed by unexpected > > > > > masters. > > > > > The security violation is logged and sent to the processor for > > > > > further analysis or countermeasures. > > > > > > > > > > Any occurrence of security violation would raise an interrupt, an= d > > > > > it will be handled by mtk-devapc driver. The violation > > > > > information is printed in order to find the murderer. > > > > > > > > > > Signed-off-by: Neal Liu > > > > > --- > > > > > > > > [snip] > > > > > > > > > + > > > > > +/* > > > > > + * devapc_extract_vio_dbg - extract full violation information a= fter doing > > > > > + * shift mechanism. > > > > > + */ > > > > > +static void devapc_extract_vio_dbg(struct mtk_devapc_context *ct= x) > > > > > +{ > > > > > + const struct mtk_devapc_vio_dbgs *vio_dbgs; > > > > > + struct mtk_devapc_vio_info *vio_info; > > > > > + void __iomem *vio_dbg0_reg; > > > > > + void __iomem *vio_dbg1_reg; > > > > > + u32 dbg0; > > > > > + > > > > > + vio_dbg0_reg =3D ctx->devapc_pd_base + ctx->offset->vio_d= bg0; > > > > > + vio_dbg1_reg =3D ctx->devapc_pd_base + ctx->offset->vio_d= bg1; > > > > > + > > > > > + vio_dbgs =3D ctx->vio_dbgs; > > > > > + vio_info =3D ctx->vio_info; > > > > > + > > > > > + /* Starts to extract violation information */ > > > > > + dbg0 =3D readl(vio_dbg0_reg); > > > > > + vio_info->vio_addr =3D readl(vio_dbg1_reg); > > > > > + > > > > > + vio_info->master_id =3D (dbg0 & vio_dbgs->mstid.mask) >> > > > > > + vio_dbgs->mstid.start; > > > > > > > > What is master_id? How could we use it to debug? For example, if we > > > > get a master_id =3D 1, what should we do for this? > > > > > > > > > + vio_info->domain_id =3D (dbg0 & vio_dbgs->dmnid.mask) >> > > > > > + vio_dbgs->dmnid.start; > > > > > > > > What is domain_id? How could we use it to debug? For example, if we > > > > get a domain_id =3D 2, what should we do for this? > > > > > > > > > > master_id and domain_id belongs our bus side-band signal info. It can > > > help us to find the violation master. > > > > Does 'violation master' means the hardware could access the protected > > register? (ex. CPU, GCE, ...) If so, I think it's better to add > > comment to explain how to map (master_id, domain_id) to a hardware > > (maybe the device in device tree) because every body does not know > > what the number means. Don't try to translate the number to a string > > because this would cost much time to do this. Just print a number and > > we could find out the master by the comment. > > 'violation master' means the master which violates the permission > control. For example, if we set permission 'Secure R/W only' as CPU to > spi register. When violation is triggered, it means CPU access spi > register through normal world instead of secure world, which is not > allowed. > > 'master_id' cannot use the simple comments to describe which master it > is. It depends on violation slaves. For example, if there are two > violations: > 1. CPU access spi reg > 2. CPU access timer reg > It might be different 'master_id' for CPU on these two cases. > I would prefer to remain the id number if translate to a string is a bad > idea. > Thanks ! It seams that master_id and domain_id does not help for debug. When we get master_id =3D 1 and domain_id =3D 2, we don't know what it mean. I think we just need violation address because we could find the driver that write this address and the bug would be inside this driver. So need not to process master_id and domain_id. Regards, Chun-Kuang. > > > > > > > > > > > + vio_info->write =3D ((dbg0 & vio_dbgs->vio_w.mask) >> > > > > > + vio_dbgs->vio_w.start) =3D=3D 1; > > > > > + vio_info->read =3D ((dbg0 & vio_dbgs->vio_r.mask) >> > > > > > + vio_dbgs->vio_r.start) =3D=3D 1; > > > > > + vio_info->vio_addr_high =3D (dbg0 & vio_dbgs->addr_h.mask= ) >> > > > > > + vio_dbgs->addr_h.start; > > > > > > > > What is vio_addr_high? As I know all register address are 32 bits, = is > > > > vio_addr_high the address above 32 bits? > > > > > > Yes, you are right. In MT6779, all register base are 32 bits. We can > > > ignore this info for current driver. I'll update on next patch. > > > Thanks ! > > > > Such a strange hardware, all register is 32 bits but it has a > > vio_addr_high in its register. OK, just drop this. > > > > > > > > > > > > > > + > > > > > + devapc_vio_info_print(ctx); > > > > > +} > > > > > + > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29E7EC433DF for ; Mon, 3 Aug 2020 16:13:54 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EBC7020738 for ; Mon, 3 Aug 2020 16:13:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="xAolyU4H"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="X5IxzLoG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EBC7020738 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1Ha3mQhaKey+y55Ic4n/Se50MYRUl9WCJpCIdfop5/8=; b=xAolyU4H/nZX03a7foo3EL9CJ a1CYsQBXOdoyt7OWETYzKCN6H8YA5ElmQdK/ebDirLTIq+H7SAh7W24kCSTO+5I5Of+zZeRXhLWgy LWHlLIKdsa1Cttrp+kyRyh1ISI069MnjGKPQjmD1Lwu4xLPeh2cWzlU8MKTzWmQ668KnuOM2LoD2G +8NqDhW0ZTx7vjkIPWMQ3bYgyGI+e7LAL5x8SWUcAjm1PgukLZlwJZLGYf+FQmUYI20gKro8W5R+F LA3cUaFZnAq1HBYqxkKdC/AIew1e4h5+O/6vyJRu3J9YiSxEFD795cb5x00JUblWk12VxGCQ17W44 Jyq4s/zeA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k2d5t-0007x0-Gn; Mon, 03 Aug 2020 16:13:45 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k2d5n-0007ve-93; Mon, 03 Aug 2020 16:13:41 +0000 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 26D4420738; Mon, 3 Aug 2020 16:13:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596471217; bh=HiU07JR1A+F1+Z53kyhPMkQd/qW5e56jQ2jPVulC8+4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=X5IxzLoGXGhZ8Bs4qDZQdy04EZQYbwGYyq5pZ6j4Y154+ryCc3QMwHdQGC5v1tq34 4A2h7BH/2Cmd0xibFPwmhNDUoaeGWgtGGAg/l/XlMLE6LQt0g8m2WA7gn23Ll+ewgf tIcyXRtGkEbtd56lShh1UKfNr4Icfv8vx+v7EjRM= Received: by mail-ed1-f42.google.com with SMTP id m20so18156268eds.2; Mon, 03 Aug 2020 09:13:38 -0700 (PDT) X-Gm-Message-State: AOAM533Kfy+do5vGIBsbQyEFw49szgYGszg2ma+AvEO/JoGuNlCWEvb7 Yap7ABy81xpmzFbgRlmXaha1QjFJmUuenL4qXA== X-Google-Smtp-Source: ABdhPJxVBbThlPNq2pTchCAyLxwz7hgBlwFmi8zFSCXl7qnrzYmZzBYIfzjIAbCSg/UXEzg38x48cLfkIWq4AkAuZYg= X-Received: by 2002:a50:d2c7:: with SMTP id q7mr11624009edg.61.1596471216633; Mon, 03 Aug 2020 09:13:36 -0700 (PDT) MIME-Version: 1.0 References: <1596010690-13178-1-git-send-email-neal.liu@mediatek.com> <1596010690-13178-3-git-send-email-neal.liu@mediatek.com> <1596163478.3932.17.camel@mtkswgap22> <1596425521.22971.13.camel@mtkswgap22> In-Reply-To: <1596425521.22971.13.camel@mtkswgap22> From: Chun-Kuang Hu Date: Tue, 4 Aug 2020 00:13:23 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 2/2] soc: mediatek: add mtk-devapc driver To: Neal Liu X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200803_121339_459321_3DFB0F32 X-CRM114-Status: GOOD ( 35.60 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chun-Kuang Hu , wsd_upstream , devicetree@vger.kernel.org, lkml , Rob Herring , "moderated list:ARM/Mediatek SoC support" , Matthias Brugger , Linux ARM Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org SGksIE5lYWw6CgpOZWFsIExpdSA8bmVhbC5saXVAbWVkaWF0ZWsuY29tPiDmlrwgMjAyMOW5tDjm nIgz5pelIOmAseS4gCDkuIrljYgxMTozMuWvq+mBk++8mgo+Cj4gSGkgQ2h1bi1LdWFuZywKPgo+ IE9uIEZyaSwgMjAyMC0wNy0zMSBhdCAyMzowMyArMDgwMCwgQ2h1bi1LdWFuZyBIdSB3cm90ZToK PiA+IEhpLCBOZWFsOgo+ID4KPiA+IE5lYWwgTGl1IDxuZWFsLmxpdUBtZWRpYXRlay5jb20+IOaW vCAyMDIw5bm0N+aciDMx5pelIOmAseS6lCDkuIrljYgxMDo0NOWvq+mBk++8mgo+ID4gPgo+ID4g PiBIaSBDaHVuLUt1YW5nLAo+ID4gPgo+ID4gPgo+ID4gPiBPbiBUaHUsIDIwMjAtMDctMzAgYXQg MDA6MzggKzA4MDAsIENodW4tS3VhbmcgSHUgd3JvdGU6Cj4gPiA+ID4gSGksIE5lYWw6Cj4gPiA+ ID4KPiA+ID4gPiBOZWFsIExpdSA8bmVhbC5saXVAbWVkaWF0ZWsuY29tPiDmlrwgMjAyMOW5tDfm nIgyOeaXpSDpgLHkuIkg5LiL5Y2INDoyOeWvq+mBk++8mgo+ID4gPiA+ID4KPiA+ID4gPiA+IE1l ZGlhVGVrIGJ1cyBmYWJyaWMgcHJvdmlkZXMgVHJ1c3Rab25lIHNlY3VyaXR5IHN1cHBvcnQgYW5k IGRhdGEKPiA+ID4gPiA+IHByb3RlY3Rpb24gdG8gcHJldmVudCBzbGF2ZXMgZnJvbSBiZWluZyBh Y2Nlc3NlZCBieSB1bmV4cGVjdGVkCj4gPiA+ID4gPiBtYXN0ZXJzLgo+ID4gPiA+ID4gVGhlIHNl Y3VyaXR5IHZpb2xhdGlvbiBpcyBsb2dnZWQgYW5kIHNlbnQgdG8gdGhlIHByb2Nlc3NvciBmb3IK PiA+ID4gPiA+IGZ1cnRoZXIgYW5hbHlzaXMgb3IgY291bnRlcm1lYXN1cmVzLgo+ID4gPiA+ID4K PiA+ID4gPiA+IEFueSBvY2N1cnJlbmNlIG9mIHNlY3VyaXR5IHZpb2xhdGlvbiB3b3VsZCByYWlz ZSBhbiBpbnRlcnJ1cHQsIGFuZAo+ID4gPiA+ID4gaXQgd2lsbCBiZSBoYW5kbGVkIGJ5IG10ay1k ZXZhcGMgZHJpdmVyLiBUaGUgdmlvbGF0aW9uCj4gPiA+ID4gPiBpbmZvcm1hdGlvbiBpcyBwcmlu dGVkIGluIG9yZGVyIHRvIGZpbmQgdGhlIG11cmRlcmVyLgo+ID4gPiA+ID4KPiA+ID4gPiA+IFNp Z25lZC1vZmYtYnk6IE5lYWwgTGl1IDxuZWFsLmxpdUBtZWRpYXRlay5jb20+Cj4gPiA+ID4gPiAt LS0KPiA+ID4gPgo+ID4gPiA+IFtzbmlwXQo+ID4gPiA+Cj4gPiA+ID4gPiArCj4gPiA+ID4gPiAr LyoKPiA+ID4gPiA+ICsgKiBkZXZhcGNfZXh0cmFjdF92aW9fZGJnIC0gZXh0cmFjdCBmdWxsIHZp b2xhdGlvbiBpbmZvcm1hdGlvbiBhZnRlciBkb2luZwo+ID4gPiA+ID4gKyAqICAgICAgICAgICAg ICAgICAgICAgICAgICBzaGlmdCBtZWNoYW5pc20uCj4gPiA+ID4gPiArICovCj4gPiA+ID4gPiAr c3RhdGljIHZvaWQgZGV2YXBjX2V4dHJhY3RfdmlvX2RiZyhzdHJ1Y3QgbXRrX2RldmFwY19jb250 ZXh0ICpjdHgpCj4gPiA+ID4gPiArewo+ID4gPiA+ID4gKyAgICAgICBjb25zdCBzdHJ1Y3QgbXRr X2RldmFwY192aW9fZGJncyAqdmlvX2RiZ3M7Cj4gPiA+ID4gPiArICAgICAgIHN0cnVjdCBtdGtf ZGV2YXBjX3Zpb19pbmZvICp2aW9faW5mbzsKPiA+ID4gPiA+ICsgICAgICAgdm9pZCBfX2lvbWVt ICp2aW9fZGJnMF9yZWc7Cj4gPiA+ID4gPiArICAgICAgIHZvaWQgX19pb21lbSAqdmlvX2RiZzFf cmVnOwo+ID4gPiA+ID4gKyAgICAgICB1MzIgZGJnMDsKPiA+ID4gPiA+ICsKPiA+ID4gPiA+ICsg ICAgICAgdmlvX2RiZzBfcmVnID0gY3R4LT5kZXZhcGNfcGRfYmFzZSArIGN0eC0+b2Zmc2V0LT52 aW9fZGJnMDsKPiA+ID4gPiA+ICsgICAgICAgdmlvX2RiZzFfcmVnID0gY3R4LT5kZXZhcGNfcGRf YmFzZSArIGN0eC0+b2Zmc2V0LT52aW9fZGJnMTsKPiA+ID4gPiA+ICsKPiA+ID4gPiA+ICsgICAg ICAgdmlvX2RiZ3MgPSBjdHgtPnZpb19kYmdzOwo+ID4gPiA+ID4gKyAgICAgICB2aW9faW5mbyA9 IGN0eC0+dmlvX2luZm87Cj4gPiA+ID4gPiArCj4gPiA+ID4gPiArICAgICAgIC8qIFN0YXJ0cyB0 byBleHRyYWN0IHZpb2xhdGlvbiBpbmZvcm1hdGlvbiAqLwo+ID4gPiA+ID4gKyAgICAgICBkYmcw ID0gcmVhZGwodmlvX2RiZzBfcmVnKTsKPiA+ID4gPiA+ICsgICAgICAgdmlvX2luZm8tPnZpb19h ZGRyID0gcmVhZGwodmlvX2RiZzFfcmVnKTsKPiA+ID4gPiA+ICsKPiA+ID4gPiA+ICsgICAgICAg dmlvX2luZm8tPm1hc3Rlcl9pZCA9IChkYmcwICYgdmlvX2RiZ3MtPm1zdGlkLm1hc2spID4+Cj4g PiA+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICB2aW9fZGJncy0+bXN0aWQuc3Rh cnQ7Cj4gPiA+ID4KPiA+ID4gPiBXaGF0IGlzIG1hc3Rlcl9pZD8gSG93IGNvdWxkIHdlIHVzZSBp dCB0byBkZWJ1Zz8gRm9yIGV4YW1wbGUsIGlmIHdlCj4gPiA+ID4gZ2V0IGEgbWFzdGVyX2lkID0g MSwgd2hhdCBzaG91bGQgd2UgZG8gZm9yIHRoaXM/Cj4gPiA+ID4KPiA+ID4gPiA+ICsgICAgICAg dmlvX2luZm8tPmRvbWFpbl9pZCA9IChkYmcwICYgdmlvX2RiZ3MtPmRtbmlkLm1hc2spID4+Cj4g PiA+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICB2aW9fZGJncy0+ZG1uaWQuc3Rh cnQ7Cj4gPiA+ID4KPiA+ID4gPiBXaGF0IGlzIGRvbWFpbl9pZD8gSG93IGNvdWxkIHdlIHVzZSBp dCB0byBkZWJ1Zz8gRm9yIGV4YW1wbGUsIGlmIHdlCj4gPiA+ID4gZ2V0IGEgZG9tYWluX2lkID0g Miwgd2hhdCBzaG91bGQgd2UgZG8gZm9yIHRoaXM/Cj4gPiA+ID4KPiA+ID4KPiA+ID4gbWFzdGVy X2lkIGFuZCBkb21haW5faWQgYmVsb25ncyBvdXIgYnVzIHNpZGUtYmFuZCBzaWduYWwgaW5mby4g SXQgY2FuCj4gPiA+IGhlbHAgdXMgdG8gZmluZCB0aGUgdmlvbGF0aW9uIG1hc3Rlci4KPiA+Cj4g PiBEb2VzICd2aW9sYXRpb24gbWFzdGVyJyBtZWFucyB0aGUgaGFyZHdhcmUgY291bGQgYWNjZXNz IHRoZSBwcm90ZWN0ZWQKPiA+IHJlZ2lzdGVyPyAoZXguIENQVSwgR0NFLCAuLi4pIElmIHNvLCBJ IHRoaW5rIGl0J3MgYmV0dGVyIHRvIGFkZAo+ID4gY29tbWVudCB0byBleHBsYWluIGhvdyB0byBt YXAgKG1hc3Rlcl9pZCwgZG9tYWluX2lkKSB0byBhIGhhcmR3YXJlCj4gPiAobWF5YmUgdGhlIGRl dmljZSBpbiBkZXZpY2UgdHJlZSkgYmVjYXVzZSBldmVyeSBib2R5IGRvZXMgbm90IGtub3cKPiA+ IHdoYXQgdGhlIG51bWJlciBtZWFucy4gRG9uJ3QgdHJ5IHRvIHRyYW5zbGF0ZSB0aGUgbnVtYmVy IHRvIGEgc3RyaW5nCj4gPiBiZWNhdXNlIHRoaXMgd291bGQgY29zdCBtdWNoIHRpbWUgdG8gZG8g dGhpcy4gSnVzdCBwcmludCBhIG51bWJlciBhbmQKPiA+IHdlIGNvdWxkIGZpbmQgb3V0IHRoZSBt YXN0ZXIgYnkgdGhlIGNvbW1lbnQuCj4KPiAndmlvbGF0aW9uIG1hc3RlcicgbWVhbnMgdGhlIG1h c3RlciB3aGljaCB2aW9sYXRlcyB0aGUgcGVybWlzc2lvbgo+IGNvbnRyb2wuIEZvciBleGFtcGxl LCBpZiB3ZSBzZXQgcGVybWlzc2lvbiAnU2VjdXJlIFIvVyBvbmx5JyBhcyBDUFUgdG8KPiBzcGkg cmVnaXN0ZXIuIFdoZW4gdmlvbGF0aW9uIGlzIHRyaWdnZXJlZCwgaXQgbWVhbnMgQ1BVIGFjY2Vz cyBzcGkKPiByZWdpc3RlciB0aHJvdWdoIG5vcm1hbCB3b3JsZCBpbnN0ZWFkIG9mIHNlY3VyZSB3 b3JsZCwgd2hpY2ggaXMgbm90Cj4gYWxsb3dlZC4KPgo+ICdtYXN0ZXJfaWQnIGNhbm5vdCB1c2Ug dGhlIHNpbXBsZSBjb21tZW50cyB0byBkZXNjcmliZSB3aGljaCBtYXN0ZXIgaXQKPiBpcy4gSXQg ZGVwZW5kcyBvbiB2aW9sYXRpb24gc2xhdmVzLiBGb3IgZXhhbXBsZSwgaWYgdGhlcmUgYXJlIHR3 bwo+IHZpb2xhdGlvbnM6Cj4gMS4gQ1BVIGFjY2VzcyBzcGkgcmVnCj4gMi4gQ1BVIGFjY2VzcyB0 aW1lciByZWcKPiBJdCBtaWdodCBiZSBkaWZmZXJlbnQgJ21hc3Rlcl9pZCcgZm9yIENQVSBvbiB0 aGVzZSB0d28gY2FzZXMuCj4gSSB3b3VsZCBwcmVmZXIgdG8gcmVtYWluIHRoZSBpZCBudW1iZXIg aWYgdHJhbnNsYXRlIHRvIGEgc3RyaW5nIGlzIGEgYmFkCj4gaWRlYS4KPiBUaGFua3MgIQoKSXQg c2VhbXMgdGhhdCBtYXN0ZXJfaWQgYW5kIGRvbWFpbl9pZCBkb2VzIG5vdCBoZWxwIGZvciBkZWJ1 Zy4gV2hlbiB3ZQpnZXQgbWFzdGVyX2lkID0gMSBhbmQgZG9tYWluX2lkID0gMiwgd2UgZG9uJ3Qg a25vdyB3aGF0IGl0IG1lYW4uIEkKdGhpbmsgd2UganVzdCBuZWVkIHZpb2xhdGlvbiBhZGRyZXNz IGJlY2F1c2Ugd2UgY291bGQgZmluZCB0aGUgZHJpdmVyCnRoYXQgd3JpdGUgdGhpcyBhZGRyZXNz IGFuZCB0aGUgYnVnIHdvdWxkIGJlIGluc2lkZSB0aGlzIGRyaXZlci4gU28KbmVlZCBub3QgdG8g cHJvY2VzcyBtYXN0ZXJfaWQgYW5kIGRvbWFpbl9pZC4KClJlZ2FyZHMsCkNodW4tS3VhbmcuCgo+ Cj4gPgo+ID4gPgo+ID4gPiA+ID4gKyAgICAgICB2aW9faW5mby0+d3JpdGUgPSAoKGRiZzAgJiB2 aW9fZGJncy0+dmlvX3cubWFzaykgPj4KPiA+ID4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAg ICAgICB2aW9fZGJncy0+dmlvX3cuc3RhcnQpID09IDE7Cj4gPiA+ID4gPiArICAgICAgIHZpb19p bmZvLT5yZWFkID0gKChkYmcwICYgdmlvX2RiZ3MtPnZpb19yLm1hc2spID4+Cj4gPiA+ID4gPiAr ICAgICAgICAgICAgICAgICAgICAgICAgIHZpb19kYmdzLT52aW9fci5zdGFydCkgPT0gMTsKPiA+ ID4gPiA+ICsgICAgICAgdmlvX2luZm8tPnZpb19hZGRyX2hpZ2ggPSAoZGJnMCAmIHZpb19kYmdz LT5hZGRyX2gubWFzaykgPj4KPiA+ID4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICB2aW9fZGJncy0+YWRkcl9oLnN0YXJ0Owo+ID4gPiA+Cj4gPiA+ID4gV2hhdCBpcyB2aW9f YWRkcl9oaWdoPyBBcyBJIGtub3cgYWxsIHJlZ2lzdGVyIGFkZHJlc3MgYXJlIDMyIGJpdHMsIGlz Cj4gPiA+ID4gdmlvX2FkZHJfaGlnaCB0aGUgYWRkcmVzcyBhYm92ZSAzMiBiaXRzPwo+ID4gPgo+ ID4gPiBZZXMsIHlvdSBhcmUgcmlnaHQuIEluIE1UNjc3OSwgYWxsIHJlZ2lzdGVyIGJhc2UgYXJl IDMyIGJpdHMuIFdlIGNhbgo+ID4gPiBpZ25vcmUgdGhpcyBpbmZvIGZvciBjdXJyZW50IGRyaXZl ci4gSSdsbCB1cGRhdGUgb24gbmV4dCBwYXRjaC4KPiA+ID4gVGhhbmtzICEKPiA+Cj4gPiBTdWNo IGEgc3RyYW5nZSBoYXJkd2FyZSwgYWxsIHJlZ2lzdGVyIGlzIDMyIGJpdHMgYnV0IGl0IGhhcyBh Cj4gPiB2aW9fYWRkcl9oaWdoIGluIGl0cyByZWdpc3Rlci4gT0ssIGp1c3QgZHJvcCB0aGlzLgo+ ID4KPiA+ID4KPiA+ID4gPgo+ID4gPiA+ID4gKwo+ID4gPiA+ID4gKyAgICAgICBkZXZhcGNfdmlv X2luZm9fcHJpbnQoY3R4KTsKPiA+ID4gPiA+ICt9Cj4gPiA+ID4gPiArCj4gPiA+ID4KCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4LW1lZGlhdGVr IG1haWxpbmcgbGlzdApMaW51eC1tZWRpYXRla0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9s aXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtbWVkaWF0ZWsK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E43ECC433E0 for ; Mon, 3 Aug 2020 16:15:04 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B0A1F20738 for ; Mon, 3 Aug 2020 16:15:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="TiTh5FNh"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="X5IxzLoG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B0A1F20738 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TZNVqhKNy3crOcOjSm8x5yDyFGQEQXnGJKbUvs2dES8=; b=TiTh5FNhHkpI3EOqXvbRFcYI9 G/ubUj9RV4peM936svT0cHU6lTuZVyNl1khuUGMa6S7wgf4QOQcUmJ0K6Dd7AlYEGLlmPEzB3wdAz /GGS253L+0RzB3EMtWM1vwBRltlUUF/x4sKdteebTOzjkYjO6aOUjui5BuqC/Uggv+k45vDTNxyWZ RzLxxxoYJ4hBrmzzFBJdxq8ElmuSk9fa2bLsGDchHrUcHvfiEbtZv7OK+QPEUL5lP6aytBcD63+XG D6gg/EKf+PRP00vZ0NlI0EbttzpW0STP3sgmH7slGXX4S+7rAPLrFP7vlWe2GDxHCTI62dFADbDoA D1fpnCAsw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k2d5s-0007wg-29; Mon, 03 Aug 2020 16:13:44 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k2d5n-0007ve-93; Mon, 03 Aug 2020 16:13:41 +0000 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 26D4420738; Mon, 3 Aug 2020 16:13:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596471217; bh=HiU07JR1A+F1+Z53kyhPMkQd/qW5e56jQ2jPVulC8+4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=X5IxzLoGXGhZ8Bs4qDZQdy04EZQYbwGYyq5pZ6j4Y154+ryCc3QMwHdQGC5v1tq34 4A2h7BH/2Cmd0xibFPwmhNDUoaeGWgtGGAg/l/XlMLE6LQt0g8m2WA7gn23Ll+ewgf tIcyXRtGkEbtd56lShh1UKfNr4Icfv8vx+v7EjRM= Received: by mail-ed1-f42.google.com with SMTP id m20so18156268eds.2; Mon, 03 Aug 2020 09:13:38 -0700 (PDT) X-Gm-Message-State: AOAM533Kfy+do5vGIBsbQyEFw49szgYGszg2ma+AvEO/JoGuNlCWEvb7 Yap7ABy81xpmzFbgRlmXaha1QjFJmUuenL4qXA== X-Google-Smtp-Source: ABdhPJxVBbThlPNq2pTchCAyLxwz7hgBlwFmi8zFSCXl7qnrzYmZzBYIfzjIAbCSg/UXEzg38x48cLfkIWq4AkAuZYg= X-Received: by 2002:a50:d2c7:: with SMTP id q7mr11624009edg.61.1596471216633; Mon, 03 Aug 2020 09:13:36 -0700 (PDT) MIME-Version: 1.0 References: <1596010690-13178-1-git-send-email-neal.liu@mediatek.com> <1596010690-13178-3-git-send-email-neal.liu@mediatek.com> <1596163478.3932.17.camel@mtkswgap22> <1596425521.22971.13.camel@mtkswgap22> In-Reply-To: <1596425521.22971.13.camel@mtkswgap22> From: Chun-Kuang Hu Date: Tue, 4 Aug 2020 00:13:23 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 2/2] soc: mediatek: add mtk-devapc driver To: Neal Liu X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200803_121339_459321_3DFB0F32 X-CRM114-Status: GOOD ( 35.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chun-Kuang Hu , wsd_upstream , devicetree@vger.kernel.org, lkml , Rob Herring , "moderated list:ARM/Mediatek SoC support" , Matthias Brugger , Linux ARM Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGksIE5lYWw6CgpOZWFsIExpdSA8bmVhbC5saXVAbWVkaWF0ZWsuY29tPiDmlrwgMjAyMOW5tDjm nIgz5pelIOmAseS4gCDkuIrljYgxMTozMuWvq+mBk++8mgo+Cj4gSGkgQ2h1bi1LdWFuZywKPgo+ IE9uIEZyaSwgMjAyMC0wNy0zMSBhdCAyMzowMyArMDgwMCwgQ2h1bi1LdWFuZyBIdSB3cm90ZToK PiA+IEhpLCBOZWFsOgo+ID4KPiA+IE5lYWwgTGl1IDxuZWFsLmxpdUBtZWRpYXRlay5jb20+IOaW vCAyMDIw5bm0N+aciDMx5pelIOmAseS6lCDkuIrljYgxMDo0NOWvq+mBk++8mgo+ID4gPgo+ID4g PiBIaSBDaHVuLUt1YW5nLAo+ID4gPgo+ID4gPgo+ID4gPiBPbiBUaHUsIDIwMjAtMDctMzAgYXQg MDA6MzggKzA4MDAsIENodW4tS3VhbmcgSHUgd3JvdGU6Cj4gPiA+ID4gSGksIE5lYWw6Cj4gPiA+ ID4KPiA+ID4gPiBOZWFsIExpdSA8bmVhbC5saXVAbWVkaWF0ZWsuY29tPiDmlrwgMjAyMOW5tDfm nIgyOeaXpSDpgLHkuIkg5LiL5Y2INDoyOeWvq+mBk++8mgo+ID4gPiA+ID4KPiA+ID4gPiA+IE1l ZGlhVGVrIGJ1cyBmYWJyaWMgcHJvdmlkZXMgVHJ1c3Rab25lIHNlY3VyaXR5IHN1cHBvcnQgYW5k IGRhdGEKPiA+ID4gPiA+IHByb3RlY3Rpb24gdG8gcHJldmVudCBzbGF2ZXMgZnJvbSBiZWluZyBh Y2Nlc3NlZCBieSB1bmV4cGVjdGVkCj4gPiA+ID4gPiBtYXN0ZXJzLgo+ID4gPiA+ID4gVGhlIHNl Y3VyaXR5IHZpb2xhdGlvbiBpcyBsb2dnZWQgYW5kIHNlbnQgdG8gdGhlIHByb2Nlc3NvciBmb3IK PiA+ID4gPiA+IGZ1cnRoZXIgYW5hbHlzaXMgb3IgY291bnRlcm1lYXN1cmVzLgo+ID4gPiA+ID4K PiA+ID4gPiA+IEFueSBvY2N1cnJlbmNlIG9mIHNlY3VyaXR5IHZpb2xhdGlvbiB3b3VsZCByYWlz ZSBhbiBpbnRlcnJ1cHQsIGFuZAo+ID4gPiA+ID4gaXQgd2lsbCBiZSBoYW5kbGVkIGJ5IG10ay1k ZXZhcGMgZHJpdmVyLiBUaGUgdmlvbGF0aW9uCj4gPiA+ID4gPiBpbmZvcm1hdGlvbiBpcyBwcmlu dGVkIGluIG9yZGVyIHRvIGZpbmQgdGhlIG11cmRlcmVyLgo+ID4gPiA+ID4KPiA+ID4gPiA+IFNp Z25lZC1vZmYtYnk6IE5lYWwgTGl1IDxuZWFsLmxpdUBtZWRpYXRlay5jb20+Cj4gPiA+ID4gPiAt LS0KPiA+ID4gPgo+ID4gPiA+IFtzbmlwXQo+ID4gPiA+Cj4gPiA+ID4gPiArCj4gPiA+ID4gPiAr LyoKPiA+ID4gPiA+ICsgKiBkZXZhcGNfZXh0cmFjdF92aW9fZGJnIC0gZXh0cmFjdCBmdWxsIHZp b2xhdGlvbiBpbmZvcm1hdGlvbiBhZnRlciBkb2luZwo+ID4gPiA+ID4gKyAqICAgICAgICAgICAg ICAgICAgICAgICAgICBzaGlmdCBtZWNoYW5pc20uCj4gPiA+ID4gPiArICovCj4gPiA+ID4gPiAr c3RhdGljIHZvaWQgZGV2YXBjX2V4dHJhY3RfdmlvX2RiZyhzdHJ1Y3QgbXRrX2RldmFwY19jb250 ZXh0ICpjdHgpCj4gPiA+ID4gPiArewo+ID4gPiA+ID4gKyAgICAgICBjb25zdCBzdHJ1Y3QgbXRr X2RldmFwY192aW9fZGJncyAqdmlvX2RiZ3M7Cj4gPiA+ID4gPiArICAgICAgIHN0cnVjdCBtdGtf ZGV2YXBjX3Zpb19pbmZvICp2aW9faW5mbzsKPiA+ID4gPiA+ICsgICAgICAgdm9pZCBfX2lvbWVt ICp2aW9fZGJnMF9yZWc7Cj4gPiA+ID4gPiArICAgICAgIHZvaWQgX19pb21lbSAqdmlvX2RiZzFf cmVnOwo+ID4gPiA+ID4gKyAgICAgICB1MzIgZGJnMDsKPiA+ID4gPiA+ICsKPiA+ID4gPiA+ICsg ICAgICAgdmlvX2RiZzBfcmVnID0gY3R4LT5kZXZhcGNfcGRfYmFzZSArIGN0eC0+b2Zmc2V0LT52 aW9fZGJnMDsKPiA+ID4gPiA+ICsgICAgICAgdmlvX2RiZzFfcmVnID0gY3R4LT5kZXZhcGNfcGRf YmFzZSArIGN0eC0+b2Zmc2V0LT52aW9fZGJnMTsKPiA+ID4gPiA+ICsKPiA+ID4gPiA+ICsgICAg ICAgdmlvX2RiZ3MgPSBjdHgtPnZpb19kYmdzOwo+ID4gPiA+ID4gKyAgICAgICB2aW9faW5mbyA9 IGN0eC0+dmlvX2luZm87Cj4gPiA+ID4gPiArCj4gPiA+ID4gPiArICAgICAgIC8qIFN0YXJ0cyB0 byBleHRyYWN0IHZpb2xhdGlvbiBpbmZvcm1hdGlvbiAqLwo+ID4gPiA+ID4gKyAgICAgICBkYmcw ID0gcmVhZGwodmlvX2RiZzBfcmVnKTsKPiA+ID4gPiA+ICsgICAgICAgdmlvX2luZm8tPnZpb19h ZGRyID0gcmVhZGwodmlvX2RiZzFfcmVnKTsKPiA+ID4gPiA+ICsKPiA+ID4gPiA+ICsgICAgICAg dmlvX2luZm8tPm1hc3Rlcl9pZCA9IChkYmcwICYgdmlvX2RiZ3MtPm1zdGlkLm1hc2spID4+Cj4g PiA+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICB2aW9fZGJncy0+bXN0aWQuc3Rh cnQ7Cj4gPiA+ID4KPiA+ID4gPiBXaGF0IGlzIG1hc3Rlcl9pZD8gSG93IGNvdWxkIHdlIHVzZSBp dCB0byBkZWJ1Zz8gRm9yIGV4YW1wbGUsIGlmIHdlCj4gPiA+ID4gZ2V0IGEgbWFzdGVyX2lkID0g MSwgd2hhdCBzaG91bGQgd2UgZG8gZm9yIHRoaXM/Cj4gPiA+ID4KPiA+ID4gPiA+ICsgICAgICAg dmlvX2luZm8tPmRvbWFpbl9pZCA9IChkYmcwICYgdmlvX2RiZ3MtPmRtbmlkLm1hc2spID4+Cj4g PiA+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICB2aW9fZGJncy0+ZG1uaWQuc3Rh cnQ7Cj4gPiA+ID4KPiA+ID4gPiBXaGF0IGlzIGRvbWFpbl9pZD8gSG93IGNvdWxkIHdlIHVzZSBp dCB0byBkZWJ1Zz8gRm9yIGV4YW1wbGUsIGlmIHdlCj4gPiA+ID4gZ2V0IGEgZG9tYWluX2lkID0g Miwgd2hhdCBzaG91bGQgd2UgZG8gZm9yIHRoaXM/Cj4gPiA+ID4KPiA+ID4KPiA+ID4gbWFzdGVy X2lkIGFuZCBkb21haW5faWQgYmVsb25ncyBvdXIgYnVzIHNpZGUtYmFuZCBzaWduYWwgaW5mby4g SXQgY2FuCj4gPiA+IGhlbHAgdXMgdG8gZmluZCB0aGUgdmlvbGF0aW9uIG1hc3Rlci4KPiA+Cj4g PiBEb2VzICd2aW9sYXRpb24gbWFzdGVyJyBtZWFucyB0aGUgaGFyZHdhcmUgY291bGQgYWNjZXNz IHRoZSBwcm90ZWN0ZWQKPiA+IHJlZ2lzdGVyPyAoZXguIENQVSwgR0NFLCAuLi4pIElmIHNvLCBJ IHRoaW5rIGl0J3MgYmV0dGVyIHRvIGFkZAo+ID4gY29tbWVudCB0byBleHBsYWluIGhvdyB0byBt YXAgKG1hc3Rlcl9pZCwgZG9tYWluX2lkKSB0byBhIGhhcmR3YXJlCj4gPiAobWF5YmUgdGhlIGRl dmljZSBpbiBkZXZpY2UgdHJlZSkgYmVjYXVzZSBldmVyeSBib2R5IGRvZXMgbm90IGtub3cKPiA+ IHdoYXQgdGhlIG51bWJlciBtZWFucy4gRG9uJ3QgdHJ5IHRvIHRyYW5zbGF0ZSB0aGUgbnVtYmVy IHRvIGEgc3RyaW5nCj4gPiBiZWNhdXNlIHRoaXMgd291bGQgY29zdCBtdWNoIHRpbWUgdG8gZG8g dGhpcy4gSnVzdCBwcmludCBhIG51bWJlciBhbmQKPiA+IHdlIGNvdWxkIGZpbmQgb3V0IHRoZSBt YXN0ZXIgYnkgdGhlIGNvbW1lbnQuCj4KPiAndmlvbGF0aW9uIG1hc3RlcicgbWVhbnMgdGhlIG1h c3RlciB3aGljaCB2aW9sYXRlcyB0aGUgcGVybWlzc2lvbgo+IGNvbnRyb2wuIEZvciBleGFtcGxl LCBpZiB3ZSBzZXQgcGVybWlzc2lvbiAnU2VjdXJlIFIvVyBvbmx5JyBhcyBDUFUgdG8KPiBzcGkg cmVnaXN0ZXIuIFdoZW4gdmlvbGF0aW9uIGlzIHRyaWdnZXJlZCwgaXQgbWVhbnMgQ1BVIGFjY2Vz cyBzcGkKPiByZWdpc3RlciB0aHJvdWdoIG5vcm1hbCB3b3JsZCBpbnN0ZWFkIG9mIHNlY3VyZSB3 b3JsZCwgd2hpY2ggaXMgbm90Cj4gYWxsb3dlZC4KPgo+ICdtYXN0ZXJfaWQnIGNhbm5vdCB1c2Ug dGhlIHNpbXBsZSBjb21tZW50cyB0byBkZXNjcmliZSB3aGljaCBtYXN0ZXIgaXQKPiBpcy4gSXQg ZGVwZW5kcyBvbiB2aW9sYXRpb24gc2xhdmVzLiBGb3IgZXhhbXBsZSwgaWYgdGhlcmUgYXJlIHR3 bwo+IHZpb2xhdGlvbnM6Cj4gMS4gQ1BVIGFjY2VzcyBzcGkgcmVnCj4gMi4gQ1BVIGFjY2VzcyB0 aW1lciByZWcKPiBJdCBtaWdodCBiZSBkaWZmZXJlbnQgJ21hc3Rlcl9pZCcgZm9yIENQVSBvbiB0 aGVzZSB0d28gY2FzZXMuCj4gSSB3b3VsZCBwcmVmZXIgdG8gcmVtYWluIHRoZSBpZCBudW1iZXIg aWYgdHJhbnNsYXRlIHRvIGEgc3RyaW5nIGlzIGEgYmFkCj4gaWRlYS4KPiBUaGFua3MgIQoKSXQg c2VhbXMgdGhhdCBtYXN0ZXJfaWQgYW5kIGRvbWFpbl9pZCBkb2VzIG5vdCBoZWxwIGZvciBkZWJ1 Zy4gV2hlbiB3ZQpnZXQgbWFzdGVyX2lkID0gMSBhbmQgZG9tYWluX2lkID0gMiwgd2UgZG9uJ3Qg a25vdyB3aGF0IGl0IG1lYW4uIEkKdGhpbmsgd2UganVzdCBuZWVkIHZpb2xhdGlvbiBhZGRyZXNz IGJlY2F1c2Ugd2UgY291bGQgZmluZCB0aGUgZHJpdmVyCnRoYXQgd3JpdGUgdGhpcyBhZGRyZXNz IGFuZCB0aGUgYnVnIHdvdWxkIGJlIGluc2lkZSB0aGlzIGRyaXZlci4gU28KbmVlZCBub3QgdG8g cHJvY2VzcyBtYXN0ZXJfaWQgYW5kIGRvbWFpbl9pZC4KClJlZ2FyZHMsCkNodW4tS3VhbmcuCgo+ Cj4gPgo+ID4gPgo+ID4gPiA+ID4gKyAgICAgICB2aW9faW5mby0+d3JpdGUgPSAoKGRiZzAgJiB2 aW9fZGJncy0+dmlvX3cubWFzaykgPj4KPiA+ID4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAg ICAgICB2aW9fZGJncy0+dmlvX3cuc3RhcnQpID09IDE7Cj4gPiA+ID4gPiArICAgICAgIHZpb19p bmZvLT5yZWFkID0gKChkYmcwICYgdmlvX2RiZ3MtPnZpb19yLm1hc2spID4+Cj4gPiA+ID4gPiAr ICAgICAgICAgICAgICAgICAgICAgICAgIHZpb19kYmdzLT52aW9fci5zdGFydCkgPT0gMTsKPiA+ ID4gPiA+ICsgICAgICAgdmlvX2luZm8tPnZpb19hZGRyX2hpZ2ggPSAoZGJnMCAmIHZpb19kYmdz LT5hZGRyX2gubWFzaykgPj4KPiA+ID4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICB2aW9fZGJncy0+YWRkcl9oLnN0YXJ0Owo+ID4gPiA+Cj4gPiA+ID4gV2hhdCBpcyB2aW9f YWRkcl9oaWdoPyBBcyBJIGtub3cgYWxsIHJlZ2lzdGVyIGFkZHJlc3MgYXJlIDMyIGJpdHMsIGlz Cj4gPiA+ID4gdmlvX2FkZHJfaGlnaCB0aGUgYWRkcmVzcyBhYm92ZSAzMiBiaXRzPwo+ID4gPgo+ ID4gPiBZZXMsIHlvdSBhcmUgcmlnaHQuIEluIE1UNjc3OSwgYWxsIHJlZ2lzdGVyIGJhc2UgYXJl IDMyIGJpdHMuIFdlIGNhbgo+ID4gPiBpZ25vcmUgdGhpcyBpbmZvIGZvciBjdXJyZW50IGRyaXZl ci4gSSdsbCB1cGRhdGUgb24gbmV4dCBwYXRjaC4KPiA+ID4gVGhhbmtzICEKPiA+Cj4gPiBTdWNo IGEgc3RyYW5nZSBoYXJkd2FyZSwgYWxsIHJlZ2lzdGVyIGlzIDMyIGJpdHMgYnV0IGl0IGhhcyBh Cj4gPiB2aW9fYWRkcl9oaWdoIGluIGl0cyByZWdpc3Rlci4gT0ssIGp1c3QgZHJvcCB0aGlzLgo+ ID4KPiA+ID4KPiA+ID4gPgo+ID4gPiA+ID4gKwo+ID4gPiA+ID4gKyAgICAgICBkZXZhcGNfdmlv X2luZm9fcHJpbnQoY3R4KTsKPiA+ID4gPiA+ICt9Cj4gPiA+ID4gPiArCj4gPiA+ID4KCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJu ZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRw Oi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK