From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF3AAC4363C for ; Sat, 3 Oct 2020 03:22:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 97534206E3 for ; Sat, 3 Oct 2020 03:22:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601695368; bh=vshNU8D+9cfgnyb4qi/vgpJ80rl6DobvFOc+lNmiq4A=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=QxKYEv5nTJIoTgbk9W4VmLoksNw4CsQz7aQmTt01xzPufxZEOXvhaTDVRULyZkDfK Do+92dJmCp9+Xth/KdE28ZUP+CNgF8Fo/5b1VPdBkDbZ+Pdfu4+9893w/MFneAfbYx m/tBEksy/6Jc8jRYgiZyB4UMPpEFghPYClANte9w= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725834AbgJCDWo (ORCPT ); Fri, 2 Oct 2020 23:22:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:52674 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725772AbgJCDWo (ORCPT ); Fri, 2 Oct 2020 23:22:44 -0400 Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2786C206FA for ; Sat, 3 Oct 2020 03:22:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601695363; bh=vshNU8D+9cfgnyb4qi/vgpJ80rl6DobvFOc+lNmiq4A=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=hFlAjzq6mVuQfPmTTpOyDSjt2poAiniCQC7B4VG6VvKy/a9HVw1KOanp3JnlMwGcz OsYAzWC62+LsskUIxEsw5P2ZhQLt09I23uMxY35DuZEk8tPOtZ0iY7dUwa69pddMV+ SVeJ1Gt2OgHRnTkYSAr6RLFodXInMeh/iwBwen+A= Received: by mail-ej1-f49.google.com with SMTP id p15so4412570ejm.7 for ; Fri, 02 Oct 2020 20:22:43 -0700 (PDT) X-Gm-Message-State: AOAM533hauHQur/PvEDI4Ogh2fk79sKfsR3tBLOfqF2FpOZExdZRGYOq NLbwETTPTY7CP6DlPSaeqL4KJxnnMXcjzD0lOA== X-Google-Smtp-Source: ABdhPJwfK6hFOAL1k6cStLol7QwYclHeuIdUmnRprFtlrITDDNE5+T91NUK9YTbudQEGp0c8nEIdFwMRV6jYoHi1EXo= X-Received: by 2002:a17:906:158f:: with SMTP id k15mr180684ejd.310.1601695361687; Fri, 02 Oct 2020 20:22:41 -0700 (PDT) MIME-Version: 1.0 References: <20200927230422.11610-1-chunkuang.hu@kernel.org> In-Reply-To: From: Chun-Kuang Hu Date: Sat, 3 Oct 2020 11:22:30 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 0/4] Mediatek DRM driver detect CMDQ execution timeout by vblank IRQ To: Jassi Brar Cc: Chun-Kuang Hu , Matthias Brugger , Linux Kernel Mailing List , DRI Development , "moderated list:ARM/Mediatek SoC support" , linux-arm-kernel Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Jassi: Jassi Brar =E6=96=BC 2020=E5=B9=B410=E6=9C=883= =E6=97=A5 =E9=80=B1=E5=85=AD =E4=B8=8A=E5=8D=884:30=E5=AF=AB=E9=81=93=EF=BC= =9A > > On Sun, Sep 27, 2020 at 6:04 PM Chun-Kuang Hu w= rote: > > > > CMDQ helper provide timer to detect execution timeout, but DRM driver > > could have a better way to detect execution timeout by vblank IRQ. > > For DRM, CMDQ command should execute in vblank, so if it fail to > > execute in next 2 vblank, timeout happen. Even though we could > > calculate time between 2 vblank and use timer to delect, this would > > make things more complicated. > > > > This introduce a series refinement for CMDQ mailbox controller and CMDQ > > helper. Remove timer handler in helper function because different > > client have different way to detect timeout. Use standard mailbox > > callback instead of proprietary one to get the necessary data > > in callback function. Remove struct cmdq_client to access client > > instance data by struct mbox_client. > > > > Chun-Kuang Hu (4): > > soc / drm: mediatek: cmdq: Remove timeout handler in helper function > > mailbox / soc / drm: mediatek: Use mailbox rx_callback instead of > > cmdq_task_cb > > mailbox / soc / drm: mediatek: Remove struct cmdq_client > > drm/mediatek: Detect CMDQ execution timeout > > > > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 54 ++++++--- > > drivers/mailbox/mtk-cmdq-mailbox.c | 24 ++-- > > drivers/soc/mediatek/mtk-cmdq-helper.c | 146 ++--------------------- > > include/linux/mailbox/mtk-cmdq-mailbox.h | 25 +--- > > include/linux/soc/mediatek/mtk-cmdq.h | 54 +-------- > > 5 files changed, 66 insertions(+), 237 deletions(-) > > > Please break this into two patchsets - one for mailbox and one for its us= ers. > Also, CC original author and recent major contributors to mtk-cmdq-mailbo= x.c > Agree with you. But for patch [2/4] ("Use mailbox rx_callback instead of cmdq_task_cb"), I think it would be a long term process. I would break it into: 1. mtk-cmdq-mailbox.c: add rx_callback and keep cmdq_task_cb because client is using cmdq_task_cb. 2. client: change from cmdq_task_cb to rx_callback. 3. mtk-cmdq-mailbox.c: remove cmdq_task_cb. The three step has dependency, but the 2nd should move to another series, so I would go 1st step first. Regards, Chun-Kuang. > Thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD59BC4363C for ; Sat, 3 Oct 2020 03:23:01 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F32B8206E3 for ; Sat, 3 Oct 2020 03:23:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PO3W8yOR"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="hFlAjzq6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F32B8206E3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=atXmMZtalU+IPXT5Xe+NDw7jtulCxI38Zmacn/hoNgE=; b=PO3W8yORbll2EkSGVry/r6H/K /GVUgprf+dYTzdXnl31IFK6ECGBBMqAbvweyWCJHyODcnZUkVeAm5dfXyramL1Q+xLNlzXykGdMz/ ZCFCxzerVh6tFReWdglpCLp92JQhrMkHxKXeLapr/Sxw9ImukpvOUqzz531+ybF0l7qIUyXoKhkUZ NYk/Y2QXY1c1SnkzkvzJ5EivZJWslNj1YlgWTBGeNqJKVPFxwRQdRkN3ZcJtdFcvOoz6FQn846Cf5 IMQ1cTHab7CfZHWE4MAPrS68KbKqqDeP0rZLXAK72FD848Glw5F0KLUSMugf9G6x/lOa93gf/WQMi vAaIZHXUw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kOY8H-0000dE-0r; Sat, 03 Oct 2020 03:22:49 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kOY8D-0000cW-61; Sat, 03 Oct 2020 03:22:46 +0000 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 23DFC206E3; Sat, 3 Oct 2020 03:22:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601695363; bh=vshNU8D+9cfgnyb4qi/vgpJ80rl6DobvFOc+lNmiq4A=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=hFlAjzq6mVuQfPmTTpOyDSjt2poAiniCQC7B4VG6VvKy/a9HVw1KOanp3JnlMwGcz OsYAzWC62+LsskUIxEsw5P2ZhQLt09I23uMxY35DuZEk8tPOtZ0iY7dUwa69pddMV+ SVeJ1Gt2OgHRnTkYSAr6RLFodXInMeh/iwBwen+A= Received: by mail-ej1-f43.google.com with SMTP id u21so4442024eja.2; Fri, 02 Oct 2020 20:22:43 -0700 (PDT) X-Gm-Message-State: AOAM531YP4vL4U/ze4jhRFGYWo27pMLBvCBZhKoUD9pPnzPZdWOPGri4 3T3eEWIfz6wmMmtUFw/WgBalkGW1lvGbZrDtzA== X-Google-Smtp-Source: ABdhPJwfK6hFOAL1k6cStLol7QwYclHeuIdUmnRprFtlrITDDNE5+T91NUK9YTbudQEGp0c8nEIdFwMRV6jYoHi1EXo= X-Received: by 2002:a17:906:158f:: with SMTP id k15mr180684ejd.310.1601695361687; Fri, 02 Oct 2020 20:22:41 -0700 (PDT) MIME-Version: 1.0 References: <20200927230422.11610-1-chunkuang.hu@kernel.org> In-Reply-To: From: Chun-Kuang Hu Date: Sat, 3 Oct 2020 11:22:30 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 0/4] Mediatek DRM driver detect CMDQ execution timeout by vblank IRQ To: Jassi Brar X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201002_232245_432110_5BF3B93D X-CRM114-Status: GOOD ( 20.94 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chun-Kuang Hu , Linux Kernel Mailing List , DRI Development , "moderated list:ARM/Mediatek SoC support" , Matthias Brugger , linux-arm-kernel Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org SGksIEphc3NpOgoKSmFzc2kgQnJhciA8amFzc2lzaW5naGJyYXJAZ21haWwuY29tPiDmlrwgMjAy MOW5tDEw5pyIM+aXpSDpgLHlha0g5LiK5Y2INDozMOWvq+mBk++8mgo+Cj4gT24gU3VuLCBTZXAg MjcsIDIwMjAgYXQgNjowNCBQTSBDaHVuLUt1YW5nIEh1IDxjaHVua3VhbmcuaHVAa2VybmVsLm9y Zz4gd3JvdGU6Cj4gPgo+ID4gQ01EUSBoZWxwZXIgcHJvdmlkZSB0aW1lciB0byBkZXRlY3QgZXhl Y3V0aW9uIHRpbWVvdXQsIGJ1dCBEUk0gZHJpdmVyCj4gPiBjb3VsZCBoYXZlIGEgYmV0dGVyIHdh eSB0byBkZXRlY3QgZXhlY3V0aW9uIHRpbWVvdXQgYnkgdmJsYW5rIElSUS4KPiA+IEZvciBEUk0s IENNRFEgY29tbWFuZCBzaG91bGQgZXhlY3V0ZSBpbiB2YmxhbmssIHNvIGlmIGl0IGZhaWwgdG8K PiA+IGV4ZWN1dGUgaW4gbmV4dCAyIHZibGFuaywgdGltZW91dCBoYXBwZW4uIEV2ZW4gdGhvdWdo IHdlIGNvdWxkCj4gPiBjYWxjdWxhdGUgdGltZSBiZXR3ZWVuIDIgdmJsYW5rIGFuZCB1c2UgdGlt ZXIgdG8gZGVsZWN0LCB0aGlzIHdvdWxkCj4gPiBtYWtlIHRoaW5ncyBtb3JlIGNvbXBsaWNhdGVk Lgo+ID4KPiA+IFRoaXMgaW50cm9kdWNlIGEgc2VyaWVzIHJlZmluZW1lbnQgZm9yIENNRFEgbWFp bGJveCBjb250cm9sbGVyIGFuZCBDTURRCj4gPiBoZWxwZXIuIFJlbW92ZSB0aW1lciBoYW5kbGVy IGluIGhlbHBlciBmdW5jdGlvbiBiZWNhdXNlIGRpZmZlcmVudAo+ID4gY2xpZW50IGhhdmUgZGlm ZmVyZW50IHdheSB0byBkZXRlY3QgdGltZW91dC4gVXNlIHN0YW5kYXJkIG1haWxib3gKPiA+IGNh bGxiYWNrIGluc3RlYWQgb2YgcHJvcHJpZXRhcnkgb25lIHRvIGdldCB0aGUgbmVjZXNzYXJ5IGRh dGEKPiA+IGluIGNhbGxiYWNrIGZ1bmN0aW9uLiBSZW1vdmUgc3RydWN0IGNtZHFfY2xpZW50IHRv IGFjY2VzcyBjbGllbnQKPiA+IGluc3RhbmNlIGRhdGEgYnkgc3RydWN0IG1ib3hfY2xpZW50Lgo+ ID4KPiA+IENodW4tS3VhbmcgSHUgKDQpOgo+ID4gICBzb2MgLyBkcm06IG1lZGlhdGVrOiBjbWRx OiBSZW1vdmUgdGltZW91dCBoYW5kbGVyIGluIGhlbHBlciBmdW5jdGlvbgo+ID4gICBtYWlsYm94 IC8gc29jIC8gZHJtOiBtZWRpYXRlazogVXNlIG1haWxib3ggcnhfY2FsbGJhY2sgaW5zdGVhZCBv Zgo+ID4gICAgIGNtZHFfdGFza19jYgo+ID4gICBtYWlsYm94IC8gc29jIC8gZHJtOiBtZWRpYXRl azogUmVtb3ZlIHN0cnVjdCBjbWRxX2NsaWVudAo+ID4gICBkcm0vbWVkaWF0ZWs6IERldGVjdCBD TURRIGV4ZWN1dGlvbiB0aW1lb3V0Cj4gPgo+ID4gIGRyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9t dGtfZHJtX2NydGMuYyAgfCAgNTQgKysrKysrLS0tCj4gPiAgZHJpdmVycy9tYWlsYm94L210ay1j bWRxLW1haWxib3guYyAgICAgICB8ICAyNCArKy0tCj4gPiAgZHJpdmVycy9zb2MvbWVkaWF0ZWsv bXRrLWNtZHEtaGVscGVyLmMgICB8IDE0NiArKy0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ID4gIGlu Y2x1ZGUvbGludXgvbWFpbGJveC9tdGstY21kcS1tYWlsYm94LmggfCAgMjUgKy0tLQo+ID4gIGlu Y2x1ZGUvbGludXgvc29jL21lZGlhdGVrL210ay1jbWRxLmggICAgfCAgNTQgKy0tLS0tLS0tCj4g PiAgNSBmaWxlcyBjaGFuZ2VkLCA2NiBpbnNlcnRpb25zKCspLCAyMzcgZGVsZXRpb25zKC0pCj4g Pgo+IFBsZWFzZSBicmVhayB0aGlzIGludG8gdHdvIHBhdGNoc2V0cyAtIG9uZSBmb3IgbWFpbGJv eCBhbmQgb25lIGZvciBpdHMgdXNlcnMuCj4gQWxzbywgQ0Mgb3JpZ2luYWwgYXV0aG9yIGFuZCBy ZWNlbnQgbWFqb3IgY29udHJpYnV0b3JzIHRvIG10ay1jbWRxLW1haWxib3guYwo+CgpBZ3JlZSB3 aXRoIHlvdS4gQnV0IGZvciBwYXRjaCBbMi80XSAoIlVzZSBtYWlsYm94IHJ4X2NhbGxiYWNrIGlu c3RlYWQKb2YgY21kcV90YXNrX2NiIiksIEkgdGhpbmsgaXQgd291bGQgYmUgYSBsb25nIHRlcm0g cHJvY2Vzcy4KSSB3b3VsZCBicmVhayBpdCBpbnRvOgoKMS4gbXRrLWNtZHEtbWFpbGJveC5jOiBh ZGQgcnhfY2FsbGJhY2sgYW5kIGtlZXAgIGNtZHFfdGFza19jYiBiZWNhdXNlCmNsaWVudCBpcyB1 c2luZyBjbWRxX3Rhc2tfY2IuCjIuIGNsaWVudDogY2hhbmdlIGZyb20gY21kcV90YXNrX2NiIHRv IHJ4X2NhbGxiYWNrLgozLiBtdGstY21kcS1tYWlsYm94LmM6IHJlbW92ZSBjbWRxX3Rhc2tfY2Iu CgpUaGUgdGhyZWUgc3RlcCBoYXMgZGVwZW5kZW5jeSwgYnV0IHRoZSAybmQgc2hvdWxkIG1vdmUg dG8gYW5vdGhlcgpzZXJpZXMsIHNvIEkgd291bGQgZ28gMXN0IHN0ZXAgZmlyc3QuCgpSZWdhcmRz LApDaHVuLUt1YW5nLgoKPiBUaGFua3MuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpMaW51eC1tZWRpYXRlayBtYWlsaW5nIGxpc3QKTGludXgtbWVkaWF0 ZWtAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2xpbnV4LW1lZGlhdGVrCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9B1CC4363C for ; Sat, 3 Oct 2020 03:24:54 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 717F2206E3 for ; Sat, 3 Oct 2020 03:24:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MvKsuBVW"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="hFlAjzq6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 717F2206E3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DyCkwGPOyZVc0cyDIgjkQQ5jdT+rbrNHm4d497EVp5A=; b=MvKsuBVWM7BMqCassHfBrvU11 agbsDXnzziJrJkZ3du3tNTmeixhMUEh4SeJIbRZ4nrgN6GdsIo34cDisyo83GUpCwTYRdeddXMa33 LI4C1QUqAus9e8+dDdzACYtZexfqpC0rMWe4V/VN5M9kyhE2hmumC5AAxWFvMAaSozq/c1FYipy5X cbskG6LXPDF2yteGIL5TUlYagW8mkl8mf26yqUhBUpGO2We1csQ1VWiXrzC/g+eRHIDDTOKquL8BQ OteAzOgZddJga9O91En5xf3MaacZSJl0XhAGbh4RGmtds91YIX4B+y4wT9NkO0GaIQwKdGxOOg3i7 W7bOtf1Vw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kOY8F-0000d2-LK; Sat, 03 Oct 2020 03:22:47 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kOY8D-0000cW-61; Sat, 03 Oct 2020 03:22:46 +0000 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 23DFC206E3; Sat, 3 Oct 2020 03:22:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601695363; bh=vshNU8D+9cfgnyb4qi/vgpJ80rl6DobvFOc+lNmiq4A=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=hFlAjzq6mVuQfPmTTpOyDSjt2poAiniCQC7B4VG6VvKy/a9HVw1KOanp3JnlMwGcz OsYAzWC62+LsskUIxEsw5P2ZhQLt09I23uMxY35DuZEk8tPOtZ0iY7dUwa69pddMV+ SVeJ1Gt2OgHRnTkYSAr6RLFodXInMeh/iwBwen+A= Received: by mail-ej1-f43.google.com with SMTP id u21so4442024eja.2; Fri, 02 Oct 2020 20:22:43 -0700 (PDT) X-Gm-Message-State: AOAM531YP4vL4U/ze4jhRFGYWo27pMLBvCBZhKoUD9pPnzPZdWOPGri4 3T3eEWIfz6wmMmtUFw/WgBalkGW1lvGbZrDtzA== X-Google-Smtp-Source: ABdhPJwfK6hFOAL1k6cStLol7QwYclHeuIdUmnRprFtlrITDDNE5+T91NUK9YTbudQEGp0c8nEIdFwMRV6jYoHi1EXo= X-Received: by 2002:a17:906:158f:: with SMTP id k15mr180684ejd.310.1601695361687; Fri, 02 Oct 2020 20:22:41 -0700 (PDT) MIME-Version: 1.0 References: <20200927230422.11610-1-chunkuang.hu@kernel.org> In-Reply-To: From: Chun-Kuang Hu Date: Sat, 3 Oct 2020 11:22:30 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 0/4] Mediatek DRM driver detect CMDQ execution timeout by vblank IRQ To: Jassi Brar X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201002_232245_432110_5BF3B93D X-CRM114-Status: GOOD ( 20.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chun-Kuang Hu , Linux Kernel Mailing List , DRI Development , "moderated list:ARM/Mediatek SoC support" , Matthias Brugger , linux-arm-kernel Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGksIEphc3NpOgoKSmFzc2kgQnJhciA8amFzc2lzaW5naGJyYXJAZ21haWwuY29tPiDmlrwgMjAy MOW5tDEw5pyIM+aXpSDpgLHlha0g5LiK5Y2INDozMOWvq+mBk++8mgo+Cj4gT24gU3VuLCBTZXAg MjcsIDIwMjAgYXQgNjowNCBQTSBDaHVuLUt1YW5nIEh1IDxjaHVua3VhbmcuaHVAa2VybmVsLm9y Zz4gd3JvdGU6Cj4gPgo+ID4gQ01EUSBoZWxwZXIgcHJvdmlkZSB0aW1lciB0byBkZXRlY3QgZXhl Y3V0aW9uIHRpbWVvdXQsIGJ1dCBEUk0gZHJpdmVyCj4gPiBjb3VsZCBoYXZlIGEgYmV0dGVyIHdh eSB0byBkZXRlY3QgZXhlY3V0aW9uIHRpbWVvdXQgYnkgdmJsYW5rIElSUS4KPiA+IEZvciBEUk0s IENNRFEgY29tbWFuZCBzaG91bGQgZXhlY3V0ZSBpbiB2YmxhbmssIHNvIGlmIGl0IGZhaWwgdG8K PiA+IGV4ZWN1dGUgaW4gbmV4dCAyIHZibGFuaywgdGltZW91dCBoYXBwZW4uIEV2ZW4gdGhvdWdo IHdlIGNvdWxkCj4gPiBjYWxjdWxhdGUgdGltZSBiZXR3ZWVuIDIgdmJsYW5rIGFuZCB1c2UgdGlt ZXIgdG8gZGVsZWN0LCB0aGlzIHdvdWxkCj4gPiBtYWtlIHRoaW5ncyBtb3JlIGNvbXBsaWNhdGVk Lgo+ID4KPiA+IFRoaXMgaW50cm9kdWNlIGEgc2VyaWVzIHJlZmluZW1lbnQgZm9yIENNRFEgbWFp bGJveCBjb250cm9sbGVyIGFuZCBDTURRCj4gPiBoZWxwZXIuIFJlbW92ZSB0aW1lciBoYW5kbGVy IGluIGhlbHBlciBmdW5jdGlvbiBiZWNhdXNlIGRpZmZlcmVudAo+ID4gY2xpZW50IGhhdmUgZGlm ZmVyZW50IHdheSB0byBkZXRlY3QgdGltZW91dC4gVXNlIHN0YW5kYXJkIG1haWxib3gKPiA+IGNh bGxiYWNrIGluc3RlYWQgb2YgcHJvcHJpZXRhcnkgb25lIHRvIGdldCB0aGUgbmVjZXNzYXJ5IGRh dGEKPiA+IGluIGNhbGxiYWNrIGZ1bmN0aW9uLiBSZW1vdmUgc3RydWN0IGNtZHFfY2xpZW50IHRv IGFjY2VzcyBjbGllbnQKPiA+IGluc3RhbmNlIGRhdGEgYnkgc3RydWN0IG1ib3hfY2xpZW50Lgo+ ID4KPiA+IENodW4tS3VhbmcgSHUgKDQpOgo+ID4gICBzb2MgLyBkcm06IG1lZGlhdGVrOiBjbWRx OiBSZW1vdmUgdGltZW91dCBoYW5kbGVyIGluIGhlbHBlciBmdW5jdGlvbgo+ID4gICBtYWlsYm94 IC8gc29jIC8gZHJtOiBtZWRpYXRlazogVXNlIG1haWxib3ggcnhfY2FsbGJhY2sgaW5zdGVhZCBv Zgo+ID4gICAgIGNtZHFfdGFza19jYgo+ID4gICBtYWlsYm94IC8gc29jIC8gZHJtOiBtZWRpYXRl azogUmVtb3ZlIHN0cnVjdCBjbWRxX2NsaWVudAo+ID4gICBkcm0vbWVkaWF0ZWs6IERldGVjdCBD TURRIGV4ZWN1dGlvbiB0aW1lb3V0Cj4gPgo+ID4gIGRyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9t dGtfZHJtX2NydGMuYyAgfCAgNTQgKysrKysrLS0tCj4gPiAgZHJpdmVycy9tYWlsYm94L210ay1j bWRxLW1haWxib3guYyAgICAgICB8ICAyNCArKy0tCj4gPiAgZHJpdmVycy9zb2MvbWVkaWF0ZWsv bXRrLWNtZHEtaGVscGVyLmMgICB8IDE0NiArKy0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ID4gIGlu Y2x1ZGUvbGludXgvbWFpbGJveC9tdGstY21kcS1tYWlsYm94LmggfCAgMjUgKy0tLQo+ID4gIGlu Y2x1ZGUvbGludXgvc29jL21lZGlhdGVrL210ay1jbWRxLmggICAgfCAgNTQgKy0tLS0tLS0tCj4g PiAgNSBmaWxlcyBjaGFuZ2VkLCA2NiBpbnNlcnRpb25zKCspLCAyMzcgZGVsZXRpb25zKC0pCj4g Pgo+IFBsZWFzZSBicmVhayB0aGlzIGludG8gdHdvIHBhdGNoc2V0cyAtIG9uZSBmb3IgbWFpbGJv eCBhbmQgb25lIGZvciBpdHMgdXNlcnMuCj4gQWxzbywgQ0Mgb3JpZ2luYWwgYXV0aG9yIGFuZCBy ZWNlbnQgbWFqb3IgY29udHJpYnV0b3JzIHRvIG10ay1jbWRxLW1haWxib3guYwo+CgpBZ3JlZSB3 aXRoIHlvdS4gQnV0IGZvciBwYXRjaCBbMi80XSAoIlVzZSBtYWlsYm94IHJ4X2NhbGxiYWNrIGlu c3RlYWQKb2YgY21kcV90YXNrX2NiIiksIEkgdGhpbmsgaXQgd291bGQgYmUgYSBsb25nIHRlcm0g cHJvY2Vzcy4KSSB3b3VsZCBicmVhayBpdCBpbnRvOgoKMS4gbXRrLWNtZHEtbWFpbGJveC5jOiBh ZGQgcnhfY2FsbGJhY2sgYW5kIGtlZXAgIGNtZHFfdGFza19jYiBiZWNhdXNlCmNsaWVudCBpcyB1 c2luZyBjbWRxX3Rhc2tfY2IuCjIuIGNsaWVudDogY2hhbmdlIGZyb20gY21kcV90YXNrX2NiIHRv IHJ4X2NhbGxiYWNrLgozLiBtdGstY21kcS1tYWlsYm94LmM6IHJlbW92ZSBjbWRxX3Rhc2tfY2Iu CgpUaGUgdGhyZWUgc3RlcCBoYXMgZGVwZW5kZW5jeSwgYnV0IHRoZSAybmQgc2hvdWxkIG1vdmUg dG8gYW5vdGhlcgpzZXJpZXMsIHNvIEkgd291bGQgZ28gMXN0IHN0ZXAgZmlyc3QuCgpSZWdhcmRz LApDaHVuLUt1YW5nLgoKPiBUaGFua3MuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0t a2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFp bG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E813C4363C for ; Sat, 3 Oct 2020 03:22:46 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F084D206FA for ; Sat, 3 Oct 2020 03:22:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="hFlAjzq6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F084D206FA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C77E36EA23; Sat, 3 Oct 2020 03:22:44 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id F21D66EA23 for ; Sat, 3 Oct 2020 03:22:43 +0000 (UTC) Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 30A0D20719 for ; Sat, 3 Oct 2020 03:22:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601695363; bh=vshNU8D+9cfgnyb4qi/vgpJ80rl6DobvFOc+lNmiq4A=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=hFlAjzq6mVuQfPmTTpOyDSjt2poAiniCQC7B4VG6VvKy/a9HVw1KOanp3JnlMwGcz OsYAzWC62+LsskUIxEsw5P2ZhQLt09I23uMxY35DuZEk8tPOtZ0iY7dUwa69pddMV+ SVeJ1Gt2OgHRnTkYSAr6RLFodXInMeh/iwBwen+A= Received: by mail-ej1-f51.google.com with SMTP id nw23so4432176ejb.4 for ; Fri, 02 Oct 2020 20:22:43 -0700 (PDT) X-Gm-Message-State: AOAM533hbOxuuAPMILbQ/dSZTU6IIOJS8ovUzxmaG/zRExVJIg6h5Yi6 XTX39m/wQKmJ+kHsbidm8D9VDnPlOY/hcHniDQ== X-Google-Smtp-Source: ABdhPJwfK6hFOAL1k6cStLol7QwYclHeuIdUmnRprFtlrITDDNE5+T91NUK9YTbudQEGp0c8nEIdFwMRV6jYoHi1EXo= X-Received: by 2002:a17:906:158f:: with SMTP id k15mr180684ejd.310.1601695361687; Fri, 02 Oct 2020 20:22:41 -0700 (PDT) MIME-Version: 1.0 References: <20200927230422.11610-1-chunkuang.hu@kernel.org> In-Reply-To: From: Chun-Kuang Hu Date: Sat, 3 Oct 2020 11:22:30 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 0/4] Mediatek DRM driver detect CMDQ execution timeout by vblank IRQ To: Jassi Brar X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chun-Kuang Hu , Linux Kernel Mailing List , DRI Development , "moderated list:ARM/Mediatek SoC support" , Matthias Brugger , linux-arm-kernel Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" SGksIEphc3NpOgoKSmFzc2kgQnJhciA8amFzc2lzaW5naGJyYXJAZ21haWwuY29tPiDmlrwgMjAy MOW5tDEw5pyIM+aXpSDpgLHlha0g5LiK5Y2INDozMOWvq+mBk++8mgo+Cj4gT24gU3VuLCBTZXAg MjcsIDIwMjAgYXQgNjowNCBQTSBDaHVuLUt1YW5nIEh1IDxjaHVua3VhbmcuaHVAa2VybmVsLm9y Zz4gd3JvdGU6Cj4gPgo+ID4gQ01EUSBoZWxwZXIgcHJvdmlkZSB0aW1lciB0byBkZXRlY3QgZXhl Y3V0aW9uIHRpbWVvdXQsIGJ1dCBEUk0gZHJpdmVyCj4gPiBjb3VsZCBoYXZlIGEgYmV0dGVyIHdh eSB0byBkZXRlY3QgZXhlY3V0aW9uIHRpbWVvdXQgYnkgdmJsYW5rIElSUS4KPiA+IEZvciBEUk0s IENNRFEgY29tbWFuZCBzaG91bGQgZXhlY3V0ZSBpbiB2YmxhbmssIHNvIGlmIGl0IGZhaWwgdG8K PiA+IGV4ZWN1dGUgaW4gbmV4dCAyIHZibGFuaywgdGltZW91dCBoYXBwZW4uIEV2ZW4gdGhvdWdo IHdlIGNvdWxkCj4gPiBjYWxjdWxhdGUgdGltZSBiZXR3ZWVuIDIgdmJsYW5rIGFuZCB1c2UgdGlt ZXIgdG8gZGVsZWN0LCB0aGlzIHdvdWxkCj4gPiBtYWtlIHRoaW5ncyBtb3JlIGNvbXBsaWNhdGVk Lgo+ID4KPiA+IFRoaXMgaW50cm9kdWNlIGEgc2VyaWVzIHJlZmluZW1lbnQgZm9yIENNRFEgbWFp bGJveCBjb250cm9sbGVyIGFuZCBDTURRCj4gPiBoZWxwZXIuIFJlbW92ZSB0aW1lciBoYW5kbGVy IGluIGhlbHBlciBmdW5jdGlvbiBiZWNhdXNlIGRpZmZlcmVudAo+ID4gY2xpZW50IGhhdmUgZGlm ZmVyZW50IHdheSB0byBkZXRlY3QgdGltZW91dC4gVXNlIHN0YW5kYXJkIG1haWxib3gKPiA+IGNh bGxiYWNrIGluc3RlYWQgb2YgcHJvcHJpZXRhcnkgb25lIHRvIGdldCB0aGUgbmVjZXNzYXJ5IGRh dGEKPiA+IGluIGNhbGxiYWNrIGZ1bmN0aW9uLiBSZW1vdmUgc3RydWN0IGNtZHFfY2xpZW50IHRv IGFjY2VzcyBjbGllbnQKPiA+IGluc3RhbmNlIGRhdGEgYnkgc3RydWN0IG1ib3hfY2xpZW50Lgo+ ID4KPiA+IENodW4tS3VhbmcgSHUgKDQpOgo+ID4gICBzb2MgLyBkcm06IG1lZGlhdGVrOiBjbWRx OiBSZW1vdmUgdGltZW91dCBoYW5kbGVyIGluIGhlbHBlciBmdW5jdGlvbgo+ID4gICBtYWlsYm94 IC8gc29jIC8gZHJtOiBtZWRpYXRlazogVXNlIG1haWxib3ggcnhfY2FsbGJhY2sgaW5zdGVhZCBv Zgo+ID4gICAgIGNtZHFfdGFza19jYgo+ID4gICBtYWlsYm94IC8gc29jIC8gZHJtOiBtZWRpYXRl azogUmVtb3ZlIHN0cnVjdCBjbWRxX2NsaWVudAo+ID4gICBkcm0vbWVkaWF0ZWs6IERldGVjdCBD TURRIGV4ZWN1dGlvbiB0aW1lb3V0Cj4gPgo+ID4gIGRyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9t dGtfZHJtX2NydGMuYyAgfCAgNTQgKysrKysrLS0tCj4gPiAgZHJpdmVycy9tYWlsYm94L210ay1j bWRxLW1haWxib3guYyAgICAgICB8ICAyNCArKy0tCj4gPiAgZHJpdmVycy9zb2MvbWVkaWF0ZWsv bXRrLWNtZHEtaGVscGVyLmMgICB8IDE0NiArKy0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ID4gIGlu Y2x1ZGUvbGludXgvbWFpbGJveC9tdGstY21kcS1tYWlsYm94LmggfCAgMjUgKy0tLQo+ID4gIGlu Y2x1ZGUvbGludXgvc29jL21lZGlhdGVrL210ay1jbWRxLmggICAgfCAgNTQgKy0tLS0tLS0tCj4g PiAgNSBmaWxlcyBjaGFuZ2VkLCA2NiBpbnNlcnRpb25zKCspLCAyMzcgZGVsZXRpb25zKC0pCj4g Pgo+IFBsZWFzZSBicmVhayB0aGlzIGludG8gdHdvIHBhdGNoc2V0cyAtIG9uZSBmb3IgbWFpbGJv eCBhbmQgb25lIGZvciBpdHMgdXNlcnMuCj4gQWxzbywgQ0Mgb3JpZ2luYWwgYXV0aG9yIGFuZCBy ZWNlbnQgbWFqb3IgY29udHJpYnV0b3JzIHRvIG10ay1jbWRxLW1haWxib3guYwo+CgpBZ3JlZSB3 aXRoIHlvdS4gQnV0IGZvciBwYXRjaCBbMi80XSAoIlVzZSBtYWlsYm94IHJ4X2NhbGxiYWNrIGlu c3RlYWQKb2YgY21kcV90YXNrX2NiIiksIEkgdGhpbmsgaXQgd291bGQgYmUgYSBsb25nIHRlcm0g cHJvY2Vzcy4KSSB3b3VsZCBicmVhayBpdCBpbnRvOgoKMS4gbXRrLWNtZHEtbWFpbGJveC5jOiBh ZGQgcnhfY2FsbGJhY2sgYW5kIGtlZXAgIGNtZHFfdGFza19jYiBiZWNhdXNlCmNsaWVudCBpcyB1 c2luZyBjbWRxX3Rhc2tfY2IuCjIuIGNsaWVudDogY2hhbmdlIGZyb20gY21kcV90YXNrX2NiIHRv IHJ4X2NhbGxiYWNrLgozLiBtdGstY21kcS1tYWlsYm94LmM6IHJlbW92ZSBjbWRxX3Rhc2tfY2Iu CgpUaGUgdGhyZWUgc3RlcCBoYXMgZGVwZW5kZW5jeSwgYnV0IHRoZSAybmQgc2hvdWxkIG1vdmUg dG8gYW5vdGhlcgpzZXJpZXMsIHNvIEkgd291bGQgZ28gMXN0IHN0ZXAgZmlyc3QuCgpSZWdhcmRz LApDaHVuLUt1YW5nLgoKPiBUaGFua3MuCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2RyaS1kZXZlbAo=