From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B197C433FE for ; Wed, 29 Sep 2021 14:57:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 435C761407 for ; Wed, 29 Sep 2021 14:57:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344871AbhI2O7I (ORCPT ); Wed, 29 Sep 2021 10:59:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:41734 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344677AbhI2O7H (ORCPT ); Wed, 29 Sep 2021 10:59:07 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1A52C613A6 for ; Wed, 29 Sep 2021 14:57:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632927446; bh=m2Q3ldX4i8hJz/lYMTrW/Tc7jkjEgA48T0avsrMIFb0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=OS8/FZ05Bwuqc7c8Yy1ebTTrRtR/7Sh9oRAFWvlRbSE+GtdDhVhQbnVJIaynmoVWt m4IAX3oh1iS08p/skrS1lSt6hHe2G6wCncmmwuqGK0ZgxHf+1Ygs72Y7fi/upjuMMa gyZyOtJ2tbN5qyXOJBW7/Rf+T4AgEejImrVVaIrd1dmvdXSR3vxixr1yKFYsy0R2NZ xjzDAevLhcKK0ozr8OsK2+G3i25e3qCEMf5fBPkWeBpjmp02C+mAxVAeMADaSK1fqx 2AzpH1jc2IwTfgbbpdXp84QfYdWhK29rTVjFi+2n6Wf24AFtCS9XdysC1gI5art90I kn9etznjpw1gQ== Received: by mail-ed1-f45.google.com with SMTP id s17so9583808edd.8 for ; Wed, 29 Sep 2021 07:57:26 -0700 (PDT) X-Gm-Message-State: AOAM530mhRTPMOSURKb6SoYwMYLCH+ENln8xSJV2PzqWJonxJOr4OgBp wVERaZBVsEPbHonRbLQhQXpXpIbWYYTESlWUsw== X-Google-Smtp-Source: ABdhPJy2oIyAhlML1lKHkEI+GYb7Xf5WZ4jL2sSq+xZsFvjhx2y5gie/l/Dq825/3UzuJiV9rAUHrF0xKV//SQBZD0k= X-Received: by 2002:a17:906:7ac4:: with SMTP id k4mr178848ejo.430.1632927358007; Wed, 29 Sep 2021 07:55:58 -0700 (PDT) MIME-Version: 1.0 References: <20210929070235.4290-1-jason-jh.lin@mediatek.com> <20210929070235.4290-4-jason-jh.lin@mediatek.com> In-Reply-To: <20210929070235.4290-4-jason-jh.lin@mediatek.com> From: Chun-Kuang Hu Date: Wed, 29 Sep 2021 22:55:46 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 3/3] drm/mediatek: Fix cursor plane is not config when primary is updating To: "jason-jh.lin" Cc: Chun-Kuang Hu , Philipp Zabel , David Airlie , Daniel Vetter , Matthias Brugger , Yongqiang Niu , DRI Development , "moderated list:ARM/Mediatek SoC support" , Linux ARM , linux-kernel , Hsin-Yi Wang , fshao@chromium.org, Nancy Lin , singo.chang@mediatek.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Jason: jason-jh.lin =E6=96=BC 2021=E5=B9=B49=E6=9C=882= 9=E6=97=A5 =E9=80=B1=E4=B8=89 =E4=B8=8B=E5=8D=883:02=E5=AF=AB=E9=81=93=EF= =BC=9A > > If cursor plane has updated but primary plane config task is not > finished, mtk_drm_crtc_update_config will call mbox_flush() to clear > all task in current GCE thread and let cursor plane re-send a new > GCE task with cursor + primary plane config to replace the unfinished > GCE task. > > So the plane config flag should not be cleared when mailbox callback > with a error status. > > Fixes: 9efb16c2fdd6 ("drm/mediatek: Clear pending flag when cmdq packet i= s done") > Signed-off-by: jason-jh.lin > --- > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/me= diatek/mtk_drm_crtc.c > index 06342df2a0be..fb0d9424acec 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > @@ -281,6 +281,9 @@ static void ddp_cmdq_cb(struct mbox_client *cl, void = *mssg) > struct mtk_crtc_state *state; > unsigned int i; > > + if (data->sta !=3D 0) data->sta is now the standard error code, so data->sta < 0 is an error. Regards, Chun-Kuang. > + return; > + > state =3D to_mtk_crtc_state(mtk_crtc->base.state); > > state->pending_config =3D false; > -- > 2.18.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31D58C433F5 for ; Wed, 29 Sep 2021 14:57:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E7F42613A6 for ; Wed, 29 Sep 2021 14:57:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E7F42613A6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mIu8aGSwjG2NEvSLNTtVN4BLPPbcrkWUXpZdfvQiSBM=; b=KneO8rxEO+AAOp zSIr85KH4hr8au1vYUEtNKFQndVFui1aU48rWO2N0EQ72lQkgY0/y/sp3KfaJDVPhokTRBXToteQC J4Xg+2IL5mycIIAqOr1SOvNOocsj3wG6wjcA4Con3U+YzaGzkO8nO6UxwMF0DjYQjGwTV+hHG3Kn8 eEoaVg5wgk7hgzyyCZfIHdMtH46xL+y3LOvgGhtdNgZzvyjzyhKEVF2b6lC9XbrLVht/k6j2ilzGT yezVblyXmFr4Kbygz2G6VbzrP0wEK0GlbF+Hqx2o4/Zpk9lxeRLmRuYy2xJpldW+fJSYbNoenNO0x zozwVAleUCE2OxB01hfA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVb1R-00BQb2-Ln; Wed, 29 Sep 2021 14:57:25 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVb1C-00BQWD-HO; Wed, 29 Sep 2021 14:57:12 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0A5D261406; Wed, 29 Sep 2021 14:57:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632927430; bh=m2Q3ldX4i8hJz/lYMTrW/Tc7jkjEgA48T0avsrMIFb0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=gWFQ3OxM+zlx5cOWwCsZPh5DG7BsFXnu98NTkCs+mOcp7Ey8FcXCBJo0g8+riLu0X wU6z55q6PhafzSiSGpIlMa5m2o8GLG1p3SG223uY8PKm8DrsBkP/yeywoTU7zaO7V7 Lpn8OfKULxV/0BhHBYJoP7RccfPv5Tm3OeHMWTVYqsFWBURZUvgkEgjUvR4q9aGxH1 6dbO2DosvrEzi91Pzfe0MUUfFjuCbUUMjIumlfR2Swo+KuOwRWdkBp8GYBNZhTDfxU ULn6r6Az0vpyLmxmViOQXgJauMS5JdQ4VBEn/fhwIX54iRZJDZrPP82DSCPsi7E7n2 Fn4uqb6LKT67A== Received: by mail-ed1-f54.google.com with SMTP id dn26so9684996edb.13; Wed, 29 Sep 2021 07:57:09 -0700 (PDT) X-Gm-Message-State: AOAM532/iBLuTgjYuOpsnredfUUVYYcKZsBLd9WcKr5Cg/Dx4es5wvQK RTU/iORYnZIk/HOJUHpL/hzhUjqC6qzPgbFrMQ== X-Google-Smtp-Source: ABdhPJy2oIyAhlML1lKHkEI+GYb7Xf5WZ4jL2sSq+xZsFvjhx2y5gie/l/Dq825/3UzuJiV9rAUHrF0xKV//SQBZD0k= X-Received: by 2002:a17:906:7ac4:: with SMTP id k4mr178848ejo.430.1632927358007; Wed, 29 Sep 2021 07:55:58 -0700 (PDT) MIME-Version: 1.0 References: <20210929070235.4290-1-jason-jh.lin@mediatek.com> <20210929070235.4290-4-jason-jh.lin@mediatek.com> In-Reply-To: <20210929070235.4290-4-jason-jh.lin@mediatek.com> From: Chun-Kuang Hu Date: Wed, 29 Sep 2021 22:55:46 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 3/3] drm/mediatek: Fix cursor plane is not config when primary is updating To: "jason-jh.lin" Cc: Chun-Kuang Hu , Philipp Zabel , David Airlie , Daniel Vetter , Matthias Brugger , Yongqiang Niu , DRI Development , "moderated list:ARM/Mediatek SoC support" , Linux ARM , linux-kernel , Hsin-Yi Wang , fshao@chromium.org, Nancy Lin , singo.chang@mediatek.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210929_075710_644088_167DBA59 X-CRM114-Status: GOOD ( 17.48 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org SGksIEphc29uOgoKamFzb24tamgubGluIDxqYXNvbi1qaC5saW5AbWVkaWF0ZWsuY29tPiDmlrwg MjAyMeW5tDnmnIgyOeaXpSDpgLHkuIkg5LiL5Y2IMzowMuWvq+mBk++8mgo+Cj4gSWYgY3Vyc29y IHBsYW5lIGhhcyB1cGRhdGVkIGJ1dCBwcmltYXJ5IHBsYW5lIGNvbmZpZyB0YXNrIGlzIG5vdAo+ IGZpbmlzaGVkLCBtdGtfZHJtX2NydGNfdXBkYXRlX2NvbmZpZyB3aWxsIGNhbGwgbWJveF9mbHVz aCgpIHRvIGNsZWFyCj4gYWxsIHRhc2sgaW4gY3VycmVudCBHQ0UgdGhyZWFkIGFuZCBsZXQgY3Vy c29yIHBsYW5lIHJlLXNlbmQgYSBuZXcKPiBHQ0UgdGFzayB3aXRoIGN1cnNvciArIHByaW1hcnkg cGxhbmUgY29uZmlnIHRvIHJlcGxhY2UgdGhlIHVuZmluaXNoZWQKPiBHQ0UgdGFzay4KPgo+IFNv IHRoZSBwbGFuZSBjb25maWcgZmxhZyBzaG91bGQgbm90IGJlIGNsZWFyZWQgd2hlbiBtYWlsYm94 IGNhbGxiYWNrCj4gd2l0aCBhIGVycm9yIHN0YXR1cy4KPgo+IEZpeGVzOiA5ZWZiMTZjMmZkZDYg KCJkcm0vbWVkaWF0ZWs6IENsZWFyIHBlbmRpbmcgZmxhZyB3aGVuIGNtZHEgcGFja2V0IGlzIGRv bmUiKQo+IFNpZ25lZC1vZmYtYnk6IGphc29uLWpoLmxpbiA8amFzb24tamgubGluQG1lZGlhdGVr LmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fY3J0Yy5jIHwg MyArKysKPiAgMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKQo+Cj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2NydGMuYyBiL2RyaXZlcnMvZ3B1L2Ry bS9tZWRpYXRlay9tdGtfZHJtX2NydGMuYwo+IGluZGV4IDA2MzQyZGYyYTBiZS4uZmIwZDk0MjRh Y2VjIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2NydGMu Ywo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2NydGMuYwo+IEBAIC0y ODEsNiArMjgxLDkgQEAgc3RhdGljIHZvaWQgZGRwX2NtZHFfY2Ioc3RydWN0IG1ib3hfY2xpZW50 ICpjbCwgdm9pZCAqbXNzZykKPiAgICAgICAgIHN0cnVjdCBtdGtfY3J0Y19zdGF0ZSAqc3RhdGU7 Cj4gICAgICAgICB1bnNpZ25lZCBpbnQgaTsKPgo+ICsgICAgICAgaWYgKGRhdGEtPnN0YSAhPSAw KQoKZGF0YS0+c3RhIGlzIG5vdyB0aGUgc3RhbmRhcmQgZXJyb3IgY29kZSwgc28gZGF0YS0+c3Rh IDwgMCBpcyBhbiBlcnJvci4KClJlZ2FyZHMsCkNodW4tS3VhbmcuCgo+ICsgICAgICAgICAgICAg ICByZXR1cm47Cj4gKwo+ICAgICAgICAgc3RhdGUgPSB0b19tdGtfY3J0Y19zdGF0ZShtdGtfY3J0 Yy0+YmFzZS5zdGF0ZSk7Cj4KPiAgICAgICAgIHN0YXRlLT5wZW5kaW5nX2NvbmZpZyA9IGZhbHNl Owo+IC0tCj4gMi4xOC4wCj4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCkxpbnV4LW1lZGlhdGVrIG1haWxpbmcgbGlzdApMaW51eC1tZWRpYXRla0BsaXN0 cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGlu Zm8vbGludXgtbWVkaWF0ZWsK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 724BBC433F5 for ; Wed, 29 Sep 2021 14:57:14 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 31EEC613A6 for ; Wed, 29 Sep 2021 14:57:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 31EEC613A6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 763346EA9E; Wed, 29 Sep 2021 14:57:13 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id BA03D6EA9E for ; Wed, 29 Sep 2021 14:57:12 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 9005A61407 for ; Wed, 29 Sep 2021 14:57:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632927432; bh=m2Q3ldX4i8hJz/lYMTrW/Tc7jkjEgA48T0avsrMIFb0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=I6t9M2nwemRwrQSICjKBtwpC+J4aoewq4SNgP0rGrTtaHnU3JsDefsOY5eJPtdY5U fDNckqOmXgH2mhRy7nLTKyY10trM3urnU9BvLOke/N1y/7mr2+v0TuL+r20vX1JCIO f2w/kyFDh/0RiV+srRjRxKPXa4+H3ACd/5osE4TvRPz05tSRjvHuuXI9cjklYJNuu8 KpMte6W842e6WFwGtaExsSLjfkhNNudfaNW4foVCKLwlQuvL63hwwRanEbsTfsjaZw LPeERERdu2uOYSF2wk2lmTT6QlAfsvrxdXJF5EunlrHqHnAYd6To/vCLIvvm7cJue4 /mzZvQJwu4dlQ== Received: by mail-ed1-f43.google.com with SMTP id bd28so9660974edb.9 for ; Wed, 29 Sep 2021 07:57:12 -0700 (PDT) X-Gm-Message-State: AOAM531hq7/QykaNRnbv2CgsAfMES5SUV7BxfxNb4Zbc4DjyxV1joRML XBB9vgkFY/FsdC4fcDilYsAfXvJqR5C0vvG+Mg== X-Google-Smtp-Source: ABdhPJy2oIyAhlML1lKHkEI+GYb7Xf5WZ4jL2sSq+xZsFvjhx2y5gie/l/Dq825/3UzuJiV9rAUHrF0xKV//SQBZD0k= X-Received: by 2002:a17:906:7ac4:: with SMTP id k4mr178848ejo.430.1632927358007; Wed, 29 Sep 2021 07:55:58 -0700 (PDT) MIME-Version: 1.0 References: <20210929070235.4290-1-jason-jh.lin@mediatek.com> <20210929070235.4290-4-jason-jh.lin@mediatek.com> In-Reply-To: <20210929070235.4290-4-jason-jh.lin@mediatek.com> From: Chun-Kuang Hu Date: Wed, 29 Sep 2021 22:55:46 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 3/3] drm/mediatek: Fix cursor plane is not config when primary is updating To: "jason-jh.lin" Cc: Chun-Kuang Hu , Philipp Zabel , David Airlie , Daniel Vetter , Matthias Brugger , Yongqiang Niu , DRI Development , "moderated list:ARM/Mediatek SoC support" , Linux ARM , linux-kernel , Hsin-Yi Wang , fshao@chromium.org, Nancy Lin , singo.chang@mediatek.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, Jason: jason-jh.lin =E6=96=BC 2021=E5=B9=B49=E6=9C=882= 9=E6=97=A5 =E9=80=B1=E4=B8=89 =E4=B8=8B=E5=8D=883:02=E5=AF=AB=E9=81=93=EF= =BC=9A > > If cursor plane has updated but primary plane config task is not > finished, mtk_drm_crtc_update_config will call mbox_flush() to clear > all task in current GCE thread and let cursor plane re-send a new > GCE task with cursor + primary plane config to replace the unfinished > GCE task. > > So the plane config flag should not be cleared when mailbox callback > with a error status. > > Fixes: 9efb16c2fdd6 ("drm/mediatek: Clear pending flag when cmdq packet i= s done") > Signed-off-by: jason-jh.lin > --- > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/me= diatek/mtk_drm_crtc.c > index 06342df2a0be..fb0d9424acec 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > @@ -281,6 +281,9 @@ static void ddp_cmdq_cb(struct mbox_client *cl, void = *mssg) > struct mtk_crtc_state *state; > unsigned int i; > > + if (data->sta !=3D 0) data->sta is now the standard error code, so data->sta < 0 is an error. Regards, Chun-Kuang. > + return; > + > state =3D to_mtk_crtc_state(mtk_crtc->base.state); > > state->pending_config =3D false; > -- > 2.18.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2CC0C433F5 for ; Wed, 29 Sep 2021 14:59:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9F531613A6 for ; Wed, 29 Sep 2021 14:59:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9F531613A6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MAJg5EB5wUWvgXa/cphx2J2kQjnHUjfs2t7ejkw+/wg=; b=YpXKzLbfB8Yl4f RMxdbj/8wXOyvml/M0/kYwTj+qLNuX0csOhYHHH1lE6Gek4e0zVDPZ4q2Fn9ft/bG0IE6w+hnv/qX NbyJyqrOvOIiASCc9TpSwYCiKn2MVHchh7unvmPvDyZRb3NL/rJE67nMc/UPXi02B0oDy3QwGQ1tX Wxw4IXqF9CNTg5JamVo9VBHBaODAFcLOFByzyBv44XHPOffV2UagCOuWSEqfR5B6jKSI/BQGvkXw+ 98zKzgAwVl//kQzaDnl+KJOTUwmfmOGnFAJW2yuCvm7SJSWEX/63C/vFOLCj3Ak7RelEVxslHPG13 +qJ6VtxLt47/47zO+AuQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVb1G-00BQX2-0P; Wed, 29 Sep 2021 14:57:14 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVb1C-00BQWD-HO; Wed, 29 Sep 2021 14:57:12 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0A5D261406; Wed, 29 Sep 2021 14:57:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632927430; bh=m2Q3ldX4i8hJz/lYMTrW/Tc7jkjEgA48T0avsrMIFb0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=gWFQ3OxM+zlx5cOWwCsZPh5DG7BsFXnu98NTkCs+mOcp7Ey8FcXCBJo0g8+riLu0X wU6z55q6PhafzSiSGpIlMa5m2o8GLG1p3SG223uY8PKm8DrsBkP/yeywoTU7zaO7V7 Lpn8OfKULxV/0BhHBYJoP7RccfPv5Tm3OeHMWTVYqsFWBURZUvgkEgjUvR4q9aGxH1 6dbO2DosvrEzi91Pzfe0MUUfFjuCbUUMjIumlfR2Swo+KuOwRWdkBp8GYBNZhTDfxU ULn6r6Az0vpyLmxmViOQXgJauMS5JdQ4VBEn/fhwIX54iRZJDZrPP82DSCPsi7E7n2 Fn4uqb6LKT67A== Received: by mail-ed1-f54.google.com with SMTP id dn26so9684996edb.13; Wed, 29 Sep 2021 07:57:09 -0700 (PDT) X-Gm-Message-State: AOAM532/iBLuTgjYuOpsnredfUUVYYcKZsBLd9WcKr5Cg/Dx4es5wvQK RTU/iORYnZIk/HOJUHpL/hzhUjqC6qzPgbFrMQ== X-Google-Smtp-Source: ABdhPJy2oIyAhlML1lKHkEI+GYb7Xf5WZ4jL2sSq+xZsFvjhx2y5gie/l/Dq825/3UzuJiV9rAUHrF0xKV//SQBZD0k= X-Received: by 2002:a17:906:7ac4:: with SMTP id k4mr178848ejo.430.1632927358007; Wed, 29 Sep 2021 07:55:58 -0700 (PDT) MIME-Version: 1.0 References: <20210929070235.4290-1-jason-jh.lin@mediatek.com> <20210929070235.4290-4-jason-jh.lin@mediatek.com> In-Reply-To: <20210929070235.4290-4-jason-jh.lin@mediatek.com> From: Chun-Kuang Hu Date: Wed, 29 Sep 2021 22:55:46 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 3/3] drm/mediatek: Fix cursor plane is not config when primary is updating To: "jason-jh.lin" Cc: Chun-Kuang Hu , Philipp Zabel , David Airlie , Daniel Vetter , Matthias Brugger , Yongqiang Niu , DRI Development , "moderated list:ARM/Mediatek SoC support" , Linux ARM , linux-kernel , Hsin-Yi Wang , fshao@chromium.org, Nancy Lin , singo.chang@mediatek.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210929_075710_644088_167DBA59 X-CRM114-Status: GOOD ( 17.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGksIEphc29uOgoKamFzb24tamgubGluIDxqYXNvbi1qaC5saW5AbWVkaWF0ZWsuY29tPiDmlrwg MjAyMeW5tDnmnIgyOeaXpSDpgLHkuIkg5LiL5Y2IMzowMuWvq+mBk++8mgo+Cj4gSWYgY3Vyc29y IHBsYW5lIGhhcyB1cGRhdGVkIGJ1dCBwcmltYXJ5IHBsYW5lIGNvbmZpZyB0YXNrIGlzIG5vdAo+ IGZpbmlzaGVkLCBtdGtfZHJtX2NydGNfdXBkYXRlX2NvbmZpZyB3aWxsIGNhbGwgbWJveF9mbHVz aCgpIHRvIGNsZWFyCj4gYWxsIHRhc2sgaW4gY3VycmVudCBHQ0UgdGhyZWFkIGFuZCBsZXQgY3Vy c29yIHBsYW5lIHJlLXNlbmQgYSBuZXcKPiBHQ0UgdGFzayB3aXRoIGN1cnNvciArIHByaW1hcnkg cGxhbmUgY29uZmlnIHRvIHJlcGxhY2UgdGhlIHVuZmluaXNoZWQKPiBHQ0UgdGFzay4KPgo+IFNv IHRoZSBwbGFuZSBjb25maWcgZmxhZyBzaG91bGQgbm90IGJlIGNsZWFyZWQgd2hlbiBtYWlsYm94 IGNhbGxiYWNrCj4gd2l0aCBhIGVycm9yIHN0YXR1cy4KPgo+IEZpeGVzOiA5ZWZiMTZjMmZkZDYg KCJkcm0vbWVkaWF0ZWs6IENsZWFyIHBlbmRpbmcgZmxhZyB3aGVuIGNtZHEgcGFja2V0IGlzIGRv bmUiKQo+IFNpZ25lZC1vZmYtYnk6IGphc29uLWpoLmxpbiA8amFzb24tamgubGluQG1lZGlhdGVr LmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fY3J0Yy5jIHwg MyArKysKPiAgMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKQo+Cj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2NydGMuYyBiL2RyaXZlcnMvZ3B1L2Ry bS9tZWRpYXRlay9tdGtfZHJtX2NydGMuYwo+IGluZGV4IDA2MzQyZGYyYTBiZS4uZmIwZDk0MjRh Y2VjIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2NydGMu Ywo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2NydGMuYwo+IEBAIC0y ODEsNiArMjgxLDkgQEAgc3RhdGljIHZvaWQgZGRwX2NtZHFfY2Ioc3RydWN0IG1ib3hfY2xpZW50 ICpjbCwgdm9pZCAqbXNzZykKPiAgICAgICAgIHN0cnVjdCBtdGtfY3J0Y19zdGF0ZSAqc3RhdGU7 Cj4gICAgICAgICB1bnNpZ25lZCBpbnQgaTsKPgo+ICsgICAgICAgaWYgKGRhdGEtPnN0YSAhPSAw KQoKZGF0YS0+c3RhIGlzIG5vdyB0aGUgc3RhbmRhcmQgZXJyb3IgY29kZSwgc28gZGF0YS0+c3Rh IDwgMCBpcyBhbiBlcnJvci4KClJlZ2FyZHMsCkNodW4tS3VhbmcuCgo+ICsgICAgICAgICAgICAg ICByZXR1cm47Cj4gKwo+ICAgICAgICAgc3RhdGUgPSB0b19tdGtfY3J0Y19zdGF0ZShtdGtfY3J0 Yy0+YmFzZS5zdGF0ZSk7Cj4KPiAgICAgICAgIHN0YXRlLT5wZW5kaW5nX2NvbmZpZyA9IGZhbHNl Owo+IC0tCj4gMi4xOC4wCj4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxA bGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK