From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753483AbcGDLYR (ORCPT ); Mon, 4 Jul 2016 07:24:17 -0400 Received: from mail-wm0-f49.google.com ([74.125.82.49]:36306 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750984AbcGDLYM (ORCPT ); Mon, 4 Jul 2016 07:24:12 -0400 MIME-Version: 1.0 In-Reply-To: References: <1460464350-30414-1-git-send-email-tomeu.vizoso@collabora.com> <1460464350-30414-3-git-send-email-tomeu.vizoso@collabora.com> <20160425211735.GG26059@dtor-ws> <20160426065755.GA19037@dell> From: Tomeu Vizoso Date: Mon, 4 Jul 2016 13:23:51 +0200 X-Google-Sender-Auth: HX3RUiiuonEBv0bY_ewnspY9Rzc Message-ID: Subject: Re: [PATCH v8 2/7] Input: cros_ec_keyb - Stop handling interrupts directly To: Enric Balletbo Serra Cc: Lee Jones , Dmitry Torokhov , "linux-kernel@vger.kernel.org" , Sameer Nanda , Javier Martinez Canillas , Benson Leung , =?UTF-8?Q?Enric_Balletb=C3=B2?= , Vic Yang , Stephen Boyd , Vincent Palatin , Randall Spangler , Todd Broch , Gwendal Grignou , Vic Yang , linux-input@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1 July 2016 at 10:49, Enric Balletbo Serra wrote: > Hi Tomeu, > > 2016-04-26 9:06 GMT+02:00 Tomeu Vizoso : >> On 26 April 2016 at 08:57, Lee Jones wrote: >>> On Tue, 26 Apr 2016, Tomeu Vizoso wrote: >>> >>>> On 25 April 2016 at 23:17, Dmitry Torokhov wrote: >>>> > On Tue, Apr 12, 2016 at 02:32:25PM +0200, Tomeu Vizoso wrote: >>>> >> From: Vic Yang >>>> >> >>>> >> Because events other that keyboard ones will be handled by now on by >>>> >> other drivers, stop directly handling interrupts and instead listen to >>>> >> the new notifier in the MFD driver. >>>> >> >>>> > >>>> > Hmm, where did Vic's sign-off go? >>>> >>>> Lee Jones asked to remove them in a previous version as he considers >>>> them superfluous. My understanding is that as I'm the first to submit >>>> them to mainline, the chain starts with me (I certify the b section of >>>> http://developercertificate.org/). >>> >>> Hmm... It seems what I said has been misconstrued a little. You >>> *should* remove SoBs from people who were *only* part of the >>> submission path. However, you should *not* remove SoBs from patch >>> *authors*. Since Vic is the author (or at least one of them), their >>> SoB should remain. >>> >>> Apologies if that was not clear. >> >> I see now, will fix the tags in the next revision. >> > > With your permission I'll fix this and send a new patch series with > only the patch that adds the MKBP event support and this patch. These > two patches has sense by itself and are only a dependency of cros-ec > USB PD driver and other drivers, so I think makes sense send within a > separate series to increase the possibility to get merged and don't > block other drivers that depends on these. Sounds great, MKBP event support is indeed a dependency for the upcoming features that we want to upstream. Thanks, Tomeu > Thanks, > > Enric > > >> Thanks, >> >> Tomeu