All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ariadne Conill <ariadne@dereferenced.org>
To: Beat Bolli <dev+git@drbeat.li>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2 3/3] tests: add test for git log --no-use-mailmap
Date: Thu, 11 Jul 2019 12:38:39 -0500	[thread overview]
Message-ID: <CAAOiGNxrkVQy=2OHEJROtH+S_MdUMGCDOnjhgNK_x6iANcGiig@mail.gmail.com> (raw)
In-Reply-To: <f2cd0072-95de-3e60-d860-a5dd2c58c41a@drbeat.li>

Hello,

On Thu, Jul 11, 2019 at 12:32 PM Beat Bolli <dev+git@drbeat.li> wrote:
>
> On 11.07.19 19:26, Ariadne Conill wrote:
> > In order to prove that the --no-use-mailmap option works as expected,
> > we add a test for it which runs with -Dlog.mailmap=true to ensure that
>
> s/-D/-c /
>
> This ain't Java :-)

Indeed, it is not.  I thought I caught that when proofreading the
commit message.  Will resolve in v3.

Thanks for the review!

Ariadne

      reply	other threads:[~2019-07-11 17:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-11 17:26 [PATCH v2 0/3] use mailmap by default in git log Ariadne Conill
2019-07-11 17:26 ` [PATCH v2 1/3] log: use mailmap by default Ariadne Conill
2019-07-11 17:26 ` [PATCH v2 2/3] log: add --no-use-mailmap option to complement --use-mailmap option Ariadne Conill
2019-07-11 18:24   ` Beat Bolli
2019-07-11 18:25     ` Ariadne Conill
2019-07-11 18:27       ` Beat Bolli
2019-07-11 17:26 ` [PATCH v2 3/3] tests: add test for git log --no-use-mailmap Ariadne Conill
2019-07-11 17:32   ` Beat Bolli
2019-07-11 17:38     ` Ariadne Conill [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAOiGNxrkVQy=2OHEJROtH+S_MdUMGCDOnjhgNK_x6iANcGiig@mail.gmail.com' \
    --to=ariadne@dereferenced.org \
    --cc=dev+git@drbeat.li \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.