From: Aleksander Morgado <aleksander@aleksander.es>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] package/libqmi: needs headers >= 4.14
Date: Mon, 29 Mar 2021 23:40:59 +0200 [thread overview]
Message-ID: <CAAP7uc+4zEWFj-unho79p7mm6puX_XR-xiXPjcLqpfbScuwUYA@mail.gmail.com> (raw)
In-Reply-To: <20210329211957.321612-2-fontaine.fabrice@gmail.com>
Hey Fabrice,
On Mon, Mar 29, 2021 at 11:23 PM Fabrice Fontaine
<fontaine.fabrice@gmail.com> wrote:
>
> libqmi unconditionnally uses ARPHRD_RAWIP since version 1.28.0 and
> https://github.com/freedesktop/libqmi/commit/4085a2d6b771a40fb637433ed6a05b9d5d4d94b9
> https://github.com/freedesktop/libqmi/commit/19f4b39ee85500e7e868b8a100fba19c04fb3c30
>
> However, ARPHRD_RAWIP is only available since kernel 4.14 and
> https://github.com/torvalds/linux/commit/cdf4969c42a6c1a376dd03a9e846cf638d3cd4b1
>
> Fixes:
> - http://autobuild.buildroot.org/results/c8853b7161bd85d46c1282c6c097e7ef4042ae68
>
This is totally not intentional; the ARPHRD_RAWIP symbol is used in
the rmnet backend, and the rmnet backend itself should only be used if
the kernel has rmnet support, which we look for at configure time with
the following check:
AC_EGREP_HEADER([ifla_rmnet_flags],
[linux/if_link.h],
[enable_rmnet_support=yes],
[enable_rmnet_support=no])
We should probably improve that check to also include a lookup for the
ARPHRD_RAWIP symbol.
What do you think?
--
Aleksander
https://aleksander.es
next prev parent reply other threads:[~2021-03-29 21:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-29 21:19 [Buildroot] [PATCH 1/2] package/libqmi: drop unrecognized option Fabrice Fontaine
2021-03-29 21:19 ` [Buildroot] [PATCH 2/2] package/libqmi: needs headers >= 4.14 Fabrice Fontaine
2021-03-29 21:40 ` Aleksander Morgado [this message]
2021-03-29 21:44 ` Fabrice Fontaine
2021-03-29 22:13 ` Aleksander Morgado
2021-03-29 21:46 ` [Buildroot] [PATCH 1/2] package/libqmi: drop unrecognized option Aleksander Morgado
2021-03-30 19:37 ` Yann E. MORIN
2021-03-30 19:51 ` Aleksander Morgado
2021-04-03 10:33 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAP7uc+4zEWFj-unho79p7mm6puX_XR-xiXPjcLqpfbScuwUYA@mail.gmail.com \
--to=aleksander@aleksander.es \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.