From: Aleksander Morgado <aleksander@aleksander.es>
To: Loic Poulain <loic.poulain@linaro.org>
Cc: "Dan Williams" <dcbw@gapps.redhat.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Oliver Neukum" <oliver@neukum.org>,
"David S. Miller" <davem@davemloft.net>,
"Bjørn Mork" <bjorn@mork.no>,
"Network Development" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next v2 2/2] usb: class: cdc-wdm: WWAN framework integration
Date: Wed, 19 May 2021 11:40:00 +0200 [thread overview]
Message-ID: <CAAP7ucKrQeXhxuva_QA_M8us1Vp+EfAAHjCv80Ouh7XZi4Ma0w@mail.gmail.com> (raw)
In-Reply-To: <CAMZdPi-p13nk8OES-Fdc2hjTak8Ywk-TabYaeJBhS=kF0QFyag@mail.gmail.com>
> > But another thought: why couldn't wwan_create_port() take a devname
> > template like alloc_netdev() does and cdc-wdm can just pass "cdc-
> > wdm%d"? eg, why do we need to change the name?
> > Tools that care about
> > finding WWAN devices should be looking at sysfs attributes/links and
> > TYPE=XXXX in uevent, not at the device name. Nothing should be looking
> > at device name really.
>
> Right, passing the legacy cdc-wdm dev-name as a parameter seems to be
> a fair solution, making the transition smoother.
>
Reusing the cdc-wdm name is indeed a good compromise; plus then
reading port type (QMI, MBIM...) via sysfs attributes as you suggested
in your last patch would make it work perfectly fine in userspace.
--
Aleksander
https://aleksander.es
next prev parent reply other threads:[~2021-05-19 9:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 14:42 [PATCH net-next v2 1/2] net: wwan: Add unknown port type Loic Poulain
2021-05-11 14:42 ` [PATCH net-next v2 2/2] usb: class: cdc-wdm: WWAN framework integration Loic Poulain
2021-05-12 7:30 ` Aleksander Morgado
[not found] ` <CAMZdPi_2PdM9+_RQi0hL=eQauXfN3wFJVyHwSWGsfnK2QBaHbw@mail.gmail.com>
2021-05-12 9:04 ` Aleksander Morgado
2021-05-12 11:01 ` Loic Poulain
2021-05-12 11:05 ` Bjørn Mork
2021-05-12 16:34 ` Dan Williams
2021-05-19 9:25 ` Loic Poulain
2021-05-19 9:40 ` Aleksander Morgado [this message]
2021-05-11 23:33 ` [PATCH net-next v2 1/2] net: wwan: Add unknown port type patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAP7ucKrQeXhxuva_QA_M8us1Vp+EfAAHjCv80Ouh7XZi4Ma0w@mail.gmail.com \
--to=aleksander@aleksander.es \
--cc=bjorn@mork.no \
--cc=davem@davemloft.net \
--cc=dcbw@gapps.redhat.com \
--cc=kuba@kernel.org \
--cc=loic.poulain@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=oliver@neukum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.