Re: [Buildroot] [PATCH] package/libmbim: bump to version 1.24.8

[Aleksander Morgado <aleksander@aleksander.es>]

Hey,

> > > > > > > INTROSPECTION_MAKEFILE is the problem. If I replace the path to the
> > > > > > > path inside my BR, everything is working (the same issue is with
> > > > > > > Qmi-1.0.typelib).
> > > > > > >
> > > > > >
> > > > > > The introspection.m4 included in the sources is a bit outdated, the
> > > > > > attached patch syncs it with the newest one I have installed in my
> > > > > > system. I do see some fixes in the INTROSPECTION_MAKEFILE definition
> > > > > > in the patch, so these may be enough. Any chance you can give this
> > > > > > patch a try? You may need to force autoreconf as we're patching a m4
> > > > > > file-
> > > > >
> > > > > >>> libmbim 1.24.8 Patching
> > > > >
> > > > > Applying 0001-build-fix-introspection-setup-in-cross-builds.patch using patch:
> > > > > patching file m4/introspection.m4
> > > > > >>> libmbim 1.24.8 Updating config.sub and config.guess
> > > > > for file in config.guess config.sub; do for i in $(find
> > > > > /home/user/MyProjects/oss/br-test-v2/s2srv/build/libmbim-1.24.8 -name
> > > > > $file); do cp support/gnuconfig/$file $i; done; done
> > > > > >>> libmbim 1.24.8 Configuring
> > > > > >>> libmbim 1.24.8 Autoreconfiguring
> > > > > libtoolize: putting auxiliary files in '.'.
> > > > > libtoolize: copying file './ltmain.sh'
> > > > > libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'm4'.
> > > > > libtoolize: copying file 'm4/libtool.m4'
> > > > > libtoolize: copying file 'm4/ltoptions.m4'
> > > > > libtoolize: copying file 'm4/ltsugar.m4'
> > > > > libtoolize: copying file 'm4/ltversion.m4'
> > > > > libtoolize: copying file 'm4/lt~obsolete.m4'
> > > > > configure.ac:65: error: Unexpanded AX_ macro found. Please install GNU
> > > > > autoconf-archive
> > > > >       If this token and others are legitimate, please use m4_pattern_allow.
> > > > >       See the Autoconf documentation.
> > > > > configure.ac:66: error: Unexpanded AX_ macro found. Please install GNU
> > > > > autoconf-archive
> > > > >
> > > >
> > > > Gah... forgot autoconf-archive is a prerequisite when autoreconf-ing.
> > >
> > > My BR has autoconf-archive installed. Why does it fail?
> > >
> > > > I don't have time myself to test it right now, but the steps to do
> > > > this properly would be to git clone the libmbim git repo, switch to
> > > > mbim-1-24 branch, apply the patch, "NOCONFIGURE=1 ./autogen.sh &&
> > > > ./configure --enable-gtk-doc && make && make distcheck". And once you
> > > > have the release tarball, use that in buildroot.
> > > >
> > > > I can probably play with that later today if you don't do it earlier :)
> > >
> > > It doesn't work :-( Though I see introspection.m4 file in
> > > output/build/libmbim/m4 folder after replacing the tarball, the result
> > > in Makefile is still the same.
> > >
> >
> > I've opened this issue in GNOME bugzilla:
> > https://gitlab.gnome.org/GNOME/gobject-introspection/-/issues/391
> > I believe I know how to fix it, I'm giving it a try now.
>

Nah, it's getting out of hand, don't have time to get deep into
solving the bug today I'm afraid.

I think it could be some lack of alignment between the latest
gobject-introspection release and what buildroot is doing in
GOBJECT_INTROSPECTION_INSTALL_WRAPPERS (in
package/gobject-introspection/gobject-introspection.mk). That logic is
replacing how girdir and typelibdir are being built, using exec_prefix
instead of datadir and libdir, and in my build, that gives us some
unexpected results when INTROSPECTION_GIRDIR and
INTROSPECTION_TYPELIBDIR are built:

INTROSPECTION_GIRDIR = /share/gir-1.0
INTROSPECTION_TYPELIBDIR = /lib/girepository-1.0

As if the exec_prefix replacement gave an empty string?

And the same kind of issue when building INTROSPECTION_MAKEFILE. The
buildroot specific wrappers attempt to define a datarootdir based on
$(libdir)/../share, but still, we're getting a path to the host prefix
instead:

INTROSPECTION_MAKEFILE =
/usr/share/gobject-introspection-1.0/Makefile.introspection

The fact that libmbim ships its own introspection.m4 file also doesn't
help clear the issue, even if I think it could be unrelated to the
actual problem (the bug is reproduced in the very same way when
updating the file in libmbim to the newest one). E.g. the
gobject-introspection from release 1.68 does some AS_AC_EXPAND()
operations on datadir and libdir, and the one shipped with libmbim
doesn't do any of that. Maybe I should also make it a requirement when
building from git, instead of shipping our own, so that the
introspection.m4 from /usr/share/aclocal is used, not sure about that
though.

Adding Adam Duskett in CC to see if he has any idea about this
problem. It's easily reproducible here as well, with a clean buildroot
build using glibc toolchain, python3 enabled, gobject-introspection
enabled, and libmbim enabled (and without gobject-introspection in the
host). Adam, could you help us solve this issue?

>
> Just curious, are you going to port mm and libs to meson?
>

libmbim and libqmi are already ported in git master, next releases
will support both autotools and meson. MM is not ported yet, patches
welcome :)

-- 
Aleksander
https://aleksander.es
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot