Re: [PATCH v2] exynos-drm: Fix unsupported GEM memory type error message to be clear

From: Inki Dae <daeinki@gmail.com>
To: Shuah Khan <shuahkh@osg.samsung.com>
Cc: "Krzysztof Kozłowski" <k.kozlowski@samsung.com>,
	"linux-samsung-soc@vger.kernel.org"
	<linux-samsung-soc@vger.kernel.org>,
	"Seung-Woo Kim" <sw0312.kim@samsung.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"DRI mailing list" <dri-devel@lists.freedesktop.org>,
	"Kyungmin Park" <kyungmin.park@samsung.com>,
	"Kukjin Kim" <kgene@kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2] exynos-drm: Fix unsupported GEM memory type error message to be clear
Date: Tue, 9 Aug 2016 22:32:12 +0900	[thread overview]
Message-ID: <CAAQKjZMXf4C7e1isAHBCMxNps7xG2V_Fx66+Du8Ywhp02qcJ9A@mail.gmail.com> (raw)
In-Reply-To: <1470700100-13306-1-git-send-email-shuahkh@osg.samsung.com>

[-- Attachment #1.1: Type: text/plain, Size: 1493 bytes --]

Picked it up. :)

Thanks,
Inki Dae

2016-08-09 8:48 GMT+09:00 Shuah Khan <shuahkh@osg.samsung.com>:

> Fix unsupported GEM memory type error message to include the memory type
> information.
>
> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
> ---
> Changes since v1:
> -- Comment changed to read clearly
>
>  drivers/gpu/drm/exynos/exynos_drm_fb.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fb.c
> b/drivers/gpu/drm/exynos/exynos_drm_fb.c
> index e016640..40ce841 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_fb.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_fb.c
> @@ -55,11 +55,11 @@ static int check_fb_gem_memory_type(struct drm_device
> *drm_dev,
>         flags = exynos_gem->flags;
>
>         /*
> -        * without iommu support, not support physically non-continuous
> memory
> -        * for framebuffer.
> +        * Physically non-contiguous memory type for framebuffer is not
> +        * supported without IOMMU.
>          */
>         if (IS_NONCONTIG_BUFFER(flags)) {
> -               DRM_ERROR("cannot use this gem memory type for fb.\n");
> +               DRM_ERROR("Non-contiguous GEM memory is not supported.\n");
>                 return -EINVAL;
>         }
>
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe
> linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

[-- Attachment #1.2: Type: text/html, Size: 2493 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel