All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH -next] drm/exynos: g2d: fix missing unlock on error in g2d_runqueue_worker()
@ 2021-06-15 17:21 ` Wei Yongjun
  0 siblings, 0 replies; 4+ messages in thread
From: Wei Yongjun @ 2021-06-15 17:21 UTC (permalink / raw)
  To: weiyongjun1, Inki Dae, Joonyoung Shim, Seung-Woo Kim,
	Kyungmin Park, David Airlie, Daniel Vetter, Krzysztof Kozlowski
  Cc: dri-devel, linux-arm-kernel, linux-samsung-soc, kernel-janitors,
	Hulk Robot

Add the missing unlock before return from function g2d_runqueue_worker()
in the error handling case.

Fixes: 445d3bed75de ("drm/exynos: use pm_runtime_resume_and_get()")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/gpu/drm/exynos/exynos_drm_g2d.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c b/drivers/gpu/drm/exynos/exynos_drm_g2d.c
index cab4d2c370a7..0ed665501ac4 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_g2d.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.c
@@ -897,13 +897,14 @@ static void g2d_runqueue_worker(struct work_struct *work)
 			ret = pm_runtime_resume_and_get(g2d->dev);
 			if (ret < 0) {
 				dev_err(g2d->dev, "failed to enable G2D device.\n");
-				return;
+				goto out;
 			}
 
 			g2d_dma_start(g2d, g2d->runqueue_node);
 		}
 	}
 
+out:
 	mutex_unlock(&g2d->runqueue_mutex);
 }
 


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH -next] drm/exynos: g2d: fix missing unlock on error in g2d_runqueue_worker()
@ 2021-06-15 17:21 ` Wei Yongjun
  0 siblings, 0 replies; 4+ messages in thread
From: Wei Yongjun @ 2021-06-15 17:21 UTC (permalink / raw)
  To: weiyongjun1, Inki Dae, Joonyoung Shim, Seung-Woo Kim,
	Kyungmin Park, David Airlie, Daniel Vetter, Krzysztof Kozlowski
  Cc: dri-devel, linux-arm-kernel, linux-samsung-soc, kernel-janitors,
	Hulk Robot

Add the missing unlock before return from function g2d_runqueue_worker()
in the error handling case.

Fixes: 445d3bed75de ("drm/exynos: use pm_runtime_resume_and_get()")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/gpu/drm/exynos/exynos_drm_g2d.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c b/drivers/gpu/drm/exynos/exynos_drm_g2d.c
index cab4d2c370a7..0ed665501ac4 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_g2d.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.c
@@ -897,13 +897,14 @@ static void g2d_runqueue_worker(struct work_struct *work)
 			ret = pm_runtime_resume_and_get(g2d->dev);
 			if (ret < 0) {
 				dev_err(g2d->dev, "failed to enable G2D device.\n");
-				return;
+				goto out;
 			}
 
 			g2d_dma_start(g2d, g2d->runqueue_node);
 		}
 	}
 
+out:
 	mutex_unlock(&g2d->runqueue_mutex);
 }
 


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH -next] drm/exynos: g2d: fix missing unlock on error in g2d_runqueue_worker()
@ 2021-06-15 17:21 ` Wei Yongjun
  0 siblings, 0 replies; 4+ messages in thread
From: Wei Yongjun @ 2021-06-15 17:21 UTC (permalink / raw)
  To: weiyongjun1, Inki Dae, Joonyoung Shim, Seung-Woo Kim,
	Kyungmin Park, David Airlie, Daniel Vetter, Krzysztof Kozlowski
  Cc: Hulk Robot, linux-samsung-soc, kernel-janitors, linux-arm-kernel,
	dri-devel

Add the missing unlock before return from function g2d_runqueue_worker()
in the error handling case.

Fixes: 445d3bed75de ("drm/exynos: use pm_runtime_resume_and_get()")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/gpu/drm/exynos/exynos_drm_g2d.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c b/drivers/gpu/drm/exynos/exynos_drm_g2d.c
index cab4d2c370a7..0ed665501ac4 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_g2d.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.c
@@ -897,13 +897,14 @@ static void g2d_runqueue_worker(struct work_struct *work)
 			ret = pm_runtime_resume_and_get(g2d->dev);
 			if (ret < 0) {
 				dev_err(g2d->dev, "failed to enable G2D device.\n");
-				return;
+				goto out;
 			}
 
 			g2d_dma_start(g2d, g2d->runqueue_node);
 		}
 	}
 
+out:
 	mutex_unlock(&g2d->runqueue_mutex);
 }
 


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH -next] drm/exynos: g2d: fix missing unlock on error in g2d_runqueue_worker()
  2021-06-15 17:21 ` Wei Yongjun
  (?)
  (?)
@ 2021-07-26  2:36 ` Inki Dae
  -1 siblings, 0 replies; 4+ messages in thread
From: Inki Dae @ 2021-07-26  2:36 UTC (permalink / raw)
  To: Wei Yongjun
  Cc: linux-samsung-soc, Joonyoung Shim, Krzysztof Kozlowski,
	David Airlie, kernel-janitors, Seung-Woo Kim, dri-devel,
	Hulk Robot, Kyungmin Park, linux-arm-kernel

[-- Attachment #1: Type: text/plain, Size: 1371 bytes --]

Sorry for late and thanks for fixing it.

Thanks,
Inki Dae

2021년 6월 16일 수요일, Wei Yongjun <weiyongjun1@huawei.com>님이 작성:

> Add the missing unlock before return from function g2d_runqueue_worker()
> in the error handling case.
>
> Fixes: 445d3bed75de ("drm/exynos: use pm_runtime_resume_and_get()")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
>  drivers/gpu/drm/exynos/exynos_drm_g2d.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c
> b/drivers/gpu/drm/exynos/exynos_drm_g2d.c
> index cab4d2c370a7..0ed665501ac4 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_g2d.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.c
> @@ -897,13 +897,14 @@ static void g2d_runqueue_worker(struct work_struct
> *work)
>                         ret = pm_runtime_resume_and_get(g2d->dev);
>                         if (ret < 0) {
>                                 dev_err(g2d->dev, "failed to enable G2D
> device.\n");
> -                               return;
> +                               goto out;
>                         }
>
>                         g2d_dma_start(g2d, g2d->runqueue_node);
>                 }
>         }
>
> +out:
>         mutex_unlock(&g2d->runqueue_mutex);
>  }
>
>
>

[-- Attachment #2: Type: text/html, Size: 1913 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-07-26  2:36 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-15 17:21 [PATCH -next] drm/exynos: g2d: fix missing unlock on error in g2d_runqueue_worker() Wei Yongjun
2021-06-15 17:21 ` Wei Yongjun
2021-06-15 17:21 ` Wei Yongjun
2021-07-26  2:36 ` Inki Dae

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.