All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/9] Restore parallel display support for Exynos based boards
@ 2014-03-17 10:27 Andrzej Hajda
  2014-03-17 10:27 ` [PATCH 1/9] drm/exynos: delay fbdev initialization until an output is connected Andrzej Hajda
                   ` (9 more replies)
  0 siblings, 10 replies; 17+ messages in thread
From: Andrzej Hajda @ 2014-03-17 10:27 UTC (permalink / raw)
  To: dri-devel
  Cc: Mark Rutland, devicetree, linux-samsung-soc, Pawel Moll,
	Ian Campbell, Andrzej Hajda, Kyungmin Park, Rob Herring,
	Kumar Gala, Grant Likely, Denis Carikli, Marek Szyprowski

Hi,

This patch set restores parallel display support removed during exynos
refactorization. It is rebased on the latest exynos-drm-next branch plus patch
adding polarization flags to drm_display_mode [1].

[1]: http://permalink.gmane.org/gmane.linux.drivers.driver-project.devel/47216

Regards
Andrzej


Andrzej Hajda (9):
  drm/exynos: delay fbdev initialization until an output is connected
  drm/exynos: init kms poll after creation of connectors
  drm/exynos: correct timing porch conversion
  exynos/fimd: add parallel output related bindings
  drm/exynos: restore parallel output interface support
  ARM: dts: exynos4210-universal: add exynos/fimd node
  drm/modes: add polarization handling to mode conversion
  drm/exynos/fimd: use polarization flags provided by drm_display_mode
  drm/exynos/fimd: remove unused variable

 .../devicetree/bindings/video/samsung-fimd.txt     |  15 +
 arch/arm/boot/dts/exynos4210-universal_c210.dts    |  25 ++
 drivers/gpu/drm/drm_modes.c                        |  11 +
 drivers/gpu/drm/exynos/Kconfig                     |   8 +
 drivers/gpu/drm/exynos/Makefile                    |   1 +
 drivers/gpu/drm/exynos/exynos_drm_dpi.c            | 339 +++++++++++++++++++++
 drivers/gpu/drm/exynos/exynos_drm_drv.c            |  22 +-
 drivers/gpu/drm/exynos/exynos_drm_drv.h            |   8 +
 drivers/gpu/drm/exynos/exynos_drm_fb.c             |   3 +
 drivers/gpu/drm/exynos/exynos_drm_fimd.c           |  32 +-
 10 files changed, 432 insertions(+), 32 deletions(-)
 create mode 100644 drivers/gpu/drm/exynos/exynos_drm_dpi.c

-- 
1.8.3.2

^ permalink raw reply	[flat|nested] 17+ messages in thread

* [PATCH 1/9] drm/exynos: delay fbdev initialization until an output is connected
  2014-03-17 10:27 [PATCH 0/9] Restore parallel display support for Exynos based boards Andrzej Hajda
@ 2014-03-17 10:27 ` Andrzej Hajda
  2014-03-17 10:27 ` [PATCH 2/9] drm/exynos: init kms poll after creation of connectors Andrzej Hajda
                   ` (8 subsequent siblings)
  9 siblings, 0 replies; 17+ messages in thread
From: Andrzej Hajda @ 2014-03-17 10:27 UTC (permalink / raw)
  To: dri-devel
  Cc: Andrzej Hajda, Mark Rutland, devicetree, linux-samsung-soc,
	Pawel Moll, Ian Campbell, Kyungmin Park, Rob Herring, Kumar Gala,
	Grant Likely, Sean Paul, Inki Dae, Marek Szyprowski,
	Denis Carikli

In case fbdev is initialized before any output is connected,
fb resolution defaults to 1024x768. After that any output with
bigger resolution is ignored and fbdev is not displayed.
The patch postpones fbdev initialization to avoid such situation.

Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
---
 drivers/gpu/drm/exynos/exynos_drm_drv.c | 16 ++++------------
 drivers/gpu/drm/exynos/exynos_drm_fb.c  |  3 +++
 2 files changed, 7 insertions(+), 12 deletions(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/drm/exynos/exynos_drm_drv.c
index c8869de..25f45b8 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_drv.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c
@@ -109,24 +109,15 @@ static int exynos_drm_load(struct drm_device *dev, unsigned long flags)
 	/* setup possible_clones. */
 	exynos_drm_encoder_setup(dev);
 
-	/*
-	 * create and configure fb helper and also exynos specific
-	 * fbdev object.
-	 */
-	ret = exynos_drm_fbdev_init(dev);
-	if (ret) {
-		DRM_ERROR("failed to initialize drm fbdev\n");
-		goto err_drm_device;
-	}
-
 	drm_vblank_offdelay = VBLANK_OFF_DELAY;
 
 	platform_set_drvdata(dev->platformdev, dev);
 
+	/* force connectors detection */
+	drm_helper_hpd_irq_event(dev);
+
 	return 0;
 
-err_drm_device:
-	exynos_drm_device_unregister(dev);
 err_vblank:
 	drm_vblank_cleanup(dev);
 err_display_cleanup:
@@ -571,6 +562,7 @@ out_hdmi:
 	platform_driver_unregister(&fimd_driver);
 out_fimd:
 #endif
+
 #ifdef CONFIG_DRM_EXYNOS_DP
 	platform_driver_unregister(&dp_driver);
 out_dp:
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fb.c b/drivers/gpu/drm/exynos/exynos_drm_fb.c
index c7c08d0..65a22ca 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_fb.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_fb.c
@@ -20,6 +20,7 @@
 
 #include "exynos_drm_drv.h"
 #include "exynos_drm_fb.h"
+#include "exynos_drm_fbdev.h"
 #include "exynos_drm_gem.h"
 #include "exynos_drm_iommu.h"
 #include "exynos_drm_crtc.h"
@@ -300,6 +301,8 @@ static void exynos_drm_output_poll_changed(struct drm_device *dev)
 
 	if (fb_helper)
 		drm_fb_helper_hotplug_event(fb_helper);
+	else
+		exynos_drm_fbdev_init(dev);
 }
 
 static const struct drm_mode_config_funcs exynos_drm_mode_config_funcs = {
-- 
1.8.3.2

^ permalink raw reply related	[flat|nested] 17+ messages in thread

* [PATCH 2/9] drm/exynos: init kms poll after creation of connectors
  2014-03-17 10:27 [PATCH 0/9] Restore parallel display support for Exynos based boards Andrzej Hajda
  2014-03-17 10:27 ` [PATCH 1/9] drm/exynos: delay fbdev initialization until an output is connected Andrzej Hajda
@ 2014-03-17 10:27 ` Andrzej Hajda
  2014-03-17 10:27 ` [PATCH 3/9] drm/exynos: correct timing porch conversion Andrzej Hajda
                   ` (7 subsequent siblings)
  9 siblings, 0 replies; 17+ messages in thread
From: Andrzej Hajda @ 2014-03-17 10:27 UTC (permalink / raw)
  To: dri-devel
  Cc: Mark Rutland, devicetree, linux-samsung-soc, Pawel Moll,
	Ian Campbell, Andrzej Hajda, Kyungmin Park, Rob Herring,
	Kumar Gala, Grant Likely, Denis Carikli, Marek Szyprowski

KMS poll init helper should be run when connectors are created,
otherwise it will not schedule connection detector.

Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
---
 drivers/gpu/drm/exynos/exynos_drm_drv.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/drm/exynos/exynos_drm_drv.c
index 25f45b8..dfee083 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_drv.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c
@@ -71,9 +71,6 @@ static int exynos_drm_load(struct drm_device *dev, unsigned long flags)
 
 	drm_mode_config_init(dev);
 
-	/* init kms poll for handling hpd */
-	drm_kms_helper_poll_init(dev);
-
 	exynos_drm_mode_config_init(dev);
 
 	ret = exynos_drm_initialize_managers(dev);
@@ -93,6 +90,9 @@ static int exynos_drm_load(struct drm_device *dev, unsigned long flags)
 	if (ret)
 		goto err_manager_cleanup;
 
+	/* init kms poll for handling hpd */
+	drm_kms_helper_poll_init(dev);
+
 	ret = drm_vblank_init(dev, MAX_CRTC);
 	if (ret)
 		goto err_display_cleanup;
-- 
1.8.3.2

^ permalink raw reply related	[flat|nested] 17+ messages in thread

* [PATCH 3/9] drm/exynos: correct timing porch conversion
  2014-03-17 10:27 [PATCH 0/9] Restore parallel display support for Exynos based boards Andrzej Hajda
  2014-03-17 10:27 ` [PATCH 1/9] drm/exynos: delay fbdev initialization until an output is connected Andrzej Hajda
  2014-03-17 10:27 ` [PATCH 2/9] drm/exynos: init kms poll after creation of connectors Andrzej Hajda
@ 2014-03-17 10:27 ` Andrzej Hajda
  2014-03-17 10:27 ` [PATCH 4/9] exynos/fimd: add parallel output related bindings Andrzej Hajda
                   ` (6 subsequent siblings)
  9 siblings, 0 replies; 17+ messages in thread
From: Andrzej Hajda @ 2014-03-17 10:27 UTC (permalink / raw)
  To: dri-devel
  Cc: Mark Rutland, devicetree, linux-samsung-soc, Pawel Moll,
	Ian Campbell, Andrzej Hajda, Kyungmin Park, Rob Herring,
	Kumar Gala, Grant Likely, Denis Carikli, Marek Szyprowski

The patch corrects porch calculation. It should
be calculated as a difference between adjacent
respective fields of drm_display_mode.

Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Reviewed-by: Daniel Kurtz <djkurtz@chromium.org>
---
 drivers/gpu/drm/exynos/exynos_drm_fimd.c | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
index f78fbf4..10431b0 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
@@ -221,7 +221,7 @@ static void fimd_commit(struct exynos_drm_manager *mgr)
 	struct drm_display_mode *mode = &ctx->mode;
 	struct fimd_driver_data *driver_data;
 	u32 val, clkdiv, vidcon1;
-	int hblank, vblank, vsync_len, vbpd, vfpd, hsync_len, hbpd, hfpd;
+	int vsync_len, vbpd, vfpd, hsync_len, hbpd, hfpd;
 
 	driver_data = ctx->driver_data;
 	if (ctx->suspended)
@@ -240,10 +240,9 @@ static void fimd_commit(struct exynos_drm_manager *mgr)
 	writel(vidcon1, ctx->regs + driver_data->timing_base + VIDCON1);
 
 	/* setup vertical timing values. */
-	vblank = mode->crtc_vblank_end - mode->crtc_vblank_start;
 	vsync_len = mode->crtc_vsync_end - mode->crtc_vsync_start;
-	vbpd = (vblank - vsync_len) / 2;
-	vfpd = vblank - vsync_len - vbpd;
+	vbpd = mode->crtc_vtotal - mode->crtc_vsync_end;
+	vfpd = mode->crtc_vsync_start - mode->crtc_vdisplay;
 
 	val = VIDTCON0_VBPD(vbpd - 1) |
 		VIDTCON0_VFPD(vfpd - 1) |
@@ -251,10 +250,9 @@ static void fimd_commit(struct exynos_drm_manager *mgr)
 	writel(val, ctx->regs + driver_data->timing_base + VIDTCON0);
 
 	/* setup horizontal timing values.  */
-	hblank = mode->crtc_hblank_end - mode->crtc_hblank_start;
 	hsync_len = mode->crtc_hsync_end - mode->crtc_hsync_start;
-	hbpd = (hblank - hsync_len) / 2;
-	hfpd = hblank - hsync_len - hbpd;
+	hbpd = mode->crtc_htotal - mode->crtc_hsync_end;
+	hfpd = mode->crtc_hsync_start - mode->crtc_hdisplay;
 
 	val = VIDTCON1_HBPD(hbpd - 1) |
 		VIDTCON1_HFPD(hfpd - 1) |
-- 
1.8.3.2

^ permalink raw reply related	[flat|nested] 17+ messages in thread

* [PATCH 4/9] exynos/fimd: add parallel output related bindings
  2014-03-17 10:27 [PATCH 0/9] Restore parallel display support for Exynos based boards Andrzej Hajda
                   ` (2 preceding siblings ...)
  2014-03-17 10:27 ` [PATCH 3/9] drm/exynos: correct timing porch conversion Andrzej Hajda
@ 2014-03-17 10:27 ` Andrzej Hajda
  2014-03-17 10:27 ` [PATCH 5/9] drm/exynos: restore parallel output interface support Andrzej Hajda
                   ` (5 subsequent siblings)
  9 siblings, 0 replies; 17+ messages in thread
From: Andrzej Hajda @ 2014-03-17 10:27 UTC (permalink / raw)
  To: dri-devel
  Cc: Mark Rutland, devicetree, linux-samsung-soc, Pawel Moll,
	Ian Campbell, Andrzej Hajda, Kyungmin Park, Rob Herring,
	Kumar Gala, Grant Likely, Denis Carikli, Marek Szyprowski

The patch adds bindings required to add support
for parallel output.

Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
---
 Documentation/devicetree/bindings/video/samsung-fimd.txt | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/Documentation/devicetree/bindings/video/samsung-fimd.txt b/Documentation/devicetree/bindings/video/samsung-fimd.txt
index 36b7895..2dad41b 100644
--- a/Documentation/devicetree/bindings/video/samsung-fimd.txt
+++ b/Documentation/devicetree/bindings/video/samsung-fimd.txt
@@ -41,6 +41,21 @@ Optional Properties:
 - samsung,power-domain: a phandle to FIMD power domain node.
 - samsung,invert-vden: video enable signal is inverted
 - samsung,invert-vclk: video clock signal is inverted
+- display-timings: timing settings for FIMD, as described in document [1].
+		Can be used in case timings cannot be provided otherwise
+		or to override timings provided by the panel.
+
+The device node can contain 'port' child nodes according to the bindings defined
+in [2]. The following are properties specific to those nodes:
+- reg: (required) port index, can be:
+		0 - for CAMIF0 input,
+		1 - for CAMIF1 input,
+		2 - for CAMIF2 input,
+		3 - for parallel output,
+		4 - for write-back interface
+
+[1]: Documentation/devicetree/bindings/video/display-timing.txt
+[2]: Documentation/devicetree/bindings/media/video-interfaces.txt
 
 Example:
 
-- 
1.8.3.2

^ permalink raw reply related	[flat|nested] 17+ messages in thread

* [PATCH 5/9] drm/exynos: restore parallel output interface support
  2014-03-17 10:27 [PATCH 0/9] Restore parallel display support for Exynos based boards Andrzej Hajda
                   ` (3 preceding siblings ...)
  2014-03-17 10:27 ` [PATCH 4/9] exynos/fimd: add parallel output related bindings Andrzej Hajda
@ 2014-03-17 10:27 ` Andrzej Hajda
  2014-03-17 12:03   ` [PATCH v2 " Andrzej Hajda
  2014-03-17 10:27 ` [PATCH 6/9] ARM: dts: exynos4210-universal: add exynos/fimd node Andrzej Hajda
                   ` (4 subsequent siblings)
  9 siblings, 1 reply; 17+ messages in thread
From: Andrzej Hajda @ 2014-03-17 10:27 UTC (permalink / raw)
  To: dri-devel
  Cc: Andrzej Hajda, Mark Rutland, devicetree, linux-samsung-soc,
	Pawel Moll, Ian Campbell, Kyungmin Park, Rob Herring, Kumar Gala,
	Grant Likely, Sean Paul, Inki Dae, Marek Szyprowski,
	Denis Carikli

The patch adds parallel output interface to FIMD device driver.
It also restores support for panels initialized by boot loader,
but without proper kernel driver.
Driver uses video interface bindings to find connected panel.
It uses drm_panel interface to interact with the panel.

Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
---
 drivers/gpu/drm/exynos/Kconfig           |   8 +
 drivers/gpu/drm/exynos/Makefile          |   1 +
 drivers/gpu/drm/exynos/exynos_drm_dpi.c  | 339 +++++++++++++++++++++++++++++++
 drivers/gpu/drm/exynos/exynos_drm_drv.h  |   8 +
 drivers/gpu/drm/exynos/exynos_drm_fimd.c |   4 +
 5 files changed, 360 insertions(+)
 create mode 100644 drivers/gpu/drm/exynos/exynos_drm_dpi.c

diff --git a/drivers/gpu/drm/exynos/Kconfig b/drivers/gpu/drm/exynos/Kconfig
index 7eea698..56f9581 100644
--- a/drivers/gpu/drm/exynos/Kconfig
+++ b/drivers/gpu/drm/exynos/Kconfig
@@ -31,6 +31,14 @@ config DRM_EXYNOS_FIMD
 	help
 	  Choose this option if you want to use Exynos FIMD for DRM.
 
+config DRM_EXYNOS_DPI
+	bool "EXYNOS DRM parallel output support"
+	depends on DRM_EXYNOS
+	select DRM_PANEL
+	default n
+	help
+	  This enables support for Exynos parallel output.
+
 config DRM_EXYNOS_DP
 	bool "EXYNOS DRM DP driver support"
 	depends on DRM_EXYNOS && ARCH_EXYNOS
diff --git a/drivers/gpu/drm/exynos/Makefile b/drivers/gpu/drm/exynos/Makefile
index b1839e8..babcd52 100644
--- a/drivers/gpu/drm/exynos/Makefile
+++ b/drivers/gpu/drm/exynos/Makefile
@@ -11,6 +11,7 @@ exynosdrm-y := exynos_drm_drv.o exynos_drm_encoder.o \
 exynosdrm-$(CONFIG_DRM_EXYNOS_IOMMU) += exynos_drm_iommu.o
 exynosdrm-$(CONFIG_DRM_EXYNOS_DMABUF) += exynos_drm_dmabuf.o
 exynosdrm-$(CONFIG_DRM_EXYNOS_FIMD)	+= exynos_drm_fimd.o
+exynosdrm-$(CONFIG_DRM_EXYNOS_DPI)	+= exynos_drm_dpi.o
 exynosdrm-$(CONFIG_DRM_EXYNOS_DP)	+= exynos_dp_core.o exynos_dp_reg.o
 exynosdrm-$(CONFIG_DRM_EXYNOS_HDMI)	+= exynos_hdmi.o exynos_mixer.o
 exynosdrm-$(CONFIG_DRM_EXYNOS_VIDI)	+= exynos_drm_vidi.o
diff --git a/drivers/gpu/drm/exynos/exynos_drm_dpi.c b/drivers/gpu/drm/exynos/exynos_drm_dpi.c
new file mode 100644
index 0000000..2b09c7c
--- /dev/null
+++ b/drivers/gpu/drm/exynos/exynos_drm_dpi.c
@@ -0,0 +1,339 @@
+/*
+ * Exynos DRM Parallel output support.
+ *
+ * Copyright (c) 2014 Samsung Electronics Co., Ltd
+ *
+ * Contacts: Andrzej Hajda <a.hajda@samsung.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+*/
+
+#include <drm/drmP.h>
+#include <drm/drm_crtc_helper.h>
+#include <drm/drm_panel.h>
+
+#include <linux/regulator/consumer.h>
+
+#include <video/of_videomode.h>
+#include <video/videomode.h>
+
+#include "exynos_drm_drv.h"
+
+struct exynos_dpi {
+	struct device *dev;
+	struct device_node *panel_node;
+
+	struct drm_panel *panel;
+	struct drm_connector connector;
+	struct drm_encoder *encoder;
+
+	struct videomode *vm;
+	int dpms_mode;
+};
+
+#define connector_to_dpi(c) container_of(c, struct exynos_dpi, connector)
+
+static enum drm_connector_status
+exynos_dpi_detect(struct drm_connector *connector, bool force)
+{
+	struct exynos_dpi *ctx = connector_to_dpi(connector);
+
+	/* panels supported only by boot-loader are always connected */
+	if (!ctx->panel_node)
+		return connector_status_connected;
+
+	if (!ctx->panel) {
+		ctx->panel = of_drm_find_panel(ctx->panel_node);
+		if (ctx->panel)
+			drm_panel_attach(ctx->panel, &ctx->connector);
+	}
+
+	if (ctx->panel)
+		return connector_status_connected;
+
+	return connector_status_disconnected;
+}
+
+static void exynos_dpi_connector_destroy(struct drm_connector *connector)
+{
+	drm_sysfs_connector_remove(connector);
+	drm_connector_cleanup(connector);
+}
+
+static struct drm_connector_funcs exynos_dpi_connector_funcs = {
+	.dpms = drm_helper_connector_dpms,
+	.detect = exynos_dpi_detect,
+	.fill_modes = drm_helper_probe_single_connector_modes,
+	.destroy = exynos_dpi_connector_destroy,
+};
+
+static int exynos_dpi_get_modes(struct drm_connector *connector)
+{
+	struct exynos_dpi *ctx = connector_to_dpi(connector);
+
+	/* fimd timings gets precedence over panel modes */
+	if (ctx->vm) {
+		struct drm_display_mode *mode;
+
+		mode = drm_mode_create(connector->dev);
+		if (!mode) {
+			DRM_ERROR("failed to create a new display mode\n");
+			return 0;
+		}
+		drm_display_mode_from_videomode(ctx->vm, mode);
+		mode->type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED;
+		drm_mode_probed_add(connector, mode);
+		return 1;
+	}
+
+	if (ctx->panel)
+		return ctx->panel->funcs->get_modes(ctx->panel);
+
+	return 0;
+}
+
+static int exynos_dpi_mode_valid(struct drm_connector *connector,
+				 struct drm_display_mode *mode)
+{
+	return MODE_OK;
+}
+
+static struct drm_encoder *
+exynos_dpi_best_encoder(struct drm_connector *connector)
+{
+	struct exynos_dpi *ctx = connector_to_dpi(connector);
+
+	return ctx->encoder;
+}
+
+static struct drm_connector_helper_funcs exynos_dpi_connector_helper_funcs = {
+	.get_modes = exynos_dpi_get_modes,
+	.mode_valid = exynos_dpi_mode_valid,
+	.best_encoder = exynos_dpi_best_encoder,
+};
+
+static int exynos_dpi_create_connector(struct exynos_drm_display *display,
+				       struct drm_encoder *encoder)
+{
+	struct exynos_dpi *ctx = display->ctx;
+	struct drm_connector *connector = &ctx->connector;
+	int ret;
+
+	ctx->encoder = encoder;
+
+	if (ctx->panel_node)
+		connector->polled = DRM_CONNECTOR_POLL_CONNECT;
+	else
+		connector->polled = DRM_CONNECTOR_POLL_HPD;
+
+	ret = drm_connector_init(encoder->dev, connector,
+				 &exynos_dpi_connector_funcs,
+				 DRM_MODE_CONNECTOR_VGA);
+	if (ret) {
+		DRM_ERROR("failed to initialize connector with drm\n");
+		return ret;
+	}
+
+	drm_connector_helper_add(connector, &exynos_dpi_connector_helper_funcs);
+	drm_sysfs_connector_add(connector);
+	drm_mode_connector_attach_encoder(connector, encoder);
+
+	return 0;
+}
+
+static void exynos_dpi_poweron(struct exynos_dpi *ctx)
+{
+	if (ctx->panel)
+		drm_panel_enable(ctx->panel);
+}
+
+static void exynos_dpi_poweroff(struct exynos_dpi *ctx)
+{
+	if (ctx->panel)
+		drm_panel_disable(ctx->panel);
+}
+
+static void exynos_dpi_dpms(struct exynos_drm_display *display, int mode)
+{
+	struct exynos_dpi *ctx = display->ctx;
+
+	switch (mode) {
+	case DRM_MODE_DPMS_ON:
+		if (ctx->dpms_mode != DRM_MODE_DPMS_ON)
+				exynos_dpi_poweron(ctx);
+			break;
+	case DRM_MODE_DPMS_STANDBY:
+	case DRM_MODE_DPMS_SUSPEND:
+	case DRM_MODE_DPMS_OFF:
+		if (ctx->dpms_mode == DRM_MODE_DPMS_ON)
+			exynos_dpi_poweroff(ctx);
+		break;
+	default:
+		break;
+	};
+	ctx->dpms_mode = mode;
+}
+
+static struct exynos_drm_display_ops exynos_dpi_display_ops = {
+	.create_connector = exynos_dpi_create_connector,
+	.dpms = exynos_dpi_dpms
+};
+
+static struct exynos_drm_display exynos_dpi_display = {
+	.type = EXYNOS_DISPLAY_TYPE_LCD,
+	.ops = &exynos_dpi_display_ops,
+};
+
+/* of_* functions will be removed after merge of of_graph patches */
+static struct device_node *
+of_get_child_by_name_reg(struct device_node *parent, const char *name, u32 reg)
+{
+	struct device_node *np;
+
+	for_each_child_of_node(parent, np) {
+		u32 r;
+
+		if (!np->name || of_node_cmp(np->name, name))
+			continue;
+
+		if (of_property_read_u32(np, "reg", &r) < 0)
+			r = 0;
+
+		if (reg == r)
+			break;
+	}
+
+	return np;
+}
+
+static struct device_node *of_graph_get_port_by_reg(struct device_node *parent,
+						    u32 reg)
+{
+	struct device_node *ports, *port;
+
+	ports = of_get_child_by_name(parent, "ports");
+	if (ports)
+		parent = ports;
+
+	port = of_get_child_by_name_reg(parent, "port", reg);
+
+	of_node_put(ports);
+
+	return port;
+}
+
+static struct device_node *
+of_graph_get_endpoint_by_reg(struct device_node *port, u32 reg)
+{
+	return of_get_child_by_name_reg(port, "endpoint", reg);
+}
+
+static struct device_node *
+of_graph_get_remote_port_parent(const struct device_node *node)
+{
+	struct device_node *np;
+	unsigned int depth;
+
+	np = of_parse_phandle(node, "remote-endpoint", 0);
+
+	/* Walk 3 levels up only if there is 'ports' node. */
+	for (depth = 3; depth && np; depth--) {
+		np = of_get_next_parent(np);
+		if (depth == 2 && of_node_cmp(np->name, "ports"))
+			break;
+	}
+	return np;
+}
+
+enum {
+	FIMD_PORT_IN0,
+	FIMD_PORT_IN1,
+	FIMD_PORT_IN2,
+	FIMD_PORT_RGB,
+	FIMD_PORT_WRB,
+};
+
+static struct device_node *exynos_dpi_of_find_panel_node(struct device *dev)
+{
+	struct device_node *np, *ep;
+
+	np = of_graph_get_port_by_reg(dev->of_node, FIMD_PORT_RGB);
+	if (!np)
+		return NULL;
+
+	ep = of_graph_get_endpoint_by_reg(np, 0);
+	of_node_put(np);
+	if (!ep)
+		return NULL;
+
+	np = of_graph_get_remote_port_parent(ep);
+	of_node_put(ep);
+
+	return np;
+}
+
+static int exynos_dpi_parse_dt(struct exynos_dpi *ctx)
+{
+	struct device *dev = ctx->dev;
+	struct device_node *dn = dev->of_node;
+	struct device_node *np;
+
+	ctx->panel_node = exynos_dpi_of_find_panel_node(dev);
+
+	np = of_get_child_by_name(dn, "display-timings");
+	if (np) {
+		struct videomode *vm;
+		int ret;
+
+		of_node_put(np);
+
+		vm = devm_kzalloc(dev, sizeof(*ctx->vm), GFP_KERNEL);
+		if (!vm)
+			return -ENOMEM;
+
+		ret = of_get_videomode(dn, vm, 0);
+		if (ret < 0)
+			return ret;
+
+		ctx->vm = vm;
+
+		return 0;
+	}
+
+	if (!ctx->panel_node)
+		return -EINVAL;
+
+	return 0;
+}
+
+int exynos_dpi_probe(struct device *dev)
+{
+	struct exynos_dpi *ctx;
+	int ret;
+
+	ctx = devm_kzalloc(dev, sizeof(*ctx), GFP_KERNEL);
+	if (!ctx)
+		return -ENOMEM;
+
+	ctx->dev = dev;
+	exynos_dpi_display.ctx = ctx;
+	ctx->dpms_mode = DRM_MODE_DPMS_OFF;
+
+	ret = exynos_dpi_parse_dt(ctx);
+	if (ret < 0)
+		return ret;
+
+	exynos_drm_display_register(&exynos_dpi_display);
+
+	return 0;
+}
+
+int exynos_dpi_remove(struct device *dev)
+{
+	exynos_dpi_dpms(&exynos_dpi_display, DRM_MODE_DPMS_OFF);
+	exynos_drm_display_unregister(&exynos_dpi_display);
+
+	return 0;
+}
diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.h b/drivers/gpu/drm/exynos/exynos_drm_drv.h
index 1c78806..8bbc415 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_drv.h
+++ b/drivers/gpu/drm/exynos/exynos_drm_drv.h
@@ -361,6 +361,14 @@ int exynos_platform_device_ipp_register(void);
  */
 void exynos_platform_device_ipp_unregister(void);
 
+#ifdef CONFIG_DRM_EXYNOS_DPI
+int exynos_dpi_probe(struct device *dev);
+int exynos_dpi_remove(struct device *dev);
+#else
+int exynos_dpi_probe(struct device *dev) { return 0; }
+int exynos_dpi_remove(struct device *dev) { return 0; }
+#endif
+
 extern struct platform_driver dp_driver;
 extern struct platform_driver fimd_driver;
 extern struct platform_driver hdmi_driver;
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
index 10431b0..15d6b37 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
@@ -920,6 +920,8 @@ static int fimd_probe(struct platform_device *pdev)
 	fimd_manager.ctx = ctx;
 	exynos_drm_manager_register(&fimd_manager);
 
+	exynos_dpi_probe(ctx->dev);
+
 	pm_runtime_enable(dev);
 
 	for (win = 0; win < WINDOWS_NR; win++)
@@ -932,6 +934,8 @@ static int fimd_remove(struct platform_device *pdev)
 {
 	struct exynos_drm_manager *mgr = platform_get_drvdata(pdev);
 
+	exynos_dpi_remove(&pdev->dev);
+
 	exynos_drm_manager_unregister(&fimd_manager);
 
 	fimd_dpms(mgr, DRM_MODE_DPMS_OFF);
-- 
1.8.3.2

^ permalink raw reply related	[flat|nested] 17+ messages in thread

* [PATCH 6/9] ARM: dts: exynos4210-universal: add exynos/fimd node
  2014-03-17 10:27 [PATCH 0/9] Restore parallel display support for Exynos based boards Andrzej Hajda
                   ` (4 preceding siblings ...)
  2014-03-17 10:27 ` [PATCH 5/9] drm/exynos: restore parallel output interface support Andrzej Hajda
@ 2014-03-17 10:27 ` Andrzej Hajda
  2014-03-17 10:27 ` [PATCH 7/9] drm/modes: add polarization handling to mode conversion Andrzej Hajda
                   ` (3 subsequent siblings)
  9 siblings, 0 replies; 17+ messages in thread
From: Andrzej Hajda @ 2014-03-17 10:27 UTC (permalink / raw)
  To: dri-devel
  Cc: Mark Rutland, devicetree, linux-samsung-soc, Pawel Moll,
	Ian Campbell, Andrzej Hajda, Kyungmin Park, Rob Herring,
	Kumar Gala, Grant Likely, Denis Carikli, Marek Szyprowski

The patch adds fimd node with display timings for exynos4210-universal device.
It also makes LCD regulators always on. This allow to re-use panel initialized
by boot loader.

Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
---
 arch/arm/boot/dts/exynos4210-universal_c210.dts | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/arch/arm/boot/dts/exynos4210-universal_c210.dts b/arch/arm/boot/dts/exynos4210-universal_c210.dts
index d2e3f5f..21ca0b978 100644
--- a/arch/arm/boot/dts/exynos4210-universal_c210.dts
+++ b/arch/arm/boot/dts/exynos4210-universal_c210.dts
@@ -225,6 +225,7 @@
 					regulator-name = "VLCD+VMIPI_1.8V";
 					regulator-min-microvolt = <1800000>;
 					regulator-max-microvolt = <1800000>;
+					regulator-always-on;
 				};
 
 				ldo8_reg: LDO8 {
@@ -288,6 +289,7 @@
 					regulator-name = "VCC_3.0V_LCD";
 					regulator-min-microvolt = <3000000>;
 					regulator-max-microvolt = <3000000>;
+					regulator-always-on;
 				};
 
 				buck1_reg: BUCK1 {
@@ -345,6 +347,29 @@
 		};
 	};
 
+	fimd: fimd@11c00000 {
+		pinctrl-0 = <&lcd_clk>, <&lcd_data24>;
+		pinctrl-names = "default";
+		status = "okay";
+		display-timings {
+			timing {
+				clock-frequency = <23492370>;
+				hactive = <480>;
+				vactive = <800>;
+				hback-porch = <16>;
+				hfront-porch = <16>;
+				vback-porch = <2>;
+				vfront-porch = <28>;
+				hsync-len = <2>;
+				vsync-len = <1>;
+				hsync-active = <0>;
+				vsync-active = <0>;
+				de-active = <0>;
+				pixelclk-active = <0>;
+			};
+		};
+	};
+
 	pwm@139D0000 {
 		compatible = "samsung,s5p6440-pwm";
 		status = "okay";
-- 
1.8.3.2

^ permalink raw reply related	[flat|nested] 17+ messages in thread

* [PATCH 7/9] drm/modes: add polarization handling to mode conversion
  2014-03-17 10:27 [PATCH 0/9] Restore parallel display support for Exynos based boards Andrzej Hajda
                   ` (5 preceding siblings ...)
  2014-03-17 10:27 ` [PATCH 6/9] ARM: dts: exynos4210-universal: add exynos/fimd node Andrzej Hajda
@ 2014-03-17 10:27 ` Andrzej Hajda
  2014-03-17 10:27 ` [PATCH 8/9] drm/exynos/fimd: use polarization flags provided by drm_display_mode Andrzej Hajda
                   ` (2 subsequent siblings)
  9 siblings, 0 replies; 17+ messages in thread
From: Andrzej Hajda @ 2014-03-17 10:27 UTC (permalink / raw)
  To: dri-devel
  Cc: Andrzej Hajda, Mark Rutland, devicetree, linux-samsung-soc,
	Pawel Moll, Ian Campbell, Kyungmin Park, Rob Herring, Kumar Gala,
	Grant Likely, Sean Paul, Inki Dae, Marek Szyprowski,
	Denis Carikli

The patch adds conversion of DISPLAY_FLAGS_DE_* and DISPLAY_FLAGS_PIXDATA_*
flags to pol_flags in drm_display_mode_from_videomode function.

Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
---
 drivers/gpu/drm/drm_modes.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c
index b073315..5dbff8d 100644
--- a/drivers/gpu/drm/drm_modes.c
+++ b/drivers/gpu/drm/drm_modes.c
@@ -537,6 +537,17 @@ int drm_display_mode_from_videomode(const struct videomode *vm,
 		dmode->flags |= DRM_MODE_FLAG_DBLSCAN;
 	if (vm->flags & DISPLAY_FLAGS_DOUBLECLK)
 		dmode->flags |= DRM_MODE_FLAG_DBLCLK;
+
+	dmode->pol_flags = 0;
+	if (vm->flags & DISPLAY_FLAGS_DE_LOW)
+		dmode->pol_flags |= DRM_MODE_FLAG_POL_DE_NEGEDGE;
+	if (vm->flags & DISPLAY_FLAGS_DE_HIGH)
+		dmode->pol_flags |= DRM_MODE_FLAG_POL_DE_POSEDGE;
+	if (vm->flags & DISPLAY_FLAGS_PIXDATA_NEGEDGE)
+		dmode->pol_flags |= DRM_MODE_FLAG_POL_PIXDATA_NEGEDGE;
+	if (vm->flags & DISPLAY_FLAGS_PIXDATA_POSEDGE)
+		dmode->pol_flags |= DRM_MODE_FLAG_POL_PIXDATA_POSEDGE;
+
 	drm_mode_set_name(dmode);
 
 	return 0;
-- 
1.8.3.2

^ permalink raw reply related	[flat|nested] 17+ messages in thread

* [PATCH 8/9] drm/exynos/fimd: use polarization flags provided by drm_display_mode
  2014-03-17 10:27 [PATCH 0/9] Restore parallel display support for Exynos based boards Andrzej Hajda
                   ` (6 preceding siblings ...)
  2014-03-17 10:27 ` [PATCH 7/9] drm/modes: add polarization handling to mode conversion Andrzej Hajda
@ 2014-03-17 10:27 ` Andrzej Hajda
  2014-03-20  6:03   ` Inki Dae
       [not found] ` <1395052045-23848-1-git-send-email-a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
  2014-03-18 13:05 ` [PATCH 0/9] Restore parallel display support for Exynos based boards Tomasz Figa
  9 siblings, 1 reply; 17+ messages in thread
From: Andrzej Hajda @ 2014-03-17 10:27 UTC (permalink / raw)
  To: dri-devel
  Cc: Andrzej Hajda, Mark Rutland, devicetree, linux-samsung-soc,
	Pawel Moll, Ian Campbell, Kyungmin Park, Rob Herring, Kumar Gala,
	Grant Likely, Sean Paul, Inki Dae, Marek Szyprowski,
	Denis Carikli

The patch replaces fimd private bindings for signal polarization by
polarization flags provided by drm_display_mode.

Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
---
 drivers/gpu/drm/exynos/exynos_drm_fimd.c | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
index 15d6b37..dbfad4e 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
@@ -115,7 +115,6 @@ struct fimd_context {
 	unsigned int			default_win;
 	unsigned long			irq_flags;
 	u32				vidcon0;
-	u32				vidcon1;
 	bool				suspended;
 	int				pipe;
 	wait_queue_head_t		wait_vsync_queue;
@@ -232,7 +231,11 @@ static void fimd_commit(struct exynos_drm_manager *mgr)
 		return;
 
 	/* setup polarity values */
-	vidcon1 = ctx->vidcon1;
+	vidcon1 = 0;
+	if (mode->pol_flags & DRM_MODE_FLAG_POL_DE_NEGEDGE)
+		vidcon1 |= VIDCON1_INV_VDEN;
+	if (mode->pol_flags & DRM_MODE_FLAG_POL_PIXDATA_NEGEDGE)
+		vidcon1 |= VIDCON1_INV_VCLK;
 	if (mode->flags & DRM_MODE_FLAG_NVSYNC)
 		vidcon1 |= VIDCON1_INV_VSYNC;
 	if (mode->flags & DRM_MODE_FLAG_NHSYNC)
@@ -875,11 +878,6 @@ static int fimd_probe(struct platform_device *pdev)
 	ctx->dev = dev;
 	ctx->suspended = true;
 
-	if (of_property_read_bool(dev->of_node, "samsung,invert-vden"))
-		ctx->vidcon1 |= VIDCON1_INV_VDEN;
-	if (of_property_read_bool(dev->of_node, "samsung,invert-vclk"))
-		ctx->vidcon1 |= VIDCON1_INV_VCLK;
-
 	ctx->bus_clk = devm_clk_get(dev, "fimd");
 	if (IS_ERR(ctx->bus_clk)) {
 		dev_err(dev, "failed to get bus clock\n");
-- 
1.8.3.2

^ permalink raw reply related	[flat|nested] 17+ messages in thread

* [PATCH 9/9] drm/exynos/fimd: remove unused variable
       [not found] ` <1395052045-23848-1-git-send-email-a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
@ 2014-03-17 10:27   ` Andrzej Hajda
  2014-03-17 13:16     ` [PATCH v2 " Andrzej Hajda
  0 siblings, 1 reply; 17+ messages in thread
From: Andrzej Hajda @ 2014-03-17 10:27 UTC (permalink / raw)
  To: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
  Cc: Andrzej Hajda, Mark Rutland, devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA, Pawel Moll,
	Ian Campbell, Kyungmin Park, Rob Herring, Kumar Gala,
	Grant Likely, Sean Paul, Inki Dae, Marek Szyprowski,
	Denis Carikli

The patch removes unused vidcon0 field from fimd_context structure.

Signed-off-by: Andrzej Hajda <a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
---
 drivers/gpu/drm/exynos/exynos_drm_fimd.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
index dbfad4e..375ec66 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
@@ -114,7 +114,6 @@ struct fimd_context {
 	struct fimd_win_data		win_data[WINDOWS_NR];
 	unsigned int			default_win;
 	unsigned long			irq_flags;
-	u32				vidcon0;
 	bool				suspended;
 	int				pipe;
 	wait_queue_head_t		wait_vsync_queue;
@@ -270,8 +269,7 @@ static void fimd_commit(struct exynos_drm_manager *mgr)
 	writel(val, ctx->regs + driver_data->timing_base + VIDTCON2);
 
 	/* setup clock source, clock divider, enable dma. */
-	val = ctx->vidcon0;
-	val &= ~(VIDCON0_CLKVAL_F_MASK | VIDCON0_CLKDIR);
+	val = ~(VIDCON0_CLKVAL_F_MASK | VIDCON0_CLKDIR);
 
 	if (ctx->driver_data->has_clksel) {
 		val &= ~VIDCON0_CLKSEL_MASK;
-- 
1.8.3.2

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 17+ messages in thread

* [PATCH v2 5/9] drm/exynos: restore parallel output interface support
  2014-03-17 10:27 ` [PATCH 5/9] drm/exynos: restore parallel output interface support Andrzej Hajda
@ 2014-03-17 12:03   ` Andrzej Hajda
  0 siblings, 0 replies; 17+ messages in thread
From: Andrzej Hajda @ 2014-03-17 12:03 UTC (permalink / raw)
  To: dri-devel
  Cc: Mark Rutland, devicetree, linux-samsung-soc, Pawel Moll,
	Ian Campbell, Andrzej Hajda, Kyungmin Park, Rob Herring,
	Kumar Gala, Grant Likely, Denis Carikli, Marek Szyprowski

The patch adds parallel output interface to FIMD device driver.
It also restores support for panels initialized by boot loader,
but without proper kernel driver.
Driver uses video interface bindings to find connected panel.
It uses drm_panel interface to interact with the panel.

Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
---
v2:
- corrected stub definitions
---
 drivers/gpu/drm/exynos/Kconfig           |   8 +
 drivers/gpu/drm/exynos/Makefile          |   1 +
 drivers/gpu/drm/exynos/exynos_drm_dpi.c  | 339 +++++++++++++++++++++++++++++++
 drivers/gpu/drm/exynos/exynos_drm_drv.h  |   8 +
 drivers/gpu/drm/exynos/exynos_drm_fimd.c |   4 +
 5 files changed, 360 insertions(+)
 create mode 100644 drivers/gpu/drm/exynos/exynos_drm_dpi.c

diff --git a/drivers/gpu/drm/exynos/Kconfig b/drivers/gpu/drm/exynos/Kconfig
index 7eea698..56f9581 100644
--- a/drivers/gpu/drm/exynos/Kconfig
+++ b/drivers/gpu/drm/exynos/Kconfig
@@ -31,6 +31,14 @@ config DRM_EXYNOS_FIMD
 	help
 	  Choose this option if you want to use Exynos FIMD for DRM.
 
+config DRM_EXYNOS_DPI
+	bool "EXYNOS DRM parallel output support"
+	depends on DRM_EXYNOS
+	select DRM_PANEL
+	default n
+	help
+	  This enables support for Exynos parallel output.
+
 config DRM_EXYNOS_DP
 	bool "EXYNOS DRM DP driver support"
 	depends on DRM_EXYNOS && ARCH_EXYNOS
diff --git a/drivers/gpu/drm/exynos/Makefile b/drivers/gpu/drm/exynos/Makefile
index b1839e8..babcd52 100644
--- a/drivers/gpu/drm/exynos/Makefile
+++ b/drivers/gpu/drm/exynos/Makefile
@@ -11,6 +11,7 @@ exynosdrm-y := exynos_drm_drv.o exynos_drm_encoder.o \
 exynosdrm-$(CONFIG_DRM_EXYNOS_IOMMU) += exynos_drm_iommu.o
 exynosdrm-$(CONFIG_DRM_EXYNOS_DMABUF) += exynos_drm_dmabuf.o
 exynosdrm-$(CONFIG_DRM_EXYNOS_FIMD)	+= exynos_drm_fimd.o
+exynosdrm-$(CONFIG_DRM_EXYNOS_DPI)	+= exynos_drm_dpi.o
 exynosdrm-$(CONFIG_DRM_EXYNOS_DP)	+= exynos_dp_core.o exynos_dp_reg.o
 exynosdrm-$(CONFIG_DRM_EXYNOS_HDMI)	+= exynos_hdmi.o exynos_mixer.o
 exynosdrm-$(CONFIG_DRM_EXYNOS_VIDI)	+= exynos_drm_vidi.o
diff --git a/drivers/gpu/drm/exynos/exynos_drm_dpi.c b/drivers/gpu/drm/exynos/exynos_drm_dpi.c
new file mode 100644
index 0000000..2b09c7c
--- /dev/null
+++ b/drivers/gpu/drm/exynos/exynos_drm_dpi.c
@@ -0,0 +1,339 @@
+/*
+ * Exynos DRM Parallel output support.
+ *
+ * Copyright (c) 2014 Samsung Electronics Co., Ltd
+ *
+ * Contacts: Andrzej Hajda <a.hajda@samsung.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+*/
+
+#include <drm/drmP.h>
+#include <drm/drm_crtc_helper.h>
+#include <drm/drm_panel.h>
+
+#include <linux/regulator/consumer.h>
+
+#include <video/of_videomode.h>
+#include <video/videomode.h>
+
+#include "exynos_drm_drv.h"
+
+struct exynos_dpi {
+	struct device *dev;
+	struct device_node *panel_node;
+
+	struct drm_panel *panel;
+	struct drm_connector connector;
+	struct drm_encoder *encoder;
+
+	struct videomode *vm;
+	int dpms_mode;
+};
+
+#define connector_to_dpi(c) container_of(c, struct exynos_dpi, connector)
+
+static enum drm_connector_status
+exynos_dpi_detect(struct drm_connector *connector, bool force)
+{
+	struct exynos_dpi *ctx = connector_to_dpi(connector);
+
+	/* panels supported only by boot-loader are always connected */
+	if (!ctx->panel_node)
+		return connector_status_connected;
+
+	if (!ctx->panel) {
+		ctx->panel = of_drm_find_panel(ctx->panel_node);
+		if (ctx->panel)
+			drm_panel_attach(ctx->panel, &ctx->connector);
+	}
+
+	if (ctx->panel)
+		return connector_status_connected;
+
+	return connector_status_disconnected;
+}
+
+static void exynos_dpi_connector_destroy(struct drm_connector *connector)
+{
+	drm_sysfs_connector_remove(connector);
+	drm_connector_cleanup(connector);
+}
+
+static struct drm_connector_funcs exynos_dpi_connector_funcs = {
+	.dpms = drm_helper_connector_dpms,
+	.detect = exynos_dpi_detect,
+	.fill_modes = drm_helper_probe_single_connector_modes,
+	.destroy = exynos_dpi_connector_destroy,
+};
+
+static int exynos_dpi_get_modes(struct drm_connector *connector)
+{
+	struct exynos_dpi *ctx = connector_to_dpi(connector);
+
+	/* fimd timings gets precedence over panel modes */
+	if (ctx->vm) {
+		struct drm_display_mode *mode;
+
+		mode = drm_mode_create(connector->dev);
+		if (!mode) {
+			DRM_ERROR("failed to create a new display mode\n");
+			return 0;
+		}
+		drm_display_mode_from_videomode(ctx->vm, mode);
+		mode->type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED;
+		drm_mode_probed_add(connector, mode);
+		return 1;
+	}
+
+	if (ctx->panel)
+		return ctx->panel->funcs->get_modes(ctx->panel);
+
+	return 0;
+}
+
+static int exynos_dpi_mode_valid(struct drm_connector *connector,
+				 struct drm_display_mode *mode)
+{
+	return MODE_OK;
+}
+
+static struct drm_encoder *
+exynos_dpi_best_encoder(struct drm_connector *connector)
+{
+	struct exynos_dpi *ctx = connector_to_dpi(connector);
+
+	return ctx->encoder;
+}
+
+static struct drm_connector_helper_funcs exynos_dpi_connector_helper_funcs = {
+	.get_modes = exynos_dpi_get_modes,
+	.mode_valid = exynos_dpi_mode_valid,
+	.best_encoder = exynos_dpi_best_encoder,
+};
+
+static int exynos_dpi_create_connector(struct exynos_drm_display *display,
+				       struct drm_encoder *encoder)
+{
+	struct exynos_dpi *ctx = display->ctx;
+	struct drm_connector *connector = &ctx->connector;
+	int ret;
+
+	ctx->encoder = encoder;
+
+	if (ctx->panel_node)
+		connector->polled = DRM_CONNECTOR_POLL_CONNECT;
+	else
+		connector->polled = DRM_CONNECTOR_POLL_HPD;
+
+	ret = drm_connector_init(encoder->dev, connector,
+				 &exynos_dpi_connector_funcs,
+				 DRM_MODE_CONNECTOR_VGA);
+	if (ret) {
+		DRM_ERROR("failed to initialize connector with drm\n");
+		return ret;
+	}
+
+	drm_connector_helper_add(connector, &exynos_dpi_connector_helper_funcs);
+	drm_sysfs_connector_add(connector);
+	drm_mode_connector_attach_encoder(connector, encoder);
+
+	return 0;
+}
+
+static void exynos_dpi_poweron(struct exynos_dpi *ctx)
+{
+	if (ctx->panel)
+		drm_panel_enable(ctx->panel);
+}
+
+static void exynos_dpi_poweroff(struct exynos_dpi *ctx)
+{
+	if (ctx->panel)
+		drm_panel_disable(ctx->panel);
+}
+
+static void exynos_dpi_dpms(struct exynos_drm_display *display, int mode)
+{
+	struct exynos_dpi *ctx = display->ctx;
+
+	switch (mode) {
+	case DRM_MODE_DPMS_ON:
+		if (ctx->dpms_mode != DRM_MODE_DPMS_ON)
+				exynos_dpi_poweron(ctx);
+			break;
+	case DRM_MODE_DPMS_STANDBY:
+	case DRM_MODE_DPMS_SUSPEND:
+	case DRM_MODE_DPMS_OFF:
+		if (ctx->dpms_mode == DRM_MODE_DPMS_ON)
+			exynos_dpi_poweroff(ctx);
+		break;
+	default:
+		break;
+	};
+	ctx->dpms_mode = mode;
+}
+
+static struct exynos_drm_display_ops exynos_dpi_display_ops = {
+	.create_connector = exynos_dpi_create_connector,
+	.dpms = exynos_dpi_dpms
+};
+
+static struct exynos_drm_display exynos_dpi_display = {
+	.type = EXYNOS_DISPLAY_TYPE_LCD,
+	.ops = &exynos_dpi_display_ops,
+};
+
+/* of_* functions will be removed after merge of of_graph patches */
+static struct device_node *
+of_get_child_by_name_reg(struct device_node *parent, const char *name, u32 reg)
+{
+	struct device_node *np;
+
+	for_each_child_of_node(parent, np) {
+		u32 r;
+
+		if (!np->name || of_node_cmp(np->name, name))
+			continue;
+
+		if (of_property_read_u32(np, "reg", &r) < 0)
+			r = 0;
+
+		if (reg == r)
+			break;
+	}
+
+	return np;
+}
+
+static struct device_node *of_graph_get_port_by_reg(struct device_node *parent,
+						    u32 reg)
+{
+	struct device_node *ports, *port;
+
+	ports = of_get_child_by_name(parent, "ports");
+	if (ports)
+		parent = ports;
+
+	port = of_get_child_by_name_reg(parent, "port", reg);
+
+	of_node_put(ports);
+
+	return port;
+}
+
+static struct device_node *
+of_graph_get_endpoint_by_reg(struct device_node *port, u32 reg)
+{
+	return of_get_child_by_name_reg(port, "endpoint", reg);
+}
+
+static struct device_node *
+of_graph_get_remote_port_parent(const struct device_node *node)
+{
+	struct device_node *np;
+	unsigned int depth;
+
+	np = of_parse_phandle(node, "remote-endpoint", 0);
+
+	/* Walk 3 levels up only if there is 'ports' node. */
+	for (depth = 3; depth && np; depth--) {
+		np = of_get_next_parent(np);
+		if (depth == 2 && of_node_cmp(np->name, "ports"))
+			break;
+	}
+	return np;
+}
+
+enum {
+	FIMD_PORT_IN0,
+	FIMD_PORT_IN1,
+	FIMD_PORT_IN2,
+	FIMD_PORT_RGB,
+	FIMD_PORT_WRB,
+};
+
+static struct device_node *exynos_dpi_of_find_panel_node(struct device *dev)
+{
+	struct device_node *np, *ep;
+
+	np = of_graph_get_port_by_reg(dev->of_node, FIMD_PORT_RGB);
+	if (!np)
+		return NULL;
+
+	ep = of_graph_get_endpoint_by_reg(np, 0);
+	of_node_put(np);
+	if (!ep)
+		return NULL;
+
+	np = of_graph_get_remote_port_parent(ep);
+	of_node_put(ep);
+
+	return np;
+}
+
+static int exynos_dpi_parse_dt(struct exynos_dpi *ctx)
+{
+	struct device *dev = ctx->dev;
+	struct device_node *dn = dev->of_node;
+	struct device_node *np;
+
+	ctx->panel_node = exynos_dpi_of_find_panel_node(dev);
+
+	np = of_get_child_by_name(dn, "display-timings");
+	if (np) {
+		struct videomode *vm;
+		int ret;
+
+		of_node_put(np);
+
+		vm = devm_kzalloc(dev, sizeof(*ctx->vm), GFP_KERNEL);
+		if (!vm)
+			return -ENOMEM;
+
+		ret = of_get_videomode(dn, vm, 0);
+		if (ret < 0)
+			return ret;
+
+		ctx->vm = vm;
+
+		return 0;
+	}
+
+	if (!ctx->panel_node)
+		return -EINVAL;
+
+	return 0;
+}
+
+int exynos_dpi_probe(struct device *dev)
+{
+	struct exynos_dpi *ctx;
+	int ret;
+
+	ctx = devm_kzalloc(dev, sizeof(*ctx), GFP_KERNEL);
+	if (!ctx)
+		return -ENOMEM;
+
+	ctx->dev = dev;
+	exynos_dpi_display.ctx = ctx;
+	ctx->dpms_mode = DRM_MODE_DPMS_OFF;
+
+	ret = exynos_dpi_parse_dt(ctx);
+	if (ret < 0)
+		return ret;
+
+	exynos_drm_display_register(&exynos_dpi_display);
+
+	return 0;
+}
+
+int exynos_dpi_remove(struct device *dev)
+{
+	exynos_dpi_dpms(&exynos_dpi_display, DRM_MODE_DPMS_OFF);
+	exynos_drm_display_unregister(&exynos_dpi_display);
+
+	return 0;
+}
diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.h b/drivers/gpu/drm/exynos/exynos_drm_drv.h
index 1c78806..2d892f3 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_drv.h
+++ b/drivers/gpu/drm/exynos/exynos_drm_drv.h
@@ -361,6 +361,14 @@ int exynos_platform_device_ipp_register(void);
  */
 void exynos_platform_device_ipp_unregister(void);
 
+#ifdef CONFIG_DRM_EXYNOS_DPI
+int exynos_dpi_probe(struct device *dev);
+int exynos_dpi_remove(struct device *dev);
+#else
+static inline int exynos_dpi_probe(struct device *dev) { return 0; }
+static inline int exynos_dpi_remove(struct device *dev) { return 0; }
+#endif
+
 extern struct platform_driver dp_driver;
 extern struct platform_driver fimd_driver;
 extern struct platform_driver hdmi_driver;
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
index 10431b0..15d6b37 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
@@ -920,6 +920,8 @@ static int fimd_probe(struct platform_device *pdev)
 	fimd_manager.ctx = ctx;
 	exynos_drm_manager_register(&fimd_manager);
 
+	exynos_dpi_probe(ctx->dev);
+
 	pm_runtime_enable(dev);
 
 	for (win = 0; win < WINDOWS_NR; win++)
@@ -932,6 +934,8 @@ static int fimd_remove(struct platform_device *pdev)
 {
 	struct exynos_drm_manager *mgr = platform_get_drvdata(pdev);
 
+	exynos_dpi_remove(&pdev->dev);
+
 	exynos_drm_manager_unregister(&fimd_manager);
 
 	fimd_dpms(mgr, DRM_MODE_DPMS_OFF);
-- 
1.8.3.2

^ permalink raw reply related	[flat|nested] 17+ messages in thread

* [PATCH v2 9/9] drm/exynos/fimd: remove unused variable
  2014-03-17 10:27   ` [PATCH 9/9] drm/exynos/fimd: remove unused variable Andrzej Hajda
@ 2014-03-17 13:16     ` Andrzej Hajda
  0 siblings, 0 replies; 17+ messages in thread
From: Andrzej Hajda @ 2014-03-17 13:16 UTC (permalink / raw)
  To: dri-devel
  Cc: Mark Rutland, devicetree, linux-samsung-soc, Pawel Moll,
	Ian Campbell, Andrzej Hajda, Kyungmin Park, Rob Herring,
	Kumar Gala, Grant Likely, Denis Carikli, Marek Szyprowski

The patch removes unused vidcon0 field from fimd_context structure.

Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
---
v2:
- corrected vidcon0 calculation
---
 drivers/gpu/drm/exynos/exynos_drm_fimd.c | 20 ++++++--------------
 1 file changed, 6 insertions(+), 14 deletions(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
index dbfad4e..158d53a 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
@@ -114,7 +114,6 @@ struct fimd_context {
 	struct fimd_win_data		win_data[WINDOWS_NR];
 	unsigned int			default_win;
 	unsigned long			irq_flags;
-	u32				vidcon0;
 	bool				suspended;
 	int				pipe;
 	wait_queue_head_t		wait_vsync_queue;
@@ -269,26 +268,19 @@ static void fimd_commit(struct exynos_drm_manager *mgr)
 	       VIDTCON2_HOZVAL_E(mode->hdisplay - 1);
 	writel(val, ctx->regs + driver_data->timing_base + VIDTCON2);
 
-	/* setup clock source, clock divider, enable dma. */
-	val = ctx->vidcon0;
-	val &= ~(VIDCON0_CLKVAL_F_MASK | VIDCON0_CLKDIR);
+	/*
+	 * fields of register with prefix '_F' would be updated
+	 * at vsync(same as dma start)
+	 */
+	val = VIDCON0_ENVID | VIDCON0_ENVID_F;
 
-	if (ctx->driver_data->has_clksel) {
-		val &= ~VIDCON0_CLKSEL_MASK;
+	if (ctx->driver_data->has_clksel)
 		val |= VIDCON0_CLKSEL_LCD;
-	}
 
 	clkdiv = fimd_calc_clkdiv(ctx, mode);
 	if (clkdiv > 1)
 		val |= VIDCON0_CLKVAL_F(clkdiv - 1) | VIDCON0_CLKDIR;
-	else
-		val &= ~VIDCON0_CLKDIR;	/* 1:1 clock */
 
-	/*
-	 * fields of register with prefix '_F' would be updated
-	 * at vsync(same as dma start)
-	 */
-	val |= VIDCON0_ENVID | VIDCON0_ENVID_F;
 	writel(val, ctx->regs + VIDCON0);
 }
 
-- 
1.8.3.2

^ permalink raw reply related	[flat|nested] 17+ messages in thread

* Re: [PATCH 0/9] Restore parallel display support for Exynos based boards
  2014-03-17 10:27 [PATCH 0/9] Restore parallel display support for Exynos based boards Andrzej Hajda
                   ` (8 preceding siblings ...)
       [not found] ` <1395052045-23848-1-git-send-email-a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
@ 2014-03-18 13:05 ` Tomasz Figa
  9 siblings, 0 replies; 17+ messages in thread
From: Tomasz Figa @ 2014-03-18 13:05 UTC (permalink / raw)
  To: Andrzej Hajda, dri-devel
  Cc: Mark Rutland, devicetree, linux-samsung-soc, Pawel Moll,
	Ian Campbell, Denis Carikli, Kyungmin Park, Rob Herring,
	Kumar Gala, Grant Likely, Marek Szyprowski

Hi Andrzej,

On 17.03.2014 11:27, Andrzej Hajda wrote:
> Hi,
>
> This patch set restores parallel display support removed during exynos
> refactorization. It is rebased on the latest exynos-drm-next branch plus patch
> adding polarization flags to drm_display_mode [1].
>
> [1]: http://permalink.gmane.org/gmane.linux.drivers.driver-project.devel/47216
>
> Regards
> Andrzej
>
>
> Andrzej Hajda (9):
>    drm/exynos: delay fbdev initialization until an output is connected
>    drm/exynos: init kms poll after creation of connectors
>    drm/exynos: correct timing porch conversion
>    exynos/fimd: add parallel output related bindings
>    drm/exynos: restore parallel output interface support
>    ARM: dts: exynos4210-universal: add exynos/fimd node
>    drm/modes: add polarization handling to mode conversion
>    drm/exynos/fimd: use polarization flags provided by drm_display_mode
>    drm/exynos/fimd: remove unused variable
>
>   .../devicetree/bindings/video/samsung-fimd.txt     |  15 +
>   arch/arm/boot/dts/exynos4210-universal_c210.dts    |  25 ++
>   drivers/gpu/drm/drm_modes.c                        |  11 +
>   drivers/gpu/drm/exynos/Kconfig                     |   8 +
>   drivers/gpu/drm/exynos/Makefile                    |   1 +
>   drivers/gpu/drm/exynos/exynos_drm_dpi.c            | 339 +++++++++++++++++++++
>   drivers/gpu/drm/exynos/exynos_drm_drv.c            |  22 +-
>   drivers/gpu/drm/exynos/exynos_drm_drv.h            |   8 +
>   drivers/gpu/drm/exynos/exynos_drm_fb.c             |   3 +
>   drivers/gpu/drm/exynos/exynos_drm_fimd.c           |  32 +-
>   10 files changed, 432 insertions(+), 32 deletions(-)
>   create mode 100644 drivers/gpu/drm/exynos/exynos_drm_dpi.c
>

Including the V2 fixups sent for particular patches:

Reviewed-by: Tomasz Figa <t.figa@samsung.com>

Will try to test on one of my boards with parallel displays soon.

Best regards,
Tomasz

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH 8/9] drm/exynos/fimd: use polarization flags provided by drm_display_mode
  2014-03-17 10:27 ` [PATCH 8/9] drm/exynos/fimd: use polarization flags provided by drm_display_mode Andrzej Hajda
@ 2014-03-20  6:03   ` Inki Dae
  2014-03-20  7:01     ` Andrzej Hajda
  2014-03-20 13:26     ` [PATCH] ARM: dts: exynos4210-universal: add fimd polarization settings Andrzej Hajda
  0 siblings, 2 replies; 17+ messages in thread
From: Inki Dae @ 2014-03-20  6:03 UTC (permalink / raw)
  To: Andrzej Hajda
  Cc: Mark Rutland, devicetree, linux-samsung-soc, Pawel Moll,
	Ian Campbell, DRI mailing list, Denis Carikli, Kyungmin Park,
	Rob Herring, Kumar Gala, Grant Likely, Marek Szyprowski

Thanks for your contributions,


2014-03-17 19:27 GMT+09:00 Andrzej Hajda <a.hajda@samsung.com>:
> The patch replaces fimd private bindings for signal polarization by
> polarization flags provided by drm_display_mode.
>

This patch needs below patch not merged yet,
     drm: drm_display_mode: add signal polarity flags

So let me pick up all of your path series except for patch 7 and 8.
And for these two patches, later.

Your opinion?

Thanks,
Inki Dae

> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
> ---
>  drivers/gpu/drm/exynos/exynos_drm_fimd.c | 12 +++++-------
>  1 file changed, 5 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> index 15d6b37..dbfad4e 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> @@ -115,7 +115,6 @@ struct fimd_context {
>         unsigned int                    default_win;
>         unsigned long                   irq_flags;
>         u32                             vidcon0;
> -       u32                             vidcon1;
>         bool                            suspended;
>         int                             pipe;
>         wait_queue_head_t               wait_vsync_queue;
> @@ -232,7 +231,11 @@ static void fimd_commit(struct exynos_drm_manager *mgr)
>                 return;
>
>         /* setup polarity values */
> -       vidcon1 = ctx->vidcon1;
> +       vidcon1 = 0;
> +       if (mode->pol_flags & DRM_MODE_FLAG_POL_DE_NEGEDGE)
> +               vidcon1 |= VIDCON1_INV_VDEN;
> +       if (mode->pol_flags & DRM_MODE_FLAG_POL_PIXDATA_NEGEDGE)
> +               vidcon1 |= VIDCON1_INV_VCLK;
>         if (mode->flags & DRM_MODE_FLAG_NVSYNC)
>                 vidcon1 |= VIDCON1_INV_VSYNC;
>         if (mode->flags & DRM_MODE_FLAG_NHSYNC)
> @@ -875,11 +878,6 @@ static int fimd_probe(struct platform_device *pdev)
>         ctx->dev = dev;
>         ctx->suspended = true;
>
> -       if (of_property_read_bool(dev->of_node, "samsung,invert-vden"))
> -               ctx->vidcon1 |= VIDCON1_INV_VDEN;
> -       if (of_property_read_bool(dev->of_node, "samsung,invert-vclk"))
> -               ctx->vidcon1 |= VIDCON1_INV_VCLK;
> -
>         ctx->bus_clk = devm_clk_get(dev, "fimd");
>         if (IS_ERR(ctx->bus_clk)) {
>                 dev_err(dev, "failed to get bus clock\n");
> --
> 1.8.3.2
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH 8/9] drm/exynos/fimd: use polarization flags provided by drm_display_mode
  2014-03-20  6:03   ` Inki Dae
@ 2014-03-20  7:01     ` Andrzej Hajda
  2014-03-20 13:26     ` [PATCH] ARM: dts: exynos4210-universal: add fimd polarization settings Andrzej Hajda
  1 sibling, 0 replies; 17+ messages in thread
From: Andrzej Hajda @ 2014-03-20  7:01 UTC (permalink / raw)
  To: Inki Dae
  Cc: Mark Rutland, devicetree, linux-samsung-soc, Pawel Moll,
	Ian Campbell, DRI mailing list, Denis Carikli, Kyungmin Park,
	Rob Herring, Kumar Gala, Grant Likely, Marek Szyprowski

On 03/20/2014 07:03 AM, Inki Dae wrote:
> Thanks for your contributions,
> 
> 
> 2014-03-17 19:27 GMT+09:00 Andrzej Hajda <a.hajda@samsung.com>:
>> The patch replaces fimd private bindings for signal polarization by
>> polarization flags provided by drm_display_mode.
>>
> 
> This patch needs below patch not merged yet,
>      drm: drm_display_mode: add signal polarity flags
> 
> So let me pick up all of your path series except for patch 7 and 8.
> And for these two patches, later.
> 
> Your opinion?

Yes, please do it.

Regards
Andrzej

> 
> Thanks,
> Inki Dae
> 
>> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
>> ---
>>  drivers/gpu/drm/exynos/exynos_drm_fimd.c | 12 +++++-------
>>  1 file changed, 5 insertions(+), 7 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
>> index 15d6b37..dbfad4e 100644
>> --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
>> +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
>> @@ -115,7 +115,6 @@ struct fimd_context {
>>         unsigned int                    default_win;
>>         unsigned long                   irq_flags;
>>         u32                             vidcon0;
>> -       u32                             vidcon1;
>>         bool                            suspended;
>>         int                             pipe;
>>         wait_queue_head_t               wait_vsync_queue;
>> @@ -232,7 +231,11 @@ static void fimd_commit(struct exynos_drm_manager *mgr)
>>                 return;
>>
>>         /* setup polarity values */
>> -       vidcon1 = ctx->vidcon1;
>> +       vidcon1 = 0;
>> +       if (mode->pol_flags & DRM_MODE_FLAG_POL_DE_NEGEDGE)
>> +               vidcon1 |= VIDCON1_INV_VDEN;
>> +       if (mode->pol_flags & DRM_MODE_FLAG_POL_PIXDATA_NEGEDGE)
>> +               vidcon1 |= VIDCON1_INV_VCLK;
>>         if (mode->flags & DRM_MODE_FLAG_NVSYNC)
>>                 vidcon1 |= VIDCON1_INV_VSYNC;
>>         if (mode->flags & DRM_MODE_FLAG_NHSYNC)
>> @@ -875,11 +878,6 @@ static int fimd_probe(struct platform_device *pdev)
>>         ctx->dev = dev;
>>         ctx->suspended = true;
>>
>> -       if (of_property_read_bool(dev->of_node, "samsung,invert-vden"))
>> -               ctx->vidcon1 |= VIDCON1_INV_VDEN;
>> -       if (of_property_read_bool(dev->of_node, "samsung,invert-vclk"))
>> -               ctx->vidcon1 |= VIDCON1_INV_VCLK;
>> -
>>         ctx->bus_clk = devm_clk_get(dev, "fimd");
>>         if (IS_ERR(ctx->bus_clk)) {
>>                 dev_err(dev, "failed to get bus clock\n");
>> --
>> 1.8.3.2
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 17+ messages in thread

* [PATCH] ARM: dts: exynos4210-universal: add fimd polarization settings
  2014-03-20  6:03   ` Inki Dae
  2014-03-20  7:01     ` Andrzej Hajda
@ 2014-03-20 13:26     ` Andrzej Hajda
  2014-03-21  5:36       ` Inki Dae
  1 sibling, 1 reply; 17+ messages in thread
From: Andrzej Hajda @ 2014-03-20 13:26 UTC (permalink / raw)
  To: Inki Dae
  Cc: linux-samsung-soc, Denis Carikli, DRI mailing list,
	Andrzej Hajda, Kyungmin Park, Marek Szyprowski

The patch adds polarization flags to fimd node.
It fixes parallel display support.

Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
---
Hi Inki,

Since polarization patches were not merged, polarization
settings should be provided to fimd via properties.
This patch fixes it.

Regards
Andrzej
---
 arch/arm/boot/dts/exynos4210-universal_c210.dts | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/boot/dts/exynos4210-universal_c210.dts b/arch/arm/boot/dts/exynos4210-universal_c210.dts
index 21ca0b978..477208d 100644
--- a/arch/arm/boot/dts/exynos4210-universal_c210.dts
+++ b/arch/arm/boot/dts/exynos4210-universal_c210.dts
@@ -351,6 +351,8 @@
 		pinctrl-0 = <&lcd_clk>, <&lcd_data24>;
 		pinctrl-names = "default";
 		status = "okay";
+		samsung,invert-vden;
+		samsung,invert-vclk;
 		display-timings {
 			timing {
 				clock-frequency = <23492370>;
-- 
1.8.3.2

^ permalink raw reply related	[flat|nested] 17+ messages in thread

* Re: [PATCH] ARM: dts: exynos4210-universal: add fimd polarization settings
  2014-03-20 13:26     ` [PATCH] ARM: dts: exynos4210-universal: add fimd polarization settings Andrzej Hajda
@ 2014-03-21  5:36       ` Inki Dae
  0 siblings, 0 replies; 17+ messages in thread
From: Inki Dae @ 2014-03-21  5:36 UTC (permalink / raw)
  To: Andrzej Hajda
  Cc: linux-samsung-soc, Denis Carikli, DRI mailing list,
	Kyungmin Park, Marek Szyprowski

Hi Andrzej,


2014-03-20 22:26 GMT+09:00 Andrzej Hajda <a.hajda@samsung.com>:
> The patch adds polarization flags to fimd node.
> It fixes parallel display support.
>
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
> ---
> Hi Inki,
>
> Since polarization patches were not merged, polarization
> settings should be provided to fimd via properties.
> This patch fixes it.
>

Just let me integrate it to old one, 'ARM: dts: exynos4210-universal:
add exynos/fimd node'.

Thanks,
Inki Dae

> Regards
> Andrzej
> ---
>  arch/arm/boot/dts/exynos4210-universal_c210.dts | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4210-universal_c210.dts b/arch/arm/boot/dts/exynos4210-universal_c210.dts
> index 21ca0b978..477208d 100644
> --- a/arch/arm/boot/dts/exynos4210-universal_c210.dts
> +++ b/arch/arm/boot/dts/exynos4210-universal_c210.dts
> @@ -351,6 +351,8 @@
>                 pinctrl-0 = <&lcd_clk>, <&lcd_data24>;
>                 pinctrl-names = "default";
>                 status = "okay";
> +               samsung,invert-vden;
> +               samsung,invert-vclk;
>                 display-timings {
>                         timing {
>                                 clock-frequency = <23492370>;
> --
> 1.8.3.2
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 17+ messages in thread

end of thread, other threads:[~2014-03-21  5:36 UTC | newest]

Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-03-17 10:27 [PATCH 0/9] Restore parallel display support for Exynos based boards Andrzej Hajda
2014-03-17 10:27 ` [PATCH 1/9] drm/exynos: delay fbdev initialization until an output is connected Andrzej Hajda
2014-03-17 10:27 ` [PATCH 2/9] drm/exynos: init kms poll after creation of connectors Andrzej Hajda
2014-03-17 10:27 ` [PATCH 3/9] drm/exynos: correct timing porch conversion Andrzej Hajda
2014-03-17 10:27 ` [PATCH 4/9] exynos/fimd: add parallel output related bindings Andrzej Hajda
2014-03-17 10:27 ` [PATCH 5/9] drm/exynos: restore parallel output interface support Andrzej Hajda
2014-03-17 12:03   ` [PATCH v2 " Andrzej Hajda
2014-03-17 10:27 ` [PATCH 6/9] ARM: dts: exynos4210-universal: add exynos/fimd node Andrzej Hajda
2014-03-17 10:27 ` [PATCH 7/9] drm/modes: add polarization handling to mode conversion Andrzej Hajda
2014-03-17 10:27 ` [PATCH 8/9] drm/exynos/fimd: use polarization flags provided by drm_display_mode Andrzej Hajda
2014-03-20  6:03   ` Inki Dae
2014-03-20  7:01     ` Andrzej Hajda
2014-03-20 13:26     ` [PATCH] ARM: dts: exynos4210-universal: add fimd polarization settings Andrzej Hajda
2014-03-21  5:36       ` Inki Dae
     [not found] ` <1395052045-23848-1-git-send-email-a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-03-17 10:27   ` [PATCH 9/9] drm/exynos/fimd: remove unused variable Andrzej Hajda
2014-03-17 13:16     ` [PATCH v2 " Andrzej Hajda
2014-03-18 13:05 ` [PATCH 0/9] Restore parallel display support for Exynos based boards Tomasz Figa

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.