From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1702CC4167B for ; Tue, 28 Nov 2023 01:38:05 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 31E7E10E40D; Tue, 28 Nov 2023 01:38:04 +0000 (UTC) Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by gabe.freedesktop.org (Postfix) with ESMTPS id BC1B210E40D for ; Tue, 28 Nov 2023 01:38:01 +0000 (UTC) Received: by mail-lf1-x136.google.com with SMTP id 2adb3069b0e04-5079f6efd64so6655074e87.2 for ; Mon, 27 Nov 2023 17:38:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701135480; x=1701740280; darn=lists.freedesktop.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=N6kokAHXUJv+HlCSPR82UEkh5i4zBVaRZfr1LTFro7w=; b=OTbStNezAPxG8+MZV6mlHIjYSA2raE18CKw+x9J2u73DeYRdIeuMAFulkUAGzWbvkg 83dJyncxbFrR1paXd0Pk4ffkuOjyVm6moa6djDf5q0R6uI84Hs0zPyO3dx2kZaG3bLJk xhDk8ImAbmKLR/X69FyOYz2mLtg/mfXHFRuuFD4F3zevDoMYrXuYm8iaci2+QmY2CRI5 ZmzmxzFGVJM2z29SsZ6fhvNR77EtF5BmKSzPgnkDjKLM+3KvREiiDU97XLlrQozAOVMh ZxpTyChFe5dzvozEtBPUprdrDQLU3XFQodKaGyRmmYsyUYRd+KVlMmhmieyZ6rcptqej mFLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701135480; x=1701740280; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=N6kokAHXUJv+HlCSPR82UEkh5i4zBVaRZfr1LTFro7w=; b=fXWWnYT6tFXk2NDcQHcQEFUUB9NXoKmSr6EQPdmeFu/AnH+VRhFsECh9RE8uFeISlW Plbmf5qDGJRUjL/8aI2nMdQgmVqWFuqkbjMUC15DdhLEinbKi9s8j4eiIq20cNFDiuAB V+NPOveIJG1Xnpcsj3skhAWiQ9m/MsXoyudnOP1QYWIFY8rP9v9XWkdGlLRR+E2PkJDu 9nZDtNWy/uULYY5AKfnnLKjsWp1boKG/wt4ha8121KUrA5utj7aI8UTarybwmnzQzLhx JvPqzOkikQ5f/qP4p1gHO3DH5NG6E5X4e0lYrseGPgWQOGDiB9POzBUsEAN7HxYWL9dU IAJA== X-Gm-Message-State: AOJu0Ywqw7c4Sfc1lwXFYncADD5dBEbwZGhiR4zgquk1S90QCZf9iZic jUQuKJhi7R8AnE+TX+mjtipfwfytytG+4hylgX8= X-Google-Smtp-Source: AGHT+IHJmNVk/46P3cx1R68VqOfflKovRECF96SXozFXM95kE9+CRrgAPRNQXTvZTco9QexMc//PoCuBlqcn7oGygUU= X-Received: by 2002:a05:6512:3b0b:b0:509:459b:13ae with SMTP id f11-20020a0565123b0b00b00509459b13aemr11404505lfv.53.1701135479567; Mon, 27 Nov 2023 17:37:59 -0800 (PST) MIME-Version: 1.0 References: <20231120225537.1270358-1-inki.dae@samsung.com> In-Reply-To: From: Inki Dae Date: Tue, 28 Nov 2023 10:37:48 +0900 Message-ID: Subject: Re: [GIT PULL] exynos-drm-fixes To: Dave Airlie Content-Type: multipart/alternative; boundary="000000000000f97bb9060b2c77c0" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dave Airlie , linux-samsung-soc@vger.kernel.org, DRI mailing list Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --000000000000f97bb9060b2c77c0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Dave, 2023=EB=85=84 11=EC=9B=94 24=EC=9D=BC (=EA=B8=88) =EC=98=A4=EC=A0=84 10:14,= Dave Airlie =EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1: > On Tue, 21 Nov 2023 at 09:00, Inki Dae wrote: > > > > Hi Dave and Daniel, > > > > Two fixups - fixing a potential error pointer dereference and wrong > > error checking. > Hi Inki, > > This fails to build on arm32, and it seems one of the fixes is wrong > > [airlied@dreadlord drm-fixes]$ make ARCH=3Darm > CROSS_COMPILE=3Darm-linux-gnu- O=3D../../arm-build-fixes/ -j16 > make[1]: Entering directory '/home/airlied/devel/kernel/arm-build-fixes' > GEN Makefile > CALL > /home/airlied/devel/kernel/dim/drm-fixes/scripts/checksyscalls.sh > CC [M] drivers/gpu/drm/exynos/exynos_drm_dma.o > > /home/airlied/devel/kernel/dim/drm-fixes/drivers/gpu/drm/exynos/exynos_dr= m_dma.c: > In function =E2=80=98exynos_drm_register_dma=E2=80=99: > > /home/airlied/devel/kernel/dim/drm-fixes/drivers/gpu/drm/exynos/exynos_dr= m_dma.c:119:40: > error: passing argument 1 of =E2=80=98PTR_ERR=E2=80=99 makes pointer from= integer > without a cast [-Werror=3Dint-conversion] > 119 | return PTR_ERR(-ENODEV); > In file included from > /home/airlied/devel/kernel/dim/drm-fixes/include/linux/string.h:9, > from > /home/airlied/devel/kernel/dim/drm-fixes/include/linux/dma-mapping.h:7, > from > /home/airlied/devel/kernel/dim/drm-fixes/include/linux/dma-map-ops.h:9, > from > > /home/airlied/devel/kernel/dim/drm-fixes/drivers/gpu/drm/exynos/exynos_dr= m_dma.c:7: > /home/airlied/devel/kernel/dim/drm-fixes/include/linux/err.h:49:61: > note: expected =E2=80=98const void *=E2=80=99 but argument is of type =E2= =80=98int=E2=80=99 > 49 | static inline long __must_check PTR_ERR(__force const void *ptr) > | ~~~~~~~~~~~~^~~ > cc1: all warnings being treated as errors > > I think it should just be return -ENODEV, since the function returns an > int. > > Please fix it up and resend. > Really sorry for this. Will resend after fixing it. Thanks, Inki Dae > Thanks, > Dave. > > > > > > > Ps. regarding the first patch, I had sent a GIT-PULL[1] but it seems > > you missed. > > [1] > https://lore.kernel.org/dri-devel/20231006040950.4397-1-inki.dae@samsung.= com/T/#u > > > > Please kindly let me know if there is any problem. > > > > Thanks, > > Inki Dae > > > > The following changes since commit > 98b1cc82c4affc16f5598d4fa14b1858671b2263: > > > > Linux 6.7-rc2 (2023-11-19 15:02:14 -0800) > > > > are available in the Git repository at: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos > tags/exynos-drm-fixes-for-v6.7-rc3 > > > > for you to fetch changes up to a30ba4bd7cdb5726d86a557c5df8df71c7bc7fad= : > > > > drm/exynos: fix a wrong error checking (2023-11-21 07:41:11 +0900) > > > > ---------------------------------------------------------------- > > Two fixups > > - Fix a potential error pointer dereference by checking the return valu= e > > of exynos_drm_crtc_get_by_type() function before accessing to crtc > > object. > > - Fix a wrong error checking in exynos_drm_dma.c modules, which was > reported > > by Dan[1] > > > > [1] > https://lore.kernel.org/all/33e52277-1349-472b-a55b-ab5c3462bfcf@moroto.m= ountain/ > > > > ---------------------------------------------------------------- > > Inki Dae (1): > > drm/exynos: fix a wrong error checking > > > > Xiang Yang (1): > > drm/exynos: fix a potential error pointer dereference > > > > drivers/gpu/drm/exynos/exynos_drm_dma.c | 8 +++----- > > drivers/gpu/drm/exynos/exynos_hdmi.c | 2 ++ > > 2 files changed, 5 insertions(+), 5 deletions(-) > > --000000000000f97bb9060b2c77c0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Dave,

2023=EB=85=84 11=EC=9B=94 24=EC=9D=BC (=EA=B8= =88) =EC=98=A4=EC=A0=84 10:14, Dave Airlie <airlied@gmail.com>=EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1:
On Tue, 21 Nov 2023 at 09:00, Inki Da= e <inki.dae@samsung.com> wrote:
>
> Hi Dave and Daniel,
>
>=C2=A0 =C2=A0 Two fixups - fixing a potential error pointer dereference= and wrong
>=C2=A0 =C2=A0 error checking.
Hi Inki,

This fails to build on arm32, and it seems one of the fixes is wrong

[airlied@dreadlord drm-fixes]$ make ARCH=3Darm
CROSS_COMPILE=3Darm-linux-gnu- O=3D../../arm-build-fixes/=C2=A0 -j16
make[1]: Entering directory '/home/airlied/devel/kernel/arm-build-fixes= '
=C2=A0 GEN=C2=A0 =C2=A0 =C2=A0Makefile
=C2=A0 =C2=A0 =C2=A0 CALL=C2=A0 =C2=A0 /home/airlied/devel/kernel/dim/drm-f= ixes/scripts/checksyscalls.sh
=C2=A0 CC [M]=C2=A0 drivers/gpu/drm/exynos/exynos_drm_dma.o
/home/airlied/devel/kernel/dim/drm-fixes/drivers/gpu/drm/exynos/exynos_drm_= dma.c:
In function =E2=80=98exynos_drm_register_dma=E2=80=99:
/home/airlied/devel/kernel/dim/drm-fixes/drivers/gpu/drm/exynos/exynos_drm_= dma.c:119:40:
error: passing argument 1 of =E2=80=98PTR_ERR=E2=80=99 makes pointer from i= nteger
without a cast [-Werror=3Dint-conversion]
=C2=A0 119 |=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0return PTR_ERR(-ENODEV);
In file included from
/home/airlied/devel/kernel/dim/drm-fixes/include/linux/string.h:9,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0from
/home/airlied/devel/kernel/dim/drm-fixes/include/linux/dma-mapping.h:7,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0from
/home/airlied/devel/kernel/dim/drm-fixes/include/linux/dma-map-ops.h:9,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0from
/home/airlied/devel/kernel/dim/drm-fixes/drivers/gpu/drm/exynos/exynos_drm_= dma.c:7:
/home/airlied/devel/kernel/dim/drm-fixes/include/linux/err.h:49:61:
note: expected =E2=80=98const void *=E2=80=99 but argument is of type =E2= =80=98int=E2=80=99
=C2=A0 =C2=A049 | static inline long __must_check PTR_ERR(__force const voi= d *ptr)
=C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0~~~~~~~~~~~~^~~
cc1: all warnings being treated as errors

I think it should just be return -ENODEV, since the function returns an int= .

Please fix it up and resend.
=
Really sorry for this. Will resend after fixing= it.

Thanks,
Inki Dae


Thanks,
Dave.



>
>=C2=A0 =C2=A0 Ps. regarding the first patch, I had sent a GIT-PULL[1] b= ut it seems
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 you missed.
>=C2=A0 =C2=A0 [1] https://lore.kernel.org/dri-devel/20231006040950.4397-1-inki.= dae@samsung.com/T/#u
>
>=C2=A0 =C2=A0 Please kindly let me know if there is any problem.
>
> Thanks,
> Inki Dae
>
> The following changes since commit 98b1cc82c4affc16f5598d4fa14b1858671= b2263:
>
>=C2=A0 =C2=A0Linux 6.7-rc2 (2023-11-19 15:02:14 -0800)
>
> are available in the Git repository at:
>
>=C2=A0 =C2=A0git://g= it.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos tags/exynos-d= rm-fixes-for-v6.7-rc3
>
> for you to fetch changes up to a30ba4bd7cdb5726d86a557c5df8df71c7bc7fa= d:
>
>=C2=A0 =C2=A0drm/exynos: fix a wrong error checking (2023-11-21 07:41:1= 1 +0900)
>
> ----------------------------------------------------------------
> Two fixups
> - Fix a potential error pointer dereference by checking the return val= ue
>=C2=A0 =C2=A0of exynos_drm_crtc_get_by_type() function before accessing= to crtc
>=C2=A0 =C2=A0object.
> - Fix a wrong error checking in exynos_drm_dma.c modules, which was re= ported
>=C2=A0 =C2=A0by Dan[1]
>
> [1] https://lore.kernel.org/all/33e52277-1349-472b-a55b-ab5c3462bfcf@moroto.mo= untain/
>
> ----------------------------------------------------------------
> Inki Dae (1):
>=C2=A0 =C2=A0 =C2=A0 =C2=A0drm/exynos: fix a wrong error checking
>
> Xiang Yang (1):
>=C2=A0 =C2=A0 =C2=A0 =C2=A0drm/exynos: fix a potential error pointer de= reference
>
>=C2=A0 drivers/gpu/drm/exynos/exynos_drm_dma.c | 8 +++-----
>=C2=A0 drivers/gpu/drm/exynos/exynos_hdmi.c=C2=A0 =C2=A0 | 2 ++
>=C2=A0 2 files changed, 5 insertions(+), 5 deletions(-)

--000000000000f97bb9060b2c77c0--