From mboxrd@z Thu Jan 1 00:00:00 1970 From: Inki Dae Subject: Re: [PATCH] drm/exynos: change the method for getting the interrupt resource of FIMD Date: Tue, 2 Apr 2013 17:57:14 +0900 Message-ID: References: <1363171939-9672-1-git-send-email-vikas.sajjan@linaro.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0389642252==" Return-path: Received: from mail-la0-f48.google.com (mail-la0-f48.google.com [209.85.215.48]) by gabe.freedesktop.org (Postfix) with ESMTP id 59E10E6094 for ; Tue, 2 Apr 2013 01:57:15 -0700 (PDT) Received: by mail-la0-f48.google.com with SMTP id fq13so167550lab.7 for ; Tue, 02 Apr 2013 01:57:14 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Vikas Sajjan Cc: Sylwester Nawrocki , Kukjin Kim , sunil joshi , DRI mailing list , "linux-media@vger.kernel.org" List-Id: dri-devel@lists.freedesktop.org --===============0389642252== Content-Type: multipart/alternative; boundary=bcaec5524516744cf704d95cec0f --bcaec5524516744cf704d95cec0f Content-Type: text/plain; charset=ISO-8859-1 Applied. :) Thanks, Inki Dae 2013/4/2 Vikas Sajjan > Hi Mr. Inki Dae, > > Can you please review this patch.? > > On Wed, Mar 13, 2013 at 4:22 PM, Vikas Sajjan > wrote: > > Replaces the "platform_get_resource() for IORESOURCE_IRQ" with > > platform_get_resource_byname(). > > Both in exynos4 and exynos5, FIMD IP has 3 interrupts in the order: > "fifo", > > "vsync", and "lcd_sys". > > But The FIMD driver expects the "vsync" interrupt to be mentioned as the > > 1st parameter in the FIMD DT node. So to meet this expectation of the > > driver, the FIMD DT node was forced to be made by keeping "vsync" as the > > 1st paramter. > > For example in exynos4, the FIMD DT node has interrupt numbers > > mentioned as <11, 1> <11, 0> <11, 2> keeping "vsync" as the 1st paramter. > > > > This patch fixes the above mentioned "hack" of re-ordering of the > > FIMD interrupt numbers by getting interrupt resource of FIMD by using > > platform_get_resource_byname(). > > > > Signed-off-by: Vikas Sajjan > > --- > > drivers/gpu/drm/exynos/exynos_drm_fimd.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c > b/drivers/gpu/drm/exynos/exynos_drm_fimd.c > > index 1ea173a..cd79d38 100644 > > --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c > > +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c > > @@ -945,7 +945,7 @@ static int fimd_probe(struct platform_device *pdev) > > return -ENXIO; > > } > > > > - res = platform_get_resource(pdev, IORESOURCE_IRQ, 0); > > + res = platform_get_resource_byname(pdev, IORESOURCE_IRQ, > "vsync"); > > if (!res) { > > dev_err(dev, "irq request failed.\n"); > > return -ENXIO; > > -- > > 1.7.9.5 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-media" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel > --bcaec5524516744cf704d95cec0f Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
Applied. :)

Thanks,
Inki Dae
=


201= 3/4/2 Vikas Sajjan <sajjan.linux@gmail.com>
Hi Mr. Inki Dae,

Can you please review this patch.?

On Wed, Mar 13, 2013 at 4:22 PM, Vikas Sajjan <vikas.sajjan@linaro.org> wrote:
> Replaces the "platform_get_resource() for IORESOURCE_IRQ" wi= th
> platform_get_resource_byname().
> Both in exynos4 and exynos5, FIMD IP has 3 interrupts in the order: &q= uot;fifo",
> "vsync", and "lcd_sys".
> But The FIMD driver expects the "vsync" interrupt to be ment= ioned as the
> 1st parameter in the FIMD DT node. So to meet this expectation of the<= br> > driver, the FIMD DT node was forced to be made by keeping "vsync&= quot; as the
> 1st paramter.
> For example in exynos4, the FIMD DT node has interrupt numbers
> mentioned as <11, 1> <11, 0> <11, 2> keeping "v= sync" as the 1st paramter.
>
> This patch fixes the above mentioned "hack" of re-ordering o= f the
> FIMD interrupt numbers by getting interrupt resource of FIMD by using<= br> > platform_get_resource_byname().
>
> Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>
> ---
> =A0drivers/gpu/drm/exynos/exynos_drm_fimd.c | =A0 =A02 +-
> =A01 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/dr= m/exynos/exynos_drm_fimd.c
> index 1ea173a..cd79d38 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> @@ -945,7 +945,7 @@ static int fimd_probe(struct platform_device *pdev= )
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 return -ENXIO;
> =A0 =A0 =A0 =A0 }
>
> - =A0 =A0 =A0 res =3D platform_get_resource(pdev, IORESOURCE_IRQ, 0);<= br> > + =A0 =A0 =A0 res =3D platform_get_resource_byname(pdev, IORESOURCE_IR= Q, "vsync");
> =A0 =A0 =A0 =A0 if (!res) {
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 dev_err(dev, "irq request failed.= \n");
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 return -ENXIO;
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-m= edia" in
> the body of a message to = majordomo@vger.kernel.org
> More majordomo info at =A0http://vger.kernel.org/majordomo-info.html=
_____________________= __________________________
dri-devel mailing list
dri-devel@lists.freedesk= top.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

--bcaec5524516744cf704d95cec0f-- --===============0389642252== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0389642252==--