All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mine <mine260309@gmail.com>
To: Cyril Bur <cyrilbur@gmail.com>
Cc: Joel Stanley <joel@jms.id.au>,
	OpenBMC Maillist <openbmc@lists.ozlabs.org>
Subject: Re: [PATCH] ARM: dts: aspeed: Update reserved memory nodes for zaius and witherspoon
Date: Thu, 16 Feb 2017 14:14:41 +0800	[thread overview]
Message-ID: <CAARXrtm=xGhKQrngbjx2qZZhOx8tq-S3f948n+TnxGjkgb14Gg@mail.gmail.com> (raw)
In-Reply-To: <20170216054922.19722-1-cyrilbur@gmail.com>

Hi Cyril,

On Thu, Feb 16, 2017 at 1:49 PM, Cyril Bur <cyrilbur@gmail.com> wrote:
> Signed-off-by: Cyril Bur <cyrilbur@gmail.com>
> ---
>  arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts | 9 +++++++--
>  arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts       | 9 +++++++--
>  2 files changed, 14 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
> index 4b2d8aa8abb6..2d76bfee1262 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
> @@ -25,9 +25,14 @@
>                 #size-cells = <1>;
>                 ranges;
>
> -               flash_memory: region@94000000 {
> +               flash_memory: region@98000000 {
>                         no-map;
> -                       reg = <0x94000000 0x04000000>; /* 64M */
> +                       reg = <0x98000000 0x04000000>; /* 64M */
> +               };
> +
> +               vga_memory: framebuffer@9c000000 {
> +                       no-map;
> +                       reg = <0x9c000000 0x04000000>; /* 64MB */

This assumes that Witherspoon has 512MiB RAM, then why the memory part
indicates it has 1GiB?
```
        memory {
                reg = <0x80000000 0x40000000>;
        };
```

>                 };
>         };
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts b/arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts
> index e1c9b3f4fe44..f30288f735bc 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts
> @@ -25,9 +25,14 @@
>                 #size-cells = <1>;
>                 ranges;
>
> -               flash_memory: region@94000000 {
> +               flash_memory: region@98000000 {
>                         no-map;
> -                       reg = <0x94000000 0x04000000>; /* 64M */
> +                       reg = <0x98000000 0x04000000>; /* 64M */
> +               };
> +
> +               vga_memory: framebuffer@9c000000 {
> +                       no-map;
> +                       reg = <0x9c000000 0x04000000>; /* 64MB */

As I know Google decides to not support VGA on Zaius, so maybe
vga_memory is not needed to Zaius at all.

>                 };
>         };
>
> --
> 2.11.1
>

  reply	other threads:[~2017-02-16  6:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-16  5:49 [PATCH] ARM: dts: aspeed: Update reserved memory nodes for zaius and witherspoon Cyril Bur
2017-02-16  6:14 ` Mine [this message]
2017-02-17  2:51   ` Cyril Bur
2017-02-17  2:56     ` Cyril Bur
2017-02-16 14:05 ` Patrick Williams
2017-02-17  2:48   ` Cyril Bur
2017-02-21  4:16     ` Patrick Williams
2017-02-21  4:45       ` Joel Stanley
2017-02-21  5:13         ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAARXrtm=xGhKQrngbjx2qZZhOx8tq-S3f948n+TnxGjkgb14Gg@mail.gmail.com' \
    --to=mine260309@gmail.com \
    --cc=cyrilbur@gmail.com \
    --cc=joel@jms.id.au \
    --cc=openbmc@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.