From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 53363C54EE9 for ; Fri, 16 Sep 2022 09:35:20 +0000 (UTC) Received: from localhost ([::1]:37632 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oZ7kk-0002gc-W6 for qemu-devel@archiver.kernel.org; Fri, 16 Sep 2022 05:35:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54136) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZ7iO-00017i-FW for qemu-devel@nongnu.org; Fri, 16 Sep 2022 05:32:52 -0400 Received: from mail-ej1-x630.google.com ([2a00:1450:4864:20::630]:35463) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oZ7iM-0001D3-EG for qemu-devel@nongnu.org; Fri, 16 Sep 2022 05:32:52 -0400 Received: by mail-ej1-x630.google.com with SMTP id go34so48118366ejc.2 for ; Fri, 16 Sep 2022 02:32:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anisinha-ca.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=j+seZhNxUchyTfIfDq9mopu2KOkdZjZOZXBz06YX3Ag=; b=zzgaalBs1LR2cQ61lbAw932Lhb+XKirzOC8eeidtE5HqlfM0+rsKPbCLssGXXyaIZx PqI99FUuk/hjS68tfgdU6myRg8tVfDVgRxe49oTkAfCgVYbVAYAyTlvnbyy4TiIpStak REk+uQnKtUqgdhWjVAENkbjvLjHZmNzsfF9dnmCOskAcP49zJ1x1ykgAR+g7lPqRxVHj sI35gt5bAMN8CRIyesszKE6xlHbS9Au4pPCVnP2W5nIo91hYIoDsf235Bliki9TYpVCb oofep1M9XnVyjDDjxDqGtN/v1LHcdugJoO9Zr6YSeszuUVEBrzIfqT1ci6nRmY2y4yfr 8zLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=j+seZhNxUchyTfIfDq9mopu2KOkdZjZOZXBz06YX3Ag=; b=cN7koCsn22wtQp7EU7Ch7p+rWLVCMIbyntiaLjXDZpDsqg7paxBDp+PP7wUpjBzUSW PhauyTBfl2tbP6I5ITOATp92iQdWll/oRT0EqdLDbrxAU3J2SXFxo3Z5WUspbqqpCQhD PjmHxO6GJnajB/m3HRYmru2GNw3vR/1TYrm3g5/sdtF9cmD6D1CICZ6BZrnViucxfblO bp11kcsuDPe8neo75rxrjFpScqKOuNo46+Rzp35sOrnR5/+2B+4KzxUVuKDnU73QBZ7q 7sEB4vaRyrOz0ZL/Q1DxGC/niBFYHq/DVXrd/jJ65pgFvO94t87hSnrJYPKdf8+wfu/M 1mCw== X-Gm-Message-State: ACrzQf3kfZzvYUkh1sHzg6q3HEsZuBu7NTZccAp3MU9KyQ1Itdy+u9Yv erPgIzBJrGSb6j+mTIc/f9uden4nMwfRJuWQ78j75Q== X-Google-Smtp-Source: AMsMyM6GUtitv3VgNoQeQN16537153BhP1vbfOo0z8H25I4A9DNfYJfXPGh1Rv0XeCRecX/m5C0gCq001IU4Rz9zQjE= X-Received: by 2002:a17:906:9c82:b0:6e1:2c94:1616 with SMTP id fj2-20020a1709069c8200b006e12c941616mr3018381ejc.64.1663320767556; Fri, 16 Sep 2022 02:32:47 -0700 (PDT) MIME-Version: 1.0 References: <20220915204317.3766007-1-armbru@redhat.com> <20220915204317.3766007-7-armbru@redhat.com> <87illnenpv.fsf@pond.sub.org> In-Reply-To: From: Ani Sinha Date: Fri, 16 Sep 2022 15:02:36 +0530 Message-ID: Subject: Re: [PATCH 06/27] qapi acpi: Elide redundant has_FOO in generated C To: =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= Cc: Igor Mammedov , Markus Armbruster , "Michael S . Tsirkin" , eblake@redhat.com, jsnow@redhat.com, michael.roth@amd.com, qemu-devel@nongnu.org Content-Type: multipart/alternative; boundary="0000000000007f97d305e8c80b91" Received-SPF: none client-ip=2a00:1450:4864:20::630; envelope-from=ani@anisinha.ca; helo=mail-ej1-x630.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --0000000000007f97d305e8c80b91 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Sep 16, 2022 at 14:15 Ani Sinha wrote: > > > On Fri, Sep 16, 2022 at 14:08 Daniel P. Berrang=C3=A9 > wrote: > >> On Fri, Sep 16, 2022 at 01:51:14PM +0530, Ani Sinha wrote: >> > On Fri, Sep 16, 2022 at 1:48 PM Markus Armbruster >> wrote: >> > > >> > > Ani Sinha writes: >> > > >> > > > On Fri, Sep 16, 2022 at 2:13 AM Markus Armbruster < >> armbru@redhat.com> wrote: >> > > >> >> > > >> The has_FOO for pointer-valued FOO are redundant, except for >> arrays. >> > > >> They are also a nuisance to work with. Recent commit "qapi: Star= t >> to >> > > >> elide redundant has_FOO in generated C" >> > > > >> > > > Commit is referenced using ("commit >> header") >> > > >> > > Apply my patches in your tree, and your hashes will differ from mine= . >> > > Hashes can serve as stable reference only when we git-fetch patches, >> not >> > > when we git-send-email then. >> > >> > Has the referenced patch not been pushed upstream already? I thought >> > it was and hence was asking for the reference. >> >> Err, it is just a few patches earlier in this very series you're >> looking at. > > > Hmm ok. It=E2=80=99s missing from my inbox. Probably was not CC=E2=80=99d= to me. > Indeed. https://lore.kernel.org/all/20220915204317.3766007-5-armbru@redhat.com/ > --0000000000007f97d305e8c80b91 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Fri, Sep 16, 2022 at 14:15 Ani Sinha <ani@anisinha.ca> wrote:


On Fri, Sep 16, 2022 at 14:08 Daniel P. Berrang=C3=A9 <<= a href=3D"mailto:berrange@redhat.com" target=3D"_blank">berrange@redhat.com= > wrote:
On Fri, Sep 16, 2022 at 01:51:14P= M +0530, Ani Sinha wrote:
> On Fri, Sep 16, 2022 at 1:48 PM Markus Armbruster <armbru@redhat.com> wrote:
> >
> > Ani Sinha <ani@anisinha.ca> writes:
> >
> > > On Fri, Sep 16, 2022 at 2:13 AM Markus Armbruster <armbru@redhat.com> = wrote:
> > >>
> > >> The has_FOO for pointer-valued FOO are redundant, except= for arrays.
> > >> They are also a nuisance to work with.=C2=A0 Recent comm= it "qapi: Start to
> > >> elide redundant has_FOO in generated C"
> > >
> > > Commit is referenced using <commit hash 13 chars min> = ("commit header")
> >
> > Apply my patches in your tree, and your hashes will differ from m= ine.
> > Hashes can serve as stable reference only when we git-fetch patch= es, not
> > when we git-send-email then.
>
> Has the referenced patch not been pushed upstream already? I thought > it was and hence was asking for the reference.

Err, it is just a few patches earlier in this very series you're
looking at.

Hmm o= k. It=E2=80=99s missing from my inbox. Probably was not CC=E2=80=99d to me.= =C2=A0

--0000000000007f97d305e8c80b91--