From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C35C5C433EF for ; Tue, 5 Jul 2022 13:51:03 +0000 (UTC) Received: from localhost ([::1]:58868 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o8ixC-0004Pp-NJ for qemu-devel@archiver.kernel.org; Tue, 05 Jul 2022 09:51:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49924) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o8ivK-0002yR-Oo for qemu-devel@nongnu.org; Tue, 05 Jul 2022 09:49:06 -0400 Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]:43826) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o8ivI-0006EE-PN for qemu-devel@nongnu.org; Tue, 05 Jul 2022 09:49:06 -0400 Received: by mail-ed1-x534.google.com with SMTP id v12so2749359edc.10 for ; Tue, 05 Jul 2022 06:49:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anisinha-ca.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VXg9GM9kcgZogBb4NVTD+ieKzzFjbx1VgT1hUCWlEBU=; b=CLVxNI8Ni8+f1K6Y8iRje1kq2lW/9FzKWFbCxEDVKM7EhaIL7fMe9rZi8ig2idm1jK 9crcMjKsfvv34b0TKESgK2w3PgXS9I5jdI44Ewk3YtGsdCIVlaf/n2VSFQpAAkLrWWA9 vgqoIm5kswYtBm/TaamApDANY/xWWpbaDB1mqvoZfvgIXMBtHPnV1FfM5ACA5ZnxrzXJ uSpVU8x5DpKXlEsCeCd1w6163Op53ujEHmzt6jAN8gn78cJN3ExWNCQ0ZL/0SYcjZhGK bz3OYAYQk8i/OqT96dAfo3HPSFmFm9324IgMXyV7fv6F2lrIdaX6Jl+6yLmiUoeE/gOw fRTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VXg9GM9kcgZogBb4NVTD+ieKzzFjbx1VgT1hUCWlEBU=; b=Ac7fbm9f7hpkbR+oovKnBm30nFpnzAY+LxGDurVptkWw0/8BJGZLftsAa6BKtjaUvX R3CcVLZEDNvLzPCXCdZvL+B4qbu0najC+CspVTGM1aK6VhBuaBxdhGHyisanv+ULTQCX XuMN/5Mi9QZGBm1zPnUqVONP6z2grt86IB26ibnumGXFE4cBruCTrbhlymOLh/4aJ/Pu jeHRzWHve2tdXy4tT+0Rns4DnwnjJxJ0FbFXf7Ps1r76TYQ+4YIVtos61Hbukh/QzFVE Fs9ccaf5e2mN/q43QfeUSpz3iK9msgH7JtBVnm9Nac1h2AUgQBVxOY9SL6jg0vTunOqx w2VA== X-Gm-Message-State: AJIora/wsLwEgnEj2+Y29HUr2zLH5NX3Bx3e0T5zBGEBGyM0no9TCG2v iC96Tb2WZTNdGlYJAKrnASAFBftwmoEkftP/d4Sorg== X-Google-Smtp-Source: AGRyM1sgG0dh64yBTsvbu6wNo20vyNbfRbSV1kBFJdZCvMTd2eaZnrLtHESLdpr+O7zM8ZGollOv3JaIcH2wOmVcPCk= X-Received: by 2002:a05:6402:5250:b0:43a:6c36:2e57 with SMTP id t16-20020a056402525000b0043a6c362e57mr12373296edd.65.1657028942727; Tue, 05 Jul 2022 06:49:02 -0700 (PDT) MIME-Version: 1.0 References: <9b96f98e-2b7d-47a3-c64d-9cd785432840@redhat.com> <20220701024108-mutt-send-email-mst@kernel.org> <20220701033006-mutt-send-email-mst@kernel.org> <20220701053949-mutt-send-email-mst@kernel.org> <20220701082552-mutt-send-email-mst@kernel.org> In-Reply-To: From: Ani Sinha Date: Tue, 5 Jul 2022 19:18:51 +0530 Message-ID: Subject: Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests) To: "Michael S. Tsirkin" Cc: Thomas Huth , Peter Maydell , =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= , John Snow , Laurent Vivier , Paolo Bonzini , imammedo@redhat.com, qemu-devel@nongnu.org Content-Type: text/plain; charset="UTF-8" Received-SPF: none client-ip=2a00:1450:4864:20::534; envelope-from=ani@anisinha.ca; helo=mail-ed1-x534.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Jul 4, 2022 at 7:02 PM Ani Sinha wrote: > > On Fri, Jul 1, 2022 at 6:25 PM Michael S. Tsirkin wrote: > > > > On Fri, Jul 01, 2022 at 03:44:32PM +0530, Ani Sinha wrote: > > > but I thought you were suggesting we built bits every time the test is run? > > > > In my opinion 3 scenarios are worth supporting: > > - people not touching ACPI, including users - simply don't run the tests, > > comparing tables with expected output should be enough > > - people making changes indirectly affecting ACPI - > > use tests to validate that tables are still well formed, > > using a pre built binary should be enough IMO > > - people working on ACPI - use tests to analyse the tables, > > building from source might be necessary for debugging, > > sources change very rarely > > - people developing the tests > > building from source is required > > > > So I would suggest basically two github repos, one with binaries one with > > sources. We'll keep relevant hashes to use in the script. > > All in all not that different from submodules but I guess > > people have submodules and that is that. > > > > And I personally would probably not tie it to CI whoever owns the > > repository can worry about the builds, and I think keeping > > things distributed is important. > > > > So > > - people not touching ACPI - make check should see directory not found > > and skip the test > > - people making changes indirectly affecting ACPI - > > check out binaries and use > > - people working on ACPI - > > see that source directory is present, go there > > and run make. should not rebuild each time right? > > - people developing the tests > > building from source is required > > Ok I have now committed a Dockerfile that has all the build time > dependencies and builds bits and generates the tarballs/zip file that > my test requires: > https://github.com/ani-sinha/bits/blob/bits-qemu-logging/Dockerfile > > We just need to fork the repo and generate automated builds with this > Dockerfile and put the binaries somewhere. This should also help > developers requiring to rebuild bits when necessary. > Oh and btw, I also made bits compliant with the latest gcc 11 compiler > that comes with Ubuntu 22.04 LTS :-) Pushed a build script here: https://github.com/ani-sinha/bits/commit/90b99ef05d55ead4b33b2fb19ad07dfb9682ec92 and the bios bits binaries are in this branch: https://github.com/ani-sinha/bits/tree/bits-builds