From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14159C433EF for ; Thu, 23 Sep 2021 13:47:20 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D469960F70 for ; Thu, 23 Sep 2021 13:47:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D469960F70 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=anisinha.ca Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.194262.346052 (Exim 4.92) (envelope-from ) id 1mTP43-0002gs-VJ; Thu, 23 Sep 2021 13:47:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 194262.346052; Thu, 23 Sep 2021 13:47:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mTP43-0002gl-S0; Thu, 23 Sep 2021 13:47:03 +0000 Received: by outflank-mailman (input) for mailman id 194262; Thu, 23 Sep 2021 13:47:02 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mTP42-0002gf-2e for xen-devel@lists.xenproject.org; Thu, 23 Sep 2021 13:47:02 +0000 Received: from mail-ed1-x52d.google.com (unknown [2a00:1450:4864:20::52d]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 9cbeecaa-b1b2-4cdd-ae9a-8cc795971c54; Thu, 23 Sep 2021 13:47:01 +0000 (UTC) Received: by mail-ed1-x52d.google.com with SMTP id c21so23596735edj.0 for ; Thu, 23 Sep 2021 06:47:01 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9cbeecaa-b1b2-4cdd-ae9a-8cc795971c54 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anisinha-ca.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=X6tPYj9oUhcOZ+uoKP+nG8NnVQLmoHX/d9g9BCvLsR4=; b=hhQ6niECsnZzrG0mdkN3l2WljsCA50VtPKnZq/g/2/G/ZURvGbApaDR4yM3Qu7Nedr yCbU2ae+DEh22mAwEsYAFVeHCmi2bWr7WdChJM2pKepbtPDure7P44nCJZ2ISY4/vdNs bq8yhJ5dTW5mGd3AfNM1D7FzOCp7GGd6zmvX2Sac656+re+366zG2dB+NClxqXqRq0xh htyslKOh7ULkt6Pot837zj5o9iN+TyPQOYd2F9w9eoRyHdRezVHYpRhoZ3Njl2piiKKY XjR+oCA6huAJMYDWQDZUBthnwD5zHMYYY3ylJSOJ4a0uQ9yJ3GvdPxnjKj4UhEWK172g MV7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=X6tPYj9oUhcOZ+uoKP+nG8NnVQLmoHX/d9g9BCvLsR4=; b=wHcfr42cb1QDILBnQo7IrKLqqxLyzml/JDvCP2tZwCEKdXoulwVuusYrqNumDiH3XE X7AeX9/VrNaA9Di1l9T8h87jx1FEJ3/x5a2xEGtvKZxn8hSBkgFHUmyS11ajII7JYV/R L3xKzV9gFUtvRSrVCP7ixMzsit5qgifTfOItVNyPKeybb/LkV9J4bKRiDNQHngSKRhle 9qkTNtJujl+qxiRasx1QpSeGwjt0fPf3K0m27F/DMwRQeElnbavv0MiQmUO+vkIFZ0vZ kLwzr6tqVOCw/bGzhjmOWOGKDs8CYt2IluVVvb2HtaYMX+CmwqsLO8nlRjzKcFlnMTTs Rdfw== X-Gm-Message-State: AOAM533DyQy4aR0kFHpnOIZaON23KCOxb1yNjxdFHHChkCPwDjaetTDy 9vwzFKMXgerjr0YexO13YMHkh9xrJxvc9ZfT83tsOg== X-Google-Smtp-Source: ABdhPJwICFJ0kqduDlOdG2Bm7hRT1CYmYq3zG89jCtiaURODn4W0xVzTn8I3igE6k1ZKJtFQaXUt4Jr9El0Yfcd7sdE= X-Received: by 2002:a05:6402:3128:: with SMTP id dd8mr5448390edb.383.1632404816373; Thu, 23 Sep 2021 06:46:56 -0700 (PDT) MIME-Version: 1.0 References: <20210922161405.140018-1-damien.hedde@greensocs.com> <20210922161405.140018-3-damien.hedde@greensocs.com> In-Reply-To: From: Ani Sinha Date: Thu, 23 Sep 2021 19:16:45 +0530 Message-ID: Subject: Re: [RFC PATCH v2 02/16] qapi: Implement query-machine-phase QMP command To: Damien Hedde Cc: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , QEMU Developers , Peter Maydell , "Michael S. Tsirkin" , David Hildenbrand , Peter Xu , mirela.grujic@greensocs.com, Alistair Francis , Gerd Hoffmann , Eric Blake , Stefano Stabellini , xen-devel@lists.xenproject.org, Paul Durrant , Markus Armbruster , Anthony Perard , =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= , Eduardo Habkost , "Dr. David Alan Gilbert" , Eric Auger , Paolo Bonzini , qemu-riscv@nongnu.org, =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= , mark.burton@greensocs.com, edgari@xilinx.com, Igor Mammedov Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Sep 23, 2021 at 6:13 PM Damien Hedde w= rote: > > > > On 9/22/21 19:37, Philippe Mathieu-Daud=C3=A9 wrote: > > On 9/22/21 18:13, Damien Hedde wrote: > >> From: Mirela Grujic > >> > >> The command returns current machine initialization phase. > >> From now on, the MachineInitPhase enum is generated from the > >> QAPI schema. > >> > >> Signed-off-by: Mirela Grujic > > > > Missing your S-o-b, otherwise: > > Sorry. I did not realize I had to add it since it was already done by > Mirela. I'll add it for this patch and patches 1, 6 and 8. https://wiki.qemu.org/Contribute/SubmitAPatch#Patch_emails_must_include_a_S= igned-off-by:_line btw, it's strictly not mandatory if you are both from the same company and you did not write the patch or contribute in anyway to it. > > > Reviewed-by: Philippe Mathieu-Daud=C3=A9 > >> --- > >> qapi/machine.json | 56 ++++++++++++++++++++++++++++++++++++= ++ > >> include/hw/qdev-core.h | 30 ++------------------ > >> hw/core/machine-qmp-cmds.c | 9 ++++++ > >> hw/core/qdev.c | 5 ++++ > >> 4 files changed, 72 insertions(+), 28 deletions(-) > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29C45C433F5 for ; Thu, 23 Sep 2021 13:48:22 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8CC16610C8 for ; Thu, 23 Sep 2021 13:48:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8CC16610C8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=anisinha.ca Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:55208 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mTP5I-0005JG-Ia for qemu-devel@archiver.kernel.org; Thu, 23 Sep 2021 09:48:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41708) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mTP42-0004U0-0f for qemu-devel@nongnu.org; Thu, 23 Sep 2021 09:47:02 -0400 Received: from mail-ed1-x536.google.com ([2a00:1450:4864:20::536]:42646) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mTP40-0006Rn-75 for qemu-devel@nongnu.org; Thu, 23 Sep 2021 09:47:01 -0400 Received: by mail-ed1-x536.google.com with SMTP id u27so23430879edi.9 for ; Thu, 23 Sep 2021 06:46:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anisinha-ca.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=X6tPYj9oUhcOZ+uoKP+nG8NnVQLmoHX/d9g9BCvLsR4=; b=hhQ6niECsnZzrG0mdkN3l2WljsCA50VtPKnZq/g/2/G/ZURvGbApaDR4yM3Qu7Nedr yCbU2ae+DEh22mAwEsYAFVeHCmi2bWr7WdChJM2pKepbtPDure7P44nCJZ2ISY4/vdNs bq8yhJ5dTW5mGd3AfNM1D7FzOCp7GGd6zmvX2Sac656+re+366zG2dB+NClxqXqRq0xh htyslKOh7ULkt6Pot837zj5o9iN+TyPQOYd2F9w9eoRyHdRezVHYpRhoZ3Njl2piiKKY XjR+oCA6huAJMYDWQDZUBthnwD5zHMYYY3ylJSOJ4a0uQ9yJ3GvdPxnjKj4UhEWK172g MV7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=X6tPYj9oUhcOZ+uoKP+nG8NnVQLmoHX/d9g9BCvLsR4=; b=H4YPU6gT3RfSKeK6l/ztHh9Nk6thcMO38vxb/duKiwzwN7hEbhaWWte+BFfiP6PCQ4 qHThAP0pj7Hg416aS/49CwtLoqcQrQdcMDMoqArADQwyGwUYkAr0MWAaV9UUdUDvuyv3 pQ1aIA+4Sr3JN/8doFn/fC+BWcLCoiOyeLS5B2HKwnYB6g5Qn3EWLGpHom/fGbJ6JEZb IXt0LsJllLAoJgv7Tm9A/3eBqeRROYyv1fHuWn2mc2SOXvqb/BoXfdFOAcJt18tNHhM7 7nmHp9XV8vf9TWxgLwXSbiTSN/aQSdSpZ4cOgr28cWp8Lij5TdBfDvUq7cJ3Og5vHDUR UyUA== X-Gm-Message-State: AOAM532MMZYxQLry1veX25AyiFw3dJ9yBIZe7R8hRr2JiDQ5US4S2Lx5 PAotcSNm/h8KMawsvbilwdDhIoO0DKZpM2KhrKGF9g== X-Google-Smtp-Source: ABdhPJwICFJ0kqduDlOdG2Bm7hRT1CYmYq3zG89jCtiaURODn4W0xVzTn8I3igE6k1ZKJtFQaXUt4Jr9El0Yfcd7sdE= X-Received: by 2002:a05:6402:3128:: with SMTP id dd8mr5448390edb.383.1632404816373; Thu, 23 Sep 2021 06:46:56 -0700 (PDT) MIME-Version: 1.0 References: <20210922161405.140018-1-damien.hedde@greensocs.com> <20210922161405.140018-3-damien.hedde@greensocs.com> In-Reply-To: From: Ani Sinha Date: Thu, 23 Sep 2021 19:16:45 +0530 Message-ID: Subject: Re: [RFC PATCH v2 02/16] qapi: Implement query-machine-phase QMP command To: Damien Hedde Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: none client-ip=2a00:1450:4864:20::536; envelope-from=ani@anisinha.ca; helo=mail-ed1-x536.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , David Hildenbrand , QEMU Developers , Peter Xu , mirela.grujic@greensocs.com, Alistair Francis , Gerd Hoffmann , Eric Blake , Stefano Stabellini , "Michael S. Tsirkin" , Markus Armbruster , Anthony Perard , =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , Igor Mammedov , Eduardo Habkost , "Dr. David Alan Gilbert" , Paul Durrant , Eric Auger , xen-devel@lists.xenproject.org, qemu-riscv@nongnu.org, =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= , mark.burton@greensocs.com, edgari@xilinx.com, Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Sep 23, 2021 at 6:13 PM Damien Hedde w= rote: > > > > On 9/22/21 19:37, Philippe Mathieu-Daud=C3=A9 wrote: > > On 9/22/21 18:13, Damien Hedde wrote: > >> From: Mirela Grujic > >> > >> The command returns current machine initialization phase. > >> From now on, the MachineInitPhase enum is generated from the > >> QAPI schema. > >> > >> Signed-off-by: Mirela Grujic > > > > Missing your S-o-b, otherwise: > > Sorry. I did not realize I had to add it since it was already done by > Mirela. I'll add it for this patch and patches 1, 6 and 8. https://wiki.qemu.org/Contribute/SubmitAPatch#Patch_emails_must_include_a_S= igned-off-by:_line btw, it's strictly not mandatory if you are both from the same company and you did not write the patch or contribute in anyway to it. > > > Reviewed-by: Philippe Mathieu-Daud=C3=A9 > >> --- > >> qapi/machine.json | 56 ++++++++++++++++++++++++++++++++++++= ++ > >> include/hw/qdev-core.h | 30 ++------------------ > >> hw/core/machine-qmp-cmds.c | 9 ++++++ > >> hw/core/qdev.c | 5 ++++ > >> 4 files changed, 72 insertions(+), 28 deletions(-) > >