From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EC985C43334 for ; Mon, 27 Jun 2022 16:41:14 +0000 (UTC) Received: from localhost ([::1]:53302 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o5rnV-00048B-VC for qemu-devel@archiver.kernel.org; Mon, 27 Jun 2022 12:41:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50778) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o5rPt-0002Rx-6n for qemu-devel@nongnu.org; Mon, 27 Jun 2022 12:16:50 -0400 Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]:33436) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o5rPq-0002CP-7U for qemu-devel@nongnu.org; Mon, 27 Jun 2022 12:16:48 -0400 Received: by mail-ed1-x534.google.com with SMTP id eo8so13854291edb.0 for ; Mon, 27 Jun 2022 09:16:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anisinha-ca.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=itske71PLdGmZQ7DYsMF7n2S82qHO6IkdSwrmJwY/8s=; b=eOhx2763tzPFUX5iMPZNAMVivHs+bgq91VYVs4AEakbgYC3WD+Y4GIJjyDzk6Xv2iy b3aL27XmUZ6jwL/MdW9VOH6EXhdx/17m7yHuZ/EgulO5v58si1qIIdgmrYzaxvgMmLqG UWCO3XLJCYF8M0BxTYEC+zSp6hIt0lYjug004GIPrc+EDEJJJsdnigJrB3k0y5h+jLQE 0GkVhLgwa31SLUjDu7q5AYVaKTFBK/NcLvLIlbw7iViNoQTjHSPlPxPTnNirjGGP177/ STuPLnaM1LV2CvMgGEPjigbACirfXLzm8j0JI1+x5zQI+KU47gqhKIe/M910YYZ1YJDP F76A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=itske71PLdGmZQ7DYsMF7n2S82qHO6IkdSwrmJwY/8s=; b=W3/2pdUAtN5wEzQpeQACzatQALKm8uy9yfoIPolKD/dc3SoCU/EMoWFIBx4ObX096h h6CFmSAMjyCaq+bg2zPP47tUHsa01geXyFvnSQVz+SJRuCVoPan7nSWlhxXm/Zj0cavh 8I1V8h/qvMBVmXGJwwwgTPd2hmhg7oTxmTq88kgKdYMnWjt4kIvDjCDGHS+boirLnaOg BAu8OkqnKHBwZuB16hz4qWpuqV81pqzwx5LOolFaz2d0jIASUKxW04YcDDtGhOFISk1u Hzh8u8uSCAyTFxu1DDRhf76lQlIL+6iJc26B2ZU4t0DBrDFIynsfz/xAKZyisPZJDCg5 6jVw== X-Gm-Message-State: AJIora9GIpFxpGq4NTAalOTwbWr3xyk2pcQsu0efsu/aKOOKc/5ioCmX Uc6AeV4nwHxgL969iYpbbJeotf5pm4yK9x4kr8Ozcv3IyIZEfw0q1YQ= X-Google-Smtp-Source: AGRyM1s0AvBRv/PVTXCnUzaXmcFdhuAITTNCv9NEDKw/GF0euEdMNieega5CsuX+LJ+ZN6RXmu1fO3HXiCICcF+LGKY= X-Received: by 2002:a05:6402:1d4b:b0:435:cac5:1957 with SMTP id dz11-20020a0564021d4b00b00435cac51957mr17427334edb.109.1656346603588; Mon, 27 Jun 2022 09:16:43 -0700 (PDT) MIME-Version: 1.0 References: <20220627064414.1527623-1-ani@anisinha.ca> In-Reply-To: From: Ani Sinha Date: Mon, 27 Jun 2022 21:46:32 +0530 Message-ID: Subject: Re: [PATCH 00/12] Introduce new acpi/smbios qtests using biosbits To: qemu-devel@nongnu.org Cc: imammedo@redhat.com, mst@redhat.com Content-Type: text/plain; charset="UTF-8" Received-SPF: none client-ip=2a00:1450:4864:20::534; envelope-from=ani@anisinha.ca; helo=mail-ed1-x534.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Jun 27, 2022 at 1:02 PM Ani Sinha wrote: > > On Mon, Jun 27, 2022 at 12:25 PM Ani Sinha wrote: > > > > On Mon, Jun 27, 2022 at 12:22 PM Ani Sinha wrote: > > > > > > On Mon, Jun 27, 2022 at 12:14 PM Ani Sinha wrote: > > > > > > > > Biosbits is a software written by Josh Triplett that can be downloaded by > > > > visiting https://biosbits.org/. The github codebase can be found here: > > > > https://github.com/biosbits/bits/tree/master. It is a software that exercizes > > > > the bios components such as acpi and smbios tables directly through acpica > > > > bios interpreter (a freely available C based library written by Intel, > > > > downloadable from https://acpica.org/ and is included with biosbits) without an > > > > operating system getting involved in between. > > > > There are several advantages to directly testing the bios in a real physical > > > > machine or VM as opposed to indirectly discovering bios issues through the > > > > operating system. For one thing, the OSes tend to hide bios problems from the > > > > end user. The other is that we have more control of what we wanted to test > > > > and how by directly using acpica interpreter on top of the bios on a running > > > > system. More details on the inspiration for developing biosbits and its real > > > > life uses can be found in (a) and (b). > > > > This patchset contains QEMU qtests written in python that exercizes the QEMU > > > > bios components using biosbits and reports test failures. > > > > > > > > Details of each of the files added by this patchset are provided in the README > > > > file which is part of Patch 11. Every effort to contact Josh, through various > > > > means including email, twitter, linkedIn etc has failed. Hence, the changes to > > > > build biosbits with the newer compiler, upgrade acpica and other changes are > > > > currently maintained in a forked project in my personal github. We may want to > > > > maintain bits in a separate fork in a stable repository that is accessible by > > > > QEMU developers. > > > > > > > > The newly introduced qtest currently only run for x86_64 platform. They pass > > > > both when running make check on a baremetal box as well as from inside a vm. > > > > > > > > Thanks to Igor M for pointing me to this work. > > > > > > > > (a) https://blog.linuxplumbersconf.org/2011/ocw/system/presentations/867/original/bits.pdf > > > > (b) https://www.youtube.com/watch?v=36QIepyUuhg > > > > > > Doh, sending the patch series failed since google won't allow file > > > sizes larger than 25 MB. The bits prebuilt binaries have sizes 30 MB > > > and 40 MB in two separate patches :( > > > > I have pushed the patchset here: > > https://gitlab.com/anisinha/qemu/-/commits/acpi-bits . > > I have re-sent all the patches except patches 2 and 3 that contain > pre-built biosbits archives. For those two patches, please see the > gitlab repo above. I took a peek at our avocado framework. Seems binary artefacts like these are stored in github. For example, https://github.com/philmd/qemu-testing-blob/tree/malta_i6400/mips/malta/mips64el . Maybe in this case, we can do the same - store this in my github and the test wgets it. The flip side is that this will introduce external dependencies for this test. I will wait for further comments from reviewers on this. > > > > > > > > > > > > > > Ani Sinha (12): > > > > qtest: meson.build changes required to integrate python based qtests > > > > acpi/tests/bits: add prebuilt bios bits zip archive > > > > acpi/tests/bits: add prebuilt bits generated grub modules and scripts > > > > acpi/tests/bits: initial commit of test scripts that are run by > > > > biosbits > > > > acpi/tests/bits: disable acpi PSS tests that are failing in biosbits > > > > acpi/tests/bits: add smilatency test suite from bits in order to > > > > disable it > > > > acpi/tests/bits: disable smilatency test since it does not pass > > > > everytime > > > > acpi/tests/bits: add biosbits config file for running bios tests > > > > acpi/tests/bits: add acpi and smbios python tests that uses biosbits > > > > acpi/tests/bits: add acpi bits qtest directory in meson for running > > > > tests > > > > acpi/tests/bits: add README file for bits qtests > > > > MAINTAINERS: add myself as the maintainer for acpi biosbits qtests > > > > > > > > MAINTAINERS | 5 + > > > > tests/qtest/acpi-bits/README | 168 ++ > > > > tests/qtest/acpi-bits/acpi-bits-test-venv.sh | 59 + > > > > tests/qtest/acpi-bits/acpi-bits-test.py | 327 +++ > > > > .../qtest/acpi-bits/bits-config/bits-cfg.txt | 18 + > > > > tests/qtest/acpi-bits/bits-config/meson.build | 11 + > > > > tests/qtest/acpi-bits/bits-tests/meson.build | 11 + > > > > tests/qtest/acpi-bits/bits-tests/smbios.py | 2430 +++++++++++++++++ > > > > .../qtest/acpi-bits/bits-tests/smilatency.py | 103 + > > > > tests/qtest/acpi-bits/bits-tests/testacpi.py | 283 ++ > > > > tests/qtest/acpi-bits/bits-tests/testcpuid.py | 83 + > > > > tests/qtest/acpi-bits/meson.build | 39 + > > > > .../acpi-bits/prebuilt/bits-2095-grub.tar.gz | Bin 0 -> 41416278 bytes > > > > tests/qtest/acpi-bits/prebuilt/bits-2095.zip | Bin 0 -> 31922898 bytes > > > > tests/qtest/acpi-bits/prebuilt/meson.build | 11 + > > > > tests/qtest/acpi-bits/requirements.txt | 1 + > > > > tests/qtest/meson.build | 7 +- > > > > 17 files changed, 3555 insertions(+), 1 deletion(-) > > > > create mode 100644 tests/qtest/acpi-bits/README > > > > create mode 100644 tests/qtest/acpi-bits/acpi-bits-test-venv.sh > > > > create mode 100644 tests/qtest/acpi-bits/acpi-bits-test.py > > > > create mode 100644 tests/qtest/acpi-bits/bits-config/bits-cfg.txt > > > > create mode 100644 tests/qtest/acpi-bits/bits-config/meson.build > > > > create mode 100644 tests/qtest/acpi-bits/bits-tests/meson.build > > > > create mode 100644 tests/qtest/acpi-bits/bits-tests/smbios.py > > > > create mode 100644 tests/qtest/acpi-bits/bits-tests/smilatency.py > > > > create mode 100644 tests/qtest/acpi-bits/bits-tests/testacpi.py > > > > create mode 100644 tests/qtest/acpi-bits/bits-tests/testcpuid.py > > > > create mode 100644 tests/qtest/acpi-bits/meson.build > > > > create mode 100644 tests/qtest/acpi-bits/prebuilt/bits-2095-grub.tar.gz > > > > create mode 100644 tests/qtest/acpi-bits/prebuilt/bits-2095.zip > > > > create mode 100644 tests/qtest/acpi-bits/prebuilt/meson.build > > > > create mode 100644 tests/qtest/acpi-bits/requirements.txt > > > > > > > > -- > > > > 2.25.1 > > > >