All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ani Sinha <ani@anisinha.ca>
To: Liav Albani <liavalb@gmail.com>, qemu-arm <qemu-arm@nongnu.org>
Cc: imammedo@redhat.com, qemu-devel@nongnu.org, mst@redhat.com
Subject: Re: [PATCH v2 2/2] hw/acpi: add indication for i8042 in IA-PC boot flags of the FADT table
Date: Tue, 22 Feb 2022 12:50:44 +0530	[thread overview]
Message-ID: <CAARzgwxC0g6HWGY_=roU5kbRbDR24vNDrwXAsSVXDkBReZY7sw@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2202221154300.697295@anisinha-lenovo>

> >
> > diff --git a/hw/i386/acpi-microvm.c b/hw/i386/acpi-microvm.c
> > index 68ca7e7fc2..756c69b3b0 100644
> > --- a/hw/i386/acpi-microvm.c
> > +++ b/hw/i386/acpi-microvm.c
> > @@ -189,6 +189,11 @@ static void acpi_build_microvm(AcpiBuildTables *tables,
> >          .reset_val = ACPI_GED_RESET_VALUE,
> >      };
> >
> > +    if (isa_check_device_existence("i8042")) {
> > +        /* Indicates if i8042 is present or not */
> > +        pmfadt.iapc_boot_arch = (1 << 1);
> > +    }
> > +
> >      table_offsets = g_array_new(false, true /* clear */,
> >                                          sizeof(uint32_t));
>
>
> We should do the same thing for arm architecture as well?
> hw/arm/virt-acpi-build.c .

Probably not since the spec says
"These flags pertain only to IA-PC platforms. On other system
architectures, the entire field should be set
to 0."

adding qemu-arm for confirmation.


  reply	other threads:[~2022-02-22  7:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-21 19:13 [PATCH v2 0/2] hw/acpi: add indication for i8042 in IA-PC boot flags of the FADT table Liav Albani
2022-02-21 19:13 ` [PATCH v2 1/2] hw/isa: add function to check for existence of device by its type Liav Albani
2022-02-21 19:13 ` [PATCH v2 2/2] hw/acpi: add indication for i8042 in IA-PC boot flags of the FADT table Liav Albani
2022-02-21 20:05   ` Liav Albani
2022-02-22  6:55   ` Ani Sinha
2022-02-22  7:20     ` Ani Sinha [this message]
2022-02-22  7:12   ` Ani Sinha
2022-02-22 12:20 ` [PATCH v2 0/2] " Ani Sinha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAARzgwxC0g6HWGY_=roU5kbRbDR24vNDrwXAsSVXDkBReZY7sw@mail.gmail.com' \
    --to=ani@anisinha.ca \
    --cc=imammedo@redhat.com \
    --cc=liavalb@gmail.com \
    --cc=mst@redhat.com \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.