From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A115CC433EF for ; Fri, 17 Sep 2021 06:43:24 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 57724610A7 for ; Fri, 17 Sep 2021 06:43:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 57724610A7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=anisinha.ca Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:33982 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mR7al-0004sY-4h for qemu-devel@archiver.kernel.org; Fri, 17 Sep 2021 02:43:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56952) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mR7Zk-00040Y-7m for qemu-devel@nongnu.org; Fri, 17 Sep 2021 02:42:20 -0400 Received: from mail-ed1-x52d.google.com ([2a00:1450:4864:20::52d]:43757) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mR7Zh-0004Rc-8o for qemu-devel@nongnu.org; Fri, 17 Sep 2021 02:42:20 -0400 Received: by mail-ed1-x52d.google.com with SMTP id n10so25480076eda.10 for ; Thu, 16 Sep 2021 23:42:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anisinha-ca.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mRucfBE3m0jS7yCA991+lKESEKC9rkLrp76UAzTUenY=; b=mt21cTCGQQJ87F+IBfXXO7x8n/6K5OP7nzGzKDoG3ZN0eG5UpZsj1NVSU/c7UAeFJn GDX4hkHM1cof57M+jhlsuyOYtyJsc6ZebcWyI0sWY0mW33DPxIWDuSIGES3rUn2z3Rd2 ISiHw+iwslj1owwHqb3q9JqRfvFZUSocDz6x/CCPOSeyN90bnLp7RzJvwz2oBOJm/94q i/2MCeWVNf8VotaCo5PkVK6O1lXYGSfyBKlkLqYvGRDZNLCGPfjpz2+av25nlAAGEHEr d0H/trYnv5+bOPmAzj/HqU4pJF71X722TLIG4DNpy7t2zSht3qK+0sn2vHUzBp9jO/tA 0alg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mRucfBE3m0jS7yCA991+lKESEKC9rkLrp76UAzTUenY=; b=ghscyBsL3DBG/nakKQP6PbK9BAs8/ravMh7LmyNITlumfyuIhAhp7VrzpOrb0Nu4oA Babgpnyzv352a4ydn105yOdySINjodgi+2nFLM8NTU+R6S+hDJx+EVHjA0F7HkNY6Rfd vo4Mgf0oWPurq/yqk5JhdzXZAq1qbHGLF8DoSNUP2BFsCUrCOR7l/o2ShjaU90pRLncl IWiwMhtcWwNnOwlJChBQ6oAhzoDG7CyuKWMIrI4W7Wde4V6fl4v/jjGWqHdHKHBrlhYP p+oFKBU89geUI4ri1o8zPc/MJOylZfTLYwJ7FRNcRjfqu61cTwUfhjRMqkpgN2qDS6wo mRbA== X-Gm-Message-State: AOAM533RuFNXEeTdtJml4i4V6/gn7BDBWs6Rl3B1n/8bxuh2l6WM3Zem JbsjG8vzjpKgvtsfa1t9O17eUjoO75SJGyGHxf+7Dg== X-Google-Smtp-Source: ABdhPJy+ihFP1SOEfXGL/WWr38Q8lmNq16189Sg2imTPnQ9baHK5lR+msBK7pcylotDz9Q7xOTMIjNOFAJHh3g7yh4s= X-Received: by 2002:a17:906:d045:: with SMTP id bo5mr10539111ejb.461.1631860934107; Thu, 16 Sep 2021 23:42:14 -0700 (PDT) MIME-Version: 1.0 References: <20210916132838.3469580-1-ani@anisinha.ca> <20210916185427-mutt-send-email-mst@kernel.org> In-Reply-To: From: Ani Sinha Date: Fri, 17 Sep 2021 12:12:03 +0530 Message-ID: Subject: Re: hw/i386/acpi: fix conflicting IO address range for acpi pci hotplug in q35 To: "Michael S. Tsirkin" Content-Type: text/plain; charset="UTF-8" Received-SPF: none client-ip=2a00:1450:4864:20::52d; envelope-from=ani@anisinha.ca; helo=mail-ed1-x52d.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , Igor Mammedov , Julia Suvorova , QEMU Developers , qemu-stable@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Sep 17, 2021 at 10:11 AM Ani Sinha wrote: > > > > On Thu, 16 Sep 2021, Michael S. Tsirkin wrote: > > > On Thu, Sep 16, 2021 at 06:58:35PM +0530, Ani Sinha wrote: > > > Here's sending v2. > > > > > > changelog : > > > v1: original patch. > > > v2: typo fixed. reviewed-by tags added. > > > > > > Thanks, tagged! > > Ani pls make sure the voer letter in the series has > > subject > > > > [PATCH 0/3] hw/i386/acpi: fix conflicting IO address range for acpi pci > > hotplug in q35 > > > > > > using --cover-letter with git format-patch will do this automatically. > > > > It will also include diffstat and other useful info. > > Ah I see. I was wondering about this few days back because I saw a > patchset with diffstat etc. I use git send-email --cover -v2 -3 -cc > --cc-cmd etc. I did not realize that git format-patch also has similar > options and adds more info to the cover letter. I wonder why the behavior > is different between them. Also --cc-cmd is missing in format-patch! Also note that checkpatch.pl can be run without spitting out the patches in separate files: ./scripts/checkpatch.pl HEAD~3..HEAD 1/3 Checking commit 0a4f1a3d8733 (bios-tables-test: allow changes in DSDT ACPI tables for q35) total: 0 errors, 0 warnings, 12 lines checked Patch 1/3 has no obvious style problems and is ready for submission. 2/3 Checking commit 5adcc9e39e6a (hw/i386/acpi: fix conflicting IO address range for acpi pci hotplug in q35) total: 0 errors, 0 warnings, 8 lines checked Patch 2/3 has no obvious style problems and is ready for submission. 3/3 Checking commit 5e0a8181d2d9 (bios-tables-test: Update ACPI DSDT table golden blobs for q35) total: 0 errors, 0 warnings, 1 lines checked Patch 3/3 has no obvious style problems and is ready for submission. So I guess the workflow should always be : 1) use git format-patch -o 2) run checkpatch on patches in dir 3) git send-email dir/*.patch > > Was this an essential complexity or accidental one :-) > > > > > > > > > > This issue has been reported here: > > > https://gitlab.com/qemu-project/qemu/-/issues/561 > > > > > > We have disucssed this issue at length here: > > > https://lists.gnu.org/archive/html/qemu-devel/2021-09/msg02146.html > > > > > > This issue affects Qemu version 6.1. > > > > > > Patch 1 : allows q35 DSDT table changes. > > > Patch 2 : actual fix. > > > Patch 3: updates DSDT table blobs. > > > > > > > > > >