From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755426AbbDNOhn (ORCPT ); Tue, 14 Apr 2015 10:37:43 -0400 Received: from mail-ie0-f193.google.com ([209.85.223.193]:36038 "EHLO mail-ie0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753812AbbDNOhf (ORCPT ); Tue, 14 Apr 2015 10:37:35 -0400 MIME-Version: 1.0 In-Reply-To: <5065055.RUNnjWsHWj@wuerfel> References: <1428916660-25910-1-git-send-email-bintian.wang@huawei.com> <2456827.cDpE8M58pn@wuerfel> <552D09F7.7080603@huawei.com> <5065055.RUNnjWsHWj@wuerfel> Date: Tue, 14 Apr 2015 22:37:34 +0800 Message-ID: Subject: Re: [PATCH v2 3/6] clk: hi6220: Document devicetree bindings for hi6220 clock From: Brent Wang To: Arnd Bergmann Cc: linux-arm-kernel , Bintian , Mark Rutland , "dan.zhao@hisilicon.com" , "btw@mail.itp.ac.cn" , Catalin Marinas , "wangbinghui@hisilicon.com" , Will Deacon , "huxinwei@huawei.com" , Haojian Zhuang , Haifeng Yan , Rob Herring , Mike Turquette , Xu Wei , Jaehoon Chung , "sledge.yanwei@huawei.com" , XinWei Kong , "heyunlei@huawei.com" , "w.f@huawei.com" , Zhangfei Gao , "z.liuxinliang@huawei.com" , "devicetree@vger.kernel.org" , Kevin Hilman , Pawel Moll , Ian Campbell , "puck.chen@hisilicon.com" , "xuejiancheng@huawei.com" , Rob Herring , Russell King - ARM Linux , Tyler Baker , "zhenwei.wang@hisilicon.com" , Guodong Xu , "victor.lixin@hisilicon.com" , Stephen Boyd , "linux-kernel@vger.kernel.org" , Tomeu Vizoso , Kumar Gala , Olof Johansson , jorge.ramirez-ortiz@linaro.org, "xuyiping@hisilicon.com" , "Liguozhu (Kenneth)" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Arnd, 2015-04-14 21:20 GMT+08:00 Arnd Bergmann : > On Tuesday 14 April 2015 20:37:11 Bintian wrote: >> It's really a smart fix! >> >> For the four system controllers, how about change the following strings: >> + - "hisilicon,aoctrl" >> + - "hisilicon,sysctrl" >> + - "hisilicon,mediactrl" >> + - "hisilicon,pmctrl" >> >> to >> + - "hisilicon,hi6220-aoctrl" >> + - "hisilicon,hi6220-sysctrl" >> + - "hisilicon,hi6220-mediactrl" >> + - "hisilicon,hi6220-pmctrl" > > Yes, that works. Thanks, will fix in next version. > >> and I also use "hisilicon,hi6220-xxxx" for hi6220 clk driver directly ? > > Seems fine to me, though I'd have to look at the bigger picture to see > any potential problems. At the moment, I don't see any. Sure, please also help to review the 6/6 patch of this patch set, many thanks! BR, Bintian > > Arnd > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brent Wang Subject: Re: [PATCH v2 3/6] clk: hi6220: Document devicetree bindings for hi6220 clock Date: Tue, 14 Apr 2015 22:37:34 +0800 Message-ID: References: <1428916660-25910-1-git-send-email-bintian.wang@huawei.com> <2456827.cDpE8M58pn@wuerfel> <552D09F7.7080603@huawei.com> <5065055.RUNnjWsHWj@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <5065055.RUNnjWsHWj@wuerfel> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Arnd Bergmann Cc: linux-arm-kernel , Bintian , Mark Rutland , "dan.zhao-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org" , "btw-aAikPa0K0u50tdys+9eLAQ@public.gmane.org" , Catalin Marinas , "wangbinghui-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org" , Will Deacon , "huxinwei-hv44wF8Li93QT0dZR+AlfA@public.gmane.org" , Haojian Zhuang , Haifeng Yan , Rob Herring , Mike Turquette , Xu Wei , Jaehoon Chung , "sledge.yanwei-hv44wF8Li93QT0dZR+AlfA@public.gmane.org" , XinWei Kong , "heyunlei-hv44wF8Li93QT0dZR+AlfA@public.gmane.org" , "w.f-hv44wF8Li93QT0dZR+AlfA@public.gmane.org" , Zhangfei Gao , z.liuxinliang-hv44wF8Li91hl2p70BpVqQ@public.gmane.org List-Id: devicetree@vger.kernel.org Hello Arnd, 2015-04-14 21:20 GMT+08:00 Arnd Bergmann : > On Tuesday 14 April 2015 20:37:11 Bintian wrote: >> It's really a smart fix! >> >> For the four system controllers, how about change the following strings: >> + - "hisilicon,aoctrl" >> + - "hisilicon,sysctrl" >> + - "hisilicon,mediactrl" >> + - "hisilicon,pmctrl" >> >> to >> + - "hisilicon,hi6220-aoctrl" >> + - "hisilicon,hi6220-sysctrl" >> + - "hisilicon,hi6220-mediactrl" >> + - "hisilicon,hi6220-pmctrl" > > Yes, that works. Thanks, will fix in next version. > >> and I also use "hisilicon,hi6220-xxxx" for hi6220 clk driver directly ? > > Seems fine to me, though I'd have to look at the bigger picture to see > any potential problems. At the moment, I don't see any. Sure, please also help to review the 6/6 patch of this patch set, many thanks! BR, Bintian > > Arnd > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: wangbintian@gmail.com (Brent Wang) Date: Tue, 14 Apr 2015 22:37:34 +0800 Subject: [PATCH v2 3/6] clk: hi6220: Document devicetree bindings for hi6220 clock In-Reply-To: <5065055.RUNnjWsHWj@wuerfel> References: <1428916660-25910-1-git-send-email-bintian.wang@huawei.com> <2456827.cDpE8M58pn@wuerfel> <552D09F7.7080603@huawei.com> <5065055.RUNnjWsHWj@wuerfel> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello Arnd, 2015-04-14 21:20 GMT+08:00 Arnd Bergmann : > On Tuesday 14 April 2015 20:37:11 Bintian wrote: >> It's really a smart fix! >> >> For the four system controllers, how about change the following strings: >> + - "hisilicon,aoctrl" >> + - "hisilicon,sysctrl" >> + - "hisilicon,mediactrl" >> + - "hisilicon,pmctrl" >> >> to >> + - "hisilicon,hi6220-aoctrl" >> + - "hisilicon,hi6220-sysctrl" >> + - "hisilicon,hi6220-mediactrl" >> + - "hisilicon,hi6220-pmctrl" > > Yes, that works. Thanks, will fix in next version. > >> and I also use "hisilicon,hi6220-xxxx" for hi6220 clk driver directly ? > > Seems fine to me, though I'd have to look at the bigger picture to see > any potential problems. At the moment, I don't see any. Sure, please also help to review the 6/6 patch of this patch set, many thanks! BR, Bintian > > Arnd > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo at vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/