From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751804AbdF2Ep4 (ORCPT ); Thu, 29 Jun 2017 00:45:56 -0400 Received: from mail-vk0-f67.google.com ([209.85.213.67]:34136 "EHLO mail-vk0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751584AbdF2Epx (ORCPT ); Thu, 29 Jun 2017 00:45:53 -0400 MIME-Version: 1.0 In-Reply-To: <20170627173631.2rjdzgwdwnksqjzm@flea> References: <20170624024515.4669-1-techping.chan@gmail.com> <20170624024515.4669-3-techping.chan@gmail.com> <20170626171524.cqfyasetpsfr6xfg@flea.lan> <24845446a80e3542d90a1111a6141415@aosc.io> <20170627173631.2rjdzgwdwnksqjzm@flea> From: Ziping Chen Date: Thu, 29 Jun 2017 12:45:51 +0800 Message-ID: Subject: Re: [linux-sunxi] Re: [PATCH v3 2/3] dt-bindings: input: Add R_LRADC support for A83T To: Maxime Ripard Cc: icenowy@aosc.io, Chen-Yu Tsai , Rob Herring , mark.rutland@arm.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, Alexandre Belloni Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2017-06-28 1:36 GMT+08:00 Maxime Ripard : > Hi, > > On Tue, Jun 27, 2017 at 11:29:10PM +0800, icenowy@aosc.io wrote: >> Maxime, here's another problem: if we have already a GP LRADC driver, >> how can we tell the kernel to use it as IIO ADC rather than keys? > > The GPADC IIO driver is not for the LRADC driver, but the GPADC / > temperature sensor. > > We used to have an LRADC IIO driver in the CHIP BSP written by Alex > (in CC): > https://github.com/NextThingCo/CHIP-linux/commit/8675b761c54be73dc7cc0113209f02e10cc63a27 > > But he never mainlined it. > >> Should we introduce a new property for this once ready? > > We need to keep the current binding. We can just check for the > presence or not of child nodes to see if it has some keys, and we'd > need an IIO-to-input driver that is yet to be written. > Yes, then we need an iio-to-input driver... So...whether the driver(a83t lradc keys) can be applied now, or we should wait for the iio-to-input driver. Thanks Ziping > Maxime > > -- > Maxime Ripard, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ziping Chen Subject: Re: Re: [PATCH v3 2/3] dt-bindings: input: Add R_LRADC support for A83T Date: Thu, 29 Jun 2017 12:45:51 +0800 Message-ID: References: <20170624024515.4669-1-techping.chan@gmail.com> <20170624024515.4669-3-techping.chan@gmail.com> <20170626171524.cqfyasetpsfr6xfg@flea.lan> <24845446a80e3542d90a1111a6141415@aosc.io> <20170627173631.2rjdzgwdwnksqjzm@flea> Reply-To: techping.chan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: <20170627173631.2rjdzgwdwnksqjzm@flea> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Maxime Ripard Cc: icenowy-h8G6r0blFSE@public.gmane.org, Chen-Yu Tsai , Rob Herring , mark.rutland-5wv7dgnIgG8@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, Alexandre Belloni List-Id: devicetree@vger.kernel.org 2017-06-28 1:36 GMT+08:00 Maxime Ripard : > Hi, > > On Tue, Jun 27, 2017 at 11:29:10PM +0800, icenowy-h8G6r0blFSE@public.gmane.org wrote: >> Maxime, here's another problem: if we have already a GP LRADC driver, >> how can we tell the kernel to use it as IIO ADC rather than keys? > > The GPADC IIO driver is not for the LRADC driver, but the GPADC / > temperature sensor. > > We used to have an LRADC IIO driver in the CHIP BSP written by Alex > (in CC): > https://github.com/NextThingCo/CHIP-linux/commit/8675b761c54be73dc7cc0113209f02e10cc63a27 > > But he never mainlined it. > >> Should we introduce a new property for this once ready? > > We need to keep the current binding. We can just check for the > presence or not of child nodes to see if it has some keys, and we'd > need an IIO-to-input driver that is yet to be written. > Yes, then we need an iio-to-input driver... So...whether the driver(a83t lradc keys) can be applied now, or we should wait for the iio-to-input driver. Thanks Ziping > Maxime > > -- > Maxime Ripard, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: techping.chan@gmail.com (Ziping Chen) Date: Thu, 29 Jun 2017 12:45:51 +0800 Subject: [linux-sunxi] Re: [PATCH v3 2/3] dt-bindings: input: Add R_LRADC support for A83T In-Reply-To: <20170627173631.2rjdzgwdwnksqjzm@flea> References: <20170624024515.4669-1-techping.chan@gmail.com> <20170624024515.4669-3-techping.chan@gmail.com> <20170626171524.cqfyasetpsfr6xfg@flea.lan> <24845446a80e3542d90a1111a6141415@aosc.io> <20170627173631.2rjdzgwdwnksqjzm@flea> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org 2017-06-28 1:36 GMT+08:00 Maxime Ripard : > Hi, > > On Tue, Jun 27, 2017 at 11:29:10PM +0800, icenowy at aosc.io wrote: >> Maxime, here's another problem: if we have already a GP LRADC driver, >> how can we tell the kernel to use it as IIO ADC rather than keys? > > The GPADC IIO driver is not for the LRADC driver, but the GPADC / > temperature sensor. > > We used to have an LRADC IIO driver in the CHIP BSP written by Alex > (in CC): > https://github.com/NextThingCo/CHIP-linux/commit/8675b761c54be73dc7cc0113209f02e10cc63a27 > > But he never mainlined it. > >> Should we introduce a new property for this once ready? > > We need to keep the current binding. We can just check for the > presence or not of child nodes to see if it has some keys, and we'd > need an IIO-to-input driver that is yet to be written. > Yes, then we need an iio-to-input driver... So...whether the driver(a83t lradc keys) can be applied now, or we should wait for the iio-to-input driver. Thanks Ziping > Maxime > > -- > Maxime Ripard, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com