All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Hecker <jwhecker@gmail.com>
To: Josu Lazkano <josu.lazkano@gmail.com>
Cc: Malcolm Priestley <tvboxspy@gmail.com>,
	linux-media <linux-media@vger.kernel.org>
Subject: Re: Afatech AF9013
Date: Tue, 23 Aug 2011 10:59:20 +1000	[thread overview]
Message-ID: <CAATJ+fsUWPjh5aq38triZOu0-DmU=nCbd77qUzxUn5kiDiaR+w@mail.gmail.com> (raw)
In-Reply-To: <CAL9G6WUFddsFM2V46xXCDWEfhfCR0n5G-8S4JSYwLLkmZnYu7g@mail.gmail.com>

I might have found one bug so far with the Afa9013 driver.

As part of refactoring the code in
http://git.linuxtv.org/linux-2.6.git/commitdiff/edb709b61abd3ba475e59d1ad81aab21ad025db6
I think one of the u32->u8 calculations is wrong.

The think the second last u32 in the tables has to be changed. Here is
the diff.  I will try it later as I have run out of time to test it
this morning.  This may not fix the problems we are having but it
might help...  So patch the file af9013_priv.h with this in the latest
git media_build and see what happens.  I'll report back later with my
results.

af9013_priv.h.diff

<snip>------------------------------

74c74
<               0x29, 0x03, 0x5d, 0x7a, 0xec, 0x01, 0x45, 0x14, 0x14 } },
---
>               0x29, 0x00, 0xa2, 0x85, 0x14, 0x01, 0x45, 0x14, 0x14 } },
77c77
<               0xe4, 0x03, 0x71, 0xcb, 0xe8, 0x01, 0x1c, 0x71, 0x32 } },
---
>               0xe4, 0x00, 0x8e, 0x34, 0x72, 0x01, 0x1c, 0x71, 0x32 } },
80c80
<               0x9e, 0x03, 0x86, 0x1c, 0x31, 0x00, 0xf3, 0xcf, 0x0f } },
---
>               0x9e, 0x00, 0x79, 0xe3, 0xcf, 0x00, 0xf3, 0xcf, 0x0f } },
84c84
<               0x49, 0x03, 0x1b, 0x74, 0xdb, 0x01, 0xc9, 0x24, 0x25 } },
---
>               0x49, 0x00, 0xe4, 0x8b, 0x25, 0x01, 0xc9, 0x24, 0x25 } },
87c87
<               0x00, 0x03, 0x38, 0x06, 0x40, 0x01, 0x90, 0x00, 0x00 } },
---
>               0x00, 0x00, 0xc7, 0xf9, 0xc0, 0x01, 0x90, 0x00, 0x00 } },
90c90
<               0xb7, 0x03, 0x54, 0x97, 0xa4, 0x01, 0x56, 0xdb, 0x1c } },
---
>               0xb7, 0x00, 0xab, 0x68, 0x5c, 0x01, 0x56, 0xdb, 0x1c } },
94c94
<               0x05, 0x03, 0x58, 0xd6, 0x34, 0x01, 0x4e, 0x5e, 0x03 } },
---
>               0x05, 0x00, 0xa7, 0x29, 0xcc, 0x01, 0x4e, 0x5e, 0x03 } },
97c97
<               0x25, 0x03, 0x6d, 0xbb, 0x6e, 0x01, 0x24, 0x92, 0x12 } },
---
>               0x25, 0x00, 0x92, 0x44, 0x92, 0x01, 0x24, 0x92, 0x12 } },
100c100
<               0x44, 0x03, 0x82, 0xa0, 0xa7, 0x00, 0xfa, 0xc6, 0x22 } },
---
>               0x44, 0x00, 0x7d, 0x5f, 0x59, 0x00, 0xfa, 0xc6, 0x22 } },
104c104
<               0xe7, 0x03, 0x44, 0xc6, 0xf3, 0x01, 0x76, 0x7d, 0x34 } },
---
>               0xe7, 0x00, 0xbb, 0x39, 0x0d, 0x01, 0x76, 0x7d, 0x34 } },
107c107
<               0x0a, 0x03, 0x5c, 0x2e, 0x14, 0x01, 0x47, 0xae, 0x05 } },
---
>               0x0a, 0x00, 0xa3, 0xd1, 0xec, 0x01, 0x47, 0xae, 0x05 } },
110c110
<               0x2d, 0x03, 0x73, 0x95, 0x36, 0x01, 0x18, 0xde, 0x17 } },
---
>               0x2d, 0x00, 0x8c, 0x6a, 0xca, 0x01, 0x18, 0xde, 0x17 } },

  reply	other threads:[~2011-08-23  0:59 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAATJ+fu5JqVmyY=zJn_CM_Eusst_YWKG2B2MAuu5fqELYYsYqA@mail.gmail.com>
2011-08-21  1:51 ` Afatech AF9013 Jason Hecker
2011-08-21 15:06   ` Josu Lazkano
2011-08-21 18:00   ` Malcolm Priestley
2011-08-22  2:05     ` Jason Hecker
2011-08-22 12:01       ` Josu Lazkano
2011-08-23  0:59         ` Jason Hecker [this message]
2011-08-23  1:47           ` Jason Hecker
2011-08-23 21:43             ` [PATCH] Re: Afatech AF9013 [TEST ONLY] AF9015 stream buffer size aligned with max packet size Malcolm Priestley
2011-08-23 22:29               ` Jason Hecker
2011-08-29 18:40             ` Afatech AF9013 Josu Lazkano
2011-08-30 23:31               ` Malcolm Priestley
2011-08-15 13:34 Josu Lazkano
2011-08-15 22:07 ` Jose Alberto Reguero
2011-08-15 22:22   ` Josu Lazkano
2011-08-15 23:16     ` Jose Alberto Reguero
2011-08-16 16:37       ` Josu Lazkano
2011-08-16 20:27         ` Jose Alberto Reguero
2011-08-16 20:57           ` Antti Palosaari
2011-08-16 23:23             ` Jose Alberto Reguero
2011-08-17  7:36               ` Josu Lazkano
2011-08-17 20:36                 ` Antti Palosaari
2011-08-19 14:47                   ` Josu Lazkano
2011-08-17 16:15               ` Malcolm Priestley
2011-08-17 17:27                 ` Josu Lazkano
2011-08-17 21:09                   ` Malcolm Priestley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAATJ+fsUWPjh5aq38triZOu0-DmU=nCbd77qUzxUn5kiDiaR+w@mail.gmail.com' \
    --to=jwhecker@gmail.com \
    --cc=josu.lazkano@gmail.com \
    --cc=linux-media@vger.kernel.org \
    --cc=tvboxspy@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.