From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51C2DC07E99 for ; Mon, 5 Jul 2021 11:19:17 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id ADF546135F for ; Mon, 5 Jul 2021 11:19:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ADF546135F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 096714068C; Mon, 5 Jul 2021 13:19:16 +0200 (CEST) Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by mails.dpdk.org (Postfix) with ESMTP id 67F894003C for ; Mon, 5 Jul 2021 13:19:14 +0200 (CEST) Received: from mail-oi1-f200.google.com ([209.85.167.200]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1m0Md7-0000X9-Ip for dev@dpdk.org; Mon, 05 Jul 2021 11:19:13 +0000 Received: by mail-oi1-f200.google.com with SMTP id n84-20020acaef570000b029022053bcedd7so11894003oih.17 for ; Mon, 05 Jul 2021 04:19:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2LK0Ur8rYOrKusOTg0tPWI6aY6rn/U+CfnxMIvP5vHc=; b=TT16MoVJ0MDkTbF4nhk/JEn97uRnwBC3dOBD0UcZhYe5K42RLRfWRHveeZKXbmh+T8 aelbC0vsCMOkbSadNnE6vSM3KK1uBZTHqUeCKO1SNh2SdCaPjClYdKZnbOzVXUK/7pdr zI+XMh4NDHPi8D+xLxHYVgvi6NWhEatICFPO4A8ARUYER3fcQj4xt6ol0fVuScbQCOD5 ubYUi/Dc3XMzkTJ5UCRNJSqE4YStTxUIzLArp8XtmQPeNU5usmfxTPzo4ccu7LIRyujN C7EbsOdzYGn7DGxtaZi40rb27j9FCQAD7uwTqeOu5r2XlioqNLvCZk30P9CzzcWHmSUZ Z3FA== X-Gm-Message-State: AOAM530dwsmSgil6HGi6NCKhk3W/3pm58jtX5EXb57EaiaF3M0HPCVlW buijbxBcY8M+mwkY9mNOsI+Vf0TtoRGUAPfR4UEqXRcA7iebbb5UpnLHzL5e85KRonDOKoMvZOA TOKvBpVj/FIZw/YrCfRfOOajCdnn/ETqk3EJR X-Received: by 2002:a9d:6d03:: with SMTP id o3mr8100424otp.316.1625483952616; Mon, 05 Jul 2021 04:19:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJykvmh2Qtv+yYVPZsjIWSKOETFSYNBSJxelBZwjJh7f3sbqUo/KctzEPc9qlTvPWcBv9JW6S96HQQhCrChf1I4= X-Received: by 2002:a9d:6d03:: with SMTP id o3mr8100395otp.316.1625483952362; Mon, 05 Jul 2021 04:19:12 -0700 (PDT) MIME-Version: 1.0 References: <20210617063803.3490415-1-christian.ehrhardt@canonical.com> In-Reply-To: From: Christian Ehrhardt Date: Mon, 5 Jul 2021 13:18:45 +0200 Message-ID: To: Ali Alnubani Cc: "stable@dpdk.org" , "dev@dpdk.org" , Abhishek Marathe , Akhil Goyal , "benjamin.walker@intel.com" , David Christensen , "hariprasad.govindharajan@intel.com" , Hemant Agrawal , Ian Stokes , Jerin Jacob , John McNamara , Ju-Hyoung Lee , Kevin Traynor , Luca Boccassi , Pei Zhang , "pingx.yu@intel.com" , "qian.q.xu@intel.com" , Raslan Darawsheh , NBU-Contact-Thomas Monjalon , "yuan.peng@intel.com" , "zhaoyan.chen@intel.com" , Asaf Penso , Slava Ovsiienko Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] 19.11.9 patches review and test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jul 5, 2021 at 12:44 PM Ali Alnubani wrote: > > > -----Original Message----- > > From: Ali Alnubani > > Sent: Monday, July 5, 2021 9:35 AM > > To: Christian Ehrhardt > > Cc: stable@dpdk.org; dev@dpdk.org; Abhishek Marathe > > ; Akhil Goyal ; > > benjamin.walker@intel.com; David Christensen ; > > hariprasad.govindharajan@intel.com; Hemant Agrawal > > ; Ian Stokes ; Jerin > > Jacob ; John McNamara ; > > Ju-Hyoung Lee ; Kevin Traynor > > ; Luca Boccassi ; Pei Zhang > > ; pingx.yu@intel.com; qian.q.xu@intel.com; Raslan > > Darawsheh ; NBU-Contact-Thomas Monjalon > > ; yuan.peng@intel.com; zhaoyan.chen@intel.com; > > Asaf Penso > > Subject: RE: 19.11.9 patches review and test > > > > Hi Christian, > > Sorry for the delay. > > > > > -----Original Message----- > > > From: Christian Ehrhardt > > > Sent: Friday, July 2, 2021 10:42 AM > > > To: Ali Alnubani > > > Cc: stable@dpdk.org; dev@dpdk.org; Abhishek Marathe > > > ; Akhil Goyal ; > > > benjamin.walker@intel.com; David Christensen > > ; > > > hariprasad.govindharajan@intel.com; Hemant Agrawal > > > ; Ian Stokes ; Jerin > > > Jacob ; John McNamara > > ; > > > Ju-Hyoung Lee ; Kevin Traynor > > > ; Luca Boccassi ; Pei Zhang > > > ; pingx.yu@intel.com; qian.q.xu@intel.com; > > Raslan > > > Darawsheh ; NBU-Contact-Thomas Monjalon > > > ; yuan.peng@intel.com; > > zhaoyan.chen@intel.com > > > Subject: Re: 19.11.9 patches review and test > > > > > > On Thu, Jul 1, 2021 at 5:50 PM Ali Alnubani wrote: > > > > > > > > Hi, > > > > > > > > > -----Original Message----- > > > > > From: Christian Ehrhardt > > > > > Sent: Thursday, June 17, 2021 9:38 AM > > > > > To: stable@dpdk.org > > > > > Cc: dev@dpdk.org; Abhishek Marathe > > > ; > > > > > Akhil Goyal ; Ali Alnubani > > > > > ; benjamin.walker@intel.com; David Christensen > > > > > ; hariprasad.govindharajan@intel.com; > > > Hemant > > > > > Agrawal ; Ian Stokes > > > ; > > > > > Jerin Jacob ; John McNamara > > > > > ; Ju-Hyoung Lee > > ; > > > > > Kevin Traynor ; Luca Boccassi > > > > > ; Pei Zhang ; > > > > > pingx.yu@intel.com; qian.q.xu@intel.com; Raslan Darawsheh > > > > > ; NBU-Contact-Thomas Monjalon > > > > > ; yuan.peng@intel.com; > > > zhaoyan.chen@intel.com > > > > > Subject: 19.11.9 patches review and test > > > > > > > > > > Hi all, > > > > > > > > > > Here is a list of patches targeted for stable release 19.11.9. > > > > > > > > > > The planned date for the final release is 2nd July. > > > > > > > > > > Please help with testing and validation of your use cases and > > > > > report any issues/results with reply-all to this mail. For the > > > > > final release the fixes and reported validations will be added to > > > > > the release > > > notes. > > > > > > > > > > A renewed release candidate tarball can be found at: > > > > > > > > > > https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.9-rc3 > > > > > > > > > > These patches are located at branch 19.11 of dpdk-stable repo: > > > > > https://dpdk.org/browse/dpdk-stable/ > > > > > > > > > > Thanks. > > > > > > > > > > Christian Ehrhardt > > > > > > > > > > > > > The following covers the functional tests that we ran on Mellanox > > > hardware for this release: > > > > - Basic functionality: > > > > Send and receive multiple types of traffic. > > > > - testpmd xstats counter test. > > > > - testpmd timestamp test. > > > > - Changing/checking link status through testpmd. > > > > - RTE flow tests: > > > > Items: eth / vlan / ipv4 / ipv6 / tcp / udp / icmp / gre / nvgre / > > > > vxlan / ip in > > > ip / mplsoudp / mplsogre > > > > Actions: drop / queue / rss / mark / flag / jump / count / > > > > raw_encap / raw_decap / vxlan_encap / vxlan_decap / NAT / dec_ttl > > > > - Some RSS tests. > > > > - VLAN filtering, stripping and insertion tests. > > > > - Checksum and TSO tests. > > > > - ptype tests. > > > > - link_status_interrupt example application tests. > > > > - l3fwd-power example application tests. > > > > - Multi-process example applications tests. > > > > > > > > Functional tests ran on: > > > > - NIC: ConnectX-4 Lx / OS: Ubuntu 20.04 LTS / Driver: > > > > MLNX_OFED_LINUX-5.3-1.0.0.1 / Firmware: 14.30.1004 > > > > - NIC: ConnectX-5 / OS: Ubuntu 20.04 LTS / Driver: > > > > MLNX_OFED_LINUX-5.3-1.0.0.1 / Firmware: 16.30.1004 > > > > > > > > We discovered 2 new issues due to environment changes: > > > > - can't create some rules with count action, fixed by > > > https://inbox.dpdk.org/stable/20210621145105.963179-1- > > > lmargalit@nvidia.com/T/#u. > > > > > > As discussed in the release meeting yesterday, that is a regression > > > and needs to be added. > > > While I feel slightly tired of new respins this is what we do the validation > > for. > > > So thanks you (all!) for the testing! > > > > > > I have now applied the referred fix to 19.11.9 > > > > Thank you. > > > > > > > > FYI: I see this came up ~5 days into the -rc3 testing, but I missed it > > > so I checked why. > > > It was breaking the usual subject syntax (double colon) and not > > > flagged for > > > 19.11.9 (as requested in backport mails and the common > > > style) in subject or body. > > > > > > > - rte_flow hit counter doesn't increment, still discussing this internally. > > > > > > For this issue please tell me until Monday what you expect. > > > Does it look close to being resolved (then I'll hold -rc4 back a bit > > > longer) or should I go on planning to release 19.11.9 without it (then > > > I'd tag - > > > rc4 on Monday). > > > > We are checking if we can resolve this in the next few hours. Hope that's ok > > with you. > > Should be resolved by https://inbox.dpdk.org/stable/20210705085856.13971-1-viacheslavo@nvidia.com/T/#u. Thanks - got it, applies and is mlx-only. That should be fine. I'm doing cross-arch/cross-distro build tests before tagging -rc4 based on this. > > > > > > > > Generally on -rc4 I think it would be sufficient if you would re-run > > > your testing as your tests cover the only two things we have touched > > > in -rc4 (clang > > > 12 and the flow issue). > > > I'm not "against" more tests, just saying that those should be > > > sufficient in case no others come back then. > > > Because other than the issues reported in here all other tests already > > > came back fully green for -rc3. > > > > > > FYI the usual non-official WIP repo on > > > https://github.com/cpaelzer/dpdk-stable-queue/commits/19.11 holds > > what > > > 19.11.9-rc4 would become if you want to pre-test anything. > > > > > > > Compilation tests with multiple configurations in the following > > > > OS/driver > > > combinations are also passing: > > > > - Ubuntu 20.04.2 with MLNX_OFED_LINUX-5.3-1.0.0.1. > > > > - Ubuntu 20.04.2 with rdma-core master (a66e2a5). > > > > - Ubuntu 20.04.2 with rdma-core v28.0. > > > > - Ubuntu 18.04.5 with rdma-core v17.1. > > > > - Ubuntu 18.04.5 with rdma-core master (a66e2a5) (i386). > > > > - Ubuntu 16.04.7 with rdma-core v22.7. > > > > - Fedora 34 with rdma-core v35.0 (only with gcc). > > > > - Fedora 35 (Rawhide) with rdma-core v35.0 (only with gcc). > > > > - CentOS 7 7.9.2009 with rdma-core master (a66e2a5). > > > > - CentOS 7 7.9.2009 with MLNX_OFED_LINUX-5.3-1.0.0.1. > > > > - CentOS 8 8.3.2011 with rdma-core master (7f2d460). > > > > - OpenSUSE Leap 15.3 with rdma-core v31.0. > > > > > > > > Note that clang builds are failing in Fedora 34 and 35 due to the > > > > following > > > issues: > > > > - https://bugs.dpdk.org/show_bug.cgi?id=745 > > > > > > This is still totally unknown and not specific to 19.11 series. > > > I guess this clang issue has to wait for the next stable release then. > > > > > > > - https://bugs.dpdk.org/show_bug.cgi?id=733 > > > > > > We've identified the patch that needs to be backported for this one. > > > I have done so and built across all platforms - LGTM. > > > If your tests could also confirm this once we have -rc4 tagged that > > > would be great. > > > > Sure, I'll retest once rc4 is out. > > > > > > > > > We don't see any other critical issues blocking this release. > > > > > > > > Thanks, > > > > Ali > > > > > > > > > > > > -- > > > Christian Ehrhardt > > > Staff Engineer, Ubuntu Server > > > Canonical Ltd > > > > Thanks again Christian, > > > > Ali > > Thanks, > Ali -- Christian Ehrhardt Staff Engineer, Ubuntu Server Canonical Ltd