From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Subject: Re: [PATCH 3/4] doc: add basic invocation info for
	dpdk-devbind
Date: Wed, 31 Aug 2016 09:47:24 +0200
Message-ID: <CAATJJ0JzRZuhbZDKR7Voy6rEQYyn7N0fUg-pJpPaJZAH=mH-ZQ@mail.gmail.com>
References: <1470309419-4389-1-git-send-email-christian.ehrhardt@canonical.com>
 <1470309419-4389-4-git-send-email-christian.ehrhardt@canonical.com>
 <B27915DBBA3421428155699D51E4CFE2025D8A60@IRSMSX103.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Cc: "thomas.monjalon@6wind.com" <thomas.monjalon@6wind.com>,
 "dev@dpdk.org" <dev@dpdk.org>
To: "Mcnamara, John" <john.mcnamara@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-yw0-f176.google.com (mail-yw0-f176.google.com
 [209.85.161.176]) by dpdk.org (Postfix) with ESMTP id 8D5129E3
 for <dev@dpdk.org>; Wed, 31 Aug 2016 09:47:55 +0200 (CEST)
Received: by mail-yw0-f176.google.com with SMTP id z8so26073631ywa.1
 for <dev@dpdk.org>; Wed, 31 Aug 2016 00:47:55 -0700 (PDT)
In-Reply-To: <B27915DBBA3421428155699D51E4CFE2025D8A60@IRSMSX103.ger.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi,
thanks for sharing your RST experience - I didn't see the rst issues before.
Fixed them all and checked html/man output again - looking good to me.

On Tue, Aug 30, 2016 at 5:05 PM, Mcnamara, John <john.mcnamara@intel.com>
wrote:

> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Christian Ehrhardt
> > Sent: Thursday, August 4, 2016 12:17 PM
> > To: christian.ehrhardt@canonical.com; thomas.monjalon@6wind.com;
> > dev@dpdk.org
> > Subject: [dpdk-dev] [PATCH 3/4] doc: add basic invocation info for dpdk-
> > devbind
> >
> > +
> > +OPTIONS
> > +-------
> > +
> > +* ``--help, --usage``
> > +
> > +        Display usage information and quit
> > +
> > +* ``-s, --status``
> > +
> > +        Print the current status of all known network interfaces.
> > +        For each device, it displays the PCI domain, bus, slot and
> > function,
> > +        along with a text description of the device. Depending upon
> > whether the
> > +        device is being used by a kernel driver, the igb_uio driver, or
> > no
> > +        driver, other relevant information will be displayed:
> > +        * the Linux interface name e.g. if=eth0
> > +        * the driver being used e.g. drv=igb_uio
> > +        * any suitable drivers not currently using that device
> > +            e.g. unused=igb_uio
> > +        NOTE: if this flag is passed along with a bind/unbind option,
> the
> > +        status display will always occur after the other operations have
> > taken
> > +        place.
>
> There are a few RST errors in this file. One of theme relates to the second
> level bullet list above. There should be a blank line before and after the
> list.
>
> Also, "e.g. unused=igb_uio" should be joined to, or aligned with, the
> previous
> line.
>
> Also, it would be better to quote any fixed width strings in the docs with
> ````
> quotes, like ``unused=igb_uio``. This could be applied to any of the
> ``--options``
> in the text as well.
> > +Examples
> > +--------
> > +
> > +To display current device status:
> > +.. code-block:: console
> > +
> > +   dpdk-devbind --status
> > +
>
> All the "code-block" directives should have a blank line before them.
> However it is probably better to use the simpler :: directive, like:
>
>     To display current device status::
>
>         dpdk-devbind --status
>
>


-- 
Christian Ehrhardt
Software Engineer, Ubuntu Server
Canonical Ltd