From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96AACC07E9B for ; Wed, 21 Jul 2021 10:53:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 599906144B for ; Wed, 21 Jul 2021 10:53:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239010AbhGUKJ7 (ORCPT ); Wed, 21 Jul 2021 06:09:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239664AbhGUKGP (ORCPT ); Wed, 21 Jul 2021 06:06:15 -0400 Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 858DEC0617A9 for ; Wed, 21 Jul 2021 03:45:35 -0700 (PDT) Received: by mail-pj1-x1030.google.com with SMTP id me13-20020a17090b17cdb0290173bac8b9c9so3748707pjb.3 for ; Wed, 21 Jul 2021 03:45:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3lABi16nL4MQbRpp+EfVh/1lUieQouz0Mt1Eq3+g03o=; b=e1Kye+SB7N4WedVaQMXh+r+XKa4tTEZMwHQLriWWLC4r29k6eiqa6TbO3ygi1pNDw/ KPESXu1ee6k4rudQCQ4a16OyvOBhEPMAWpvD1pwyncIeyJx+5+Q2MIyDjKLI2HAJ0DR2 OTMAk4Hr+4D+jMX8+ll/bSXIJHTyOuqNsX2Q8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3lABi16nL4MQbRpp+EfVh/1lUieQouz0Mt1Eq3+g03o=; b=ZJu7X2GUzLCw0KkeleRBlhwI5zKf48QYePap6mkeW6YNC6lp6M/Jrnwcm96t/Yn+4I QHItV7iKbO4CDPerPvQ5hHJ9Mg2e1s2/Zn5wU55wfI1DZ8iLg4n1kwb4S5beOyTxXeh4 jQeUI3u6Z974doDimyBbe5rOuP62lmQvzQrlHjCWvbe4NhCeNXqfRghN/cKbXVp/JW7K +2Y7bkHdyluN38kh9zwhMTvcqhFHlpKq8mRBAf17EMJVIfSfLsI7TCajmJWd2vAowphF nnuCe9aJFwiAsLiYPW3HZyvP7cKqmMmtL5TUDyWabhS5+ZGmkZo+BrnrcWpLenq7n7hM UcXQ== X-Gm-Message-State: AOAM531vHndGN3phrpZ7oymslTSp5DBRgYs2wbOqrz0HVwY/RR6cq+sr AtZLsEzYj0iwkwWtUCrubWixq4eKtTdLfdsHZjzNRA== X-Google-Smtp-Source: ABdhPJwseMcBhtA89/xVOfkSjI8Er/1b+WzAHYlvJAI5MGItY7qPIiQanSoTGq6Tkh3CF9f6U0apmV9yj3pMNUucrsU= X-Received: by 2002:a17:90a:f3cb:: with SMTP id ha11mr3173568pjb.144.1626864335082; Wed, 21 Jul 2021 03:45:35 -0700 (PDT) MIME-Version: 1.0 References: <20210715121209.31024-1-yong.wu@mediatek.com> <20210715121209.31024-7-yong.wu@mediatek.com> In-Reply-To: <20210715121209.31024-7-yong.wu@mediatek.com> From: Ikjoon Jang Date: Wed, 21 Jul 2021 18:45:23 +0800 Message-ID: Subject: Re: [PATCH v2 06/11] memory: mtk-smi: Add error handle for smi_probe To: Yong Wu Cc: Krzysztof Kozlowski , Rob Herring , Matthias Brugger , Krzysztof Kozlowski , Joerg Roedel , Will Deacon , Robin Murphy , Tomasz Figa , "moderated list:ARM/Mediatek SoC support" , srv_heupstream , open list , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/Mediatek SoC support" , iommu@lists.linux-foundation.org, youlin.pei@mediatek.com, anan.sun@mediatek.com, ming-fan.chen@mediatek.com, yi.kuo@mediatek.com, anthony.huang@mediatek.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 15, 2021 at 8:23 PM Yong Wu wrote: > > Add error handle while component_add fail. > > Signed-off-by: Yong Wu Reviewed-by: Ikjoon Jang > --- > It don't have the error handle when v1. it is not a fatal error. > thus don't add fix tags. > --- > drivers/memory/mtk-smi.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c > index 6f8e582bace5..e68cbb51dd12 100644 > --- a/drivers/memory/mtk-smi.c > +++ b/drivers/memory/mtk-smi.c > @@ -330,7 +330,15 @@ static int mtk_smi_larb_probe(struct platform_device *pdev) > > pm_runtime_enable(dev); > platform_set_drvdata(pdev, larb); > - return component_add(dev, &mtk_smi_larb_component_ops); > + ret = component_add(dev, &mtk_smi_larb_component_ops); > + if (ret) > + goto err_pm_disable; > + return 0; > + > +err_pm_disable: > + pm_runtime_disable(dev); > + device_link_remove(dev, larb->smi_common_dev); > + return ret; > } > > static int mtk_smi_larb_remove(struct platform_device *pdev) > -- > 2.18.0 > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA31AC636C9 for ; Wed, 21 Jul 2021 10:54:01 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 887006127C for ; Wed, 21 Jul 2021 10:54:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 887006127C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 1D1DF40142; Wed, 21 Jul 2021 10:54:01 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oDe3qwrAc4Eo; Wed, 21 Jul 2021 10:54:00 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp2.osuosl.org (Postfix) with ESMTPS id C1529404CB; Wed, 21 Jul 2021 10:53:59 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 07D92C0029; Wed, 21 Jul 2021 10:53:59 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 68C01C000E for ; Wed, 21 Jul 2021 10:45:36 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 56E5460716 for ; Wed, 21 Jul 2021 10:45:36 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp3.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=chromium.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4v6-2h8sQaSV for ; Wed, 21 Jul 2021 10:45:35 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by smtp3.osuosl.org (Postfix) with ESMTPS id 9C5BA606C6 for ; Wed, 21 Jul 2021 10:45:35 +0000 (UTC) Received: by mail-pj1-x1032.google.com with SMTP id gx2so1399080pjb.5 for ; Wed, 21 Jul 2021 03:45:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3lABi16nL4MQbRpp+EfVh/1lUieQouz0Mt1Eq3+g03o=; b=e1Kye+SB7N4WedVaQMXh+r+XKa4tTEZMwHQLriWWLC4r29k6eiqa6TbO3ygi1pNDw/ KPESXu1ee6k4rudQCQ4a16OyvOBhEPMAWpvD1pwyncIeyJx+5+Q2MIyDjKLI2HAJ0DR2 OTMAk4Hr+4D+jMX8+ll/bSXIJHTyOuqNsX2Q8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3lABi16nL4MQbRpp+EfVh/1lUieQouz0Mt1Eq3+g03o=; b=PQXEHBMpVRJyJ6WR0p1THkIo7GI7/jNptGNTTpolJgtfW6wPTA5MA3h/JYP3gIPCRX cIRyzdyDMcXvVSn7pEBgEZ5JI8mvHrIkoQas56ccGiMpm2SkrqjlCRExktsQoerkwZsj jlZtKInEmir5W86BFsHw3R/Zk0JiIGWXvYekkl9XjhTm86ChV06JyiRMblNWYOA84n4y 48GEFmB17Il82umv3aVsMC/hgv1Mc0w+S31Qou9zgt/IO3TzIhoXuDUA/w8EPoM9s84n BSFy9kFisxdCOYr6GyOicy9zBBxWxW427mck46jWL/q8RiVJTtaG/ELLmxEwnRjMryk8 eNnA== X-Gm-Message-State: AOAM533GlFJn47Bd1ru5J7c/IQ1HHXjugyiDiNE6peAn26OIbUhaDueB B679zvbET0+BcPxbJGPLozSmOod67tuGH2CFQ6Yb4A== X-Google-Smtp-Source: ABdhPJwseMcBhtA89/xVOfkSjI8Er/1b+WzAHYlvJAI5MGItY7qPIiQanSoTGq6Tkh3CF9f6U0apmV9yj3pMNUucrsU= X-Received: by 2002:a17:90a:f3cb:: with SMTP id ha11mr3173568pjb.144.1626864335082; Wed, 21 Jul 2021 03:45:35 -0700 (PDT) MIME-Version: 1.0 References: <20210715121209.31024-1-yong.wu@mediatek.com> <20210715121209.31024-7-yong.wu@mediatek.com> In-Reply-To: <20210715121209.31024-7-yong.wu@mediatek.com> From: Ikjoon Jang Date: Wed, 21 Jul 2021 18:45:23 +0800 Message-ID: Subject: Re: [PATCH v2 06/11] memory: mtk-smi: Add error handle for smi_probe To: Yong Wu X-Mailman-Approved-At: Wed, 21 Jul 2021 10:53:57 +0000 Cc: youlin.pei@mediatek.com, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , yi.kuo@mediatek.com, srv_heupstream , Krzysztof Kozlowski , Robin Murphy , open list , Krzysztof Kozlowski , iommu@lists.linux-foundation.org, Rob Herring , "moderated list:ARM/Mediatek SoC support" , Matthias Brugger , anthony.huang@mediatek.com, ming-fan.chen@mediatek.com, anan.sun@mediatek.com, Will Deacon , "moderated list:ARM/Mediatek SoC support" X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Thu, Jul 15, 2021 at 8:23 PM Yong Wu wrote: > > Add error handle while component_add fail. > > Signed-off-by: Yong Wu Reviewed-by: Ikjoon Jang > --- > It don't have the error handle when v1. it is not a fatal error. > thus don't add fix tags. > --- > drivers/memory/mtk-smi.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c > index 6f8e582bace5..e68cbb51dd12 100644 > --- a/drivers/memory/mtk-smi.c > +++ b/drivers/memory/mtk-smi.c > @@ -330,7 +330,15 @@ static int mtk_smi_larb_probe(struct platform_device *pdev) > > pm_runtime_enable(dev); > platform_set_drvdata(pdev, larb); > - return component_add(dev, &mtk_smi_larb_component_ops); > + ret = component_add(dev, &mtk_smi_larb_component_ops); > + if (ret) > + goto err_pm_disable; > + return 0; > + > +err_pm_disable: > + pm_runtime_disable(dev); > + device_link_remove(dev, larb->smi_common_dev); > + return ret; > } > > static int mtk_smi_larb_remove(struct platform_device *pdev) > -- > 2.18.0 > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15CC5C07E9B for ; Wed, 21 Jul 2021 10:45:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C244861009 for ; Wed, 21 Jul 2021 10:45:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C244861009 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yK8g91nx0mPHfiVUsbLXiqZpcT3eadTD7WJrYHk/FSA=; b=q4t4n2Dkpc8NpU lqeK7RzNYLgViQ6lH+ThXiWo/hdNCV/uQl+RgPuw4xf97Tx5HqArg8KNQwWPGRWPO3UOO/C3DSROi V1Ky1wgjx8wZRjcZDKIZDXEyIBlbPJfS00lQjmtoPMvSpkkF+M1huO4tTHXCsyOCZrwstM/By4nDj YHh8xq2FQszOZ26Qx6vjdIHQzxaununn7ow55RkVo+uyegdJfgVBnfyNro2LrOiBaYwRiFjVxmWHe 4+EvnMOgR2n7KhJ/WD8sfd0OgY0kKFZ+ve/eqFEp9bhl7kISJImh9IZLm2R2qasWkAdCU5WYQ3Rng fk418l0xckTrfNF3bnSA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m69jP-00FHXm-B0; Wed, 21 Jul 2021 10:45:39 +0000 Received: from mail-pj1-x1035.google.com ([2607:f8b0:4864:20::1035]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m69jM-00FHVn-5H for linux-mediatek@lists.infradead.org; Wed, 21 Jul 2021 10:45:37 +0000 Received: by mail-pj1-x1035.google.com with SMTP id g24so1404789pji.4 for ; Wed, 21 Jul 2021 03:45:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3lABi16nL4MQbRpp+EfVh/1lUieQouz0Mt1Eq3+g03o=; b=e1Kye+SB7N4WedVaQMXh+r+XKa4tTEZMwHQLriWWLC4r29k6eiqa6TbO3ygi1pNDw/ KPESXu1ee6k4rudQCQ4a16OyvOBhEPMAWpvD1pwyncIeyJx+5+Q2MIyDjKLI2HAJ0DR2 OTMAk4Hr+4D+jMX8+ll/bSXIJHTyOuqNsX2Q8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3lABi16nL4MQbRpp+EfVh/1lUieQouz0Mt1Eq3+g03o=; b=UEmHNuTxtVoODa7S5uEhC0YOJIhR+meWiYE9gDlTl6WYFZI+XBBGcETRX/fCjfMUtX G3HOzXtZqQllIEIXnj/XUE+0ekbUx9H3Q7T7YS3vghjey6HNWqnP90wCtdkY4PMI6BLK lvSynfkkKGcDW7U3W4gUiOAndzdta6R+KYXwAwQjENP0IEQLR609DON2CJSwYmL8+sTE quPXZn8JFgVBh4KRqE1iWpGj1x/1mKi+IY7yb3dmgMmz/U7LcaiXHH9dXIjWYR5S60SO 8IVnAUwHhkBqIjduB15Y/R1tdBdsq39+kGHNvwsuRs0CUqHf5Ag2Ylv0DL6lS008KfAJ xgEQ== X-Gm-Message-State: AOAM532kN6eT4OfIFoZQgLHCgnbIVkvbxFqJzCaci+blYkRdRXYGfaAG kDiSrbv9gM9+Qw4Y7H/g9cFX6V/sgT0e8cSGGfdxOA== X-Google-Smtp-Source: ABdhPJwseMcBhtA89/xVOfkSjI8Er/1b+WzAHYlvJAI5MGItY7qPIiQanSoTGq6Tkh3CF9f6U0apmV9yj3pMNUucrsU= X-Received: by 2002:a17:90a:f3cb:: with SMTP id ha11mr3173568pjb.144.1626864335082; Wed, 21 Jul 2021 03:45:35 -0700 (PDT) MIME-Version: 1.0 References: <20210715121209.31024-1-yong.wu@mediatek.com> <20210715121209.31024-7-yong.wu@mediatek.com> In-Reply-To: <20210715121209.31024-7-yong.wu@mediatek.com> From: Ikjoon Jang Date: Wed, 21 Jul 2021 18:45:23 +0800 Message-ID: Subject: Re: [PATCH v2 06/11] memory: mtk-smi: Add error handle for smi_probe To: Yong Wu Cc: Krzysztof Kozlowski , Rob Herring , Matthias Brugger , Krzysztof Kozlowski , Joerg Roedel , Will Deacon , Robin Murphy , Tomasz Figa , "moderated list:ARM/Mediatek SoC support" , srv_heupstream , open list , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/Mediatek SoC support" , iommu@lists.linux-foundation.org, youlin.pei@mediatek.com, anan.sun@mediatek.com, ming-fan.chen@mediatek.com, yi.kuo@mediatek.com, anthony.huang@mediatek.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210721_034536_252254_4A9C8F3E X-CRM114-Status: GOOD ( 20.43 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Thu, Jul 15, 2021 at 8:23 PM Yong Wu wrote: > > Add error handle while component_add fail. > > Signed-off-by: Yong Wu Reviewed-by: Ikjoon Jang > --- > It don't have the error handle when v1. it is not a fatal error. > thus don't add fix tags. > --- > drivers/memory/mtk-smi.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c > index 6f8e582bace5..e68cbb51dd12 100644 > --- a/drivers/memory/mtk-smi.c > +++ b/drivers/memory/mtk-smi.c > @@ -330,7 +330,15 @@ static int mtk_smi_larb_probe(struct platform_device *pdev) > > pm_runtime_enable(dev); > platform_set_drvdata(pdev, larb); > - return component_add(dev, &mtk_smi_larb_component_ops); > + ret = component_add(dev, &mtk_smi_larb_component_ops); > + if (ret) > + goto err_pm_disable; > + return 0; > + > +err_pm_disable: > + pm_runtime_disable(dev); > + device_link_remove(dev, larb->smi_common_dev); > + return ret; > } > > static int mtk_smi_larb_remove(struct platform_device *pdev) > -- > 2.18.0 > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EFB1C12002 for ; Wed, 21 Jul 2021 10:47:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0FFEE61351 for ; Wed, 21 Jul 2021 10:47:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0FFEE61351 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BkC65y+c0HwsgKLlRECNxQazU7x60qZFy/GZIlcA4pc=; b=oJ0ARXaCiPFryy LRCfJhzaByPkkoiZKO2i87ZQhFo1MawBb+7b+88ODRO2PLw4YloZ0+++dlPj1m3HE8bFCnBJhwcKT 1fqVfidNI6HRFJcj5w23yVos/gyyJDoODiSLBjzJCST0HqDg8vakwO4JlXsPr7vgK+5j7OO1GGZe4 v49gwsmxI/hyDiPd9dTEendORx4QaJSQbD0lUcdlFFC3pJKJRzAJdHwCI/vJ+N7cQUDg+PUJOotAP jRg/6WTuqG0HEDMxQYybXumz/NapP+uHZ8OpI7yKo/deNB92hybx4kYVthguUbTWmbiBX8/s7lp5u oTeWEV13rtFq7oX54unQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m69jS-00FHYJ-LY; Wed, 21 Jul 2021 10:45:43 +0000 Received: from mail-pj1-x1036.google.com ([2607:f8b0:4864:20::1036]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m69jM-00FHVo-5P for linux-arm-kernel@lists.infradead.org; Wed, 21 Jul 2021 10:45:37 +0000 Received: by mail-pj1-x1036.google.com with SMTP id d9-20020a17090ae289b0290172f971883bso3761174pjz.1 for ; Wed, 21 Jul 2021 03:45:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3lABi16nL4MQbRpp+EfVh/1lUieQouz0Mt1Eq3+g03o=; b=e1Kye+SB7N4WedVaQMXh+r+XKa4tTEZMwHQLriWWLC4r29k6eiqa6TbO3ygi1pNDw/ KPESXu1ee6k4rudQCQ4a16OyvOBhEPMAWpvD1pwyncIeyJx+5+Q2MIyDjKLI2HAJ0DR2 OTMAk4Hr+4D+jMX8+ll/bSXIJHTyOuqNsX2Q8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3lABi16nL4MQbRpp+EfVh/1lUieQouz0Mt1Eq3+g03o=; b=VRKkBjY28MY5K1vigTjfH4C6jraz7upvciIA36uuB4qtqwgP1caD8AkFoc7QtBWd3S whFIXPVWmTSesH7kb8rUXE+Dom7TmmkwDyMNHuMrJAI0PkR43Ht6EESN4BtM5ui6shGH pRHLXKZSqd6OmVyynVKBywxHPdEIxI6yZ/pPd01ry+S9kwSII4tXsex3seS3jR+sVi/W zTheG73tv+J64cwxKpXwX9CYp6TGTRa/b/1PHCs8e6Wnq3r9hWelKdm8mzKTTgd7YERb ul9OTZrYGaonHxNiuWiBca8YxeDe6iYW0WnDN7V9tEuVJII+w3r2uv8vwWjyX7NOQd/r 9ebg== X-Gm-Message-State: AOAM532IjlknsI/tag+rI1w+oOyNQnELSkIs/NciG0wPeXL1ddB4YTic O0SlGfagrX4LLIP1C0lnqEIkhb4KJkB4aFjzHHeDwg== X-Google-Smtp-Source: ABdhPJwseMcBhtA89/xVOfkSjI8Er/1b+WzAHYlvJAI5MGItY7qPIiQanSoTGq6Tkh3CF9f6U0apmV9yj3pMNUucrsU= X-Received: by 2002:a17:90a:f3cb:: with SMTP id ha11mr3173568pjb.144.1626864335082; Wed, 21 Jul 2021 03:45:35 -0700 (PDT) MIME-Version: 1.0 References: <20210715121209.31024-1-yong.wu@mediatek.com> <20210715121209.31024-7-yong.wu@mediatek.com> In-Reply-To: <20210715121209.31024-7-yong.wu@mediatek.com> From: Ikjoon Jang Date: Wed, 21 Jul 2021 18:45:23 +0800 Message-ID: Subject: Re: [PATCH v2 06/11] memory: mtk-smi: Add error handle for smi_probe To: Yong Wu Cc: Krzysztof Kozlowski , Rob Herring , Matthias Brugger , Krzysztof Kozlowski , Joerg Roedel , Will Deacon , Robin Murphy , Tomasz Figa , "moderated list:ARM/Mediatek SoC support" , srv_heupstream , open list , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/Mediatek SoC support" , iommu@lists.linux-foundation.org, youlin.pei@mediatek.com, anan.sun@mediatek.com, ming-fan.chen@mediatek.com, yi.kuo@mediatek.com, anthony.huang@mediatek.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210721_034536_251692_037A8D70 X-CRM114-Status: GOOD ( 21.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 15, 2021 at 8:23 PM Yong Wu wrote: > > Add error handle while component_add fail. > > Signed-off-by: Yong Wu Reviewed-by: Ikjoon Jang > --- > It don't have the error handle when v1. it is not a fatal error. > thus don't add fix tags. > --- > drivers/memory/mtk-smi.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c > index 6f8e582bace5..e68cbb51dd12 100644 > --- a/drivers/memory/mtk-smi.c > +++ b/drivers/memory/mtk-smi.c > @@ -330,7 +330,15 @@ static int mtk_smi_larb_probe(struct platform_device *pdev) > > pm_runtime_enable(dev); > platform_set_drvdata(pdev, larb); > - return component_add(dev, &mtk_smi_larb_component_ops); > + ret = component_add(dev, &mtk_smi_larb_component_ops); > + if (ret) > + goto err_pm_disable; > + return 0; > + > +err_pm_disable: > + pm_runtime_disable(dev); > + device_link_remove(dev, larb->smi_common_dev); > + return ret; > } > > static int mtk_smi_larb_remove(struct platform_device *pdev) > -- > 2.18.0 > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel