From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD68AC636C9 for ; Wed, 21 Jul 2021 12:40:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C743A6121F for ; Wed, 21 Jul 2021 12:40:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236061AbhGUL7W (ORCPT ); Wed, 21 Jul 2021 07:59:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58744 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234331AbhGUL7K (ORCPT ); Wed, 21 Jul 2021 07:59:10 -0400 Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62739C061767 for ; Wed, 21 Jul 2021 05:39:42 -0700 (PDT) Received: by mail-pj1-x102a.google.com with SMTP id x13-20020a17090a46cdb0290175cf22899cso947632pjg.2 for ; Wed, 21 Jul 2021 05:39:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QEkEthW7CKgy/or0VKIC3NeiSwizxj3OuVxfIG0VkUM=; b=HSwP1Zll/dPKdP3vrbbcEcVkhx/jcMPX3H7ajHXoSwKOPW+SuuBbZWuMjK5d0IvNt6 bUWR+IarJUShSq8/4Y4ZqPCNqV+Nb9C/YIRUJqW2jpOs8ycmClELT6yzWkawxONQWZYG NDq/jPElYJ19nDgdHBtVsnlcLc+P6LA8juEuE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QEkEthW7CKgy/or0VKIC3NeiSwizxj3OuVxfIG0VkUM=; b=bL79w6/641zfG7Jd3xnBuQQVe3oJfcG05Qii+jLEE2wTc522fnbqkzf9YyZUgNJceA 28BW9Wap0qlVQulKN6D5clqGAZkP2apSWm2qagrxpuBsGs6Rhwih1bPgJc0KXv8e9W6r B4g77olZd+YDdvK0VS6kCJr1IsZbKZSzmZ6P1zUglZbBgw+rtLY3a83BVlRbGfugn39f dfSnh34s8gDPXPz9jRPA+OuNJGwd12lyHbTOGfrIZISeGBdEPXj6D6Sh1D4aWXWJkCOz FqLz/P8NrTkGJ5BItVdpRPVP5TP16C/FCd+pHKiF31K2EAv70ftHnImuuPgjpCPAM4sn ec5w== X-Gm-Message-State: AOAM532ZjYgHhkFJ6+YKbxlUvXb8F2ScUVCX/fQvB+BuC73dAhfHnfRa 7yc+qfFplqr4W3gCXwiGYo4Yqn9ML+pDP/U74ArE8Q== X-Google-Smtp-Source: ABdhPJyTnNfx5pORTNjVkzxDDgtUXvJakKiVASRPKj5kfSEKa5DHdCM0Rau3Ti5Cohe2pje9E1RCRyGbz9nE8qdnWDg= X-Received: by 2002:a17:903:22d0:b029:12b:1215:5e73 with SMTP id y16-20020a17090322d0b029012b12155e73mr27536794plg.60.1626871181882; Wed, 21 Jul 2021 05:39:41 -0700 (PDT) MIME-Version: 1.0 References: <20210715121209.31024-1-yong.wu@mediatek.com> <20210715121209.31024-10-yong.wu@mediatek.com> In-Reply-To: <20210715121209.31024-10-yong.wu@mediatek.com> From: Ikjoon Jang Date: Wed, 21 Jul 2021 20:39:31 +0800 Message-ID: Subject: Re: [PATCH v2 09/11] memory: mtk-smi: mt8195: Add smi support To: Yong Wu Cc: Krzysztof Kozlowski , Rob Herring , Matthias Brugger , Krzysztof Kozlowski , Joerg Roedel , Will Deacon , Robin Murphy , Tomasz Figa , "moderated list:ARM/Mediatek SoC support" , srv_heupstream , open list , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/Mediatek SoC support" , iommu@lists.linux-foundation.org, youlin.pei@mediatek.com, anan.sun@mediatek.com, ming-fan.chen@mediatek.com, yi.kuo@mediatek.com, anthony.huang@mediatek.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 15, 2021 at 8:22 PM Yong Wu wrote: > > MT8195 has two smi-common, their IP are the same. Only the larbs that > connect with the smi-common are different. thus the bus_sel are different > for the two smi-common. > > Signed-off-by: Yong Wu Reviewed-by: Ikjoon Jang > --- > drivers/memory/mtk-smi.c | 23 +++++++++++++++++++++++ > 1 file changed, 23 insertions(+) > > diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c > index e5a34b3952a0..3c288716a378 100644 > --- a/drivers/memory/mtk-smi.c > +++ b/drivers/memory/mtk-smi.c > @@ -250,6 +250,10 @@ static const struct mtk_smi_larb_gen mtk_smi_larb_mt8192 = { > .config_port = mtk_smi_larb_config_port_gen2_general, > }; > > +static const struct mtk_smi_larb_gen mtk_smi_larb_mt8195 = { > + .config_port = mtk_smi_larb_config_port_gen2_general, > +}; > + > static const struct of_device_id mtk_smi_larb_of_ids[] = { > {.compatible = "mediatek,mt2701-smi-larb", .data = &mtk_smi_larb_mt2701}, > {.compatible = "mediatek,mt2712-smi-larb", .data = &mtk_smi_larb_mt2712}, > @@ -258,6 +262,7 @@ static const struct of_device_id mtk_smi_larb_of_ids[] = { > {.compatible = "mediatek,mt8173-smi-larb", .data = &mtk_smi_larb_mt8173}, > {.compatible = "mediatek,mt8183-smi-larb", .data = &mtk_smi_larb_mt8183}, > {.compatible = "mediatek,mt8192-smi-larb", .data = &mtk_smi_larb_mt8192}, > + {.compatible = "mediatek,mt8195-smi-larb", .data = &mtk_smi_larb_mt8195}, > {} > }; > > @@ -430,6 +435,21 @@ static const struct mtk_smi_common_plat mtk_smi_common_mt8192 = { > F_MMU1_LARB(6), > }; > > +static const struct mtk_smi_common_plat mtk_smi_common_mt8195_vdo = { > + .type = MTK_SMI_GEN2, > + .bus_sel = F_MMU1_LARB(1) | F_MMU1_LARB(3) | F_MMU1_LARB(5) | > + F_MMU1_LARB(7), > +}; > + > +static const struct mtk_smi_common_plat mtk_smi_common_mt8195_vpp = { > + .type = MTK_SMI_GEN2, > + .bus_sel = F_MMU1_LARB(1) | F_MMU1_LARB(2) | F_MMU1_LARB(7), > +}; > + > +static const struct mtk_smi_common_plat mtk_smi_sub_common_mt8195 = { > + .type = MTK_SMI_GEN2_SUB_COMM, > +}; > + > static const struct of_device_id mtk_smi_common_of_ids[] = { > {.compatible = "mediatek,mt2701-smi-common", .data = &mtk_smi_common_gen1}, > {.compatible = "mediatek,mt2712-smi-common", .data = &mtk_smi_common_gen2}, > @@ -438,6 +458,9 @@ static const struct of_device_id mtk_smi_common_of_ids[] = { > {.compatible = "mediatek,mt8173-smi-common", .data = &mtk_smi_common_gen2}, > {.compatible = "mediatek,mt8183-smi-common", .data = &mtk_smi_common_mt8183}, > {.compatible = "mediatek,mt8192-smi-common", .data = &mtk_smi_common_mt8192}, > + {.compatible = "mediatek,mt8195-smi-common-vdo", .data = &mtk_smi_common_mt8195_vdo}, > + {.compatible = "mediatek,mt8195-smi-common-vpp", .data = &mtk_smi_common_mt8195_vpp}, > + {.compatible = "mediatek,mt8195-smi-sub-common", .data = &mtk_smi_sub_common_mt8195}, > {} > }; > > -- > 2.18.0 > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNWANTED_LANGUAGE_BODY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 779D3C636C9 for ; Wed, 21 Jul 2021 12:39:47 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F19ED6121E for ; Wed, 21 Jul 2021 12:39:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F19ED6121E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id AABBA40163; Wed, 21 Jul 2021 12:39:46 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 86E5-BF33dbG; Wed, 21 Jul 2021 12:39:45 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp2.osuosl.org (Postfix) with ESMTPS id 55316400F7; Wed, 21 Jul 2021 12:39:45 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 0C052C0010; Wed, 21 Jul 2021 12:39:45 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists.linuxfoundation.org (Postfix) with ESMTP id B76F5C000E for ; Wed, 21 Jul 2021 12:39:43 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id A5F9960783 for ; Wed, 21 Jul 2021 12:39:43 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp3.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=chromium.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id S5EwYWPbS2Mm for ; Wed, 21 Jul 2021 12:39:42 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by smtp3.osuosl.org (Postfix) with ESMTPS id 79989605DD for ; Wed, 21 Jul 2021 12:39:42 +0000 (UTC) Received: by mail-pj1-x1034.google.com with SMTP id me13-20020a17090b17cdb0290173bac8b9c9so3922768pjb.3 for ; Wed, 21 Jul 2021 05:39:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QEkEthW7CKgy/or0VKIC3NeiSwizxj3OuVxfIG0VkUM=; b=HSwP1Zll/dPKdP3vrbbcEcVkhx/jcMPX3H7ajHXoSwKOPW+SuuBbZWuMjK5d0IvNt6 bUWR+IarJUShSq8/4Y4ZqPCNqV+Nb9C/YIRUJqW2jpOs8ycmClELT6yzWkawxONQWZYG NDq/jPElYJ19nDgdHBtVsnlcLc+P6LA8juEuE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QEkEthW7CKgy/or0VKIC3NeiSwizxj3OuVxfIG0VkUM=; b=e9bwmcnMnlZVbGMrMVdaLGOmR49z3Uq3s+A+VRTziX/TZahQ05i9oR/YjmSwTUFggl uz1sOIgTIe1grQ4LgTZ2bncPoIxeNkjzEBZEK8Y3YG2PWDTRRWcUIIs+sfKJ+4mbx+nG 4jOarHhDRiDKkDxDovN26cHdKndr69iqMz+ufIcKnWIA+jS+hEQWOUA/SXUhuKGO2APS 6rb1NQxFeEdScBqyty1nISicN5+ZPHQwVOOCGVIyzZxlDTnONb8lUnXzHFGe73eMUepS gRu3rxacz23whkTsoJ3GBMQ2WvT2NTykbBtZ2RJxXZHbXbPbBYJ70lMYnLBm3rHTcXMG jYvA== X-Gm-Message-State: AOAM531JPHYE1bz53Q8mTh5I2+Rp6s1MYEdCKdIawgU6RyFEBEMTukvt Qbl47xuaZCtkJT77PxIJQTYUW0qk9aLr3mqqgts8wA== X-Google-Smtp-Source: ABdhPJyTnNfx5pORTNjVkzxDDgtUXvJakKiVASRPKj5kfSEKa5DHdCM0Rau3Ti5Cohe2pje9E1RCRyGbz9nE8qdnWDg= X-Received: by 2002:a17:903:22d0:b029:12b:1215:5e73 with SMTP id y16-20020a17090322d0b029012b12155e73mr27536794plg.60.1626871181882; Wed, 21 Jul 2021 05:39:41 -0700 (PDT) MIME-Version: 1.0 References: <20210715121209.31024-1-yong.wu@mediatek.com> <20210715121209.31024-10-yong.wu@mediatek.com> In-Reply-To: <20210715121209.31024-10-yong.wu@mediatek.com> From: Ikjoon Jang Date: Wed, 21 Jul 2021 20:39:31 +0800 Message-ID: Subject: Re: [PATCH v2 09/11] memory: mtk-smi: mt8195: Add smi support To: Yong Wu Cc: youlin.pei@mediatek.com, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , yi.kuo@mediatek.com, srv_heupstream , Krzysztof Kozlowski , Robin Murphy , open list , Krzysztof Kozlowski , iommu@lists.linux-foundation.org, Rob Herring , "moderated list:ARM/Mediatek SoC support" , Matthias Brugger , anthony.huang@mediatek.com, ming-fan.chen@mediatek.com, anan.sun@mediatek.com, Will Deacon , "moderated list:ARM/Mediatek SoC support" X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Thu, Jul 15, 2021 at 8:22 PM Yong Wu wrote: > > MT8195 has two smi-common, their IP are the same. Only the larbs that > connect with the smi-common are different. thus the bus_sel are different > for the two smi-common. > > Signed-off-by: Yong Wu Reviewed-by: Ikjoon Jang > --- > drivers/memory/mtk-smi.c | 23 +++++++++++++++++++++++ > 1 file changed, 23 insertions(+) > > diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c > index e5a34b3952a0..3c288716a378 100644 > --- a/drivers/memory/mtk-smi.c > +++ b/drivers/memory/mtk-smi.c > @@ -250,6 +250,10 @@ static const struct mtk_smi_larb_gen mtk_smi_larb_mt8192 = { > .config_port = mtk_smi_larb_config_port_gen2_general, > }; > > +static const struct mtk_smi_larb_gen mtk_smi_larb_mt8195 = { > + .config_port = mtk_smi_larb_config_port_gen2_general, > +}; > + > static const struct of_device_id mtk_smi_larb_of_ids[] = { > {.compatible = "mediatek,mt2701-smi-larb", .data = &mtk_smi_larb_mt2701}, > {.compatible = "mediatek,mt2712-smi-larb", .data = &mtk_smi_larb_mt2712}, > @@ -258,6 +262,7 @@ static const struct of_device_id mtk_smi_larb_of_ids[] = { > {.compatible = "mediatek,mt8173-smi-larb", .data = &mtk_smi_larb_mt8173}, > {.compatible = "mediatek,mt8183-smi-larb", .data = &mtk_smi_larb_mt8183}, > {.compatible = "mediatek,mt8192-smi-larb", .data = &mtk_smi_larb_mt8192}, > + {.compatible = "mediatek,mt8195-smi-larb", .data = &mtk_smi_larb_mt8195}, > {} > }; > > @@ -430,6 +435,21 @@ static const struct mtk_smi_common_plat mtk_smi_common_mt8192 = { > F_MMU1_LARB(6), > }; > > +static const struct mtk_smi_common_plat mtk_smi_common_mt8195_vdo = { > + .type = MTK_SMI_GEN2, > + .bus_sel = F_MMU1_LARB(1) | F_MMU1_LARB(3) | F_MMU1_LARB(5) | > + F_MMU1_LARB(7), > +}; > + > +static const struct mtk_smi_common_plat mtk_smi_common_mt8195_vpp = { > + .type = MTK_SMI_GEN2, > + .bus_sel = F_MMU1_LARB(1) | F_MMU1_LARB(2) | F_MMU1_LARB(7), > +}; > + > +static const struct mtk_smi_common_plat mtk_smi_sub_common_mt8195 = { > + .type = MTK_SMI_GEN2_SUB_COMM, > +}; > + > static const struct of_device_id mtk_smi_common_of_ids[] = { > {.compatible = "mediatek,mt2701-smi-common", .data = &mtk_smi_common_gen1}, > {.compatible = "mediatek,mt2712-smi-common", .data = &mtk_smi_common_gen2}, > @@ -438,6 +458,9 @@ static const struct of_device_id mtk_smi_common_of_ids[] = { > {.compatible = "mediatek,mt8173-smi-common", .data = &mtk_smi_common_gen2}, > {.compatible = "mediatek,mt8183-smi-common", .data = &mtk_smi_common_mt8183}, > {.compatible = "mediatek,mt8192-smi-common", .data = &mtk_smi_common_mt8192}, > + {.compatible = "mediatek,mt8195-smi-common-vdo", .data = &mtk_smi_common_mt8195_vdo}, > + {.compatible = "mediatek,mt8195-smi-common-vpp", .data = &mtk_smi_common_mt8195_vpp}, > + {.compatible = "mediatek,mt8195-smi-sub-common", .data = &mtk_smi_sub_common_mt8195}, > {} > }; > > -- > 2.18.0 > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNWANTED_LANGUAGE_BODY autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2ABA9C636CE for ; Wed, 21 Jul 2021 12:39:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DFE9161263 for ; Wed, 21 Jul 2021 12:39:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DFE9161263 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SQb4CPHXOMzzbSK1IHxcL+VctVqHYRKcgaD6jPDwKBY=; b=zDcHjzNqiTMLf9 eWGGKKWF+BM4i3ZjFr4Y1sAX9G9hQknQwm3OtPrqjeeiAb1Vkbgm5D+g0SF+gYbgdB+VIx3+4br/c B+H5HUQiBjEgviTJI/moMOpzcRNHIT3yQdO5CDacs8pj9KGdB6U5UIU+I/KaiAopYXpdlzYUvJ/Cq /WBwhi0UKIp21gwpZ+AimC3bf5Jw2DMjU5iFjHjPAQo4NX+Xu+/w6yF2P7Hplp2WJMN2cqu149Mxm oAJUBsby9qQ2wdeJBW+1Q6WepTF/P1n0sw4ALen5deNMNiDGCKw7MHjDoSpzb1rYFGPGCN2Fhv2+X 3neorUOG+25ipptmkXhA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m6BVq-00Fe0A-8Y; Wed, 21 Jul 2021 12:39:46 +0000 Received: from mail-pl1-x62b.google.com ([2607:f8b0:4864:20::62b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m6BVn-00FdzX-J1 for linux-mediatek@lists.infradead.org; Wed, 21 Jul 2021 12:39:45 +0000 Received: by mail-pl1-x62b.google.com with SMTP id p17so870483plf.12 for ; Wed, 21 Jul 2021 05:39:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QEkEthW7CKgy/or0VKIC3NeiSwizxj3OuVxfIG0VkUM=; b=HSwP1Zll/dPKdP3vrbbcEcVkhx/jcMPX3H7ajHXoSwKOPW+SuuBbZWuMjK5d0IvNt6 bUWR+IarJUShSq8/4Y4ZqPCNqV+Nb9C/YIRUJqW2jpOs8ycmClELT6yzWkawxONQWZYG NDq/jPElYJ19nDgdHBtVsnlcLc+P6LA8juEuE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QEkEthW7CKgy/or0VKIC3NeiSwizxj3OuVxfIG0VkUM=; b=MXpGcHEfLCIwuEuQk6T5G8Du/zcWlYD5IR4XjtrTQgH9zA8BIc3m3XMZ5Sq5qTrD+q zGKdTlKtnNxYmUAu1bUqMpv1K5g0CkSjIRMxlmxDNb465rh1fQjMzhQ95N0pDi4QReZk QNcfvgtrUPyzHM3iDWFzNVehibWGy9dw4uSI1spwOHfgY2lRw3GxYeo7poBg/MJ/6VBc H4oMZbhNeK9bjURMImGKHLx02waxf8f/HJEkPmQYepDKBAF/uwmdzZrab/x7/YfOhTOj r9QXtqfXfV0xJ/Yw+yuwXUbw95mFkader5p3xMg0n78A4CdVblJ4eh4Z95x0JgIhfN2K qYAA== X-Gm-Message-State: AOAM5332YWFVAP/BM2dQTv0x4GK76smy/2nPVi7dfYom8j7SUkpPcrP9 L07p+HaBY0TbqdxITUxlv8ssNrQkaWsc3XZ/mvrdtg== X-Google-Smtp-Source: ABdhPJyTnNfx5pORTNjVkzxDDgtUXvJakKiVASRPKj5kfSEKa5DHdCM0Rau3Ti5Cohe2pje9E1RCRyGbz9nE8qdnWDg= X-Received: by 2002:a17:903:22d0:b029:12b:1215:5e73 with SMTP id y16-20020a17090322d0b029012b12155e73mr27536794plg.60.1626871181882; Wed, 21 Jul 2021 05:39:41 -0700 (PDT) MIME-Version: 1.0 References: <20210715121209.31024-1-yong.wu@mediatek.com> <20210715121209.31024-10-yong.wu@mediatek.com> In-Reply-To: <20210715121209.31024-10-yong.wu@mediatek.com> From: Ikjoon Jang Date: Wed, 21 Jul 2021 20:39:31 +0800 Message-ID: Subject: Re: [PATCH v2 09/11] memory: mtk-smi: mt8195: Add smi support To: Yong Wu Cc: Krzysztof Kozlowski , Rob Herring , Matthias Brugger , Krzysztof Kozlowski , Joerg Roedel , Will Deacon , Robin Murphy , Tomasz Figa , "moderated list:ARM/Mediatek SoC support" , srv_heupstream , open list , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/Mediatek SoC support" , iommu@lists.linux-foundation.org, youlin.pei@mediatek.com, anan.sun@mediatek.com, ming-fan.chen@mediatek.com, yi.kuo@mediatek.com, anthony.huang@mediatek.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210721_053943_690526_44854FAC X-CRM114-Status: GOOD ( 18.81 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Thu, Jul 15, 2021 at 8:22 PM Yong Wu wrote: > > MT8195 has two smi-common, their IP are the same. Only the larbs that > connect with the smi-common are different. thus the bus_sel are different > for the two smi-common. > > Signed-off-by: Yong Wu Reviewed-by: Ikjoon Jang > --- > drivers/memory/mtk-smi.c | 23 +++++++++++++++++++++++ > 1 file changed, 23 insertions(+) > > diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c > index e5a34b3952a0..3c288716a378 100644 > --- a/drivers/memory/mtk-smi.c > +++ b/drivers/memory/mtk-smi.c > @@ -250,6 +250,10 @@ static const struct mtk_smi_larb_gen mtk_smi_larb_mt8192 = { > .config_port = mtk_smi_larb_config_port_gen2_general, > }; > > +static const struct mtk_smi_larb_gen mtk_smi_larb_mt8195 = { > + .config_port = mtk_smi_larb_config_port_gen2_general, > +}; > + > static const struct of_device_id mtk_smi_larb_of_ids[] = { > {.compatible = "mediatek,mt2701-smi-larb", .data = &mtk_smi_larb_mt2701}, > {.compatible = "mediatek,mt2712-smi-larb", .data = &mtk_smi_larb_mt2712}, > @@ -258,6 +262,7 @@ static const struct of_device_id mtk_smi_larb_of_ids[] = { > {.compatible = "mediatek,mt8173-smi-larb", .data = &mtk_smi_larb_mt8173}, > {.compatible = "mediatek,mt8183-smi-larb", .data = &mtk_smi_larb_mt8183}, > {.compatible = "mediatek,mt8192-smi-larb", .data = &mtk_smi_larb_mt8192}, > + {.compatible = "mediatek,mt8195-smi-larb", .data = &mtk_smi_larb_mt8195}, > {} > }; > > @@ -430,6 +435,21 @@ static const struct mtk_smi_common_plat mtk_smi_common_mt8192 = { > F_MMU1_LARB(6), > }; > > +static const struct mtk_smi_common_plat mtk_smi_common_mt8195_vdo = { > + .type = MTK_SMI_GEN2, > + .bus_sel = F_MMU1_LARB(1) | F_MMU1_LARB(3) | F_MMU1_LARB(5) | > + F_MMU1_LARB(7), > +}; > + > +static const struct mtk_smi_common_plat mtk_smi_common_mt8195_vpp = { > + .type = MTK_SMI_GEN2, > + .bus_sel = F_MMU1_LARB(1) | F_MMU1_LARB(2) | F_MMU1_LARB(7), > +}; > + > +static const struct mtk_smi_common_plat mtk_smi_sub_common_mt8195 = { > + .type = MTK_SMI_GEN2_SUB_COMM, > +}; > + > static const struct of_device_id mtk_smi_common_of_ids[] = { > {.compatible = "mediatek,mt2701-smi-common", .data = &mtk_smi_common_gen1}, > {.compatible = "mediatek,mt2712-smi-common", .data = &mtk_smi_common_gen2}, > @@ -438,6 +458,9 @@ static const struct of_device_id mtk_smi_common_of_ids[] = { > {.compatible = "mediatek,mt8173-smi-common", .data = &mtk_smi_common_gen2}, > {.compatible = "mediatek,mt8183-smi-common", .data = &mtk_smi_common_mt8183}, > {.compatible = "mediatek,mt8192-smi-common", .data = &mtk_smi_common_mt8192}, > + {.compatible = "mediatek,mt8195-smi-common-vdo", .data = &mtk_smi_common_mt8195_vdo}, > + {.compatible = "mediatek,mt8195-smi-common-vpp", .data = &mtk_smi_common_mt8195_vpp}, > + {.compatible = "mediatek,mt8195-smi-sub-common", .data = &mtk_smi_sub_common_mt8195}, > {} > }; > > -- > 2.18.0 > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNWANTED_LANGUAGE_BODY autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC4D9C12002 for ; Wed, 21 Jul 2021 12:41:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8CCDA6023B for ; Wed, 21 Jul 2021 12:41:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8CCDA6023B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9y0qgqPQGku2f2MLJfSYza9LncWlUppg+X11e29BYac=; b=tRV3h3bAnoG+D+ szm5UI3/DE+DZ4Z5PFDcGQBqkVnDg1V1x1YTUgLWY9JBXSf8mx/E4nYS6WDX+CZkoXpJamkKMN5a2 vO4Ah7Z1xIf1Zb9R1FDsfD2fy2Aqy0Ao98CIqggiZGosr5C/DsbEFZg2i7NlDOXq2Nw1oTa9Sk88X P5h+/kjphAbHL9J/n17kVHjvLgWv66fdrHNtQJXW4lwlIKvbdCzLNKWcyXyStfScLLRUiwYCvPllj 9XeRixKhGH5fvJXcXBNlbHWyk7FgGyB3/6HaxHqjamJHRS9PePuy8gkb4/eu/gEfbxIj37KwmsvSi qxqUrfEQ7/7CAyMEaoiQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m6BVs-00Fe0I-60; Wed, 21 Jul 2021 12:39:48 +0000 Received: from mail-pj1-x1034.google.com ([2607:f8b0:4864:20::1034]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m6BVn-00FdzW-SV for linux-arm-kernel@lists.infradead.org; Wed, 21 Jul 2021 12:39:45 +0000 Received: by mail-pj1-x1034.google.com with SMTP id d9-20020a17090ae289b0290172f971883bso3935002pjz.1 for ; Wed, 21 Jul 2021 05:39:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QEkEthW7CKgy/or0VKIC3NeiSwizxj3OuVxfIG0VkUM=; b=HSwP1Zll/dPKdP3vrbbcEcVkhx/jcMPX3H7ajHXoSwKOPW+SuuBbZWuMjK5d0IvNt6 bUWR+IarJUShSq8/4Y4ZqPCNqV+Nb9C/YIRUJqW2jpOs8ycmClELT6yzWkawxONQWZYG NDq/jPElYJ19nDgdHBtVsnlcLc+P6LA8juEuE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QEkEthW7CKgy/or0VKIC3NeiSwizxj3OuVxfIG0VkUM=; b=t9l2oOcBRnh8Cu0TNABeTBQ117P6PauwM5XLs/3mnPzgS+XfP8gQIQVIiDnG29eAHC nN+RMsZ1+OkMx0dqv8AHyjgy3ubmMgSRfrY86BrBCQpxLlz5Dk5B7dkQq5BfGzk9yBpc iWzSYymLFBK3uqZH5QMP7eYVauS3GeKunEn7RIOWvlZuKTU7lVbbq2XgR5wUztL+Vcqw akxYqIEvm/OOeIjAx+TOiRJfs0Lhdji3hDjN/KWjYb96s6kNkeobJlmvLpVVzH9JhVpG vHuWe2FoNh2EqJd3WB86+oln0ToT0fVyoeZEk1xnqWnBUAiQl9wpBG1bEp/aalarktFr WJQA== X-Gm-Message-State: AOAM530Wk9SK98f7U263+NQ32/gE98rIKi3yQcgRMTm3QR89Vz556JA9 FTsHac8wRKXcpv9z3sTz1h741Y3ILgAy5G1Fv55Crw== X-Google-Smtp-Source: ABdhPJyTnNfx5pORTNjVkzxDDgtUXvJakKiVASRPKj5kfSEKa5DHdCM0Rau3Ti5Cohe2pje9E1RCRyGbz9nE8qdnWDg= X-Received: by 2002:a17:903:22d0:b029:12b:1215:5e73 with SMTP id y16-20020a17090322d0b029012b12155e73mr27536794plg.60.1626871181882; Wed, 21 Jul 2021 05:39:41 -0700 (PDT) MIME-Version: 1.0 References: <20210715121209.31024-1-yong.wu@mediatek.com> <20210715121209.31024-10-yong.wu@mediatek.com> In-Reply-To: <20210715121209.31024-10-yong.wu@mediatek.com> From: Ikjoon Jang Date: Wed, 21 Jul 2021 20:39:31 +0800 Message-ID: Subject: Re: [PATCH v2 09/11] memory: mtk-smi: mt8195: Add smi support To: Yong Wu Cc: Krzysztof Kozlowski , Rob Herring , Matthias Brugger , Krzysztof Kozlowski , Joerg Roedel , Will Deacon , Robin Murphy , Tomasz Figa , "moderated list:ARM/Mediatek SoC support" , srv_heupstream , open list , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/Mediatek SoC support" , iommu@lists.linux-foundation.org, youlin.pei@mediatek.com, anan.sun@mediatek.com, ming-fan.chen@mediatek.com, yi.kuo@mediatek.com, anthony.huang@mediatek.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210721_053943_951144_A9A4AA18 X-CRM114-Status: GOOD ( 20.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 15, 2021 at 8:22 PM Yong Wu wrote: > > MT8195 has two smi-common, their IP are the same. Only the larbs that > connect with the smi-common are different. thus the bus_sel are different > for the two smi-common. > > Signed-off-by: Yong Wu Reviewed-by: Ikjoon Jang > --- > drivers/memory/mtk-smi.c | 23 +++++++++++++++++++++++ > 1 file changed, 23 insertions(+) > > diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c > index e5a34b3952a0..3c288716a378 100644 > --- a/drivers/memory/mtk-smi.c > +++ b/drivers/memory/mtk-smi.c > @@ -250,6 +250,10 @@ static const struct mtk_smi_larb_gen mtk_smi_larb_mt8192 = { > .config_port = mtk_smi_larb_config_port_gen2_general, > }; > > +static const struct mtk_smi_larb_gen mtk_smi_larb_mt8195 = { > + .config_port = mtk_smi_larb_config_port_gen2_general, > +}; > + > static const struct of_device_id mtk_smi_larb_of_ids[] = { > {.compatible = "mediatek,mt2701-smi-larb", .data = &mtk_smi_larb_mt2701}, > {.compatible = "mediatek,mt2712-smi-larb", .data = &mtk_smi_larb_mt2712}, > @@ -258,6 +262,7 @@ static const struct of_device_id mtk_smi_larb_of_ids[] = { > {.compatible = "mediatek,mt8173-smi-larb", .data = &mtk_smi_larb_mt8173}, > {.compatible = "mediatek,mt8183-smi-larb", .data = &mtk_smi_larb_mt8183}, > {.compatible = "mediatek,mt8192-smi-larb", .data = &mtk_smi_larb_mt8192}, > + {.compatible = "mediatek,mt8195-smi-larb", .data = &mtk_smi_larb_mt8195}, > {} > }; > > @@ -430,6 +435,21 @@ static const struct mtk_smi_common_plat mtk_smi_common_mt8192 = { > F_MMU1_LARB(6), > }; > > +static const struct mtk_smi_common_plat mtk_smi_common_mt8195_vdo = { > + .type = MTK_SMI_GEN2, > + .bus_sel = F_MMU1_LARB(1) | F_MMU1_LARB(3) | F_MMU1_LARB(5) | > + F_MMU1_LARB(7), > +}; > + > +static const struct mtk_smi_common_plat mtk_smi_common_mt8195_vpp = { > + .type = MTK_SMI_GEN2, > + .bus_sel = F_MMU1_LARB(1) | F_MMU1_LARB(2) | F_MMU1_LARB(7), > +}; > + > +static const struct mtk_smi_common_plat mtk_smi_sub_common_mt8195 = { > + .type = MTK_SMI_GEN2_SUB_COMM, > +}; > + > static const struct of_device_id mtk_smi_common_of_ids[] = { > {.compatible = "mediatek,mt2701-smi-common", .data = &mtk_smi_common_gen1}, > {.compatible = "mediatek,mt2712-smi-common", .data = &mtk_smi_common_gen2}, > @@ -438,6 +458,9 @@ static const struct of_device_id mtk_smi_common_of_ids[] = { > {.compatible = "mediatek,mt8173-smi-common", .data = &mtk_smi_common_gen2}, > {.compatible = "mediatek,mt8183-smi-common", .data = &mtk_smi_common_mt8183}, > {.compatible = "mediatek,mt8192-smi-common", .data = &mtk_smi_common_mt8192}, > + {.compatible = "mediatek,mt8195-smi-common-vdo", .data = &mtk_smi_common_mt8195_vdo}, > + {.compatible = "mediatek,mt8195-smi-common-vpp", .data = &mtk_smi_common_mt8195_vpp}, > + {.compatible = "mediatek,mt8195-smi-sub-common", .data = &mtk_smi_sub_common_mt8195}, > {} > }; > > -- > 2.18.0 > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel