From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C09D1C43460 for ; Wed, 14 Apr 2021 04:16:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8CC0F61244 for ; Wed, 14 Apr 2021 04:16:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230114AbhDNEQY (ORCPT ); Wed, 14 Apr 2021 00:16:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40702 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230010AbhDNEQT (ORCPT ); Wed, 14 Apr 2021 00:16:19 -0400 Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 953FCC061756 for ; Tue, 13 Apr 2021 21:15:58 -0700 (PDT) Received: by mail-pf1-x42b.google.com with SMTP id m11so12872844pfc.11 for ; Tue, 13 Apr 2021 21:15:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=H3/pHA1QytdkqwjWI/gVaQemFDcs5MXEtw754Smro1s=; b=F29Hu7zFQzANZPHsTA7+K9pjZqrgxssfYBE838M1T0tCylLUv5Bd4xq7EvjDRPf5aW iYoe9DaH4kXAY8PXknzVl7BmpxkRX4oInzQdW/neFeORV09agxEHn+tQ723uVcZ91VrG NkMuz19o4wjMJeQlGiW23D4PfbHzYlol1Gj0s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=H3/pHA1QytdkqwjWI/gVaQemFDcs5MXEtw754Smro1s=; b=kpTV/LdHClbK6gWnUSQAup8GfnGCrnRGKFuII8Ff5vFIE9RJXPblwScAuXszsakqkc gdoPePDMtme4xXCw+ZUqVorQdhSpRT+zv4zKVualco9riJY64vSp/FurlRlZd8NsxCQ7 chPJBEkRoaGu3IKW7HumnlBjFaIgRruBv0B8ZY4kzYZ8N2vHrD1jdX9k2UFsBsk4ky6s V5oAXvOSNSSRh/x605LAXsqZiL8XTJr4Vl+N0EtSAExS3I0KoOnTEdIf7AQ5/UBxVXFb /D8XCShug5xTfrrppOXB9wDN3vujS9dlgWGwd3pc6X1AP0Ubmlo+PMQQRUziIHtEp5G6 eZXQ== X-Gm-Message-State: AOAM533OPDyrh8mUNucicJFI4OOz2yLS/jR0+HTFmYPhCzkUIF3VLA4r h7Atk9m3lh/5H/8RXkYoM00qY4HDw4DJTqaDiacClA== X-Google-Smtp-Source: ABdhPJyBQe3jzDKjD8N8Rpl8uNcj92WPr21JgAbQ25TEX1kZs3MOe6zQnijETqkrZfG9PkmDTTRhUH//ng7XXis5I64= X-Received: by 2002:a63:1024:: with SMTP id f36mr15645361pgl.299.1618373757887; Tue, 13 Apr 2021 21:15:57 -0700 (PDT) MIME-Version: 1.0 References: <20210412113020.2724134-1-ikjn@chromium.org> <20210412113020.2724134-2-ikjn@chromium.org> <20210413145730.GA1667299@robh.at.kernel.org> In-Reply-To: <20210413145730.GA1667299@robh.at.kernel.org> From: Ikjoon Jang Date: Wed, 14 Apr 2021 12:15:47 +0800 Message-ID: Subject: Re: [PATCH v4 1/2] mfd: google,cros-ec: add DT bindings for a baseboard's switch device To: Rob Herring Cc: linux-input@vger.kernel.org, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Hsin-Yi Wang , Dmitry Torokhov , Nicolas Boichat , Benson Leung , Enric Balletbo i Serra , Guenter Roeck , Lee Jones , open list Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 13, 2021 at 10:57 PM Rob Herring wrote: > > On Mon, Apr 12, 2021 at 07:30:19PM +0800, Ikjoon Jang wrote: > > This is for ChromeOS tablets which have a 'cros_cbas' switch device > > in the "Whiskers" base board. This device can be instantiated only by > > device tree on ARM platforms. ChromeOS EC doesn't provide a way to > > probe the device. > > > > Signed-off-by: Ikjoon Jang > > > > --- > > > > Changes in v4: > > Define cros-cbase bindings inside google,cros-ec.yaml instead of > > a seperated binding document. > > > > .../devicetree/bindings/mfd/google,cros-ec.yaml | 16 ++++++++++++++++ > > 1 file changed, 16 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml > > index 76bf16ee27ec..c76809cd9f7f 100644 > > --- a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml > > +++ b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml > > @@ -127,6 +127,18 @@ patternProperties: > > type: object > > $ref: "/schemas/extcon/extcon-usbc-cros-ec.yaml#" > > > > + "^cbas$": > > Not a pattern, put under 'properties'. > > > + type: object > > + properties: > > + compatible: > > + const: google,cros-cbas > > Blank line > > > + required: > > + - compatible > > Blank line > > > + additionalProperties: false > > + description: > > Make this 1st or at least before 'properties'. ACKed, thanks! > > > + This device is used to signal when a detachable base is attached > > + to a Chrome OS tablet. > > This can't happen at runtime? There is no way to detect the switch device's existence at runtime. I'll add a note to the description about this. > > > + > > required: > > - compatible > > > > @@ -180,6 +192,10 @@ examples: > > interrupts = <99 0>; > > interrupt-parent = <&gpio7>; > > spi-max-frequency = <5000000>; > > + > > + base_detection: cbas { > > + compatible = "google,cros-cbas"; > > + }; > > }; > > }; > > > > -- > > 2.31.1.295.g9ea45b61b8-goog > >