All of lore.kernel.org
 help / color / mirror / Atom feed
From: Emil Condrea <emilcondrea@gmail.com>
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	"wei.liu2" <wei.liu2@citrix.com>,
	stefanb <stefanb@linux.vnet.ibm.com>,
	qemu-devel <qemu-devel@nongnu.org>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
	"Xu, Quan" <quan.xu@intel.com>,
	Daniel De Graaf <dgdegra@tycho.nsa.gov>
Subject: Re: [Qemu-devel] [v9 00/19] QEMU:Xen stubdom vTPM for HVM virtual machine(QEMU Part)
Date: Sun, 31 Jul 2016 12:57:59 +0300	[thread overview]
Message-ID: <CAAULxKJjeNDoa76aafU5G05mrBs-QqXMJhiSZQ3QX+ZjZpTrSA__33428.6901321777$1469959187$gmane$org@mail.gmail.com> (raw)
In-Reply-To: <20160725140941.GL1835@perard.uk.xensource.com>


[-- Attachment #1.1: Type: text/plain, Size: 1211 bytes --]

Thanks Anthony for the feedback.
I will send v10 containing fixes for patches 1 to 12 + additional patches
for
fixing code style issues for moved code.

On Mon, Jul 25, 2016 at 5:09 PM, Anthony PERARD <anthony.perard@citrix.com>
wrote:

> On Sun, Jul 10, 2016 at 02:47:31PM +0300, Emil Condrea wrote:
> > Emil Condrea (19):
> >   xen: Create a new file xen_pvdev.c
> >   xen: Create a new file xen_frontend.c
> >   xen: Move xenstore_update to xen_pvdev.c
> >   xen: Move evtchn functions to xen_pvdev.c
> >   xen: Prepare xendev qtail to be shared with frontends
> >   xen: Rename xen_be_printf to xen_pv_printf
> >   xen: Rename xen_be_unbind_evtchn
> >   xen: Rename xen_be_send_notify
> >   xen: Rename xen_be_evtchn_event
> >   xen: Rename xen_be_find_xendev
> >   xen: Rename xen_be_del_xendev
> >   xen: Rename xen_be_frontend_changed
>
> Patches from 1 to 12 looks fine but ./script/checkpatch.pl reveal some
> coding style issue in the code that is moved. Could you fix those issues
> in separate patches?  (Having separate patches for code movement and for
> coding style fix makes it easier to review.)
>
> I'll start reviewing the more complicated patches now.
>
> Thanks,
>
> --
> Anthony PERARD
>

[-- Attachment #1.2: Type: text/html, Size: 1827 bytes --]

[-- Attachment #2: Type: text/plain, Size: 127 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  parent reply	other threads:[~2016-07-31  9:57 UTC|newest]

Thread overview: 71+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-10 11:47 [Qemu-devel] [v9 00/19] QEMU:Xen stubdom vTPM for HVM virtual machine(QEMU Part) Emil Condrea
2016-07-10 11:47 ` [Qemu-devel] [PATCH 01/19] xen: Create a new file xen_pvdev.c Emil Condrea
2016-07-25 13:41   ` Anthony PERARD
2016-07-25 13:41   ` Anthony PERARD
2016-07-10 11:47 ` Emil Condrea
2016-07-10 11:47 ` [Qemu-devel] [PATCH 02/19] xen: Create a new file xen_frontend.c Emil Condrea
2016-07-10 11:47   ` Emil Condrea
2016-07-25 13:45   ` [Qemu-devel] [Xen-devel] " Anthony PERARD
2016-07-25 13:45   ` Anthony PERARD
2016-07-10 11:47 ` [Qemu-devel] [PATCH 03/19] xen: Move xenstore_update to xen_pvdev.c Emil Condrea
2016-07-10 11:47   ` Emil Condrea
2016-07-10 11:47 ` [Qemu-devel] [PATCH 04/19] xen: Move evtchn functions " Emil Condrea
2016-07-10 11:47   ` Emil Condrea
2016-07-25 13:53   ` Anthony PERARD
2016-07-25 13:53   ` [Qemu-devel] [Xen-devel] " Anthony PERARD
2016-07-27 23:16     ` Eric Blake
2016-07-27 23:16     ` [Qemu-devel] [Xen-devel] " Eric Blake
2016-07-31  9:47     ` Emil Condrea
2016-07-31  9:47     ` [Qemu-devel] [Xen-devel] " Emil Condrea
2016-07-10 11:47 ` [PATCH 05/19] xen: Prepare xendev qtail to be shared with frontends Emil Condrea
2016-07-10 11:47 ` [Qemu-devel] " Emil Condrea
2016-07-10 11:47 ` [PATCH 06/19] xen: Rename xen_be_printf to xen_pv_printf Emil Condrea
2016-07-10 11:47 ` [Qemu-devel] " Emil Condrea
2016-07-10 11:47 ` [Qemu-devel] [PATCH 07/19] xen: Rename xen_be_unbind_evtchn Emil Condrea
2016-07-10 11:47   ` Emil Condrea
2016-07-25 13:56   ` [Qemu-devel] [Xen-devel] " Anthony PERARD
2016-07-25 13:56     ` Anthony PERARD
2016-07-10 11:47 ` [Qemu-devel] [PATCH 08/19] xen: Rename xen_be_send_notify Emil Condrea
2016-07-10 11:47   ` Emil Condrea
2016-07-25 13:58   ` [Qemu-devel] [Xen-devel] " Anthony PERARD
2016-07-25 13:58     ` Anthony PERARD
2016-07-10 11:47 ` [Qemu-devel] [PATCH 09/19] xen: Rename xen_be_evtchn_event Emil Condrea
2016-07-10 11:47   ` Emil Condrea
2016-07-10 11:47 ` [Qemu-devel] [PATCH 10/19] xen: Rename xen_be_find_xendev Emil Condrea
2016-07-10 11:47   ` Emil Condrea
2016-07-10 11:47 ` [Qemu-devel] [PATCH 11/19] xen: Rename xen_be_del_xendev Emil Condrea
2016-07-10 11:47   ` Emil Condrea
2016-07-10 11:47 ` [Qemu-devel] [PATCH 12/19] xen: Rename xen_be_frontend_changed Emil Condrea
2016-07-10 11:47   ` Emil Condrea
2016-07-10 11:47 ` [Qemu-devel] [PATCH 13/19] xen: Distinguish between frontend and backend devops Emil Condrea
2016-07-10 11:47   ` Emil Condrea
2016-07-10 11:47 ` [Qemu-devel] [PATCH 14/19] Qemu-Xen-vTPM: Support for Xen stubdom vTPM command line options Emil Condrea
2016-07-10 11:47   ` Emil Condrea
2016-07-10 11:47 ` [Qemu-devel] [PATCH 15/19] Qemu-Xen-vTPM: Xen frontend driver infrastructure Emil Condrea
2016-07-10 11:47   ` Emil Condrea
2016-07-25 16:01   ` [Qemu-devel] [Xen-devel] " Anthony PERARD
2016-07-25 16:01     ` Anthony PERARD
2016-08-07 11:39     ` [Qemu-devel] [Xen-devel] " Emil Condrea
2016-08-09 11:40       ` Xuquan (Euler)
2016-08-09 11:40         ` Xuquan (Euler)
2016-08-07 11:39     ` Emil Condrea
2016-07-10 11:47 ` [Qemu-devel] [PATCH 16/19] Qemu-Xen-vTPM: Register Xen stubdom vTPM frontend driver Emil Condrea
2016-07-10 11:47   ` Emil Condrea
2016-07-10 11:47 ` [Qemu-devel] [PATCH 17/19] Qemu-Xen-vTPM: Move tpm_passthrough_is_selftest() into tpm_util.c Emil Condrea
2016-07-10 11:47   ` Emil Condrea
2016-07-10 11:47 ` [Qemu-devel] [PATCH 18/19] Qemu-Xen-vTPM: Qemu vTPM xenstubdoms backend Emil Condrea
2016-07-10 11:47   ` Emil Condrea
2016-07-10 11:47 ` [Qemu-devel] [PATCH 19/19] Qemu-Xen-vTPM: QEMU machine class is initialized before tpm_init() Emil Condrea
2016-07-10 11:47   ` Emil Condrea
2016-07-13  2:55 ` [Qemu-devel] [v9 00/19] QEMU:Xen stubdom vTPM for HVM virtual machine(QEMU Part) Xu, Quan
2016-07-14 15:33   ` Stefano Stabellini
2016-07-14 15:33   ` [Qemu-devel] " Stefano Stabellini
2016-07-17  6:56   ` Quan Xu
2016-07-17  6:56     ` Quan Xu
2016-07-13  2:55 ` Xu, Quan
2016-07-25 14:09 ` [Qemu-devel] " Anthony PERARD
2016-07-25 14:09 ` Anthony PERARD
2016-07-31  9:57   ` Emil Condrea
2016-07-31  9:57   ` Emil Condrea [this message]
2016-10-04  6:52   ` Emil Condrea
2016-10-04  6:52     ` Emil Condrea

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAULxKJjeNDoa76aafU5G05mrBs-QqXMJhiSZQ3QX+ZjZpTrSA__33428.6901321777$1469959187$gmane$org@mail.gmail.com' \
    --to=emilcondrea@gmail.com \
    --cc=anthony.perard@citrix.com \
    --cc=dgdegra@tycho.nsa.gov \
    --cc=qemu-devel@nongnu.org \
    --cc=quan.xu@intel.com \
    --cc=sstabellini@kernel.org \
    --cc=stefanb@linux.vnet.ibm.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.