From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Courbot Subject: Re: [PATCH 4/5] ARM: trusted_foundations: implement do_idle() Date: Thu, 23 Jan 2014 16:39:04 +0900 Message-ID: References: <1390299016-14105-1-git-send-email-acourbot@nvidia.com> <1390299016-14105-5-git-send-email-acourbot@nvidia.com> <52E02D8C.7090309@wwwdotorg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <52E02D8C.7090309-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Stephen Warren Cc: Alexandre Courbot , Thierry Reding , Russell King , Olof Johansson , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Linux Kernel Mailing List List-Id: linux-tegra@vger.kernel.org On Thu, Jan 23, 2014 at 5:43 AM, Stephen Warren wrote: > On 01/21/2014 03:10 AM, Alexandre Courbot wrote: >> Support the do_idle() firmware call, which is necessary to properly >> support cpuidle. > >> diff --git a/arch/arm/firmware/trusted_foundations.c b/arch/arm/firmware/trusted_foundations.c > >> +#define TF_CPU_PM 0xfffffffc >> +#define TF_CPU_PM_LP0 0xffffffe3 >> +#define TF_CPU_PM_LP1 0xffffffe6 >> +#define TF_CPU_PM_LP1_NO_MC_CLK 0xffffffe5 >> +#define TF_CPU_PM_LP2 0xffffffe4 >> +#define TF_CPU_PM_LP2_NOFLUSH_L2 0xffffffe7 > > Hmm. This must be Tegra-specific, not generic to any TF client, since > aren't the names of the suspend states (LP0, LP1, LP2) entirely specific > to Tegra? The names are negligence on my part, actually. I arbitrarily named them that way without thinking this was Tegra-only denomination. The downstream kernel does not even use these, they hardcode the values directly. Will fix that, thanks for spotting it. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932185AbaAWHj1 (ORCPT ); Thu, 23 Jan 2014 02:39:27 -0500 Received: from mail-vb0-f54.google.com ([209.85.212.54]:42974 "EHLO mail-vb0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932153AbaAWHjZ (ORCPT ); Thu, 23 Jan 2014 02:39:25 -0500 MIME-Version: 1.0 In-Reply-To: <52E02D8C.7090309@wwwdotorg.org> References: <1390299016-14105-1-git-send-email-acourbot@nvidia.com> <1390299016-14105-5-git-send-email-acourbot@nvidia.com> <52E02D8C.7090309@wwwdotorg.org> From: Alexandre Courbot Date: Thu, 23 Jan 2014 16:39:04 +0900 Message-ID: Subject: Re: [PATCH 4/5] ARM: trusted_foundations: implement do_idle() To: Stephen Warren Cc: Alexandre Courbot , Thierry Reding , Russell King , Olof Johansson , "linux-arm-kernel@lists.infradead.org" , "linux-tegra@vger.kernel.org" , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 23, 2014 at 5:43 AM, Stephen Warren wrote: > On 01/21/2014 03:10 AM, Alexandre Courbot wrote: >> Support the do_idle() firmware call, which is necessary to properly >> support cpuidle. > >> diff --git a/arch/arm/firmware/trusted_foundations.c b/arch/arm/firmware/trusted_foundations.c > >> +#define TF_CPU_PM 0xfffffffc >> +#define TF_CPU_PM_LP0 0xffffffe3 >> +#define TF_CPU_PM_LP1 0xffffffe6 >> +#define TF_CPU_PM_LP1_NO_MC_CLK 0xffffffe5 >> +#define TF_CPU_PM_LP2 0xffffffe4 >> +#define TF_CPU_PM_LP2_NOFLUSH_L2 0xffffffe7 > > Hmm. This must be Tegra-specific, not generic to any TF client, since > aren't the names of the suspend states (LP0, LP1, LP2) entirely specific > to Tegra? The names are negligence on my part, actually. I arbitrarily named them that way without thinking this was Tegra-only denomination. The downstream kernel does not even use these, they hardcode the values directly. Will fix that, thanks for spotting it. From mboxrd@z Thu Jan 1 00:00:00 1970 From: gnurou@gmail.com (Alexandre Courbot) Date: Thu, 23 Jan 2014 16:39:04 +0900 Subject: [PATCH 4/5] ARM: trusted_foundations: implement do_idle() In-Reply-To: <52E02D8C.7090309@wwwdotorg.org> References: <1390299016-14105-1-git-send-email-acourbot@nvidia.com> <1390299016-14105-5-git-send-email-acourbot@nvidia.com> <52E02D8C.7090309@wwwdotorg.org> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Jan 23, 2014 at 5:43 AM, Stephen Warren wrote: > On 01/21/2014 03:10 AM, Alexandre Courbot wrote: >> Support the do_idle() firmware call, which is necessary to properly >> support cpuidle. > >> diff --git a/arch/arm/firmware/trusted_foundations.c b/arch/arm/firmware/trusted_foundations.c > >> +#define TF_CPU_PM 0xfffffffc >> +#define TF_CPU_PM_LP0 0xffffffe3 >> +#define TF_CPU_PM_LP1 0xffffffe6 >> +#define TF_CPU_PM_LP1_NO_MC_CLK 0xffffffe5 >> +#define TF_CPU_PM_LP2 0xffffffe4 >> +#define TF_CPU_PM_LP2_NOFLUSH_L2 0xffffffe7 > > Hmm. This must be Tegra-specific, not generic to any TF client, since > aren't the names of the suspend states (LP0, LP1, LP2) entirely specific > to Tegra? The names are negligence on my part, actually. I arbitrarily named them that way without thinking this was Tegra-only denomination. The downstream kernel does not even use these, they hardcode the values directly. Will fix that, thanks for spotting it.