All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexandre Courbot <gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Ilia Mirkin <imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org>
Cc: Deepak Goyal <dgoyal-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
	Ben Skeggs <bskeggs-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	"nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
	<nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>,
	"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [Nouveau] [PATCH] pmu/gk20a: PMU boot support.
Date: Fri, 13 Mar 2015 10:56:26 +0900	[thread overview]
Message-ID: <CAAVeFuJi2tSwuRyU+-yp3OQ_Un7J_--S=7VgPCatpGk_JJ6BdQ@mail.gmail.com> (raw)
In-Reply-To: <CAKb7UvgDq-FzZwAZ8VwbhaVHi4B29jXL5qjOCQ47TWfqDBDQaA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

On Fri, Mar 13, 2015 at 7:11 AM, Ilia Mirkin <imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org> wrote:
> I guess Alexandre will help you prepare this for upstream inclusion,
> but just want to make sure that my main point makes it across -- this
> is a 3K line patch. Please try to split it up into patches that add no
> more than 300 lines at a time, preferably fewer (but this isn't always
> possible). Ideally each patch should introduce one conceptual unit. Of
> course different people might draw the line of "conceptual unit"
> differently, but try to do it so that each one becomes 100-300 lines
> of code :)

Yes, please let me take care of the first few rounds of reviews. I
don't know how much this patch can be split though, as it is supposed
to be the "basic" stuff for PMU. :)

Anyway, will come again later today with a thorough review.

  parent reply	other threads:[~2015-03-13  1:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-11  6:33 [PATCH] pmu/gk20a: PMU boot support Deepak Goyal
     [not found] ` <1426055631-1166-1-git-send-email-dgoyal-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2015-03-11 17:10   ` [Nouveau] " Ilia Mirkin
     [not found]     ` <CAKb7Uvj0xMvDWjKjGzbD6Tk0NArfkh4Vjvt4eRQ8XoHgR+7bsg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-03-12  5:20       ` Deepak Goyal
     [not found]         ` <25b5050176544f47b0ac74d4086f145c-7W72rfoJkVm6sJks/06JalaTQe2KTcn/@public.gmane.org>
2015-03-12 22:11           ` Ilia Mirkin
     [not found]             ` <CAKb7UvgDq-FzZwAZ8VwbhaVHi4B29jXL5qjOCQ47TWfqDBDQaA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-03-13  1:56               ` Alexandre Courbot [this message]
2015-03-13 10:12   ` Alexandre Courbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAVeFuJi2tSwuRyU+-yp3OQ_Un7J_--S=7VgPCatpGk_JJ6BdQ@mail.gmail.com' \
    --to=gnurou-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=bskeggs-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=dgoyal-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.