From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752553AbcGBBTd (ORCPT ); Fri, 1 Jul 2016 21:19:33 -0400 Received: from mail-it0-f66.google.com ([209.85.214.66]:35807 "EHLO mail-it0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752043AbcGBBTb (ORCPT ); Fri, 1 Jul 2016 21:19:31 -0400 MIME-Version: 1.0 In-Reply-To: <1467330612-26242-3-git-send-email-mmayer@broadcom.com> References: <1467330612-26242-1-git-send-email-mmayer@broadcom.com> <1467330612-26242-3-git-send-email-mmayer@broadcom.com> From: Alexandre Courbot Date: Sat, 2 Jul 2016 10:18:11 +0900 Message-ID: Subject: Re: [Nouveau] [PATCH 2/6] drm/nouveau/core: make use of new strtolower() function To: Markus Mayer Cc: Ben Skeggs , David Airlie , Alexandre Courbot , "nouveau@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 1, 2016 at 8:50 AM, Markus Mayer wrote: > Call strtolower() rather than walking the string explicitly to convert > it to lowercase. > > Signed-off-by: Markus Mayer > --- > drivers/gpu/drm/nouveau/nvkm/core/firmware.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c > index 34ecd4a..c50594c 100644 > --- a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c > +++ b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c > @@ -36,16 +36,11 @@ nvkm_firmware_get(struct nvkm_device *device, const char *fwname, > { > char f[64]; > char cname[16]; > - int i; > > /* Convert device name to lowercase */ > strncpy(cname, device->chip->name, sizeof(cname)); > cname[sizeof(cname) - 1] = '\0'; > - i = strlen(cname); > - while (i) { > - --i; > - cname[i] = tolower(cname[i]); > - } > + strtolower(cname); This function doesn't seem to exist as of next-20160701, where have you found it? From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Courbot Subject: Re: [Nouveau] [PATCH 2/6] drm/nouveau/core: make use of new strtolower() function Date: Sat, 2 Jul 2016 10:18:11 +0900 Message-ID: References: <1467330612-26242-1-git-send-email-mmayer@broadcom.com> <1467330612-26242-3-git-send-email-mmayer@broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1467330612-26242-3-git-send-email-mmayer@broadcom.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Markus Mayer Cc: "nouveau@lists.freedesktop.org" , Linux Kernel Mailing List , "dri-devel@lists.freedesktop.org" , Ben Skeggs List-Id: nouveau.vger.kernel.org T24gRnJpLCBKdWwgMSwgMjAxNiBhdCA4OjUwIEFNLCBNYXJrdXMgTWF5ZXIgPG1tYXllckBicm9h ZGNvbS5jb20+IHdyb3RlOgo+IENhbGwgc3RydG9sb3dlcigpIHJhdGhlciB0aGFuIHdhbGtpbmcg dGhlIHN0cmluZyBleHBsaWNpdGx5IHRvIGNvbnZlcnQKPiBpdCB0byBsb3dlcmNhc2UuCj4KPiBT aWduZWQtb2ZmLWJ5OiBNYXJrdXMgTWF5ZXIgPG1tYXllckBicm9hZGNvbS5jb20+Cj4gLS0tCj4g IGRyaXZlcnMvZ3B1L2RybS9ub3V2ZWF1L252a20vY29yZS9maXJtd2FyZS5jIHwgNyArLS0tLS0t Cj4gIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgNiBkZWxldGlvbnMoLSkKPgo+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vbm91dmVhdS9udmttL2NvcmUvZmlybXdhcmUuYyBi L2RyaXZlcnMvZ3B1L2RybS9ub3V2ZWF1L252a20vY29yZS9maXJtd2FyZS5jCj4gaW5kZXggMzRl Y2Q0YS4uYzUwNTk0YyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vbm91dmVhdS9udmtt L2NvcmUvZmlybXdhcmUuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9ub3V2ZWF1L252a20vY29y ZS9maXJtd2FyZS5jCj4gQEAgLTM2LDE2ICszNiwxMSBAQCBudmttX2Zpcm13YXJlX2dldChzdHJ1 Y3QgbnZrbV9kZXZpY2UgKmRldmljZSwgY29uc3QgY2hhciAqZnduYW1lLAo+ICB7Cj4gICAgICAg ICBjaGFyIGZbNjRdOwo+ICAgICAgICAgY2hhciBjbmFtZVsxNl07Cj4gLSAgICAgICBpbnQgaTsK Pgo+ICAgICAgICAgLyogQ29udmVydCBkZXZpY2UgbmFtZSB0byBsb3dlcmNhc2UgKi8KPiAgICAg ICAgIHN0cm5jcHkoY25hbWUsIGRldmljZS0+Y2hpcC0+bmFtZSwgc2l6ZW9mKGNuYW1lKSk7Cj4g ICAgICAgICBjbmFtZVtzaXplb2YoY25hbWUpIC0gMV0gPSAnXDAnOwo+IC0gICAgICAgaSA9IHN0 cmxlbihjbmFtZSk7Cj4gLSAgICAgICB3aGlsZSAoaSkgewo+IC0gICAgICAgICAgICAgICAtLWk7 Cj4gLSAgICAgICAgICAgICAgIGNuYW1lW2ldID0gdG9sb3dlcihjbmFtZVtpXSk7Cj4gLSAgICAg ICB9Cj4gKyAgICAgICBzdHJ0b2xvd2VyKGNuYW1lKTsKClRoaXMgZnVuY3Rpb24gZG9lc24ndCBz ZWVtIHRvIGV4aXN0IGFzIG9mIG5leHQtMjAxNjA3MDEsIHdoZXJlIGhhdmUKeW91IGZvdW5kIGl0 PwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2 ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK