From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Courbot Subject: Re: [PATCH V2 05/10] firmware: tegra: add BPMP support Date: Thu, 7 Jul 2016 11:24:39 +0900 Message-ID: References: <20160705090431.5852-1-josephl@nvidia.com> <20160705090431.5852-6-josephl@nvidia.com> <577D363A.4010003@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <577D363A.4010003@nvidia.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Matt Longnecker Cc: Mark Rutland , "devicetree@vger.kernel.org" , Stephen Warren , Catalin Marinas , Peter De Schrijver , Jassi Brar , Will Deacon , Linux Kernel Mailing List , Rob Herring , Thierry Reding , Joseph Lo , "linux-tegra@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" List-Id: linux-tegra@vger.kernel.org On Thu, Jul 7, 2016 at 1:47 AM, Matt Longnecker wrote: > Alex, > > > On 07/06/2016 04:39 AM, Alexandre Courbot wrote: >>> >>> diff --git a/include/soc/tegra/bpmp_abi.h b/include/soc/tegra/bpmp_abi.h >>> >new file mode 100644 >>> >index 000000000000..0aaef5960e29 >>> >--- /dev/null >>> >+++ b/include/soc/tegra/bpmp_abi.h >>> >@@ -0,0 +1,1601 @@ >>> >+/* >>> >+ * Copyright (c) 2014-2016, NVIDIA CORPORATION. All rights reserved. >>> >+ * >>> >+ * This program is free software; you can redistribute it and/or modify >>> > it >>> >+ * under the terms and conditions of the GNU General Public License, >>> >+ * version 2, as published by the Free Software Foundation. >>> >+ * >>> >+ * This program is distributed in the hope it will be useful, but >>> > WITHOUT >>> >+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY >>> > or >>> >+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public >>> > License for >>> >+ * more details. >>> >+ * >>> >+ * You should have received a copy of the GNU General Public License >>> >+ * along with this program. If not, see. >>> >+ */ >>> >+ >>> >+#ifndef_ABI_BPMP_ABI_H_ >>> >+#define_ABI_BPMP_ABI_H_ >>> >+ >>> >> ... >> >> There is a lot of stuff in this file, most of which we are not using >> now - this is ok, but unless this is a file synced from an outside >> resource maybe we should trim the structures we don't need and add >> them as we make use of them? It helps dividing the work in bite-size >> chunks. >> >> Regarding the documentation format of this file, is this valid kernel >> documentation since the adoption of Sphynx? Or is it whatever the >> origin is using? > > bpmp_abi.h is meant to be delivered as is from an NVIDIA internal repo to a > variety of OS'es. Each of them has a different documentation standard and > coding standard. > > I'd like to avoid trimming parts from the file (or even worse modifying > parts of the file) so that future deliveries are trivial. Makes sense, thanks to you and Stephen for the clarification. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756083AbcGGCZo (ORCPT ); Wed, 6 Jul 2016 22:25:44 -0400 Received: from mail-io0-f176.google.com ([209.85.223.176]:34044 "EHLO mail-io0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754511AbcGGCZm (ORCPT ); Wed, 6 Jul 2016 22:25:42 -0400 MIME-Version: 1.0 In-Reply-To: <577D363A.4010003@nvidia.com> References: <20160705090431.5852-1-josephl@nvidia.com> <20160705090431.5852-6-josephl@nvidia.com> <577D363A.4010003@nvidia.com> From: Alexandre Courbot Date: Thu, 7 Jul 2016 11:24:39 +0900 Message-ID: Subject: Re: [PATCH V2 05/10] firmware: tegra: add BPMP support To: Matt Longnecker Cc: Joseph Lo , Stephen Warren , Thierry Reding , "linux-tegra@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Rob Herring , Mark Rutland , Peter De Schrijver , "devicetree@vger.kernel.org" , Jassi Brar , Linux Kernel Mailing List , Catalin Marinas , Will Deacon Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 7, 2016 at 1:47 AM, Matt Longnecker wrote: > Alex, > > > On 07/06/2016 04:39 AM, Alexandre Courbot wrote: >>> >>> diff --git a/include/soc/tegra/bpmp_abi.h b/include/soc/tegra/bpmp_abi.h >>> >new file mode 100644 >>> >index 000000000000..0aaef5960e29 >>> >--- /dev/null >>> >+++ b/include/soc/tegra/bpmp_abi.h >>> >@@ -0,0 +1,1601 @@ >>> >+/* >>> >+ * Copyright (c) 2014-2016, NVIDIA CORPORATION. All rights reserved. >>> >+ * >>> >+ * This program is free software; you can redistribute it and/or modify >>> > it >>> >+ * under the terms and conditions of the GNU General Public License, >>> >+ * version 2, as published by the Free Software Foundation. >>> >+ * >>> >+ * This program is distributed in the hope it will be useful, but >>> > WITHOUT >>> >+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY >>> > or >>> >+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public >>> > License for >>> >+ * more details. >>> >+ * >>> >+ * You should have received a copy of the GNU General Public License >>> >+ * along with this program. If not, see. >>> >+ */ >>> >+ >>> >+#ifndef_ABI_BPMP_ABI_H_ >>> >+#define_ABI_BPMP_ABI_H_ >>> >+ >>> >> ... >> >> There is a lot of stuff in this file, most of which we are not using >> now - this is ok, but unless this is a file synced from an outside >> resource maybe we should trim the structures we don't need and add >> them as we make use of them? It helps dividing the work in bite-size >> chunks. >> >> Regarding the documentation format of this file, is this valid kernel >> documentation since the adoption of Sphynx? Or is it whatever the >> origin is using? > > bpmp_abi.h is meant to be delivered as is from an NVIDIA internal repo to a > variety of OS'es. Each of them has a different documentation standard and > coding standard. > > I'd like to avoid trimming parts from the file (or even worse modifying > parts of the file) so that future deliveries are trivial. Makes sense, thanks to you and Stephen for the clarification. From mboxrd@z Thu Jan 1 00:00:00 1970 From: gnurou@gmail.com (Alexandre Courbot) Date: Thu, 7 Jul 2016 11:24:39 +0900 Subject: [PATCH V2 05/10] firmware: tegra: add BPMP support In-Reply-To: <577D363A.4010003@nvidia.com> References: <20160705090431.5852-1-josephl@nvidia.com> <20160705090431.5852-6-josephl@nvidia.com> <577D363A.4010003@nvidia.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Jul 7, 2016 at 1:47 AM, Matt Longnecker wrote: > Alex, > > > On 07/06/2016 04:39 AM, Alexandre Courbot wrote: >>> >>> diff --git a/include/soc/tegra/bpmp_abi.h b/include/soc/tegra/bpmp_abi.h >>> >new file mode 100644 >>> >index 000000000000..0aaef5960e29 >>> >--- /dev/null >>> >+++ b/include/soc/tegra/bpmp_abi.h >>> >@@ -0,0 +1,1601 @@ >>> >+/* >>> >+ * Copyright (c) 2014-2016, NVIDIA CORPORATION. All rights reserved. >>> >+ * >>> >+ * This program is free software; you can redistribute it and/or modify >>> > it >>> >+ * under the terms and conditions of the GNU General Public License, >>> >+ * version 2, as published by the Free Software Foundation. >>> >+ * >>> >+ * This program is distributed in the hope it will be useful, but >>> > WITHOUT >>> >+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY >>> > or >>> >+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public >>> > License for >>> >+ * more details. >>> >+ * >>> >+ * You should have received a copy of the GNU General Public License >>> >+ * along with this program. If not, see. >>> >+ */ >>> >+ >>> >+#ifndef_ABI_BPMP_ABI_H_ >>> >+#define_ABI_BPMP_ABI_H_ >>> >+ >>> >> ... >> >> There is a lot of stuff in this file, most of which we are not using >> now - this is ok, but unless this is a file synced from an outside >> resource maybe we should trim the structures we don't need and add >> them as we make use of them? It helps dividing the work in bite-size >> chunks. >> >> Regarding the documentation format of this file, is this valid kernel >> documentation since the adoption of Sphynx? Or is it whatever the >> origin is using? > > bpmp_abi.h is meant to be delivered as is from an NVIDIA internal repo to a > variety of OS'es. Each of them has a different documentation standard and > coding standard. > > I'd like to avoid trimming parts from the file (or even worse modifying > parts of the file) so that future deliveries are trivial. Makes sense, thanks to you and Stephen for the clarification.