From: Alexandre Courbot <gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Nicolas Chauvet <kwizart-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Ben Skeggs <skeggsb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
<nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>,
"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH v2] nouveau: arm: Add MODULE_FIRMWARE for gk20a
Date: Thu, 12 Nov 2015 21:53:50 +0900 [thread overview]
Message-ID: <CAAVeFuLNadYawJB0zZHzMc3CA7GiukEox=FGH8wupXjyK576MQ@mail.gmail.com> (raw)
In-Reply-To: <CABr+WTmG1p6-dGGpWJgGBAJydyWz=2aPj-e93X9metn8y8Qrcg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Wed, Nov 11, 2015 at 6:29 PM, Nicolas Chauvet <kwizart-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> 2015-09-30 6:57 GMT+02:00 Alexandre Courbot <gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>:
>>
>> On Tue, Sep 29, 2015 at 12:08 AM, Nicolas Chauvet <kwizart-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>> wrote:
>> > This patch is needed by initramfs tools to detect
>> > the required firmware files for the module.
>> >
>> > This patch tests for either TEGRA_124_SOC or TEGRA_132_SOC
>> > for the firmwares related to the Tegra K1 generation.
>> >
>> > v2: move the MODULE_FIRMWARE to the nvidia_platform.c file.
>> > This will avoid to test for NOUVEAU_PLATFORM_DRIVER
>>
>> Nice, thanks for doing this change!
>>
>> Reviewed-by: Alexandre Courbot <acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>
>
> Thx for the review.
> FYI I've tested the patch on top of 4.3+ kernels, and the initramfs
> generated with dracut works as expected.
>
> Is there any other concern with this patch ?
>
> It's certainly late for 4.4,I would expect it to hit kernel 4.3 at some
> point, but I don't think everything is wired from userspace(Xorg/Wayland)
> wrt dGPU support.
> So It could also wait for 4.5.
> What do you think ?
I don't see a particular reason to hurry, however this patch has been
sitting around for one month now - Ben, is there any particular reason
for not merging it?
WARNING: multiple messages have this Message-ID (diff)
From: gnurou@gmail.com (Alexandre Courbot)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] nouveau: arm: Add MODULE_FIRMWARE for gk20a
Date: Thu, 12 Nov 2015 21:53:50 +0900 [thread overview]
Message-ID: <CAAVeFuLNadYawJB0zZHzMc3CA7GiukEox=FGH8wupXjyK576MQ@mail.gmail.com> (raw)
In-Reply-To: <CABr+WTmG1p6-dGGpWJgGBAJydyWz=2aPj-e93X9metn8y8Qrcg@mail.gmail.com>
On Wed, Nov 11, 2015 at 6:29 PM, Nicolas Chauvet <kwizart@gmail.com> wrote:
> 2015-09-30 6:57 GMT+02:00 Alexandre Courbot <gnurou@gmail.com>:
>>
>> On Tue, Sep 29, 2015 at 12:08 AM, Nicolas Chauvet <kwizart@gmail.com>
>> wrote:
>> > This patch is needed by initramfs tools to detect
>> > the required firmware files for the module.
>> >
>> > This patch tests for either TEGRA_124_SOC or TEGRA_132_SOC
>> > for the firmwares related to the Tegra K1 generation.
>> >
>> > v2: move the MODULE_FIRMWARE to the nvidia_platform.c file.
>> > This will avoid to test for NOUVEAU_PLATFORM_DRIVER
>>
>> Nice, thanks for doing this change!
>>
>> Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
>
>
> Thx for the review.
> FYI I've tested the patch on top of 4.3+ kernels, and the initramfs
> generated with dracut works as expected.
>
> Is there any other concern with this patch ?
>
> It's certainly late for 4.4,I would expect it to hit kernel 4.3 at some
> point, but I don't think everything is wired from userspace(Xorg/Wayland)
> wrt dGPU support.
> So It could also wait for 4.5.
> What do you think ?
I don't see a particular reason to hurry, however this patch has been
sitting around for one month now - Ben, is there any particular reason
for not merging it?
next prev parent reply other threads:[~2015-11-12 12:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-28 15:08 [PATCH v2] nouveau: arm: Add MODULE_FIRMWARE for gk20a Nicolas Chauvet
2015-09-28 15:08 ` Nicolas Chauvet
[not found] ` <1443452893-18246-1-git-send-email-kwizart-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-09-30 4:57 ` Alexandre Courbot
2015-09-30 4:57 ` Alexandre Courbot
[not found] ` <CAAVeFuJLJO4LvLqq2w9gMe6V6L3VDi+Gz59GvwKF2v8OWTWgBQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-11-11 9:29 ` Nicolas Chauvet
[not found] ` <CABr+WTmG1p6-dGGpWJgGBAJydyWz=2aPj-e93X9metn8y8Qrcg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-11-12 12:53 ` Alexandre Courbot [this message]
2015-11-12 12:53 ` Alexandre Courbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAVeFuLNadYawJB0zZHzMc3CA7GiukEox=FGH8wupXjyK576MQ@mail.gmail.com' \
--to=gnurou-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=kwizart-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=skeggsb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.