Re: [PATCH v3] staging: gasket: Fix sparse "incorrect type in assignment" warnings.

[Todd Poynor <toddpoynor@google.com>]

On Wed, Oct 10, 2018 at 2:14 PM Laurence Rochfort
<laurence.rochfort@gmail.com> wrote:
>
> Remove the coherent buffer __iomem cookie because the buffer is
> allocated from dma_alloc_coherent().
>
> warning: incorrect type in assignment (different address spaces)
>    expected unsigned char [noderef] [usertype] <asn:2>*virt_base
>    got void *[assigned] mem
> warning: incorrect type in argument 3 (different address spaces)
>    expected void *cpu_addr
>    got unsigned char [noderef] [usertype] <asn:2>*virt_base
>
> Signed-off-by: Laurence Rochfort <laurence.rochfort@gmail.com>
> ---
> Changes in v3:
>  - Just remove the __iommem cookie, don't alter type.
>
>  drivers/staging/gasket/gasket_core.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/gasket/gasket_core.h b/drivers/staging/gasket/gasket_core.h
> index 275fd0b..e62adcd 100644
> --- a/drivers/staging/gasket/gasket_core.h
> +++ b/drivers/staging/gasket/gasket_core.h
> @@ -231,7 +231,7 @@ struct gasket_coherent_buffer_desc {
>  /* Coherent buffer structure. */
>  struct gasket_coherent_buffer {
>         /* Virtual base address. */
> -       u8 __iomem *virt_base;
> +       u8 *virt_base;
>
>         /* Physical base address. */
>         ulong phys_base;
> --
> 2.9.5

Reviewed-by: Todd Poynor <toddpoynor@google.com>

Thanks!