All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas De Schampheleire <patrickdepinguin@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] manual: use one-line titles instead of two-line titles (trivial)
Date: Fri, 2 May 2014 13:25:59 +0200	[thread overview]
Message-ID: <CAAXf6LVP1xtcgBRD5ztrKt9mSbOC5JK-3aO20PDjVL1TrfcxBQ@mail.gmail.com> (raw)
In-Reply-To: <20140502104351.GB3503@free.fr>

Hi Yann,

On Fri, May 2, 2014 at 12:43 PM, Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> Thomas, All,
>
> On 2014-05-02 07:47 +0200, Thomas De Schampheleire spake thusly:
>> Asciidoc supports two syntaxes for section titles: two-line titles (title
>> plus underline consisting of a particular symbol), and one-line titles
>> (title prefixed with a specific number of = signs).
> [--SNIP--]
>> and the one-line title prefixes:
>> = Document Title (level 0) =
>> == Section title (level 1) ==
>> === Section title (level 2) ===
>> ==== Section title (level 3) ====
>> ===== Section title (level 4) =====
>
> Here you use both a prefix and a suffix...
>
>> diff --git a/docs/manual/adding-packages-autotools.txt b/docs/manual/adding-packages-autotools.txt
>> --- a/docs/manual/adding-packages-autotools.txt
>> +++ b/docs/manual/adding-packages-autotools.txt
>> @@ -1,13 +1,11 @@
>>  // -*- mode:doc; -*-
>>  // vim: set syntax=asciidoc:
>>
>> -Infrastructure for autotools-based packages
>> -~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> +=== Infrastructure for autotools-based packages
>
> ... but your script only added the prefix.
>
> I just checked, and asciidoc does the right thing. The asciidoc site
> itself is written with only the prefixes, and the doc says the suffix is
> optional.
>
> Yet, I found it weird that the commit log says one thing, but the patch
> does it differently. I don't care either way, but it should have been
> coherent.

Sorry about this irregularity in the commit message. That part was
copied verbatim from the asciidoc documentation, and I did not fully
realize it still had the suffixes which I didn't add in the actual
code.
I don't like the optional suffixes a lot, as it doesn't provide any
more clarity than the prefix does and is overhead to type (and
change). So not adding the suffixes was intentional (I was aware that
it's optional in asciidoc).

Thanks for the feedback,
Thomas

      reply	other threads:[~2014-05-02 11:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-02  5:47 [Buildroot] [PATCH] manual: use one-line titles instead of two-line titles (trivial) Thomas De Schampheleire
2014-05-02  8:31 ` Peter Korsgaard
2014-05-02 10:43 ` Yann E. MORIN
2014-05-02 11:25   ` Thomas De Schampheleire [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAAXf6LVP1xtcgBRD5ztrKt9mSbOC5JK-3aO20PDjVL1TrfcxBQ@mail.gmail.com \
    --to=patrickdepinguin@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.