All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas De Schampheleire <patrickdepinguin@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/3] fs/iso9660: allow building a hybrid ISO image
Date: Tue, 3 Feb 2015 15:35:42 +0100	[thread overview]
Message-ID: <CAAXf6LWGd=qMbMgivXYX6ExOgKmRBEgeMgODZtsvHFTvLV+URQ@mail.gmail.com> (raw)
In-Reply-To: <CAOJKDvJR6jdHuQMq14GyRQDihSFEs-OMD+QDBSb8XRt7dBov9Q@mail.gmail.com>

Hi No?,

On Tue, Feb 3, 2015 at 10:43 AM, No? RUBINSTEIN
<nrubinstein@aldebaran.com> wrote:
> Hi Thomas, thanks for your review.
>
> 2015-02-02 21:39 GMT+01:00 Thomas De Schampheleire <patrickdepinguin@gmail.com>:
>> > +config BR2_TARGET_ROOTFS_ISO9660_CUSTOM_BOOT_CONFIG
>> > +       bool "Use a custom boot config file"
>> > +       depends on BR2_TARGET_ROOTFS_ISO9660
>>
>> There should be some help text on this option: what is the format of
>> the config file, what is the default one, ... ?
>
> This is a bool option, and when toggled it shows option
> BR2_TARGET_ROOTFS_ISO9660_BOOT_CONFIG which has a visible default
> value. Should I add a link to
> http://www.syslinux.org/wiki/index.php/Isolinux.cfg and
> http://www.gnu.org/software/grub/manual/html_node/Configuration.html ?

Yes, that could be a good idea, along with some short explanation on
why a user would want this option, and what the default config file
does...

Thanks,
Thomas

  reply	other threads:[~2015-02-03 14:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-19 19:52 [Buildroot] [PATCH 1/3] fs/iso9660: allow building a hybrid ISO image Noé Rubinstein
2015-01-19 19:52 ` [Buildroot] [PATCH 2/3] fs/iso9660: remove obsolete code Noé Rubinstein
2015-01-26 22:27   ` Thomas Petazzoni
2015-01-19 19:52 ` [Buildroot] [PATCH 3/3] docs/manual/beyond-buildroot: building and testing live-CDs Noé Rubinstein
2015-02-02 20:40   ` Thomas De Schampheleire
2015-07-10 17:18   ` Thomas Petazzoni
2015-02-02 20:39 ` [Buildroot] [PATCH 1/3] fs/iso9660: allow building a hybrid ISO image Thomas De Schampheleire
2015-02-03  9:43   ` Noé RUBINSTEIN
2015-02-03 14:35     ` Thomas De Schampheleire [this message]
2015-02-02 21:13 ` Arnout Vandecappelle
2015-02-03 14:15   ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAXf6LWGd=qMbMgivXYX6ExOgKmRBEgeMgODZtsvHFTvLV+URQ@mail.gmail.com' \
    --to=patrickdepinguin@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.