From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6381CCA9EB3 for ; Fri, 18 Oct 2019 01:07:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3B93621D7D for ; Fri, 18 Oct 2019 01:07:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="IQ0rhGHC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404436AbfJRBHe (ORCPT ); Thu, 17 Oct 2019 21:07:34 -0400 Received: from mail-qk1-f196.google.com ([209.85.222.196]:44383 "EHLO mail-qk1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392283AbfJRBHd (ORCPT ); Thu, 17 Oct 2019 21:07:33 -0400 Received: by mail-qk1-f196.google.com with SMTP id u22so3762974qkk.11 for ; Thu, 17 Oct 2019 18:07:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=40ujc7RfVfNaPHECTGoUgnPQAhwikPah9moYi7g/hII=; b=IQ0rhGHCOcN65fgM9jLRHhcRbUVo76BZS6covsyuFs19ytBgbCpf1OvTmoDZlhXMsQ qArY8F/CyEfKYggx5jphPxMne4ZRtHXwkQfLqMEehvN8yA4hOgdTZ6hFY6y6mhGikySH zMe6pz3lHpl1CbunXf57+0SNjUsCMKd0LCVF0jTIBRQhA1kysuXpXiX+AcCgdq8E19G+ LG9WVaJNtQq1Hyif4+yL6o/lNZJR3ULGJZgLhhaGaCDuUuybNVJGoNQde3G3yhr2LzaK 4+si8BK0/IuwAzYjJPsDCkAFpt0Bvah+j8l7b58yRhEVUDuEGmwbqD/S2hs+NYxcuC+g I5sA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=40ujc7RfVfNaPHECTGoUgnPQAhwikPah9moYi7g/hII=; b=puFmOc5IvWJQB4eEp3WdDGApOSVimvBxq14zvhRStWqzDXEJprn+bwznyyphRab5JM 33cmsXau/W+wfWiX6wGG9nPXm27FPJyH2j7vVQCopj5cWCfQouf2aPotVNWLH2ry0cQl Us5EYb7UOs3NSC2iLJd+aqqxDG6XnuShXr8bGl/xA1gTA4f3Lcvxg4hABng00+In5Prq hhwp71LLGjsyW4w/KEKmOfzgb1f22EcBmexlQV9Nn3uvJloY/XBL3pGeNgNBhJmfTXyU iGRetN/BUofCabk2mWZcMdXy9aS7C3avJ1mIvSQu57rIDT3mg6IHbQk4zYKuvGLZaq/V TmbQ== X-Gm-Message-State: APjAAAWBaHIV1XvcdwG82aAfIpZ6ZgwYIXJ/PutxV3YnpMeuu5OlUaFS VuKckIfC513ToRZscX2bIa7GFVHpfh8l++zUeZA+ X-Google-Smtp-Source: APXvYqwUYq+GM5FlMqrVgUVGG7mU2ErtSDUVpG/WKsMiZgXMVLUVdkMUgFt5Rd9wjF7reoDD1BX8kcQJUZSCvzDCA88= X-Received: by 2002:a37:348:: with SMTP id 69mr6234766qkd.28.1571360851118; Thu, 17 Oct 2019 18:07:31 -0700 (PDT) MIME-Version: 1.0 References: <20191010023931.230475-1-yzaikin@google.com> <2f2ea7b0-f683-1cdd-f3f2-ecdf44cb4a97@linuxfoundation.org> <20191011131902.GC16225@mit.edu> <1e6611e6-2fa6-6f7d-bc7f-0bc2243d9342@linuxfoundation.org> <20191017120833.GA25548@mit.edu> <957434b6-32cc-487f-f48e-f9c4416b3f60@linuxfoundation.org> <40073fc9-1de1-9253-e2f9-9cf9ee4308d4@linuxfoundation.org> In-Reply-To: From: Iurii Zaikin Date: Thu, 17 Oct 2019 18:06:54 -0700 Message-ID: Subject: Re: [PATCH linux-kselftest/test v2] ext4: add kunit test for decoding extended timestamps To: "Bird, Timothy" Cc: Shuah Khan , "Theodore Ts'o" , Brendan Higgins , "open list:KERNEL SELFTEST FRAMEWORK" , linux-ext4@vger.kernel.org, adilger.kernel@dilger.ca, KUnit Development Content-Type: text/plain; charset="UTF-8" Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org > Having a data-driven test can, in some circumstances, allow one > to more easily come up with additional interesting test cases. Let's try to break this request down: 1. You would like first-class support for parameterized tests, as they are commonly called, instead of the ad-hoc thing I did because this is all upstream KUnit has atm. Me too! 2. You would like a way to pass the data to the parameterized test other than hardcoding. Depending on how parameterizing is designed, the input part may or may not belong in KUnit. As an example we have a test which has custom code that does essentially "ls dir" and passes the list of input files as the list of parameters to the test framework and then each individual test has the code to read the file passed as the parameterized test's parameter. This is not the most elegant example but it's the quickest I could come up offhand the point being to demonstrate what can potentially belong in the core test framework what can be external to it.