From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22539C433EF for ; Tue, 14 Sep 2021 18:41:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EAC62610E6 for ; Tue, 14 Sep 2021 18:41:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231642AbhINSmj (ORCPT ); Tue, 14 Sep 2021 14:42:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229728AbhINSmh (ORCPT ); Tue, 14 Sep 2021 14:42:37 -0400 Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F522C061762 for ; Tue, 14 Sep 2021 11:41:19 -0700 (PDT) Received: by mail-lj1-x236.google.com with SMTP id r3so481410ljc.4 for ; Tue, 14 Sep 2021 11:41:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telus.net; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=5VMpWRXt0jQuCEr+r0BM8kFoy1D29x31MLf3bnRKZqo=; b=b11SCPjz52oi1yBAOvY57UeyiD8/Ms3ExnET43X/lvFkWoqblZlZUbvHg0+wdNXdFN CtUHC+3qh+hX78zPevGjyIuPDcLVquMk4uXzdJJaQHd+HiaK71IWmxnnp0vIYzGq1JMX AtyJpWb0WCFKDqWlXiWidZUM93Gm0wERsRan+CRsWEpPTJ9gVdeJHf48KYpe8fuEB2uf es8EK1+mpdeMIsqsv4hT+cxjb5HUEsmqU3MV9yeFjEO/Yl4q0xv0YMtOugxPPSgOpVHw Gg1nTijVelp3vnDjGo4pu03Hx1GOjxaum78pSG6eY99ouhpbcGSjX0tb3jl/DYEgF1Gn lV6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=5VMpWRXt0jQuCEr+r0BM8kFoy1D29x31MLf3bnRKZqo=; b=MNK9uFjsoINjipNnIAXet8lV3/SYJK8yD/PiW6BHb0SNGJ8r/FUSfB3axe9hI1g/MF 1RxU69M/gz5RrvYZ2FxRSxZ4e6I2r0vXpu++0puiIs7nast61F9SFsvqXbwoopgc+tso +Sbh+VlSiufrnoMADDgrdM8y/8kKvGqUs4pCONPC8ckt9+dnE+Q3wl5pB1keyOgsJcri hj1g6GCHAK6jqpZL9E2cHNJZ8FU18teO9V/Yn5H3faPhoB1pNnqkrbTPu3x2WxaODJ2C AQ5SsYIcqHoCj3EKmxA8OhseWqcuduVSknZRZIoWRlwEWvM6rlMPVh4RsF5049COHiNz vyog== X-Gm-Message-State: AOAM533JusP2Qn4ciEVe9SX8wY0Vqm/gzXqSOrrdx9OaZ/1By0G9UZrH JJ/L42MyP7QyOb8bBWS/BuPh9Ir2MwaaZdoaQRr/3A== X-Google-Smtp-Source: ABdhPJyJFg7U0SySGwcX4hh4wxl9aHZdQMr5YsM70bRBO1qYAVvBNFSlNsuAYAWsKhw+uCtIo3ojWd6+04ZNE3bd/P4= X-Received: by 2002:a2e:8504:: with SMTP id j4mr16617853lji.352.1631644877772; Tue, 14 Sep 2021 11:41:17 -0700 (PDT) MIME-Version: 1.0 References: <20210513132051.31465-1-ggherdovich@suse.cz> <067ee60e47a0350d01f0c3f216c1032818044b36.camel@suse.cz> <2a1b000cd101737400f6320ef18c0143d3a5145b.camel@linux.intel.com> <7abae13c235d74f4789cd93c6c6b0cbf69df243d.camel@linux.intel.com> In-Reply-To: From: Doug Smythies Date: Tue, 14 Sep 2021 11:41:07 -0700 Message-ID: Subject: Re: [PATCH v2] cpufreq: intel_pstate: Add Icelake servers support in no-HWP mode To: Srinivas Pandruvada Cc: Giovanni Gherdovich , "Rafael J . Wysocki" , Viresh Kumar , Len Brown , Linux PM list , Linux Kernel Mailing List , dsmythies Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 7, 2021 at 8:43 PM Doug Smythies wrote: > On Tue, Sep 7, 2021 at 7:04 PM Srinivas Pandruvada > wrote: > > On Tue, 2021-09-07 at 13:16 -0700, Doug Smythies wrote: > > > On Tue, Sep 7, 2021 at 9:01 AM Srinivas Pandruvada > > > wrote: > > > > On Tue, 2021-09-07 at 08:45 -0700, Doug Smythies wrote: > > > > > > > > > > Recent ASUS BIOS updates have changed the default system > > > > > response for this old thread, rendering "intel_pstate=3Dno_hwp" > > > > > useless. > > > > > > > > > > It also raises a question: If BIOS has forced HWP, then how do we > > > > > prevent the acpi-cpufreq driver from being used? Read on. > > > > > > > > Does BIOS has option to enable Intel speed shift with no legacy > > > > support? > > > > Then this option will not populate ACPI _PSS table. > > > > > > The option is there no matter what. > > > I have tried every variation of legacy or no legacy that > > > I can find. Currently: > > > Current boot mode: UEFI Firmware mode > > > SecureBoot: disabled > > > > > > > > > > > > > > > > > On Fri, May 14, 2021 at 3:12 PM Doug Smythies < > > > > > dsmythies@telus.net> > > > > > wrote: > > > > > > > > > > > > On Fri, May 14, 2021 at 1:33 PM Giovanni Gherdovich < > > > > > > ggherdovich@suse.cz> wrote: > > > > > > > On Fri, 2021-05-14 at 08:31 -0700, Doug Smythies wrote: > > > > > ... > > > > > > > > > > ... > > > > > Previous correspondence was with BIOS version 1003. There have > > > > > been 3 BIOS > > > > > releases since then (at least that I know of), 2103, 2201, 2301, > > > > > and all of them have changed the behaviour > > > > > of the "Auto" setting for Intel Speed Shift > > > > > Technology BIOS setting, forcing it on upon transfer of control > > > > > to the OS. > > > > > > > > > > Where with "intel_pstate=3Dno_hwp" one used to get 0 for > > > > > MSR_PM_ENABLE > > > > > (0x770) they now get 1. > > > > > > > > So they are forcing Out of band OOB mode. > > > > Does bit 8 or 18 in MSR 0x1aa is set? > > > > > > No. > > > > So there is no legacy path. I think you are working with their support. > > Yes, for almost a month now, with very little to show for it. > We'll see what happens. I did get a message this afternoon: > > "Our GTSD is debugging the issue,. > When they have the result, they will directly update you." > > > In HWP mode does setting scaling min/max frequency has any impact? > > No. I wouldn't have expected it to, as the system is confused as to who > is in charge. The acpi-cpufreq driver thinks it is in charge, but HWP > thinks it is. > > The intel_pstate driver works fine. Hi Srinivas, I heard back from ASUS, and they now confirm that they did change the behaviour of the "Auto" setting in BIOS version 2103. They say they did it to fix an issue with ITB3.0, which I assume means Intel Turbo Boost 3.0. I'll copy and paste the relevant portion of the email below: " I am in direct contact with the engineers. Here is the result from their test: In BIOS 2103,the =E2=80=9CAuto=E2=80=9D setting transfers control to the OS with HWP available and enabled. This is side effect to fix ITBM3.0 not work after HWP enabled. We can remove this patch, but ITBM3.0 will not work when HWP enabled" Are you familiar with this issue? I want the original behaviour of the "Auto" setting, as it is the only way for control to go to the OS with HWP available but disabled. ... Doug