All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leif Liddy <leif.linux@gmail.com>
To: Lukas Wunner <lukas@wunner.de>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
	linux-acpi@vger.kernel.org, jarkko.nikula@linux.intel.com
Subject: Re: ACPI SPI slave device
Date: Wed, 2 Mar 2016 15:37:27 +0100	[thread overview]
Message-ID: <CAAbRKOs=ySAtqn71Mf5tyHvjqOGGRs5xsO6oU5YPYWgOSXqehA@mail.gmail.com> (raw)
In-Reply-To: <CAAbRKOvP9yudKbzu_GquPUzhz2VQBtuKYmJbqLpt1jFcB6U1kQ@mail.gmail.com>

This issue is more easily resolved by just changing !OSDW to OSDW for
that method. The default behavior it seems is for Linux to identify
itself as OSX, but there are a few methods where we don't want to
identify as being OSX. I'll try and come up with a list of methods of
where we don't want to identify as being OSX.

On Wed, Mar 2, 2016 at 2:07 PM, Leif Liddy <leif.linux@gmail.com> wrote:
> You're right, it's not evaluating the OSDW method properly. I tracked
> it down to this single change:
>
> change this:
>
>       If (!OSDW ())
>       {
>           Return (UBUF) /* \_SB_.PCI0.SPI1.SPIT._CRS.UBUF */
>       }
>      Return (ABUF) /* \_SB_.PCI0.SPI1.SPIT._CRS.ABUF */
> }
>
> to:
>
>      Return (UBUF) /* \_SB_.PCI0.SPI1.SPIT._CRS.UBUF */
>
>
> On Wed, Mar 2, 2016 at 12:42 PM, Lukas Wunner <lukas@wunner.de> wrote:
>> Hi,
>>
>> On Wed, Mar 02, 2016 at 04:13:16AM +0100, Leif Liddy wrote:
>>> I'll post more tomorrow, need to evaluate the changes I made --but I
>>> think the change that did it was changing this:
>>>
>>> Method (_CRS, 0, NotSerialized)  // _CRS: Current Resource Settings
>>> {
>>>     If (!OSDW ())
>>>     {
>>>         Return (WBUF) /* \_SB_.PCI0.SPI1.WBUF */
>>>     }
>>>
>>>     Return (ConcatenateResTemplate (RBUF, DBUF))
>>> }
>>>
>>> to:
>>>
>>> Method (_CRS, 0, NotSerialized)  // _CRS: Current Resource Settings
>>> {
>>>       Return (ConcatenateResTemplate (RBUF, DBUF))
>>> }
>>
>> If that is true then the fix is to change the OS we're reporting to ACPI:
>> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/acpi/osl.c#n141
>>
>> We had trouble with this before:
>> https://mjg59.dreamwidth.org/29954.html
>>
>> I've just grabbed the acpidump you've posted here:
>> https://bugzilla.kernel.org/attachment.cgi?id=200961&action=edit
>>
>> I'll take a look at it hopefully this afternoon to see what they've
>> changed in the OSDW method.
>>
>> Thanks a lot for your perseverance in tackling this issue.
>>
>> Lukas

  reply	other threads:[~2016-03-02 14:37 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-23  1:54 ACPI SPI slave device Leif Liddy
2016-02-23  7:38 ` Mika Westerberg
2016-02-23 14:18   ` Leif Liddy
2016-02-23 15:02     ` Mika Westerberg
2016-02-23 15:32       ` Mika Westerberg
2016-02-23 20:30         ` Leif Liddy
2016-02-29  8:21           ` Mika Westerberg
2016-02-29 17:21             ` Leif Liddy
2016-03-01 15:42               ` Leif Liddy
2016-03-01 16:07                 ` Lukas Wunner
2016-03-01 23:33                   ` Leif Liddy
2016-03-02  3:13                     ` Leif Liddy
2016-03-02 11:42                       ` Lukas Wunner
2016-03-02 13:07                         ` Leif Liddy
2016-03-02 14:37                           ` Leif Liddy [this message]
2016-03-03 11:47                             ` Lukas Wunner
     [not found]                               ` <20160303114740.GA24132-JFq808J9C/izQB+pC5nmwQ@public.gmane.org>
2016-03-03 17:45                                 ` Matthew Garrett
2016-03-03 18:55                                   ` Lukas Wunner
2016-03-03 19:12                                     ` Matthew Garrett
2016-03-08 14:40                                       ` Leif Liddy
     [not found]                                         ` <CAAbRKOu8UWrn5bhxjrHx5cykFWOChyxr_ZCWK=R4nYCc11cvsw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-03-09 12:36                                           ` Lukas Wunner
     [not found]                                             ` <20160309123625.GA26143-JFq808J9C/izQB+pC5nmwQ@public.gmane.org>
2016-03-10 18:12                                               ` Leif Liddy
2016-03-03 17:48                                 ` Matthew Garrett
  -- strict thread matches above, loose matches on Subject: below --
2016-02-22 19:37 ACPI: " Leif Liddy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAbRKOs=ySAtqn71Mf5tyHvjqOGGRs5xsO6oU5YPYWgOSXqehA@mail.gmail.com' \
    --to=leif.linux@gmail.com \
    --cc=jarkko.nikula@linux.intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=mika.westerberg@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.