From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leif Liddy <leif.linux@gmail.com>
Subject: Re: ACPI SPI slave device
Date: Wed, 2 Mar 2016 14:07:31 +0100
Message-ID: <CAAbRKOvP9yudKbzu_GquPUzhz2VQBtuKYmJbqLpt1jFcB6U1kQ@mail.gmail.com>
References: <CAAbRKOvktig4w9RPngCV4PBYZmO+3emCPwjMT1XMSxNesY+M6A@mail.gmail.com>
	<20160223150222.GL1770@lahna.fi.intel.com>
	<20160223153240.GM1770@lahna.fi.intel.com>
	<CAAbRKOu+s=OZw8vw2kfWs=JCQB1YcVg+51N5Yh_dCJOuytR2zA@mail.gmail.com>
	<20160229082114.GC1770@lahna.fi.intel.com>
	<CAAbRKOt=CDOqD1FESZkxv4fdYSDm6qoi4J0wYn=e5mvN-NLpCA@mail.gmail.com>
	<CAAbRKOscDyYaUqBTFVFZ2Fe81a_Kkx9oeNXHrttm3Qs_27fAzQ@mail.gmail.com>
	<20160301160726.GA23371@wunner.de>
	<CAAbRKOuESP+_65cmeCPNtO5HzN1+ct7bDv1stbE+a8u=KEwDKw@mail.gmail.com>
	<CAAbRKOsNxsu4CYq=EByck997RWRO3fQ-+LAAS5AbSL3XNRSh7A@mail.gmail.com>
	<20160302114250.GA23487@wunner.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Return-path: <linux-acpi-owner@vger.kernel.org>
Received: from mail-io0-f174.google.com ([209.85.223.174]:35067 "EHLO
	mail-io0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750876AbcCBNHc (ORCPT
	<rfc822;linux-acpi@vger.kernel.org>); Wed, 2 Mar 2016 08:07:32 -0500
Received: by mail-io0-f174.google.com with SMTP id g203so258289928iof.2
        for <linux-acpi@vger.kernel.org>; Wed, 02 Mar 2016 05:07:32 -0800 (PST)
In-Reply-To: <20160302114250.GA23487@wunner.de>
Sender: linux-acpi-owner@vger.kernel.org
List-Id: linux-acpi@vger.kernel.org
To: Lukas Wunner <lukas@wunner.de>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>, linux-acpi@vger.kernel.org, jarkko.nikula@linux.intel.com

You're right, it's not evaluating the OSDW method properly. I tracked
it down to this single change:

change this:

      If (!OSDW ())
      {
          Return (UBUF) /* \_SB_.PCI0.SPI1.SPIT._CRS.UBUF */
      }
     Return (ABUF) /* \_SB_.PCI0.SPI1.SPIT._CRS.ABUF */
}

to:

     Return (UBUF) /* \_SB_.PCI0.SPI1.SPIT._CRS.UBUF */


On Wed, Mar 2, 2016 at 12:42 PM, Lukas Wunner <lukas@wunner.de> wrote:
> Hi,
>
> On Wed, Mar 02, 2016 at 04:13:16AM +0100, Leif Liddy wrote:
>> I'll post more tomorrow, need to evaluate the changes I made --but I
>> think the change that did it was changing this:
>>
>> Method (_CRS, 0, NotSerialized)  // _CRS: Current Resource Settings
>> {
>>     If (!OSDW ())
>>     {
>>         Return (WBUF) /* \_SB_.PCI0.SPI1.WBUF */
>>     }
>>
>>     Return (ConcatenateResTemplate (RBUF, DBUF))
>> }
>>
>> to:
>>
>> Method (_CRS, 0, NotSerialized)  // _CRS: Current Resource Settings
>> {
>>       Return (ConcatenateResTemplate (RBUF, DBUF))
>> }
>
> If that is true then the fix is to change the OS we're reporting to ACPI:
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/acpi/osl.c#n141
>
> We had trouble with this before:
> https://mjg59.dreamwidth.org/29954.html
>
> I've just grabbed the acpidump you've posted here:
> https://bugzilla.kernel.org/attachment.cgi?id=200961&action=edit
>
> I'll take a look at it hopefully this afternoon to see what they've
> changed in the OSDW method.
>
> Thanks a lot for your perseverance in tackling this issue.
>
> Lukas