From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shobhit Kumar Subject: Re: [PATCH 0/7] Misc WM fixes and Arbitrated Display Bandwidth WA for SKL Date: Mon, 25 Jan 2016 10:18:22 +0530 Message-ID: References: <1452772968-24772-1-git-send-email-shobhit.kumar@intel.com> <20160115014835.GG13799@intel.com> <56987D5B.3010808@linux.intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1372368300==" Return-path: Received: from mail-io0-f182.google.com (mail-io0-f182.google.com [209.85.223.182]) by gabe.freedesktop.org (Postfix) with ESMTPS id A8F6D6E457 for ; Sun, 24 Jan 2016 20:48:23 -0800 (PST) Received: by mail-io0-f182.google.com with SMTP id 77so140335495ioc.2 for ; Sun, 24 Jan 2016 20:48:23 -0800 (PST) In-Reply-To: <56987D5B.3010808@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Kumar, Shobhit" Cc: Shobhit Kumar , intel-gfx List-Id: intel-gfx@lists.freedesktop.org --===============1372368300== Content-Type: multipart/alternative; boundary=001a113ecd44579442052a2147e8 --001a113ecd44579442052a2147e8 Content-Type: text/plain; charset=UTF-8 On Fri, Jan 15, 2016 at 10:32 AM, Kumar, Shobhit < shobhit.kumar@linux.intel.com> wrote: > On 01/15/2016 07:18 AM, Matt Roper wrote: > >> On Thu, Jan 14, 2016 at 05:32:41PM +0530, Shobhit Kumar wrote: >> >>> Hi, >>> This series add a set of updates to the WM calculation and also enables >>> arbitrated display bandwidth based WA. Some of these patches do overlap >>> with Matts work but we wanted to send them out as we have them in our >>> internal testing for early review. Most likley some of them can be >>> superceded by patches from Matt, or can be re-used if deemed necessary. >>> >> >> I've left some feedback on your patches, but it was all pretty minor; >> they look pretty good overall. So I think we should polish up this set >> and merge it; I've got more SKL WM work coming (more atomic-y watermark >> calculation and programming) but I'll hold off on that until your series >> lands so that I don't cause too much thrash. >> > > Thanks Matt for the quick review. I will get the comments addressed and > final patches uploaded quickly. > We have the updated patches ready. Just completing some testing. Should be posting sometime this week. Regards Shobhit > > Regards > Shobhit > > >> Thanks. >> >> >> Matt >> >> >>> Especially "drm/i915/skl+: Use fb size for relative data rate >>> calculation" >>> this already addresses some of Ville's comment on similar patch from >>> Matt. >>> >>> Regards >>> Shobhit >>> >>> Kumar, Mahesh (6): >>> drm/i915/skl+: Use proper bytes_per_pixel during WM calculation >>> drm/i915/skl+: Use fb size for relative data rate calculation >>> drm/i915/skl+: calculate ddb minimum allocation >>> drm/i915/skl+: calculate plane pixel rate. >>> drm/i915/skl+: Use scaling amount for plane data rate calculation >>> drm/i915/skl: WA for watermark calculation based on Arbitrated Display >>> BW >>> >>> Shobhit Kumar (1): >>> drm/i915: Add support to parse DMI table and get platform memory info >>> >>> drivers/gpu/drm/i915/i915_dma.c | 19 +++ >>> drivers/gpu/drm/i915/i915_drv.h | 15 ++ >>> drivers/gpu/drm/i915/intel_drv.h | 2 + >>> drivers/gpu/drm/i915/intel_pm.c | 294 >>> +++++++++++++++++++++++++++++++++++++-- >>> 4 files changed, 316 insertions(+), 14 deletions(-) >>> >>> -- >>> 2.4.3 >>> >>> >> _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx > --001a113ecd44579442052a2147e8 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On F= ri, Jan 15, 2016 at 10:32 AM, Kumar, Shobhit <shobhit.kumar@l= inux.intel.com> wrote:
On 01/15/2016 07:18 AM, Matt Roper wrote:
On Thu, Jan 14, 2016 at 05:32:41PM +0530, Shobhit Kumar wrote:
Hi,
This series add a set of updates to the WM calculation and also enables
arbitrated display bandwidth based WA. Some of these patches do overlap
with Matts work but we wanted to send them out as we have them in our
internal testing for early review. Most likley some of them can be
superceded by patches from Matt, or can be re-used if deemed necessary.

I've left some feedback on your patches, but it was all pretty minor; they look pretty good overall.=C2=A0 So I think we should polish up this se= t
and merge it; I've got more SKL WM work coming (more atomic-y watermark=
calculation and programming) but I'll hold off on that until your serie= s
lands so that I don't cause too much thrash.

Thanks Matt for the quick review. I will get the comments addressed and fin= al patches uploaded quickly.

We have th= e updated patches ready. Just completing some testing. Should be posting so= metime this week.

Regards
Shobhit
=
=C2=A0

Regards
Shobhit


Thanks.


Matt


Especially "drm/i915/skl+: Use fb size for relative data rate calculat= ion"
this already addresses some of Ville's comment on similar patch from Ma= tt.

Regards
Shobhit

Kumar, Mahesh (6):
=C2=A0 =C2=A0drm/i915/skl+: Use proper bytes_per_pixel during WM calculatio= n
=C2=A0 =C2=A0drm/i915/skl+: Use fb size for relative data rate calculation<= br> =C2=A0 =C2=A0drm/i915/skl+: calculate ddb minimum allocation
=C2=A0 =C2=A0drm/i915/skl+: calculate plane pixel rate.
=C2=A0 =C2=A0drm/i915/skl+: Use scaling amount for plane data rate calculat= ion
=C2=A0 =C2=A0drm/i915/skl: WA for watermark calculation based on Arbitrated= Display
=C2=A0 =C2=A0 =C2=A0BW

Shobhit Kumar (1):
=C2=A0 =C2=A0drm/i915: Add support to parse DMI table and get platform memo= ry info

=C2=A0 drivers/gpu/drm/i915/i915_dma.c=C2=A0 |=C2=A0 19 +++
=C2=A0 drivers/gpu/drm/i915/i915_drv.h=C2=A0 |=C2=A0 15 ++
=C2=A0 drivers/gpu/drm/i915/intel_drv.h |=C2=A0 =C2=A02 +
=C2=A0 drivers/gpu/drm/i915/intel_pm.c=C2=A0 | 294 ++++++++++++++++++++++++= +++++++++++++--
=C2=A0 4 files changed, 316 insertions(+), 14 deletions(-)

--
2.4.3


_______________________________________________
Intel-gfx mailing list
Intel-= gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo= /intel-gfx

--001a113ecd44579442052a2147e8-- --===============1372368300== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK --===============1372368300==--