From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB351C4320E for ; Thu, 19 Aug 2021 06:19:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D64F1610E5 for ; Thu, 19 Aug 2021 06:19:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230390AbhHSGT7 (ORCPT ); Thu, 19 Aug 2021 02:19:59 -0400 Received: from smtp-relay-canonical-0.canonical.com ([185.125.188.120]:41252 "EHLO smtp-relay-canonical-0.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229782AbhHSGT4 (ORCPT ); Thu, 19 Aug 2021 02:19:56 -0400 Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-0.canonical.com (Postfix) with ESMTPS id 8B5163F047 for ; Thu, 19 Aug 2021 06:19:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1629353959; bh=qEtVTiJin9b0M1DkYv8DcnGnIW+RsIPC9ADG4dJnT4o=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=N3xhBs+49++GdAMSJ8xlhr5Xzp+Rr+aoUebyVTv2OTbwGRYj33wGlrWZxmlu0AIoj 8ffxay1E8CObjcUXT1mDCnStOo4ICq0Pq6ptz3n48oiVXkmYmPIawKC6gqOwkyeGjo +9WDvScWkVndFdiZYT2I9FibWg7s6zXI5w3H81dEuz0ilkxj/tlq5Z80urnh2uV6mR J4BOXDpMCH2c59ZbHRr290Htg2LhK8xGywB3V/2ubmRBYI7kLti26Ma03swvOu224k ir8n7QaqWdgPvc68uzSI9mgH5Q0rC5IilVr/dnBqa7m24ufNO8g+PJYv2mbcZZH3RV on2pgl6DQJ8+A== Received: by mail-ej1-f69.google.com with SMTP id j10-20020a17090686cab02905b86933b59dso1805276ejy.18 for ; Wed, 18 Aug 2021 23:19:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qEtVTiJin9b0M1DkYv8DcnGnIW+RsIPC9ADG4dJnT4o=; b=JqcsCLuIZxagHGybiY/h0GhWNJyIkSic8D+pY+SvlG+I0qaq0LB1+s7jXzaP3u9IXv iA88zPRSkG0iVy4QmLyaJTZVWqIzUlIm8mXynqqA3tS2upPokHSlkTyl79smMHcnkLaQ MDLazaTkJZzKVb9mTjp0Rmhn9ZH95EpIjrOuF8v198+UnNlzYj5k9ly9COsBD+cIuxrY 4S5lljMOH9/1yi+GjmvtRce8J77YFfLKNBx2oOTjKVWWbjTJwGLGJV2maq03babWmYh9 3TFd76yp0zRWBDl/zqxzwghc5ea4lRQh3XH8NZ0wiX971nZ6q1o34mhWeHW8Qt+JMkrW xF/g== X-Gm-Message-State: AOAM53055FiI5cBohwa8rCh42ZtNAK7hnQgipoDG6S9q74sA3X93hYiU J+RyfnIWWPHD8THdnImfsbd7r9kZi8kI7Eoa6W3RjuKwcdDrwLgB34MiWc1vwOj5mX/2ZxlWofy LjxfBHljbSPsdj+BtsAOhbfPo97gw/xjDI4QwEreubznD9gSI1tpJFn6TNg== X-Received: by 2002:a05:6402:b64:: with SMTP id cb4mr14429983edb.49.1629353959257; Wed, 18 Aug 2021 23:19:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw6uek5wW3YjQA4vSSYLJiAy5IA1O6J/ytxuGPYxDhJKHP7TDdnXrrE69RuJ6b7u6FD00XjM9NEQEB7GNyNEXw= X-Received: by 2002:a05:6402:b64:: with SMTP id cb4mr14429958edb.49.1629353959017; Wed, 18 Aug 2021 23:19:19 -0700 (PDT) MIME-Version: 1.0 References: <20210819054542.608745-1-kai.heng.feng@canonical.com> In-Reply-To: From: Kai-Heng Feng Date: Thu, 19 Aug 2021 14:19:07 +0800 Message-ID: Subject: Re: [PATCH net-next v3 0/3] r8169: Implement dynamic ASPM mechanism for recent 1.0/2.5Gbps Realtek NICs To: Heiner Kallweit Cc: nic_swsd , Bjorn Helgaas , David Miller , Jakub Kicinski , Linux Netdev List , Linux PCI , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 19, 2021 at 2:08 PM Heiner Kallweit wrote: > > On 19.08.2021 07:45, Kai-Heng Feng wrote: > > The latest Realtek vendor driver and its Windows driver implements a > > feature called "dynamic ASPM" which can improve performance on it's > > ethernet NICs. > > > This statement would need a proof. Which performance improvement > did you measure? And why should performance improve? It means what patch 1/3 fixes... > On mainline ASPM is disabled, therefore I don't think we can see > a performance improvement. More the opposite in the scenario > I described: If traffic starts and there's a congestion in the chip, > then it may take a second until ASPM gets disabled. This may hit > performance. OK. We can know if the 1 sec interval is enough once it's deployed in the wild. > > > Heiner Kallweit pointed out the potential root cause can be that the > > buffer is to small for its ASPM exit latency. > > > > So bring the dynamic ASPM to r8169 so we can have both nice performance > > and powersaving at the same time. > > > > v2: > > https://lore.kernel.org/netdev/20210812155341.817031-1-kai.heng.feng@canonical.com/ > > > > v1: > > https://lore.kernel.org/netdev/20210803152823.515849-1-kai.heng.feng@canonical.com/ > > > > Kai-Heng Feng (3): > > r8169: Implement dynamic ASPM mechanism > > PCI/ASPM: Introduce a new helper to report ASPM support status > > r8169: Enable ASPM for selected NICs > > > > drivers/net/ethernet/realtek/r8169_main.c | 69 ++++++++++++++++++++--- > > drivers/pci/pcie/aspm.c | 11 ++++ > > include/linux/pci.h | 2 + > > 3 files changed, 74 insertions(+), 8 deletions(-) > > > This series is meant for your downstream kernel only, and posted here to > get feedback. Therefore it should be annotated as RFC, not that it gets > applied accidentally. Noted. Will annotate in next version. Kai-Heng