All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kai-Heng Feng <kai.heng.feng@canonical.com>
To: Josef Bacik <josef@toxicpanda.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	"kernel-team@fb.com" <kernel-team@fb.com>
Subject: Re: [PATCH][RESEND] Revert "PM: ACPI: reboot: Use S5 for reboot"
Date: Sat, 20 Mar 2021 00:23:20 +0800	[thread overview]
Message-ID: <CAAd53p6=dGwtTVBcQuO+Rvt0nZ2Ck_OXtR=um=S2p=OjNXnH8w@mail.gmail.com> (raw)
In-Reply-To: <0cd8b39e-3feb-87b8-e172-70b07692b82a@toxicpanda.com>

On Fri, Mar 19, 2021 at 3:02 AM Josef Bacik <josef@toxicpanda.com> wrote:
>
> On 3/18/21 1:42 AM, Kai-Heng Feng wrote:
> > On Thu, Mar 18, 2021 at 1:25 AM Josef Bacik <josef@toxicpanda.com> wrote:
> > [snipped]
> >> "shutdown now" works fine with and without your patch.  Thanks,
> >
> > Rafael,
> > Please revert the patch while we are working on it.
> >
> > Josef,
> > Can you please test the following patch:
> >
>
> That made it work fine.  Thanks,

So there are things depend on reboot or shutdown to carry out
different behaviors.
Can you please find whether there is any code path uses SYSTEM_RESTART
or SYSTEM_POWER_OFF that leads to different behavior? Most likely
happen in a driver's .shutdown callback.

Kai-Heng

>
> Josef

  reply	other threads:[~2021-03-19 16:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-17  2:17 [PATCH][RESEND] Revert "PM: ACPI: reboot: Use S5 for reboot" Josef Bacik
2021-03-17  2:50 ` Kai-Heng Feng
2021-03-17 15:19   ` Josef Bacik
2021-03-17 16:14     ` Kai-Heng Feng
2021-03-17 17:25       ` Josef Bacik
2021-03-18  5:42         ` Kai-Heng Feng
2021-03-18 15:59           ` Rafael J. Wysocki
2021-03-18 19:02           ` Josef Bacik
2021-03-19 16:23             ` Kai-Heng Feng [this message]
2021-07-12 17:03               ` Kai-Heng Feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAd53p6=dGwtTVBcQuO+Rvt0nZ2Ck_OXtR=um=S2p=OjNXnH8w@mail.gmail.com' \
    --to=kai.heng.feng@canonical.com \
    --cc=josef@toxicpanda.com \
    --cc=kernel-team@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael.j.wysocki@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.