From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8789C43462 for ; Mon, 12 Apr 2021 13:10:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 65DD16128A for ; Mon, 12 Apr 2021 13:10:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239867AbhDLNLQ (ORCPT ); Mon, 12 Apr 2021 09:11:16 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:41698 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241498AbhDLNLN (ORCPT ); Mon, 12 Apr 2021 09:11:13 -0400 Received: from mail-lj1-f197.google.com ([209.85.208.197]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lVwL8-0002Mq-Pq for linux-kernel@vger.kernel.org; Mon, 12 Apr 2021 13:10:54 +0000 Received: by mail-lj1-f197.google.com with SMTP id t14so2093447ljj.11 for ; Mon, 12 Apr 2021 06:10:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PrLEyIjUJblo7S+sNtRpgmhy7N1VnkqDo/WR8LuV+WE=; b=jNul/lgHmi4GeGBB2I+aUc/ZGDdwOuJBN+f/O7iqGPPYWsrwwtJHIfKRobfYqrj1il 4a0OujO6jmNx+pNJE+IAEaHowuueC48Ms4zrQYiDkWICGOZ2HjJozEjzHrs+ahiZPvH+ aQwOwNuZ0NmZVVyn6S4vvYkE0Iquyy2AeXKOUMKtyL0fM5SUjcnl0qxyasfSpY1oZIIh dSRSnTeTI92B6qqyEktVAVURA/WqwP8D5lRY9gjER5wa3l5oZlBNxhUYIC54FjSG/GYA NtwEmuR69WwT5rMS/5ETeYMvV11uouhwNtwASv5nV4pg0iydahBlhg9lE6dthhaWnh2H 6PsA== X-Gm-Message-State: AOAM5314wDv+xuN4YwFfdnIjSDBGkaJRT3QHsrn0C5Nmmsqk4uDRVwMs 1wiyYsaHNQ9py5rsR39xe7xx3tGhb4/JMETnj+6zG2jwxBabmfeAFfMiBJl8R7iMbKvDT8uAOKa 7fBwU/e9yT9kmj6F0+V/kd2LZC8GWm2VzpGXm1lD+jbplmJ6vH1iFG/7Yhw== X-Received: by 2002:a2e:3013:: with SMTP id w19mr6015217ljw.97.1618233054225; Mon, 12 Apr 2021 06:10:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxR6IaQiNoP7RnPnhejo3H1RZrmk1Ll/HnLTHpwJGxLrQRRT95FsAHdmJyp1uD9Y3PpSPQl+1ZnWlUgkJFFsvs= X-Received: by 2002:a2e:3013:: with SMTP id w19mr6015202ljw.97.1618233053976; Mon, 12 Apr 2021 06:10:53 -0700 (PDT) MIME-Version: 1.0 References: <20210412130521.782373-1-kai.heng.feng@canonical.com> In-Reply-To: From: Kai-Heng Feng Date: Mon, 12 Apr 2021 21:10:41 +0800 Message-ID: Subject: Re: [PATCH v2] USB: Add LPM quirk for Lenovo ThinkPad USB-C Dock Gen2 Ethernet To: Johan Hovold Cc: Greg Kroah-Hartman , Alan Stern , penghao , Oliver Neukum , Jonathan Cox , Kars Mulder , =?UTF-8?Q?Tomasz_Meresi=C5=84ski?= , "open list:USB SUBSYSTEM" , open list Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 12, 2021 at 9:09 PM Johan Hovold wrote: > > On Mon, Apr 12, 2021 at 09:05:20PM +0800, Kai-Heng Feng wrote: > > This is another branded 8153 device that doesn't work well with LPM > > enabled: > > [ 400.597506] r8152 5-1.1:1.0 enx482ae3a2a6f0: Tx status -71 > > > > So disable LPM to resolve the issue. > > > > BugLink: https://bugs.launchpad.net/bugs/1922651 > > Signed-off-by: Kai-Heng Feng > > --- > > v2: > > - Put the quirk in the right order. > > Seriously... You sent the exact same patch again. Still not ordered. Oops, sorry for that, I mistyped the patch name :( Will send a correct one. Kai-Heng > > > > > drivers/usb/core/quirks.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c > > index 76ac5d6555ae..dfedb51cf832 100644 > > --- a/drivers/usb/core/quirks.c > > +++ b/drivers/usb/core/quirks.c > > @@ -434,6 +434,9 @@ static const struct usb_device_id usb_quirk_list[] = { > > { USB_DEVICE(0x1532, 0x0116), .driver_info = > > USB_QUIRK_LINEAR_UFRAME_INTR_BINTERVAL }, > > > > + /* Lenovo ThinkPad USB-C Dock Gen2 Ethernet (RTL8153 GigE) */ > > + { USB_DEVICE(0x17ef, 0xa387), .driver_info = USB_QUIRK_NO_LPM }, > > + > > /* Lenovo ThinkCenter A630Z TI024Gen3 usb-audio */ > > { USB_DEVICE(0x17ef, 0xa012), .driver_info = > > USB_QUIRK_DISCONNECT_SUSPEND }, > > Johan